tools: imagetool: Remove "INSERT BEFORE" from linker script
PATCH 1/1 tools: imagetool: Remove "INSERT BEFORE" from linker script
Not all linkers are able to parse "INSERT BEFORE" part of the linker script. For example following (rather new) "gold" one:
GNU gold (GNU Binutils for Debian 2.22) 1.11
produces following error:
HOSTLD tools/mkenvimage/usr/bin/ld: error: ./tools/imagetool.lds:23:8: syntax error, unexpected STRING /usr/bin/ld: fatal error: unable to parse script file ./tools/imagetool.lds
collect2: error: ld returned 1 exit status
make[1]: *** [tools/mkenvimage] Error 1
make: *** [tools] Error 2
The problem has already been reported, but no evident solution has been proposed:
https://bugzilla.redhat.com/show_bug.cgi?id=927573#c5
--- tools/imagetool.lds | 2 -- 1 file changed, 2 deletions(-)
tools/imagetool.lds +0 -2
@@ -20,5 +20,3 @@ SECTIONS __bss_start = .; } - -INSERT BEFORE .data;
Signature · 1 line
2.0.0.rc2
PATCH 1/1 tools: imagetool: Remove "INSERT BEFORE" from linker script
Quoted 13 lines · Lukasz Majewski
Not all linkers are able to parse "INSERT BEFORE" part of the linker script. For example following (rather new) "gold" one:
GNU gold (GNU Binutils for Debian 2.22) 1.11
produces following error:
HOSTLDtools/mkenvimage/usr/bin/ld: error:./tools/imagetool.lds:23:8: syntax error, unexpected STRING/usr/bin/ld: fatal error: unable to parse script file./tools/imagetool.lds
collect2: error: ld returned 1 exit status
make[1]: *** [tools/mkenvimage] Error 1
make: *** [tools] Error 2
Quoted 5 lines
The problem has already been reported, but no evident solution has been proposed:
https://bugzilla.redhat.com/show_bug.cgi?id=927573#c5Signed-off-by Lukasz Majewski <[email protected]>
Guilherme, can you please confirm that things still work as expected for you with this patch applied? Thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150216/29c326ed/attachment-0001.sig>
PATCH 1/1 tools: imagetool: Remove "INSERT BEFORE" from linker script
Quoted 15 lines · Tom Rini
Quoted 13 lines · Lukasz Majewski
Not all linkers are able to parse "INSERT BEFORE" part of the linker script. For example following (rather new) "gold" one:
GNU gold (GNU Binutils for Debian 2.22) 1.11
produces following error:
HOSTLDtools/mkenvimage/usr/bin/ld: error:./tools/imagetool.lds:23:8: syntax error, unexpected STRING/usr/bin/ld: fatal error: unable to parse script file./tools/imagetool.lds
collect2: error: ld returned 1 exit status
make[1]: *** [tools/mkenvimage] Error 1
make: *** [tools] Error 2
Quoted 8 lines
Quoted 5 lines
The problem has already been reported, but no evident solution has been proposed:
https://bugzilla.redhat.com/show_bug.cgi?id=927573#c5Signed-off-by Lukasz Majewski <[email protected]>Guilherme, can you please confirm that things still work as expected for you with this patch applied? Thanks!
On second thought I'm going to go with the patch that just drops the linker script and I see you tested that one as well, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150216/8b9ff82d/attachment.sig>
PATCH 1/1 tools: imagetool: Remove "INSERT BEFORE" from linker script
Hi Tom,
Confirmed, Andreas sent the patch and I've tested both versions. The tools still works on Ubuntu host.
Kind regards,
2015-02-16 15:12 GMT-02:00 Tom Rini <[email protected]>:
Quoted 34 lines · Tom Rini
Quoted 3 lines · Lukasz Majewski
Quoted 2 lines
Not all linkers are able to parse "INSERT BEFORE" part of the linker
script.
Quoted 7 lines
Quoted 7 lines
For example following (rather new) "gold" one:
GNU gold (GNU Binutils for Debian 2.22) 1.11
produces following error:
HOSTLDtools/mkenvimage/usr/bin/ld: error:./tools/imagetool.lds:23:8: syntax error,unexpected STRING
Quoted 1 line
Quoted 1 line
/usr/bin/ld: fatal error: unable to parse script file
./tools/imagetool.ldsQuoted 4 lines
Quoted 4 lines
collect2: error: ld returned 1 exit status
make[1]: *** [tools/mkenvimage] Error 1
make: *** [tools] Error 2Quoted 8 lines
Quoted 5 lines
The problem has already been reported, but no evident solution has been proposed:
https://bugzilla.redhat.com/show_bug.cgi?id=927573#c5Signed-off-by Lukasz Majewski <[email protected]>Guilherme, can you please confirm that things still work as expected for you with this patch applied? Thanks!
On second thought I'm going to go with the patch that just drops the linker script and I see you tested that one as well, thanks!
--
Tom
PATCH 1/1 tools: imagetool: Remove "INSERT BEFORE" from linker script
In reply to Tom RiniQuoted 15 lines · Tom Rini
Quoted 13 lines · Lukasz Majewski
Not all linkers are able to parse "INSERT BEFORE" part of the linker script. For example following (rather new) "gold" one:
GNU gold (GNU Binutils for Debian 2.22) 1.11
produces following error:
HOSTLDtools/mkenvimage/usr/bin/ld: error:./tools/imagetool.lds:23:8: syntax error, unexpected STRING/usr/bin/ld: fatal error: unable to parse script file./tools/imagetool.lds
collect2: error: ld returned 1 exit status
make[1]: *** [tools/mkenvimage] Error 1
make: *** [tools] Error 2
Quoted 8 lines
Quoted 5 lines
The problem has already been reported, but no evident solution has been proposed:
https://bugzilla.redhat.com/show_bug.cgi?id=927573#c5Signed-off-by Lukasz Majewski <[email protected]>Guilherme, can you please confirm that things still work as expected for you with this patch applied? Thanks!
I vote for 437762 [1] as replacement for this patch.
It is not only the linker script which is not understood by the Darwin linker. The linker generated lists work just differently on Darwin, therefore a93648d197df48fa46dd55f925ff70468bd81c71 broke mkimage for me. Guilherme told the RFC would work [2].
Best regards
Andreas Bie?mann
[1] http://patchwork.ozlabs.org/patch/437762/
[2] http://article.gmane.org/gmane.comp.boot-loaders.u-boot/211224
PATCH 1/1 tools: imagetool: Remove "INSERT BEFORE" from linker script
Quoted 25 lines · Andreas Bie?mann
Quoted 15 lines · Tom Rini
Quoted 13 lines · Lukasz Majewski
Not all linkers are able to parse "INSERT BEFORE" part of the linker script. For example following (rather new) "gold" one:
GNU gold (GNU Binutils for Debian 2.22) 1.11
produces following error:
HOSTLDtools/mkenvimage/usr/bin/ld: error:./tools/imagetool.lds:23:8: syntax error, unexpected STRING/usr/bin/ld: fatal error: unable to parse script file./tools/imagetool.lds
collect2: error: ld returned 1 exit status
make[1]: *** [tools/mkenvimage] Error 1
make: *** [tools] Error 2Quoted 8 lines
Quoted 5 lines
The problem has already been reported, but no evident solution has been proposed:
https://bugzilla.redhat.com/show_bug.cgi?id=927573#c5Signed-off-by Lukasz Majewski <[email protected]>Guilherme, can you please confirm that things still work as expected for you with this patch applied? Thanks!
Quoted 6 lines
I vote for 437762 [1] as replacement for this patch.
It is not only the linker script which is not understood by the Darwin linker. The linker generated lists work just differently on Darwin, therefore
a93648d197df48fa46dd55f925ff70468bd81c71broke mkimage for me. Guilherme told the RFC would work [2].
I concur and am build testing that locally now.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150216/e99629e1/attachment.sig>
PATCH 1/1 tools: imagetool: Remove "INSERT BEFORE" from linker script
In reply to Andreas BießmannHi Andreas,
Quoted 32 lines · Tom Rini
Quoted 15 lines · Lukasz Majewski
Quoted 14 lines
Not all linkers are able to parse "INSERT BEFORE" part of the linker script. For example following (rather new) "gold" one:
GNU gold (GNU Binutils for Debian 2.22) 1.11
produces following error:
HOSTLDtools/mkenvimage/usr/bin/ld: error:./tools/imagetool.lds:23:8: syntax error, unexpected STRING/usr/bin/ld: fatal error: unable to parse script file./tools/imagetool.ldscollect2: error: ld returned 1 exit status make[1]: *** [tools/mkenvimage] Error 1
make: *** [tools] Error 2Quoted 8 lines
Quoted 5 lines
The problem has already been reported, but no evident solution has been proposed:
https://bugzilla.redhat.com/show_bug.cgi?id=927573#c5Signed-off-by Lukasz Majewski <[email protected]>Guilherme, can you please confirm that things still work as expected for you with this patch applied? Thanks!
I vote for 437762 [1] as replacement for this patch.
It is not only the linker script which is not understood by the Darwin linker. The linker generated lists work just differently on Darwin, therefore
a93648d197df48fa46dd55f925ff70468bd81c71broke mkimage for me. Guilherme told the RFC would work [2].
Quoted 6 lines
Best regards
Andreas Bie?mann
[1] http://patchwork.ozlabs.org/patch/437762/
[2] http://article.gmane.org/gmane.comp.boot-loaders.u-boot/211224
I can confirm that patch [1] works on my host debian machine.
Signature · 5 lines
Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group