Skip to contentSkip to conversation

of/overlay: Directly include idr.h

PATCH In review Mark Brown 3 participants 4 messages Feb 17, 2015 – Mar 13, 2015 3 messages not in the archive Device tree

lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 of/overlay: Directly include idr.h

The overlay code uses IDRs but does not explicitly include the header providing the interface, instead relying on an implicit inclusion. Make the dependency implict to avoid potential future build issues if the implicit inclusion goes away.

---
 drivers/of/overlay.c | 1 +
 1 file changed, 1 insertion(+)
drivers/of/overlay.c +1 -0
index 352b4f28f82c..406664801cb5 100644
@@ -19,6 +19,7 @@
 #include <linux/string.h>
 #include <linux/slab.h>
 #include <linux/err.h>
+#include <linux/idr.h>
 
 #include "of_private.h"
 
Signature · 6 lines
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 1424140618-22987-1-git-send-email-broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org

#2 lore raw

Hi Mark,

Quoted 27 lines · Mark Brown

The overlay code uses IDRs but does not explicitly include the header providing the interface, instead relying on an implicit inclusion. Make the dependency implict to avoid potential future build issues if the implicit inclusion goes away.

---
drivers/of/overlay.c | 1 +

1 file changed, 1 insertion(+)
drivers/of/overlay.c +1 -0
index 352b4f28f82c..406664801cb5 100644
@@ -19,6 +19,7 @@
 #include <linux/string.h>
 #include <linux/slab.h>
 #include <linux/err.h>
+#include <linux/idr.h>
 
 #include "of_private.h"
 
Signature · 1 line
2.1.4

Nice catch.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 56CDBF0A-4E66-406D-9086-7C0128FEC6C7-OWPKS81ov/FWk0Htik3J/[email protected]

author
#4 lore raw
Quoted 2 lines · Pantelis Antoniou
Quoted 2 lines

providing the interface, instead relying on an implicit inclusion. Make the dependency implict to avoid potential future build issues if the

s/implicit/explicit/

A message that is not in the archive (sent off-list or not yet received): 20150217093351.GT9110-bheZrs9scGb3/WHNxyQH9YN0K6Il/[email protected]

#6 lore raw
Quoted 5 lines · Mark Brown
Quoted 2 lines · Pantelis Antoniou
Quoted 2 lines

providing the interface, instead relying on an implicit inclusion. Make the dependency implict to avoid potential future build issues if the

s/implicit/explicit/

Applied with fixup for 4.0. Thanks.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html