xen: pvscsi: avoid race, support suspend/resume
Subsystems (3)
Juergen Gross
maintainerv2 cover xen: pvscsi: avoid race, support suspend/resume
In the pvscsi backend copy the frontend request to ensure it is not changed by the frontend during processing it in the backend.
Support suspend/resume of the domain to be able to access a pvscsi device n the frontend afterwards.
Changes in V2:
- changed scsiback_do_cmd_fn() as sugested by Jan Beulich
- added adaption of backend parameters in frontend after resuming
Juergen Gross (3):
xen: mark pvscsi frontend request consumed only after last read
xen: scsiback: add LUN of restored domain
xen: support suspend/resume in pvscsi frontend
drivers/scsi/xen-scsifront.c | 214 ++++++++++++++++++++++++++++++++++++------- drivers/xen/xen-scsiback.c | 33 ++++--- 2 files changed, 199 insertions(+), 48 deletions(-)
Signature · 1 line
2.1.4
Juergen Gross
maintainerPATCH v2 1/3 xen: mark pvscsi frontend request consumed only after last read
A request in the ring buffer mustn't be read after it has been marked as consumed. Otherwise it might already have been reused by the frontend without violating the ring protocol.
To avoid inconsistencies in the backend only work on a private copy of the request. This will ensure a malicious guest not being able to bypass consistency checks of the backend by modifying an active request.
--- drivers/xen/xen-scsiback.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-)
drivers/xen/xen-scsiback.c +6 -8
@@ -709,12 +709,11 @@ static int prepare_pending_reqs(struct vscsibk_info *info,static int scsiback_do_cmd_fn (struct vscsibk_info *info) {struct vscsiif_back_ring *ring = &info->ring; -struct vscsiif_request *ring_req; +struct vscsiif_request ring_req;struct vscsibk_pend *pending_req;RING_IDX rc, rp;int err, more_to_do;uint32_t result; -uint8_t act; rc = ring->req_cons; rp = ring->sring->req_prod;
@@ -735,11 +734,10 @@ static int scsiback_do_cmd_fn(struct vscsibk_info *info)if (!pending_req)return 1 ; - ring_req =RING_GET_REQUEST (ring, rc); + ring_req = *RING_GET_REQUEST (ring, rc); ring->req_cons = ++rc; - act = ring_req->act; - err =prepare_pending_reqs (info, ring_req, pending_req); + err =prepare_pending_reqs (info, &ring_req, pending_req);if (err) {switch (err) {case -ENODEV :
@@ -755,9 +753,9 @@ static int scsiback_do_cmd_fn(struct vscsibk_info *info)return 1 ; } -switch (act) { +switch (ring_req.act) {case VSCSIIF_ACT_SCSI_CDB : -if (scsiback_gnttab_data_map (ring_req, pending_req)) { +if (scsiback_gnttab_data_map (&ring_req, pending_req)) {scsiback_fast_flush_area (pending_req);scsiback_do_resp_with_sense (NULL ,DRIVER_ERROR <<24 ,0 , pending_req);
@@ -768,7 +766,7 @@ static int scsiback_do_cmd_fn(struct vscsibk_info *info)break ;case VSCSIIF_ACT_SCSI_ABORT :scsiback_device_action (pending_req,TMR_ABORT_TASK , - ring_req->ref_rqid); + ring_req.ref_rqid);break ;case VSCSIIF_ACT_SCSI_RESET :scsiback_device_action (pending_req,TMR_LUN_RESET ,0 );
Signature · 1 line
2.1.4
David Vrabel
AppliedRe: [Xen-devel] [PATCH V2 1/3] xen: mark pvscsi frontend request consumed only after last read
Quoted 8 lines · Juergen Gross
A request in the ring buffer mustn't be read after it has been marked as consumed. Otherwise it might already have been reused by the frontend without violating the ring protocol.
To avoid inconsistencies in the backend only work on a private copy of the request. This will ensure a malicious guest not being able to bypass consistency checks of the backend by modifying an active request.
Applied to stable/for-linus-3.20 and tagged for stable, thanks.
David
Juergen Gross
maintainerPATCH v2 2/3 xen: scsiback: add LUN of restored domain
In reply to Juergen GrossWhen a xen domain is being restored the LUN state of a pvscsi device is "Connected" and not "Initialising" as in case of attaching a new pvscsi LUN.
This must be taken into account when adding a new pvscsi device for a domain as otherwise the pvscsi LUN won't be connected to the SCSI target associated with it.
--- drivers/xen/xen-scsiback.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-)
drivers/xen/xen-scsiback.c +14 -5
@@ -992,7 +992,7 @@ found: }static void scsiback_do_add_lun (struct vscsibk_info *info,const char *state, -char *phy,struct ids_tuple *vir) +char *phy,struct ids_tuple *vir,int try) {if (!scsiback_add_translation_entry (info, phy, vir)) { if (xenbus_printf(XBT_NIL, info->dev->nodename, state,
@@ -1000,7 +1000,7 @@ static void scsiback_do_add_lun(struct vscsibk_info *info, const char *state,pr_err ("xen-pvscsi: xenbus_printf error %s\n" , state);scsiback_del_translation_entry (info, vir); } - }else { + }else if (!try) {xenbus_printf (XBT_NIL , info->dev->nodename, state,"%d" , XenbusStateClosed); }
@@ -1060,10 +1060,19 @@ static void scsiback_do_1lun_hotplug(struct vscsibk_info *info, int op,switch (op) {case VSCSIBACK_OP_ADD_OR_DEL_LUN : -if (device_state == XenbusStateInitialising) -scsiback_do_add_lun (info, state, phy, &vir); -if (device_state == XenbusStateClosing) +switch (device_state) { +case XenbusStateInitialising: +scsiback_do_add_lun (info, state, phy, &vir,0 ); +break ; +case XenbusStateConnected: +scsiback_do_add_lun (info, state, phy, &vir,1 ); +break ; +case XenbusStateClosing:scsiback_do_del_lun (info, state, &vir); +break ; +default : +break ; + }break ;case VSCSIBACK_OP_UPDATEDEV_STATE :
Signature · 1 line
2.1.4
Re: [PATCH V2 2/3] xen: scsiback: add LUN of restored domain
Quoted 7 lines · Juergen Gross
When a xen domain is being restored the LUN state of a pvscsi device is "Connected" and not "Initialising" as in case of attaching a new pvscsi LUN.
This must be taken into account when adding a new pvscsi device for a domain as otherwise the pvscsi LUN won't be connected to the SCSI target associated with it.
scsiback_do_add_lun() is being called from scsiback_frontend_changed() which eventually sets the state to Connected. Is the added test of 'try' an optimization or is it needed for correctness?
-boris
Quoted 52 lines
Signed-off-by Juergen Gross <[email protected]>--- drivers/xen/xen-scsiback.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-)drivers/xen/xen-scsiback.c +14
-5@@ -992,7 +992,7 @@ found: }static void scsiback_do_add_lun (struct vscsibk_info *info,const char *state, -char *phy,struct ids_tuple *vir) +char *phy,struct ids_tuple *vir,int try) {if (!scsiback_add_translation_entry (info, phy, vir)) { if (xenbus_printf(XBT_NIL, info->dev->nodename, state,@@ -1000,7 +1000,7 @@ static void scsiback_do_add_lun(struct vscsibk_info *info, const char *state,pr_err ("xen-pvscsi: xenbus_printf error %s\n" , state);scsiback_del_translation_entry (info, vir); } - }else { + }else if (!try) {xenbus_printf (XBT_NIL , info->dev->nodename, state,"%d" , XenbusStateClosed); }@@ -1060,10 +1060,19 @@ static void scsiback_do_1lun_hotplug(struct vscsibk_info *info, int op,switch (op) {case VSCSIBACK_OP_ADD_OR_DEL_LUN : -if (device_state == XenbusStateInitialising) -scsiback_do_add_lun (info, state, phy, &vir); -if (device_state == XenbusStateClosing) +switch (device_state) { +case XenbusStateInitialising: +scsiback_do_add_lun (info, state, phy, &vir,0 ); +break ; +case XenbusStateConnected: +scsiback_do_add_lun (info, state, phy, &vir,1 ); +break ; +case XenbusStateClosing:scsiback_do_del_lun (info, state, &vir); +break ; +default : +break ; + }break ;case VSCSIBACK_OP_UPDATEDEV_STATE :
Juergen Gross
maintainerRe: [PATCH V2 2/3] xen: scsiback: add LUN of restored domain
Quoted 5 lines · Boris Ostrovsky
Quoted 4 lines · Juergen Gross
When a xen domain is being restored the LUN state of a pvscsi device is "Connected" and not "Initialising" as in case of attaching a new pvscsi LUN.
Quoted 8 lines
Quoted 3 lines
This must be taken into account when adding a new pvscsi device for a domain as otherwise the pvscsi LUN won't be connected to the SCSI target associated with it.
scsiback_do_add_lun()is being called fromscsiback_frontend_changed()which eventually sets the state to Connected. Is the added test of 'try' an optimization or is it needed for correctness?
It's needed for correctness. In case of resume the translation entry will be already existing, thus scsiback_add_translation_entry() will return a value unequal to zero. We don't want to set the device state to "Closed" in this case.
Juergen
Quoted 66 lines
-boris
Quoted 53 lines
Signed-off-by Juergen Gross <[email protected]>--- drivers/xen/xen-scsiback.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-)drivers/xen/xen-scsiback.c +1
-1@@ -992,7 +992,7 @@ found: }static void scsiback_do_add_lun (struct vscsibk_info *info,const char *state, -char *phy,struct ids_tuple *vir) +char *phy,struct ids_tuple *vir,int try) {if (!scsiback_add_translation_entry (info, phy, vir)) {if (xenbus_printf(XBT_NIL, info->dev->nodename, state,drivers/xen/xen-scsiback.c +1
-1@@ -1000,7 +1000,7 @@ static void scsiback_do_add_lun(struct vscsibk_info *info, const char *state, pr_err("xen-pvscsi: xenbus_printf error %s\n", state);scsiback_del_translation_entry (info, vir); } - }else { + }else if (!try) {xenbus_printf (XBT_NIL , info->dev->nodename, state,"%d" , XenbusStateClosed);}drivers/xen/xen-scsiback.c +12
-3@@ -1060,10 +1060,19 @@ static void scsiback_do_1lun_hotplug(struct vscsibk_info *info, int op, switch (op) {case VSCSIBACK_OP_ADD_OR_DEL_LUN : -if (device_state == XenbusStateInitialising) -scsiback_do_add_lun (info, state, phy, &vir); -if (device_state == XenbusStateClosing) +switch (device_state) { +case XenbusStateInitialising: +scsiback_do_add_lun (info, state, phy, &vir,0 ); +break ; +case XenbusStateConnected: +scsiback_do_add_lun (info, state, phy, &vir,1 ); +break ; +case XenbusStateClosing:scsiback_do_del_lun (info, state, &vir); +break ; +default : +break ; + }break ;Quoted 2 lines
case
VSCSIBACK_OP_UPDATEDEV_STATE:--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Boris Ostrovsky
Reviewed-byRe: [PATCH V2 2/3] xen: scsiback: add LUN of restored domain
Quoted 11 lines · Juergen Gross
Quoted 10 lines · Boris Ostrovsky
Quoted 7 lines · Juergen Gross
When a xen domain is being restored the LUN state of a pvscsi device is "Connected" and not "Initialising" as in case of attaching a new pvscsi LUN.
This must be taken into account when adding a new pvscsi device for a domain as otherwise the pvscsi LUN won't be connected to the SCSI target associated with it.
Quoted 8 lines
Quoted 3 lines
scsiback_do_add_lun()is being called fromscsiback_frontend_changed()which eventually sets the state to Connected. Is the added test of 'try' an optimization or is it needed for correctness?It's needed for correctness. In case of resume the translation entry will be already existing, thus
scsiback_add_translation_entry()will return a value unequal to zero. We don't want to set the device state to "Closed" in this case.
Right, I understand that. I thought that after you
xenbus_printf(XBT_NIL, info->dev->nodename, state,
"%d", XenbusStateClosed);in scsiback_do_add_lun() you'd eventually
xenbus_switch_state(dev, XenbusStateConnected);
in scsiback_frontend_changed().
What I didn't realize was that this switch would only happen if dev->state is not XenbusStateConnected, which it still will be, even after xenbus_printf(XenbusStateClosed).
So
Quoted 71 lines
Juergen
Quoted 67 lines
-boris
Quoted 53 lines
Signed-off-by Juergen Gross <[email protected]>--- drivers/xen/xen-scsiback.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-)drivers/xen/xen-scsiback.c +1
-1@@ -992,7 +992,7 @@ found: }static void scsiback_do_add_lun (struct vscsibk_info *info,const char *state, -char *phy,struct ids_tuple *vir) +char *phy,struct ids_tuple *vir,int try) {if (!scsiback_add_translation_entry (info, phy, vir)) {if (xenbus_printf(XBT_NIL, info->dev->nodename, state,drivers/xen/xen-scsiback.c +1
-1@@ -1000,7 +1000,7 @@ static void scsiback_do_add_lun(struct vscsibk_info *info, const char *state, pr_err("xen-pvscsi: xenbus_printf error %s\n", state);scsiback_del_translation_entry (info, vir); } - }else { + }else if (!try) {xenbus_printf (XBT_NIL , info->dev->nodename, state,"%d" , XenbusStateClosed);}drivers/xen/xen-scsiback.c +12
-3@@ -1060,10 +1060,19 @@ static void scsiback_do_1lun_hotplug(struct vscsibk_info *info, int op, switch (op) {case VSCSIBACK_OP_ADD_OR_DEL_LUN : -if (device_state == XenbusStateInitialising) -scsiback_do_add_lun (info, state, phy, &vir); -if (device_state == XenbusStateClosing) +switch (device_state) { +case XenbusStateInitialising: +scsiback_do_add_lun (info, state, phy, &vir,0 ); +break ; +case XenbusStateConnected: +scsiback_do_add_lun (info, state, phy, &vir,1 ); +break ; +case XenbusStateClosing:scsiback_do_del_lun (info, state, &vir); +break ; +default : +break ; + }break ;Quoted 2 lines
case
VSCSIBACK_OP_UPDATEDEV_STATE:--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
David Vrabel
AppliedRe: [Xen-devel] [PATCH V2 2/3] xen: scsiback: add LUN of restored domain
In reply to Juergen GrossQuoted 7 lines · Juergen Gross
When a xen domain is being restored the LUN state of a pvscsi device is "Connected" and not "Initialising" as in case of attaching a new pvscsi LUN.
This must be taken into account when adding a new pvscsi device for a domain as otherwise the pvscsi LUN won't be connected to the SCSI target associated with it.
Applied to devel/for-linus-4.1, thanks.
David
Juergen Gross
maintainerPATCH v2 3/3 xen: support suspend/resume in pvscsi frontend
In reply to Juergen GrossUp to now the pvscsi frontend hasn't supported domain suspend and resume. When a domain with an assigned pvscsi device was suspended and resumed again, it was not able to use the device any more: trying to do so resulted in hanging processes.
Support suspend and resume of pvscsi devices.
--- drivers/scsi/xen-scsifront.c | 214 ++++++++++++++++++++++++++++++++++++------- 1 file changed, 179 insertions(+), 35 deletions(-)
drivers/scsi/xen-scsifront.c +179 -35
@@ -63,6 +63,7 @@#define VSCSIFRONT_OP_ADD_LUN 1#define VSCSIFRONT_OP_DEL_LUN 2 +#define VSCSIFRONT_OP_READD_LUN 3/* Tuning point. */ #define VSCSIIF_DEFAULT_CMD_PER_LUN 10
@@ -113,8 +114,13 @@ struct vscsifrnt_info {DECLARE_BITMAP (shadow_free_bitmap,VSCSIIF_MAX_REQS );struct vscsifrnt_shadow *shadow[VSCSIIF_MAX_REQS ]; +/* Following items are protected by the host lock. */ wait_queue_head_t wq_sync; +wait_queue_head_t wq_pause; unsigned int wait_ring_available:1; + unsigned int waiting_pause:1; + unsigned int pause:1; +unsigned callers;char dev_state_path[64 ];struct task_struct *curr;
@@ -274,31 +280,31 @@ static void scsifront_sync_cmd_done(struct vscsifrnt_info *info,wake_up (&shadow->wq_reset); } -static int scsifront_cmd_done (struct vscsifrnt_info *info) +static void scsifront_do_response (struct vscsifrnt_info *info, +struct vscsiif_response *ring_rsp) +{ +if (WARN (ring_rsp->rqid >=VSCSIIF_MAX_REQS || +test_bit (ring_rsp->rqid, info->shadow_free_bitmap), +"illegal rqid %u returned by backend!\n" , ring_rsp->rqid)) +return ; + +if (info->shadow[ring_rsp->rqid]->act ==VSCSIIF_ACT_SCSI_CDB ) +scsifront_cdb_cmd_done (info, ring_rsp); +else +scsifront_sync_cmd_done (info, ring_rsp); +} + +static int scsifront_ring_drain (struct vscsifrnt_info *info) {struct vscsiif_response *ring_rsp;RING_IDX i, rp;int more_to_do =0 ; -unsigned long flags; - -spin_lock_irqsave (info->host->host_lock, flags); rp = info->ring.sring->rsp_prod;rmb ();/* ordering required respective to dom0 */ for (i = info->ring.rsp_cons; i != rp; i++) { - ring_rsp =RING_GET_RESPONSE (&info->ring, i); - -if (WARN (ring_rsp->rqid >=VSCSIIF_MAX_REQS || -test_bit (ring_rsp->rqid, info->shadow_free_bitmap), -"illegal rqid %u returned by backend!\n" , - ring_rsp->rqid)) -continue ; - -if (info->shadow[ring_rsp->rqid]->act ==VSCSIIF_ACT_SCSI_CDB ) -scsifront_cdb_cmd_done (info, ring_rsp); -else -scsifront_sync_cmd_done (info, ring_rsp); +scsifront_do_response (info, ring_rsp); } info->ring.rsp_cons = i;
@@ -308,6 +314,18 @@ static int scsifront_cmd_done(struct vscsifrnt_info *info)else info->ring.sring->rsp_event = i +1 ; +return more_to_do; +} + +static int scsifront_cmd_done (struct vscsifrnt_info *info) +{ +int more_to_do; +unsigned long flags; + +spin_lock_irqsave (info->host->host_lock, flags); + + more_to_do =scsifront_ring_drain (info); + info->wait_ring_available =0 ;spin_unlock_irqrestore (info->host->host_lock, flags);
@@ -328,6 +346,24 @@ static irqreturn_t scsifront_irq_fn(int irq, void *dev_id)return IRQ_HANDLED ; } +static void scsifront_finish_all (struct vscsifrnt_info *info) +{ +unsigned i; +struct vscsiif_response resp; + +scsifront_ring_drain (info); + +for (i =0 ; i <VSCSIIF_MAX_REQS ; i++) { +if (test_bit (i, info->shadow_free_bitmap)) +continue ; + resp.rqid = i; + resp.sense_len =0 ; + resp.rslt =DID_RESET <<16 ; + resp.residual_len =0 ; +scsifront_do_response (info, &resp); + } +} + static int map_data_for_request(struct vscsifrnt_info *info, struct scsi_cmnd *sc, struct vscsiif_request *ring_req,
@@ -475,6 +511,27 @@ static struct vscsiif_request *scsifront_command2ring(return ring_req; } +static int scsifront_enter (struct vscsifrnt_info *info) +{ +if (info->pause) +return 1 ; + info->callers++; +return 0 ; +} + +static void scsifront_return (struct vscsifrnt_info *info) +{ + info->callers--; +if (info->callers) +return ; + +if (!info->waiting_pause) +return ; + + info->waiting_pause =0 ; +wake_up (&info->wq_pause); +} +static int scsifront_queuecommand (struct Scsi_Host *shost,struct scsi_cmnd *sc) {
@@ -486,6 +543,10 @@ static int scsifront_queuecommand(struct Scsi_Host *shost,uint16_t rqid;spin_lock_irqsave (shost->host_lock, flags); +if (scsifront_enter (info)) { +spin_unlock_irqrestore (shost->host_lock, flags); +return SCSI_MLQUEUE_HOST_BUSY ; + }if (RING_FULL (&info->ring)) goto busy;
@@ -505,6 +566,7 @@ static int scsifront_queuecommand(struct Scsi_Host *shost,if (err <0 ) {pr_debug ("%s: err %d\n" , __func__, err);scsifront_put_rqid (info, rqid); +scsifront_return (info);spin_unlock_irqrestore (shost->host_lock, flags);if (err == -ENOMEM )return SCSI_MLQUEUE_HOST_BUSY ;
@@ -514,11 +576,13 @@ static int scsifront_queuecommand(struct Scsi_Host *shost, }scsifront_do_request (info); +scsifront_return (info);spin_unlock_irqrestore (shost->host_lock, flags);return 0 ; busy: +scsifront_return (info);spin_unlock_irqrestore (shost->host_lock, flags);pr_debug ("%s: busy\n" , __func__);return SCSI_MLQUEUE_HOST_BUSY ;
@@ -549,7 +613,7 @@ static int scsifront_action_handler(struct scsi_cmnd *sc, uint8_t act)if (ring_req)break ; } -if (err) { +if (err || info->pause) {spin_unlock_irq (host->host_lock);kfree (shadow);return FAILED ;
@@ -561,6 +625,11 @@ static int scsifront_action_handler(struct scsi_cmnd *sc, uint8_t act)spin_lock_irq (host->host_lock); } +if (scsifront_enter (info)) { +spin_unlock_irq (host->host_lock); +return FAILED ; + } + ring_req->act = act; ring_req->ref_rqid = s->rqid;
@@ -587,6 +656,7 @@ static int scsifront_action_handler(struct scsi_cmnd *sc, uint8_t act) err =FAILED ; } +scsifront_return (info);spin_unlock_irq (host->host_lock);return err; }
@@ -698,6 +768,13 @@ free_gnttab:return err; } +static void scsifront_free_ring (struct vscsifrnt_info *info) +{ +unbind_from_irqhandler (info->irq, info); +gnttab_end_foreign_access (info->ring_ref,0 , + (unsigned long )info->ring.sring); +} +static int scsifront_init_ring (struct vscsifrnt_info *info) {struct xenbus_device *dev = info->dev;
@@ -744,9 +821,7 @@ again: fail:xenbus_transaction_end (xbt,1 ); free_sring: -unbind_from_irqhandler (info->irq, info); -gnttab_end_foreign_access (info->ring_ref,0 , - (unsigned long )info->ring.sring); +scsifront_free_ring (info);return err; }
@@ -779,6 +854,7 @@ static int scsifront_probe(struct xenbus_device *dev, }init_waitqueue_head (&info->wq_sync); +init_waitqueue_head (&info->wq_pause);spin_lock_init (&info->shadow_lock);snprintf (name,TASK_COMM_LEN ,"vscsiif.%d" , host->host_no);
@@ -802,13 +878,60 @@ static int scsifront_probe(struct xenbus_device *dev,return 0 ; free_sring: -unbind_from_irqhandler (info->irq, info); -gnttab_end_foreign_access (info->ring_ref,0 , - (unsigned long )info->ring.sring); +scsifront_free_ring (info);scsi_host_put (host);return err; } +static int scsifront_resume (struct xenbus_device *dev) +{ +struct vscsifrnt_info *info =dev_get_drvdata (&dev->dev); +struct Scsi_Host *host = info->host; +int err; + +spin_lock_irq (host->host_lock); + +/* Finish all still pending commands. */ +scsifront_finish_all (info); + +spin_unlock_irq (host->host_lock); + +/* Reconnect to dom0. */ +scsifront_free_ring (info); + err =scsifront_init_ring (info); +if (err) { +dev_err (&dev->dev,"fail to resume %d\n" , err); +scsi_host_put (host); +return err; + } + +xenbus_switch_state (dev, XenbusStateInitialised); + +return 0 ; +} + +static int scsifront_suspend (struct xenbus_device *dev) +{ +struct vscsifrnt_info *info =dev_get_drvdata (&dev->dev); +struct Scsi_Host *host = info->host; +int err =0 ; + +/* No new commands for the backend. */ +spin_lock_irq (host->host_lock); + info->pause =1 ; +while (info->callers && !err) { + info->waiting_pause =1 ; + info->wait_ring_available =0 ; +spin_unlock_irq (host->host_lock); +wake_up (&info->wq_sync); + err =wait_event_interruptible (info->wq_pause, + !info->waiting_pause); +spin_lock_irq (host->host_lock); + } +spin_unlock_irq (host->host_lock); +return err; +} +static int scsifront_remove (struct xenbus_device *dev) {struct vscsifrnt_info *info =dev_get_drvdata (&dev->dev);
@@ -823,10 +946,7 @@ static int scsifront_remove(struct xenbus_device *dev) }mutex_unlock (&scsifront_mutex); -gnttab_end_foreign_access (info->ring_ref,0 , - (unsigned long )info->ring.sring); -unbind_from_irqhandler (info->irq, info); - +scsifront_free_ring (info);scsi_host_put (info->host);return 0 ;
@@ -919,6 +1039,12 @@ static void scsifront_do_lun_hotplug(struct vscsifrnt_info *info, int op)scsi_device_put (sdev); }break ; +case VSCSIFRONT_OP_READD_LUN : +if (device_state == XenbusStateConnected) +xenbus_printf (XBT_NIL , dev->nodename, + info->dev_state_path, +"%d" , XenbusStateConnected); +break ;default :break ; }
@@ -932,21 +1058,29 @@ static void scsifront_do_lun_hotplug(struct vscsifrnt_info *info, int op)static void scsifront_read_backend_params (struct xenbus_device *dev,struct vscsifrnt_info *info) { -unsigned int sg_grant; +unsigned int sg_grant, nr_segs;int ret;struct Scsi_Host *host = info->host; ret =xenbus_scanf (XBT_NIL , dev->otherend,"feature-sg-grant" ,"%u" , &sg_grant); -if (ret ==1 && sg_grant) { - sg_grant = min_t(unsigned int, sg_grant, SG_ALL); - sg_grant = max_t(unsigned int, sg_grant, VSCSIIF_SG_TABLESIZE); - host->sg_tablesize = min_t(unsigned int, sg_grant, +if (ret !=1 ) + sg_grant =0 ; + nr_segs = min_t(unsigned int, sg_grant, SG_ALL); + nr_segs = max_t(unsigned int, nr_segs, VSCSIIF_SG_TABLESIZE); + nr_segs = min_t(unsigned int, nr_segs,VSCSIIF_SG_TABLESIZE *PAGE_SIZE /sizeof (struct scsiif_request_segment )); - host->max_sectors = (host->sg_tablesize -1 ) *PAGE_SIZE /512 ; - } -dev_info (&dev->dev,"using up to %d SG entries\n" , host->sg_tablesize); + +if (!info->pause && sg_grant) +dev_info (&dev->dev,"using up to %d SG entries\n" , nr_segs); +else if (info->pause && nr_segs < host->sg_tablesize) +dev_warn (&dev->dev, +"SG entries decreased from %d to %u - device may not work properly anymore\n" , + host->sg_tablesize, nr_segs); + + host->sg_tablesize = nr_segs; + host->max_sectors = (nr_segs -1 ) *PAGE_SIZE /512 ; } static void scsifront_backend_changed(struct xenbus_device *dev,
@@ -965,6 +1099,14 @@ static void scsifront_backend_changed(struct xenbus_device *dev,case XenbusStateConnected:scsifront_read_backend_params (dev, info); + +if (info->pause) { +scsifront_do_lun_hotplug (info,VSCSIFRONT_OP_READD_LUN ); +xenbus_switch_state (dev, XenbusStateConnected); + info->pause =0 ; +return ; + } +if (xenbus_read_driver_state (dev->nodename) == XenbusStateInitialised)scsifront_do_lun_hotplug (info,VSCSIFRONT_OP_ADD_LUN );
@@ -1002,6 +1144,8 @@ static struct xenbus_driver scsifront_driver = { .ids = scsifront_ids, .probe = scsifront_probe, .remove = scsifront_remove, + .resume = scsifront_resume, + .suspend = scsifront_suspend, .otherend_changed = scsifront_backend_changed, };
Signature · 1 line
2.1.4
David Vrabel
AppliedRe: [Xen-devel] [PATCH V2 3/3] xen: support suspend/resume in pvscsi frontend
Quoted 6 lines · Juergen Gross
Up to now the pvscsi frontend hasn't supported domain suspend and resume. When a domain with an assigned pvscsi device was suspended and resumed again, it was not able to use the device any more: trying to do so resulted in hanging processes.
Support suspend and resume of pvscsi devices.
Applied to devel/for-linus-4.1, thanks.
David