Skip to contentSkip to conversation

Staging: rts5208: Remove braces around single if-statement

PATCH In review Haneen Mohammed 2 participants 6 messages Feb 18, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: rts5208: Remove braces around single if-statement

This patch fixes the checkpatch.pl warning:

WARNING: suspect code indent for conditional statements (8, 8)

---
 drivers/staging/rts5208/rtsx_scsi.c | 2 --
 1 file changed, 2 deletions(-)
drivers/staging/rts5208/rtsx_scsi.c +0 -2
index 1161082..42645834 100644
@@ -519,10 +519,8 @@ static int inquiry(struct scsi_cmnd *srb, struct rtsx_chip *chip)
 #else
 	if (chip->mspro_formatter_enable)
 #endif
-	{
 		if (!card || (card == MS_CARD))
 			pro_formatter_flag = 1;
-	}
 
 	if (pro_formatter_flag) {
 		if (scsi_bufflen(srb) < 56)
Signature · 1 line
1.9.1
#1 lore raw
Quoted 3 lines · Haneen Mohammed

This patch fixes the checkpatch.pl warning:

WARNING: suspect code indent for conditional statements (8, 8)

Please change the commit message as well. It should reflect what was done.

julia

Quoted 31 lines
---
 drivers/staging/rts5208/rtsx_scsi.c | 2 --
 1 file changed, 2 deletions(-)
drivers/staging/rts5208/rtsx_scsi.c +0 -2
index 1161082..42645834 100644
@@ -519,10 +519,8 @@ static int inquiry(struct scsi_cmnd *srb, struct rtsx_chip *chip)
 #else
 	if (chip->mspro_formatter_enable)
 #endif
-	{
 		if (!card || (card == MS_CARD))
 			pro_formatter_flag = 1;
-	}
 
 	if (pro_formatter_flag) {
 		if (scsi_bufflen(srb) < 56)
Signature · 8 lines
1.9.1

-- 
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1424200549-23115-1-git-send-email-hamohammed.sa%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
#2 lore raw

PATCH 1/1 Staging: rts5208: Remove braces around single if-statement

This patch fixes the following checkpatch.pl warning:
"WARNING: suspect code indent for conditional statements (8, 8)" By removing unneeded braces around a single if-statement.

---
 drivers/staging/rts5208/rtsx_scsi.c | 2 --
 1 file changed, 2 deletions(-)
drivers/staging/rts5208/rtsx_scsi.c +0 -2
index 1161082..42645834 100644
@@ -519,10 +519,8 @@ static int inquiry(struct scsi_cmnd *srb, struct rtsx_chip *chip)
 #else
 	if (chip->mspro_formatter_enable)
 #endif
-	{
 		if (!card || (card == MS_CARD))
 			pro_formatter_flag = 1;
-	}
 
 	if (pro_formatter_flag) {
 		if (scsi_bufflen(srb) < 56)
Signature · 1 line
1.9.1
#3 lore raw

PATCH 1/1 Staging: rts5208: Remove braces around single if-statement

This patch removes unneeded braces around a single if-statement. This problem was found using checkpatch.pl.

---
v2: changed commit message

 drivers/staging/rts5208/rtsx_scsi.c | 2 --
 1 file changed, 2 deletions(-)
drivers/staging/rts5208/rtsx_scsi.c +0 -2
index 1161082..42645834 100644
@@ -519,10 +519,8 @@ static int inquiry(struct scsi_cmnd *srb, struct rtsx_chip *chip)
 #else
 	if (chip->mspro_formatter_enable)
 #endif
-	{
 		if (!card || (card == MS_CARD))
 			pro_formatter_flag = 1;
-	}
 
 	if (pro_formatter_flag) {
 		if (scsi_bufflen(srb) < 56)
Signature · 1 line
1.9.1
#4 lore raw

You need to put [PATCH v2] up in the subject line as well. Then is immediately clear that this is the second version of the patch.

julia

Quoted 35 lines · Haneen Mohammed

This patch removes unneeded braces around a single if-statement. This problem was found using checkpatch.pl.

---
v2: changed commit message

 drivers/staging/rts5208/rtsx_scsi.c | 2 --
 1 file changed, 2 deletions(-)
drivers/staging/rts5208/rtsx_scsi.c +0 -2
index 1161082..42645834 100644
@@ -519,10 +519,8 @@ static int inquiry(struct scsi_cmnd *srb, struct rtsx_chip *chip)
 #else
 	if (chip->mspro_formatter_enable)
 #endif
-	{
 		if (!card || (card == MS_CARD))
 			pro_formatter_flag = 1;
-	}
 
 	if (pro_formatter_flag) {
 		if (scsi_bufflen(srb) < 56)
Signature · 8 lines
1.9.1

-- 
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1424207434-24078-1-git-send-email-hamohammed.sa%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
#5 lore raw

PATCH v2 1/1 Staging: rts5208: Remove braces around single if-statement

This patch removes unneeded braces around a single if-statement. This problem was found using checkpatch.pl.

---
v2: changed commit message

 drivers/staging/rts5208/rtsx_scsi.c | 2 --
 1 file changed, 2 deletions(-)
drivers/staging/rts5208/rtsx_scsi.c +0 -2
index 1161082..42645834 100644
@@ -519,10 +519,8 @@ static int inquiry(struct scsi_cmnd *srb, struct rtsx_chip *chip)
 #else
 	if (chip->mspro_formatter_enable)
 #endif
-	{
 		if (!card || (card == MS_CARD))
 			pro_formatter_flag = 1;
-	}
 
 	if (pro_formatter_flag) {
 		if (scsi_bufflen(srb) < 56)
Signature · 1 line
1.9.1