drivers/vmw_vmci: Show correct get_user_pages_fast upon err
Subsystems (2)
PATCH 1/1 drivers/vmw_vmci: Show correct get_user_pages_fast upon err
As of 240ddd495a9 (vmw_vmci: Convert driver to use get_user_pages_fast()) we no longer call get_user_pages(), thus update the warning.
--- drivers/misc/vmw_vmci/vmci_queue_pair.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/misc/vmw_vmci/vmci_queue_pair.c +4 -2
@@ -737,7 +737,8 @@ static int qp_host_get_user_memory(u64 produce_uva, produce_q->kernel_if->num_pages,1 , produce_q->kernel_if->u.h.header_page);if (retval < produce_q->kernel_if->num_pages) { -pr_warn ("get_user_pages(produce) failed (retval=%d)" , retval); +pr_warn ("get_user_pages_fast(produce) failed (retval=%d)" , + retval);qp_release_pages (produce_q->kernel_if->u.h.header_page, retval, false); err =VMCI_ERROR_NO_MEM ;
@@ -748,7 +749,8 @@ static int qp_host_get_user_memory(u64 produce_uva, consume_q->kernel_if->num_pages,1 , consume_q->kernel_if->u.h.header_page);if (retval < consume_q->kernel_if->num_pages) { -pr_warn ("get_user_pages(consume) failed (retval=%d)" , retval); +pr_warn ("get_user_pages_fast(consume) failed (retval=%d)" , + retval);qp_release_pages (consume_q->kernel_if->u.h.header_page, retval, false); qp_release_pages(produce_q->kernel_if->u.h.header_page,
Signature · 1 line
2.1.4
Greg Kroah-Hartman
maintainerQuoted 13 lines · Davidlohr Bueso
As of
240ddd495a9(vmw_vmci: Convert driver to useget_user_pages_fast()) we no longer callget_user_pages(), thus update the warning.Signed-off-by Davidlohr Bueso <[email protected]>--- drivers/misc/vmw_vmci/vmci_queue_pair.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/misc/vmw_vmci/vmci_queue_pair.c +0
-0
drivers/misc/vmw_vmci/vmci_queue_pair.c static int qp_host_get_user_memory(u64 produce_uva, · line 741
Quoted 6 lines
drivers/misc/vmw_vmci/vmci_queue_pair.c +2
-1@@ -737,7 +737,8 @@ static int qp_host_get_user_memory(u64 produce_uva, produce_q->kernel_if->num_pages,1 , produce_q->kernel_if->u.h.header_page);if (retval < produce_q->kernel_if->num_pages) { -pr_warn ("get_user_pages(produce) failed (retval=%d)" , retval); +pr_warn ("get_user_pages_fast(produce) failed (retval=%d)" , + retval);
What can a user do with this message? Shouldn't it be a debug message?
thanks,
greg k-h
Quoted 9 lines · Greg Kroah-Hartman
Quoted 8 lines · Davidlohr Bueso
As of
240ddd495a9(vmw_vmci: Convert driver to useget_user_pages_fast()) we no longer callget_user_pages(), thus update the warning.Signed-off-by Davidlohr Bueso <[email protected]>--- drivers/misc/vmw_vmci/vmci_queue_pair.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
Quoted 13 lines
drivers/misc/vmw_vmci/vmci_queue_pair.c static int qp_host_get_user_memory(u64 produce_uva, · line 741
Quoted 11 lines
drivers/misc/vmw_vmci/vmci_queue_pair.c +2
-1@@ -737,7 +737,8 @@ static int qp_host_get_user_memory(u64 produce_uva, produce_q->kernel_if->num_pages,1 , produce_q->kernel_if->u.h.header_page);if (retval < produce_q->kernel_if->num_pages) { -pr_warn ("get_user_pages(produce) failed (retval=%d)" , retval); +pr_warn ("get_user_pages_fast(produce) failed (retval=%d)" , + retval);What can a user do with this message? Shouldn't it be a debug message?
I was trying to be as least invasive as possible, as I zero knowledge of this thingie. But yes, such a message does seem more appropriate as pr_debug(). Do you want me to respin?
Greg Kroah-Hartman
maintainerQuoted 24 lines · Davidlohr Bueso
Quoted 9 lines · Greg Kroah-Hartman
Quoted 8 lines · Davidlohr Bueso
As of
240ddd495a9(vmw_vmci: Convert driver to useget_user_pages_fast()) we no longer callget_user_pages(), thus update the warning.Signed-off-by Davidlohr Bueso <[email protected]>--- drivers/misc/vmw_vmci/vmci_queue_pair.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)Quoted 13 lines
drivers/misc/vmw_vmci/vmci_queue_pair.c static int qp_host_get_user_memory(u64 produce_uva, · line 741
Quoted 11 lines
drivers/misc/vmw_vmci/vmci_queue_pair.c +2
-1@@ -737,7 +737,8 @@ static int qp_host_get_user_memory(u64 produce_uva, produce_q->kernel_if->num_pages,1 , produce_q->kernel_if->u.h.header_page);if (retval < produce_q->kernel_if->num_pages) { -pr_warn ("get_user_pages(produce) failed (retval=%d)" , retval); +pr_warn ("get_user_pages_fast(produce) failed (retval=%d)" , + retval);What can a user do with this message? Shouldn't it be a debug message?
Quoted 3 lines
I was trying to be as least invasive as possible, as I zero knowledge of this thingie. But yes, such a message does seem more appropriate as
pr_debug(). Do you want me to respin?
Please do.
thanks,
greg k-h
PATCH v2 1/1 drivers/vmw_vmci: Show correct get_user_pages_fast upon failure
As of 240ddd495a9 (vmw_vmci: Convert driver to use get_user_pages_fast()) we no longer user get_user_pages(), thus update the warning.
Also convert to pr_debug, which is a more appropriate level of logging.
--- drivers/misc/vmw_vmci/vmci_queue_pair.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/misc/vmw_vmci/vmci_queue_pair.c +4 -2
@@ -737,7 +737,8 @@ static int qp_host_get_user_memory(u64 produce_uva, produce_q->kernel_if->num_pages,1 , produce_q->kernel_if->u.h.header_page);if (retval < produce_q->kernel_if->num_pages) { -pr_warn ("get_user_pages(produce) failed (retval=%d)" , retval); +pr_debug ("get_user_pages_fast(produce) failed (retval=%d)" , + retval);qp_release_pages (produce_q->kernel_if->u.h.header_page, retval, false); err =VMCI_ERROR_NO_MEM ;
@@ -748,7 +749,8 @@ static int qp_host_get_user_memory(u64 produce_uva, consume_q->kernel_if->num_pages,1 , consume_q->kernel_if->u.h.header_page);if (retval < consume_q->kernel_if->num_pages) { -pr_warn ("get_user_pages(consume) failed (retval=%d)" , retval); +pr_debug ("get_user_pages_fast(consume) failed (retval=%d)" , + retval);qp_release_pages (consume_q->kernel_if->u.h.header_page, retval, false); qp_release_pages(produce_q->kernel_if->u.h.header_page,
Signature · 1 line
2.1.4