locks: fix list insertion when lock is split in two
Subsystems (2)
PATCH 1/1 locks: fix list insertion when lock is split in two
Al reported that he had seen some LTP fcntl11 and fcntl21 test failures since the merge window had opened.
In the case where we're splitting a lock in two, the current code the new "left" lock in the incorrect spot. It's inserted just before "right" when it should instead be inserted just before the new lock.
When we add a new lock, set "fl" to that value so that we can add "left" before it.
Reported-by Al Viro <[email protected]>
Signed-off-by Jeff Layton <[email protected]>
--- fs/locks.c | 1 + 1 file changed, 1 insertion(+)
fs/locks.c +1 -0
@@ -1107,6 +1107,7 @@ static int __posix_lock_file(struct inode *inode, struct file_lock *request, str }locks_copy_lock (new_fl, request);locks_insert_lock_ctx (new_fl, &fl->fl_list); + fl = new_fl; new_fl =NULL ; }if (right) {
Signature · 1 line
2.1.0