Skip to contentSkip to conversation

mjpg-streamer: disable for static builds

PATCH New Vicente Olivert Riera 2 participants 3 messages Feb 18, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 mjpg-streamer: disable for static builds

This package needs to load plugins to do its job. Those plugins are shared objects (.so) which are loaded using 'dlopen()', so it makes no sense to enable this package when doing static builds where 'dlopen()' is not available.

Fixes:

http://autobuild.buildroot.net/results/cd5/cd52b739370d57b5ecbc6472b8c7f1126700e85f/

---
 package/mjpg-streamer/Config.in |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
package/mjpg-streamer/Config.in +4 -2
index 7925d41..db57bc0 100644
@@ -3,6 +3,7 @@ config BR2_PACKAGE_MJPG_STREAMER
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 # linux/uvcvideo.h
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_USE_MMU # fork()
+	depends on !BR2_STATIC_LIBS # plugins need dlopen()
 	select BR2_PACKAGE_JPEG
 	help
 	  MJPG-streamer takes JPGs from Linux-UVC compatible webcams, filesystem
@@ -11,6 +12,7 @@ config BR2_PACKAGE_MJPG_STREAMER
 
 	  http://mjpg-streamer.sourceforge.net
 
-comment "mjpg-streamer needs a toolchain w/ threads, headers >= 3.0"
+comment "mjpg-streamer needs a toolchain w/ threads, headers >= 3.0, dynamic library"
 	depends on BR2_USE_MMU
-	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0
+	depends on !BR2_TOOLCHAIN_HAS_THREADS || \
+		!BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 || BR2_STATIC_LIBS
Signature · 1 line
1.7.1
#1 lore raw

PATCH 2/2 mjpg-streamer: limit lines length to 72 characters

---
 package/mjpg-streamer/Config.in |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
package/mjpg-streamer/Config.in +3 -3
index db57bc0..f42c2a5 100644
@@ -6,9 +6,9 @@ config BR2_PACKAGE_MJPG_STREAMER
 	depends on !BR2_STATIC_LIBS # plugins need dlopen()
 	select BR2_PACKAGE_JPEG
 	help
-	  MJPG-streamer takes JPGs from Linux-UVC compatible webcams, filesystem
-	  or other input plugins and streams them as M-JPEG via HTTP to
-	  webbrowsers, VLC and other software.
+	  MJPG-streamer takes JPGs from Linux-UVC compatible webcams,
+	  filesystem or other input plugins and streams them as
+	  M-JPEG via HTTP to webbrowsers, VLC and other software.
 
 	  http://mjpg-streamer.sourceforge.net
 
Signature · 1 line
1.7.1
#2 lore raw

PATCH 1/2 mjpg-streamer: disable for static builds

In reply to Vicente Olivert Riera
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Vicente" == Vicente Olivert Riera <[email protected]> writes:

This package needs to load plugins to do its job. Those plugins are shared objects (.so) which are loaded using 'dlopen()', so it makes no sense to enable this package when doing static builds where 'dlopen()' is not available.

Quoted 5 lines

Fixes:

http://autobuild.buildroot.net/results/cd5/cd52b739370d57b5ecbc6472b8c7f1126700e85f/

Committed both, thanks.

Signature · 1 line
Bye, Peter Korsgaard