net: Initialize all members in skb_gro_remcsum_init()
Subsystems (2)
PATCH 1/1 net: Initialize all members in skb_gro_remcsum_init()
skb_gro_remcsum_init() initializes the gro_remcsum.delta member only, leading to compiler warnings about a possibly uninitialized gro_remcsum.offset member:
drivers/net/vxlan.c: In function ‘vxlan_gro_receive’:drivers/net/vxlan.c:602: warning: ‘grc.offset’ may be used uninitialized in this function net/ipv4/fou.c: In function ‘gue_gro_receive’:net/ipv4/fou.c:262: warning: ‘grc.offset’ may be used uninitialized in this function
While these are harmless for now:
- skb_gro_remcsum_process() sets offset before changing delta,
- skb_gro_remcsum_cleanup() checks if delta is non-zero before accessing offset,
it's safer to let the initialization function initialize all members.
--- include/linux/netdevice.h | 1 + 1 file changed, 1 insertion(+)
include/linux/netdevice.h +1 -0
@@ -2342,6 +2342,7 @@ struct gro_remcsum {static inline void skb_gro_remcsum_init (struct gro_remcsum *grc) { + grc->offset =0 ; grc->delta =0 ; }
Signature · 1 line
1.9.1
Quoted 9 lines · Geert Uytterhoeven
skb_gro_remcsum_init()initializes the gro_remcsum.delta member only, leading to compiler warnings about a possibly uninitialized gro_remcsum.offset member:
drivers/net/vxlan.c: In function ‘vxlan_gro_receive’:drivers/net/vxlan.c:602: warning: ‘grc.offset’ may be used uninitialized in this functionnet/ipv4/fou.c: In function ‘gue_gro_receive’:net/ipv4/fou.c:262: warning: ‘grc.offset’ may be used uninitialized in this function
Quoted 6 lines
While these are harmless for now:
-skb_gro_remcsum_process()sets offset before changing delta,
-skb_gro_remcsum_cleanup()checks if delta is non-zero before accessing offset,
it's safer to let the initialization function initialize all members.
Quoted 20 lines
Signed-off-by Geert Uytterhoeven <[email protected]>--- include/linux/netdevice.h | 1 + 1 file changed, 1 insertion(+)include/linux/netdevice.h +1
-1@@ -2342,6 +2342,7 @@ struct gro_remcsum {static inline void skb_gro_remcsum_init (struct gro_remcsum *grc) { + grc->offset =0 ; grc->delta =0 ; } --1.9.1
From: Geert Uytterhoeven <[email protected]>
Date: Wed, 18 Feb 2015 11:38:06 +0100
Quoted 9 lines
skb_gro_remcsum_init()initializes the gro_remcsum.delta member only, leading to compiler warnings about a possibly uninitialized gro_remcsum.offset member:
drivers/net/vxlan.c: In function ‘vxlan_gro_receive’:drivers/net/vxlan.c:602: warning: ‘grc.offset’ may be used uninitialized in this functionnet/ipv4/fou.c: In function ‘gue_gro_receive’:net/ipv4/fou.c:262: warning: ‘grc.offset’ may be used uninitialized in this function
Quoted 7 lines
While these are harmless for now:
-skb_gro_remcsum_process()sets offset before changing delta,
-skb_gro_remcsum_cleanup()checks if delta is non-zero before accessing offset,
it's safer to let the initialization function initialize all members.Signed-off-by Geert Uytterhoeven <[email protected]>
Applied, thank you.