Skip to contentSkip to conversation

iio: accel: mma9551: Protect PM-only functions by #ifdef CONFIG_PM_SLEEP

PATCH In review Geert Uytterhoeven 2 participants 3 messages Feb 18, 2015 IIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: accel: mma9551: Protect PM-only functions by #ifdef CONFIG_PM_SLEEP

If CONFIG_PM_SLEEP=n:

drivers/iio/common/ssp_sensors/ssp_dev.c:644: warning: ‘ssp_suspend’ defined but not used drivers/iio/common/ssp_sensors/ssp_dev.c:669: warning: ‘ssp_resume’ defined but not used

Protect the unused functions by #ifdef CONFIG_PM_SLEEP to fix this.

---
 drivers/iio/common/ssp_sensors/ssp_dev.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/iio/common/ssp_sensors/ssp_dev.c +2 -0
index 52d70435f5a11c55..55a90082a29bd484 100644
@@ -640,6 +640,7 @@ static int ssp_remove(struct spi_device *spi)
 	return 0;
 }
 
+#ifdef CONFIG_PM_SLEEP
 static int ssp_suspend(struct device *dev)
 {
 	int ret;
@@ -688,6 +689,7 @@ static int ssp_resume(struct device *dev)
 
 	return 0;
 }
+#endif /* CONFIG_PM_SLEEP */
 
 static const struct dev_pm_ops ssp_pm_ops = {
 	SET_SYSTEM_SLEEP_PM_OPS(ssp_suspend, ssp_resume)
Signature · 1 line
1.9.1
#1 lore raw
Quoted 26 lines · Geert Uytterhoeven

If CONFIG_PM_SLEEP=n:

drivers/iio/common/ssp_sensors/ssp_dev.c:644: warning: ‘ssp_suspend’ defined but not used drivers/iio/common/ssp_sensors/ssp_dev.c:669: warning: ‘ssp_resume’ defined but not used

Protect the unused functions by #ifdef CONFIG_PM_SLEEP to fix this.

---
 drivers/iio/common/ssp_sensors/ssp_dev.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/iio/common/ssp_sensors/ssp_dev.c +1 -0
index 52d70435f5a11c55..55a90082a29bd484 100644
@@ -640,6 +640,7 @@ static int ssp_remove(struct spi_device *spi)
 	return 0;
 }
 
+#ifdef CONFIG_PM_SLEEP
 static int ssp_suspend(struct device *dev)
 {
 	int ret;

drivers/iio/common/ssp_sensors/ssp_dev.c static int ssp_resume(struct device *dev) · line 695

Quoted 7 lines
drivers/iio/common/ssp_sensors/ssp_dev.c +1 -0
@@ -688,6 +689,7 @@ static int ssp_resume(struct device *dev)
 
 	return 0;
 }
+#endif /* CONFIG_PM_SLEEP */
 
 static const struct dev_pm_ops ssp_pm_ops = {
 	SET_SYSTEM_SLEEP_PM_OPS(ssp_suspend, ssp_resume)

Patch is ok but commit title points to different driver. Irina would be surprised and confused to see it on the list and log.

Please, use something like that: iio: common: ssp_sensors: Fix warnings ...

Thanks,
Karol

#2 lore raw
Quoted 2 lines · Karol Wrona

Patch is ok but commit title points to different driver. Irina would be surprised and confused to see it on the list and log.

Woops, that was a serious copy-and-paste bug on my side. Sorry for that.

Quoted 1 line

Please, use something like that: iio: common: ssp_sensors: Fix warnings ...

Resent with corrected subject.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds