Skip to contentSkip to conversation

arm/arm64: Detect Xen support earlier

PATCH Superseded Julien Grall 5 participants 30 messages Feb 18, 2015 – May 6, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v2 cover arm/arm64: Detect Xen support earlier

Hello,

This small patch series moves the detection of running on Xen earlier. This is required in order to support earlyprintk via Xen and selecting preferred console.

Actually, the last patch of this patch series adds HVC0 as preferred console when running on Xen. The patch [1] was previously separetly sent by Ard.

For the maintainers, does this patch series should go in upstream via the ARM tree or Xen tree?

Regards,

[1] https://patches.linaro.org/44633/

Ard Biesheuvel (1):
xen/arm: allow console=hvc0 to be omitted for guests

Julien Grall (1):
arm/xen: Correctly check if the event channel interrupt is present

Stefano Stabellini (1):
arm,arm64/xen: move Xen initialization earlier

 arch/arm/include/asm/xen/hypervisor.h |  8 +++++
 arch/arm/kernel/setup.c               |  2 ++
 arch/arm/xen/enlighten.c              | 62 ++++++++++++++++++++++-------------
 arch/arm64/kernel/setup.c             |  2 ++
 4 files changed, 51 insertions(+), 23 deletions(-)
Signature · 1 line
2.1.4
#1 lore raw

PATCH v2 1/3 arm/xen: Correctly check if the event channel interrupt is present

The function irq_of_parse_and_map returns 0 when the IRQ is not found.

Futhermore, move the check before notifying the user that we are running on Xen.

---
Changes in v2:
- Add Ian's ack
- Re-add __read_mostly

---
 arch/arm/xen/enlighten.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
arch/arm/xen/enlighten.c +6 -4
index 263a204..c8d3a17 100644
@@ -51,7 +51,7 @@ EXPORT_SYMBOL_GPL(xen_have_vector_callback);
 int xen_platform_pci_unplug = XEN_UNPLUG_ALL;
 EXPORT_SYMBOL_GPL(xen_platform_pci_unplug);
 
-static __read_mostly int xen_events_irq = -1;
+static __read_mostly unsigned int xen_events_irq;
 
 /* map fgmfn of domid to lpfn in the current domain */
 static int map_foreign_page(unsigned long lpfn, unsigned long fgmfn,
@@ -251,12 +251,14 @@ static int __init xen_guest_init(void)
 		return 0;
 	grant_frames = res.start;
 	xen_events_irq = irq_of_parse_and_map(node, 0);
+	if (!xen_events_irq) {
+		pr_debug("Xen event channel interrupt not found\n");
+		return -ENODEV;
+	}
+
 	pr_info("Xen %s support found, events_irq=%d gnttab_frame=%pa\n",
 			version, xen_events_irq, &grant_frames);
 
-	if (xen_events_irq < 0)
-		return -ENODEV;
-
 	xen_domain_type = XEN_HVM_DOMAIN;
 
 	xen_setup_features();
Signature · 1 line
2.1.4
#2 lore raw

PATCH v2 1/3 arm/xen: Correctly check if the event channel interrupt is present

Quoted 7 lines · Julien Grall

The function irq_of_parse_and_map returns 0 when the IRQ is not found.

Futhermore, move the check before notifying the user that we are running on Xen.

Quoted 42 lines

---
Changes in v2:
- Add Ian's ack
- Re-add __read_mostly

---
 arch/arm/xen/enlighten.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
arch/arm/xen/enlighten.c +6 -4
index 263a204..c8d3a17 100644
@@ -51,7 +51,7 @@ EXPORT_SYMBOL_GPL(xen_have_vector_callback);
 int xen_platform_pci_unplug = XEN_UNPLUG_ALL;
 EXPORT_SYMBOL_GPL(xen_platform_pci_unplug);
 
-static __read_mostly int xen_events_irq = -1;
+static __read_mostly unsigned int xen_events_irq;
 
 /* map fgmfn of domid to lpfn in the current domain */
 static int map_foreign_page(unsigned long lpfn, unsigned long fgmfn,
@@ -251,12 +251,14 @@ static int __init xen_guest_init(void)
 		return 0;
 	grant_frames = res.start;
 	xen_events_irq = irq_of_parse_and_map(node, 0);
+	if (!xen_events_irq) {
+		pr_debug("Xen event channel interrupt not found\n");
+		return -ENODEV;
+	}
+
 	pr_info("Xen %s support found, events_irq=%d gnttab_frame=%pa\n",
 			version, xen_events_irq, &grant_frames);
 
-	if (xen_events_irq < 0)
-		return -ENODEV;
-
 	xen_domain_type = XEN_HVM_DOMAIN;
 
 	xen_setup_features();
Signature · 1 line
2.1.4
Acked-by on v2 1/3
#3 lore raw

Re: [PATCH v2 1/3] arm/xen: Correctly check if the event channel interrupt is present

In reply to Julien Grall
Quoted 7 lines · Julien Grall

The function irq_of_parse_and_map returns 0 when the IRQ is not found.

Futhermore, move the check before notifying the user that we are running on Xen.

Quoted 42 lines

---
Changes in v2:
- Add Ian's ack
- Re-add __read_mostly

---
 arch/arm/xen/enlighten.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
arch/arm/xen/enlighten.c +6 -4
index 263a204..c8d3a17 100644
@@ -51,7 +51,7 @@ EXPORT_SYMBOL_GPL(xen_have_vector_callback);
 int xen_platform_pci_unplug = XEN_UNPLUG_ALL;
 EXPORT_SYMBOL_GPL(xen_platform_pci_unplug);
 
-static __read_mostly int xen_events_irq = -1;
+static __read_mostly unsigned int xen_events_irq;
 
 /* map fgmfn of domid to lpfn in the current domain */
 static int map_foreign_page(unsigned long lpfn, unsigned long fgmfn,
@@ -251,12 +251,14 @@ static int __init xen_guest_init(void)
 		return 0;
 	grant_frames = res.start;
 	xen_events_irq = irq_of_parse_and_map(node, 0);
+	if (!xen_events_irq) {
+		pr_debug("Xen event channel interrupt not found\n");
+		return -ENODEV;
+	}
+
 	pr_info("Xen %s support found, events_irq=%d gnttab_frame=%pa\n",
 			version, xen_events_irq, &grant_frames);
 
-	if (xen_events_irq < 0)
-		return -ENODEV;
-
 	xen_domain_type = XEN_HVM_DOMAIN;
 
 	xen_setup_features();
Signature · 1 line
2.1.4
#4 lore raw

PATCH v2 1/3 arm/xen: Correctly check if the event channel interrupt is present

In reply to Julien Grall

The function irq_of_parse_and_map returns 0 when the IRQ is not found.

Futhermore, move the check before notifying the user that we are running on Xen.

---
Changes in v2:
- Add Ian's ack
- Re-add __read_mostly

---
 arch/arm/xen/enlighten.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
arch/arm/xen/enlighten.c +6 -4
index 263a204..c8d3a17 100644
@@ -51,7 +51,7 @@ EXPORT_SYMBOL_GPL(xen_have_vector_callback);
 int xen_platform_pci_unplug = XEN_UNPLUG_ALL;
 EXPORT_SYMBOL_GPL(xen_platform_pci_unplug);
 
-static __read_mostly int xen_events_irq = -1;
+static __read_mostly unsigned int xen_events_irq;
 
 /* map fgmfn of domid to lpfn in the current domain */
 static int map_foreign_page(unsigned long lpfn, unsigned long fgmfn,
@@ -251,12 +251,14 @@ static int __init xen_guest_init(void)
 		return 0;
 	grant_frames = res.start;
 	xen_events_irq = irq_of_parse_and_map(node, 0);
+	if (!xen_events_irq) {
+		pr_debug("Xen event channel interrupt not found\n");
+		return -ENODEV;
+	}
+
 	pr_info("Xen %s support found, events_irq=%d gnttab_frame=%pa\n",
 			version, xen_events_irq, &grant_frames);
 
-	if (xen_events_irq < 0)
-		return -ENODEV;
-
 	xen_domain_type = XEN_HVM_DOMAIN;
 
 	xen_setup_features();
Signature · 1 line
2.1.4
#5 lore raw

PATCH v2 2/3 arm,arm64/xen: move Xen initialization earlier

In reply to Julien Grall

From: Stefano Stabellini <[email protected]>

Currently, Xen is initialized/discovered in an initcall. This doesn't allow us to support earlyprintk or choosing the preferred console when running on Xen.

The current function xen_guest_init is now split in 2 parts:
- xen_early_init: Check if there is a Xen node in the device tree and setup domain type
- xen_guest_init: Retrieve the information from the device node and initialize Xen (grant table, shared page...)

The former is called in setup_arch, while the latter is an initcall.

---
It's based on a patch sent by Stefano nearly 2 years ago [1].

[1] http://lists.xen.org/archives/html/xen-devel/2013-08/msg02960.html

Changes in v2:
- Add Ian's ack

---
 arch/arm/include/asm/xen/hypervisor.h |  8 +++++
 arch/arm/kernel/setup.c               |  2 ++
 arch/arm/xen/enlighten.c              | 58 ++++++++++++++++++++---------------
 arch/arm64/kernel/setup.c             |  2 ++
 4 files changed, 46 insertions(+), 24 deletions(-)
arch/arm/include/asm/xen/hypervisor.h +8 -0
index 1317ee4..04ff8e7 100644
@@ -1,6 +1,8 @@
 #ifndef _ASM_ARM_XEN_HYPERVISOR_H
 #define _ASM_ARM_XEN_HYPERVISOR_H
 
+#include <linux/init.h>
+
 extern struct shared_info *HYPERVISOR_shared_info;
 extern struct start_info *xen_start_info;
 
@@ -18,4 +20,10 @@ static inline enum paravirt_lazy_mode paravirt_get_lazy_mode(void)
 
 extern struct dma_map_ops *xen_dma_ops;
 
+#ifdef CONFIG_XEN
+void __init xen_early_init(void);
+#else
+static inline void xen_early_init(void) { return; }
+#endif
+
 #endif /* _ASM_ARM_XEN_HYPERVISOR_H */
arch/arm/kernel/setup.c +2 -0
index e55408e..8b59d0d 100644
@@ -46,6 +46,7 @@
 #include <asm/cacheflush.h>
 #include <asm/cachetype.h>
 #include <asm/tlbflush.h>
+#include <asm/xen/hypervisor.h>
 
 #include <asm/prom.h>
 #include <asm/mach/arch.h>
@@ -936,6 +937,7 @@ void __init setup_arch(char **cmdline_p)
 
 	arm_dt_init_cpu_maps();
 	psci_init();
+	xen_early_init();
 #ifdef CONFIG_SMP
 	if (is_smp()) {
 		if (!mdesc->smp_init || !mdesc->smp_init()) {
arch/arm/xen/enlighten.c +34 -24

92 lines not on this page · raw message

arch/arm64/kernel/setup.c +2 -0
index e8420f6..c00ae01 100644
@@ -62,6 +62,7 @@
 #include <asm/memblock.h>
 #include <asm/psci.h>
 #include <asm/efi.h>
+#include <asm/xen/hypervisor.h>
 
 unsigned int processor_id;
 EXPORT_SYMBOL(processor_id);
@@ -388,6 +389,7 @@ void __init setup_arch(char **cmdline_p)
 	unflatten_device_tree();
 
 	psci_init();
+	xen_early_init();
 
 	cpu_read_bootcpu_ops();
 #ifdef CONFIG_SMP
Signature · 1 line
2.1.4
#6 lore raw

PATCH v2 2/3 arm,arm64/xen: move Xen initialization earlier

Russell,

I think that this patch should go via the Xen tree, however as it touches arch/arm/kernel/setup.c, I would like your Acked-by before adding it to the Xen queue.

Thanks,

Stefano

Quoted 201 lines · Julien Grall

From: Stefano Stabellini <[email protected]>

Currently, Xen is initialized/discovered in an initcall. This doesn't allow us to support earlyprintk or choosing the preferred console when running on Xen.

The current function xen_guest_init is now split in 2 parts:
- xen_early_init: Check if there is a Xen node in the device tree and setup domain type
- xen_guest_init: Retrieve the information from the device node and initialize Xen (grant table, shared page...)

The former is called in setup_arch, while the latter is an initcall.

---
It's based on a patch sent by Stefano nearly 2 years ago [1].

[1] http://lists.xen.org/archives/html/xen-devel/2013-08/msg02960.html

Changes in v2:
- Add Ian's ack

---
 arch/arm/include/asm/xen/hypervisor.h |  8 +++++
 arch/arm/kernel/setup.c               |  2 ++
 arch/arm/xen/enlighten.c              | 58 ++++++++++++++++++++---------------
 arch/arm64/kernel/setup.c             |  2 ++
 4 files changed, 46 insertions(+), 24 deletions(-)
arch/arm/include/asm/xen/hypervisor.h +8 -0
index 1317ee4..04ff8e7 100644
@@ -1,6 +1,8 @@
 #ifndef _ASM_ARM_XEN_HYPERVISOR_H
 #define _ASM_ARM_XEN_HYPERVISOR_H
 
+#include <linux/init.h>
+
 extern struct shared_info *HYPERVISOR_shared_info;
 extern struct start_info *xen_start_info;
 
@@ -18,4 +20,10 @@ static inline enum paravirt_lazy_mode paravirt_get_lazy_mode(void)
 
 extern struct dma_map_ops *xen_dma_ops;
 
+#ifdef CONFIG_XEN
+void __init xen_early_init(void);
+#else
+static inline void xen_early_init(void) { return; }
+#endif
+
 #endif /* _ASM_ARM_XEN_HYPERVISOR_H */
arch/arm/kernel/setup.c +2 -0
index e55408e..8b59d0d 100644
@@ -46,6 +46,7 @@
 #include <asm/cacheflush.h>
 #include <asm/cachetype.h>
 #include <asm/tlbflush.h>
+#include <asm/xen/hypervisor.h>
 
 #include <asm/prom.h>
 #include <asm/mach/arch.h>
@@ -936,6 +937,7 @@ void __init setup_arch(char **cmdline_p)
 
 	arm_dt_init_cpu_maps();
 	psci_init();
+	xen_early_init();
 #ifdef CONFIG_SMP
 	if (is_smp()) {
 		if (!mdesc->smp_init || !mdesc->smp_init()) {
arch/arm/xen/enlighten.c +34 -24
index c8d3a17..1660432 100644
@@ -53,6 +53,8 @@ EXPORT_SYMBOL_GPL(xen_platform_pci_unplug);
 
 static __read_mostly unsigned int xen_events_irq;
 
+static __initdata struct device_node *xen_node;
+
 /* map fgmfn of domid to lpfn in the current domain */
 static int map_foreign_page(unsigned long lpfn, unsigned long fgmfn,
 			    unsigned int domid)
@@ -222,42 +224,28 @@ static irqreturn_t xen_arm_callback(int irq, void *arg)
  * documentation of the Xen Device Tree format.
  */
 #define GRANT_TABLE_PHYSADDR 0
-static int __init xen_guest_init(void)
+void __init xen_early_init(void)
 {
-	struct xen_add_to_physmap xatp;
-	static struct shared_info *shared_info_page = 0;
-	struct device_node *node;
 	int len;
 	const char *s = NULL;
 	const char *version = NULL;
 	const char *xen_prefix = "xen,xen-";
-	struct resource res;
-	phys_addr_t grant_frames;
 
-	node = of_find_compatible_node(NULL, NULL, "xen,xen");
-	if (!node) {
+	xen_node = of_find_compatible_node(NULL, NULL, "xen,xen");
+	if (!xen_node) {
 		pr_debug("No Xen support\n");
-		return 0;
+		return;
 	}
-	s = of_get_property(node, "compatible", &len);
+	s = of_get_property(xen_node, "compatible", &len);
 	if (strlen(xen_prefix) + 3  < len &&
 			!strncmp(xen_prefix, s, strlen(xen_prefix)))
 		version = s + strlen(xen_prefix);
 	if (version == NULL) {
 		pr_debug("Xen version not found\n");
-		return 0;
-	}
-	if (of_address_to_resource(node, GRANT_TABLE_PHYSADDR, &res))
-		return 0;
-	grant_frames = res.start;
-	xen_events_irq = irq_of_parse_and_map(node, 0);
-	if (!xen_events_irq) {
-		pr_debug("Xen event channel interrupt not found\n");
-		return -ENODEV;
+		return;
 	}
 
-	pr_info("Xen %s support found, events_irq=%d gnttab_frame=%pa\n",
-			version, xen_events_irq, &grant_frames);
+	pr_info("Xen %s support found\n", version);
 
 	xen_domain_type = XEN_HVM_DOMAIN;
 
@@ -267,10 +255,32 @@ static int __init xen_guest_init(void)
 		xen_start_info->flags |= SIF_INITDOMAIN|SIF_PRIVILEGED;
 	else
 		xen_start_info->flags &= ~(SIF_INITDOMAIN|SIF_PRIVILEGED);
+}
+
+static int __init xen_guest_init(void)
+{
+	struct xen_add_to_physmap xatp;
+	struct shared_info *shared_info_page = NULL;
+	struct resource res;
+	phys_addr_t grant_frames;
+
+	if (!xen_domain())
+		return 0;
+
+	if (of_address_to_resource(xen_node, GRANT_TABLE_PHYSADDR, &res)) {
+		pr_err("Xen grant table base address not found\n");
+		return -ENODEV;
+	}
+	grant_frames = res.start;
+
+	xen_events_irq = irq_of_parse_and_map(xen_node, 0);
+	if (!xen_events_irq) {
+		pr_err("Xen event channel interrupt not found\n");
+		return -ENODEV;
+	}
+
+	shared_info_page = (struct shared_info *)get_zeroed_page(GFP_KERNEL);
 
-	if (!shared_info_page)
-		shared_info_page = (struct shared_info *)
-			get_zeroed_page(GFP_KERNEL);
 	if (!shared_info_page) {
 		pr_err("not enough memory\n");
 		return -ENOMEM;
arch/arm64/kernel/setup.c +2 -0
index e8420f6..c00ae01 100644
@@ -62,6 +62,7 @@
 #include <asm/memblock.h>
 #include <asm/psci.h>
 #include <asm/efi.h>
+#include <asm/xen/hypervisor.h>
 
 unsigned int processor_id;
 EXPORT_SYMBOL(processor_id);
@@ -388,6 +389,7 @@ void __init setup_arch(char **cmdline_p)
 	unflatten_device_tree();
 
 	psci_init();
+	xen_early_init();
 
 	cpu_read_bootcpu_ops();
 #ifdef CONFIG_SMP
Signature · 1 line
2.1.4
#7 lore raw

PATCH v2 2/3 arm,arm64/xen: move Xen initialization earlier

Hi Russell,

I am going to queue this up in the xentip tree for 4.2, let me know if you have any issues.

Cheers,

Stefano

Quoted 214 lines · Stefano Stabellini

Russell,

I think that this patch should go via the Xen tree, however as it touches arch/arm/kernel/setup.c, I would like your Acked-by before adding it to the Xen queue.

Thanks,

Stefano

Quoted 201 lines · Julien Grall

From: Stefano Stabellini <[email protected]>

Currently, Xen is initialized/discovered in an initcall. This doesn't allow us to support earlyprintk or choosing the preferred console when running on Xen.

The current function xen_guest_init is now split in 2 parts:
- xen_early_init: Check if there is a Xen node in the device tree and setup domain type
- xen_guest_init: Retrieve the information from the device node and initialize Xen (grant table, shared page...)

The former is called in setup_arch, while the latter is an initcall.

---
It's based on a patch sent by Stefano nearly 2 years ago [1].

[1] http://lists.xen.org/archives/html/xen-devel/2013-08/msg02960.html

Changes in v2:
- Add Ian's ack

---
 arch/arm/include/asm/xen/hypervisor.h |  8 +++++
 arch/arm/kernel/setup.c               |  2 ++
 arch/arm/xen/enlighten.c              | 58 ++++++++++++++++++++---------------
 arch/arm64/kernel/setup.c             |  2 ++
 4 files changed, 46 insertions(+), 24 deletions(-)
arch/arm/include/asm/xen/hypervisor.h +8 -0
index 1317ee4..04ff8e7 100644
@@ -1,6 +1,8 @@
 #ifndef _ASM_ARM_XEN_HYPERVISOR_H
 #define _ASM_ARM_XEN_HYPERVISOR_H
 
+#include <linux/init.h>
+
 extern struct shared_info *HYPERVISOR_shared_info;
 extern struct start_info *xen_start_info;
 
@@ -18,4 +20,10 @@ static inline enum paravirt_lazy_mode paravirt_get_lazy_mode(void)
 
 extern struct dma_map_ops *xen_dma_ops;
 
+#ifdef CONFIG_XEN
+void __init xen_early_init(void);
+#else
+static inline void xen_early_init(void) { return; }
+#endif
+
 #endif /* _ASM_ARM_XEN_HYPERVISOR_H */
arch/arm/kernel/setup.c +2 -0
index e55408e..8b59d0d 100644
@@ -46,6 +46,7 @@
 #include <asm/cacheflush.h>
 #include <asm/cachetype.h>
 #include <asm/tlbflush.h>
+#include <asm/xen/hypervisor.h>
 
 #include <asm/prom.h>
 #include <asm/mach/arch.h>
@@ -936,6 +937,7 @@ void __init setup_arch(char **cmdline_p)
 
 	arm_dt_init_cpu_maps();
 	psci_init();
+	xen_early_init();
 #ifdef CONFIG_SMP
 	if (is_smp()) {
 		if (!mdesc->smp_init || !mdesc->smp_init()) {
arch/arm/xen/enlighten.c +34 -24
index c8d3a17..1660432 100644
@@ -53,6 +53,8 @@ EXPORT_SYMBOL_GPL(xen_platform_pci_unplug);
 
 static __read_mostly unsigned int xen_events_irq;
 
+static __initdata struct device_node *xen_node;
+
 /* map fgmfn of domid to lpfn in the current domain */
 static int map_foreign_page(unsigned long lpfn, unsigned long fgmfn,
 			    unsigned int domid)
@@ -222,42 +224,28 @@ static irqreturn_t xen_arm_callback(int irq, void *arg)
  * documentation of the Xen Device Tree format.
  */
 #define GRANT_TABLE_PHYSADDR 0
-static int __init xen_guest_init(void)
+void __init xen_early_init(void)
 {
-	struct xen_add_to_physmap xatp;
-	static struct shared_info *shared_info_page = 0;
-	struct device_node *node;
 	int len;
 	const char *s = NULL;
 	const char *version = NULL;
 	const char *xen_prefix = "xen,xen-";
-	struct resource res;
-	phys_addr_t grant_frames;
 
-	node = of_find_compatible_node(NULL, NULL, "xen,xen");
-	if (!node) {
+	xen_node = of_find_compatible_node(NULL, NULL, "xen,xen");
+	if (!xen_node) {
 		pr_debug("No Xen support\n");
-		return 0;
+		return;
 	}
-	s = of_get_property(node, "compatible", &len);
+	s = of_get_property(xen_node, "compatible", &len);
 	if (strlen(xen_prefix) + 3  < len &&
 			!strncmp(xen_prefix, s, strlen(xen_prefix)))
 		version = s + strlen(xen_prefix);
 	if (version == NULL) {
 		pr_debug("Xen version not found\n");
-		return 0;
-	}
-	if (of_address_to_resource(node, GRANT_TABLE_PHYSADDR, &res))
-		return 0;
-	grant_frames = res.start;
-	xen_events_irq = irq_of_parse_and_map(node, 0);
-	if (!xen_events_irq) {
-		pr_debug("Xen event channel interrupt not found\n");
-		return -ENODEV;
+		return;
 	}
 
-	pr_info("Xen %s support found, events_irq=%d gnttab_frame=%pa\n",
-			version, xen_events_irq, &grant_frames);
+	pr_info("Xen %s support found\n", version);
 
 	xen_domain_type = XEN_HVM_DOMAIN;
 
@@ -267,10 +255,32 @@ static int __init xen_guest_init(void)
 		xen_start_info->flags |= SIF_INITDOMAIN|SIF_PRIVILEGED;
 	else
 		xen_start_info->flags &= ~(SIF_INITDOMAIN|SIF_PRIVILEGED);
+}
+
+static int __init xen_guest_init(void)
+{
+	struct xen_add_to_physmap xatp;
+	struct shared_info *shared_info_page = NULL;
+	struct resource res;
+	phys_addr_t grant_frames;
+
+	if (!xen_domain())
+		return 0;
+
+	if (of_address_to_resource(xen_node, GRANT_TABLE_PHYSADDR, &res)) {
+		pr_err("Xen grant table base address not found\n");
+		return -ENODEV;
+	}
+	grant_frames = res.start;
+
+	xen_events_irq = irq_of_parse_and_map(xen_node, 0);
+	if (!xen_events_irq) {
+		pr_err("Xen event channel interrupt not found\n");
+		return -ENODEV;
+	}
+
+	shared_info_page = (struct shared_info *)get_zeroed_page(GFP_KERNEL);
 
-	if (!shared_info_page)
-		shared_info_page = (struct shared_info *)
-			get_zeroed_page(GFP_KERNEL);
 	if (!shared_info_page) {
 		pr_err("not enough memory\n");
 		return -ENOMEM;
arch/arm64/kernel/setup.c +2 -0
index e8420f6..c00ae01 100644
@@ -62,6 +62,7 @@
 #include <asm/memblock.h>
 #include <asm/psci.h>
 #include <asm/efi.h>
+#include <asm/xen/hypervisor.h>
 
 unsigned int processor_id;
 EXPORT_SYMBOL(processor_id);
@@ -388,6 +389,7 @@ void __init setup_arch(char **cmdline_p)
 	unflatten_device_tree();
 
 	psci_init();
+	xen_early_init();
 
 	cpu_read_bootcpu_ops();
 #ifdef CONFIG_SMP
Signature · 1 line
2.1.4
#8 lore raw

Re: [PATCH v2 2/3] arm, arm64/xen: move Xen initialization earlier

In reply to Stefano Stabellini

Hi Russell,

I am going to queue this up in the xentip tree for 4.2, let me know if you have any issues.

Cheers,

Stefano

Quoted 214 lines · Stefano Stabellini

Russell,

I think that this patch should go via the Xen tree, however as it touches arch/arm/kernel/setup.c, I would like your Acked-by before adding it to the Xen queue.

Thanks,

Stefano

Quoted 201 lines · Julien Grall

From: Stefano Stabellini <[email protected]>

Currently, Xen is initialized/discovered in an initcall. This doesn't allow us to support earlyprintk or choosing the preferred console when running on Xen.

The current function xen_guest_init is now split in 2 parts:
- xen_early_init: Check if there is a Xen node in the device tree and setup domain type
- xen_guest_init: Retrieve the information from the device node and initialize Xen (grant table, shared page...)

The former is called in setup_arch, while the latter is an initcall.

---
It's based on a patch sent by Stefano nearly 2 years ago [1].

[1] http://lists.xen.org/archives/html/xen-devel/2013-08/msg02960.html

Changes in v2:
- Add Ian's ack

---
 arch/arm/include/asm/xen/hypervisor.h |  8 +++++
 arch/arm/kernel/setup.c               |  2 ++
 arch/arm/xen/enlighten.c              | 58 ++++++++++++++++++++---------------
 arch/arm64/kernel/setup.c             |  2 ++
 4 files changed, 46 insertions(+), 24 deletions(-)
arch/arm/include/asm/xen/hypervisor.h +8 -0
index 1317ee4..04ff8e7 100644
@@ -1,6 +1,8 @@
 #ifndef _ASM_ARM_XEN_HYPERVISOR_H
 #define _ASM_ARM_XEN_HYPERVISOR_H
 
+#include <linux/init.h>
+
 extern struct shared_info *HYPERVISOR_shared_info;
 extern struct start_info *xen_start_info;
 
@@ -18,4 +20,10 @@ static inline enum paravirt_lazy_mode paravirt_get_lazy_mode(void)
 
 extern struct dma_map_ops *xen_dma_ops;
 
+#ifdef CONFIG_XEN
+void __init xen_early_init(void);
+#else
+static inline void xen_early_init(void) { return; }
+#endif
+
 #endif /* _ASM_ARM_XEN_HYPERVISOR_H */
arch/arm/kernel/setup.c +2 -0
index e55408e..8b59d0d 100644
@@ -46,6 +46,7 @@
 #include <asm/cacheflush.h>
 #include <asm/cachetype.h>
 #include <asm/tlbflush.h>
+#include <asm/xen/hypervisor.h>
 
 #include <asm/prom.h>
 #include <asm/mach/arch.h>
@@ -936,6 +937,7 @@ void __init setup_arch(char **cmdline_p)
 
 	arm_dt_init_cpu_maps();
 	psci_init();
+	xen_early_init();
 #ifdef CONFIG_SMP
 	if (is_smp()) {
 		if (!mdesc->smp_init || !mdesc->smp_init()) {
arch/arm/xen/enlighten.c +34 -24
index c8d3a17..1660432 100644
@@ -53,6 +53,8 @@ EXPORT_SYMBOL_GPL(xen_platform_pci_unplug);
 
 static __read_mostly unsigned int xen_events_irq;
 
+static __initdata struct device_node *xen_node;
+
 /* map fgmfn of domid to lpfn in the current domain */
 static int map_foreign_page(unsigned long lpfn, unsigned long fgmfn,
 			    unsigned int domid)
@@ -222,42 +224,28 @@ static irqreturn_t xen_arm_callback(int irq, void *arg)
  * documentation of the Xen Device Tree format.
  */
 #define GRANT_TABLE_PHYSADDR 0
-static int __init xen_guest_init(void)
+void __init xen_early_init(void)
 {
-	struct xen_add_to_physmap xatp;
-	static struct shared_info *shared_info_page = 0;
-	struct device_node *node;
 	int len;
 	const char *s = NULL;
 	const char *version = NULL;
 	const char *xen_prefix = "xen,xen-";
-	struct resource res;
-	phys_addr_t grant_frames;
 
-	node = of_find_compatible_node(NULL, NULL, "xen,xen");
-	if (!node) {
+	xen_node = of_find_compatible_node(NULL, NULL, "xen,xen");
+	if (!xen_node) {
 		pr_debug("No Xen support\n");
-		return 0;
+		return;
 	}
-	s = of_get_property(node, "compatible", &len);
+	s = of_get_property(xen_node, "compatible", &len);
 	if (strlen(xen_prefix) + 3  < len &&
 			!strncmp(xen_prefix, s, strlen(xen_prefix)))
 		version = s + strlen(xen_prefix);
 	if (version == NULL) {
 		pr_debug("Xen version not found\n");
-		return 0;
-	}
-	if (of_address_to_resource(node, GRANT_TABLE_PHYSADDR, &res))
-		return 0;
-	grant_frames = res.start;
-	xen_events_irq = irq_of_parse_and_map(node, 0);
-	if (!xen_events_irq) {
-		pr_debug("Xen event channel interrupt not found\n");
-		return -ENODEV;
+		return;
 	}
 
-	pr_info("Xen %s support found, events_irq=%d gnttab_frame=%pa\n",
-			version, xen_events_irq, &grant_frames);
+	pr_info("Xen %s support found\n", version);
 
 	xen_domain_type = XEN_HVM_DOMAIN;
 
@@ -267,10 +255,32 @@ static int __init xen_guest_init(void)
 		xen_start_info->flags |= SIF_INITDOMAIN|SIF_PRIVILEGED;
 	else
 		xen_start_info->flags &= ~(SIF_INITDOMAIN|SIF_PRIVILEGED);
+}
+
+static int __init xen_guest_init(void)
+{
+	struct xen_add_to_physmap xatp;
+	struct shared_info *shared_info_page = NULL;
+	struct resource res;
+	phys_addr_t grant_frames;
+
+	if (!xen_domain())
+		return 0;
+
+	if (of_address_to_resource(xen_node, GRANT_TABLE_PHYSADDR, &res)) {
+		pr_err("Xen grant table base address not found\n");
+		return -ENODEV;
+	}
+	grant_frames = res.start;
+
+	xen_events_irq = irq_of_parse_and_map(xen_node, 0);
+	if (!xen_events_irq) {
+		pr_err("Xen event channel interrupt not found\n");
+		return -ENODEV;
+	}
+
+	shared_info_page = (struct shared_info *)get_zeroed_page(GFP_KERNEL);
 
-	if (!shared_info_page)
-		shared_info_page = (struct shared_info *)
-			get_zeroed_page(GFP_KERNEL);
 	if (!shared_info_page) {
 		pr_err("not enough memory\n");
 		return -ENOMEM;
arch/arm64/kernel/setup.c +2 -0
index e8420f6..c00ae01 100644
@@ -62,6 +62,7 @@
 #include <asm/memblock.h>
 #include <asm/psci.h>
 #include <asm/efi.h>
+#include <asm/xen/hypervisor.h>
 
 unsigned int processor_id;
 EXPORT_SYMBOL(processor_id);
@@ -388,6 +389,7 @@ void __init setup_arch(char **cmdline_p)
 	unflatten_device_tree();
 
 	psci_init();
+	xen_early_init();
 
 	cpu_read_bootcpu_ops();
 #ifdef CONFIG_SMP
Signature · 1 line
2.1.4
#9 lore raw

PATCH v2 3/3 xen/arm: allow console=hvc0 to be omitted for guests

In reply to Julien Grall

From: Ard Biesheuvel <[email protected]>

This patch registers hvc0 as the preferred console if no console has been specified explicitly on the kernel command line.

The purpose is to allow platform agnostic kernels and boot images (such as distro installers) to boot in a Xen/ARM domU without the need to modify the command line by hand.

---
 arch/arm/xen/enlighten.c | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/xen/enlighten.c +4 -0
index 1660432..904bd2d 100644
@@ -24,6 +24,7 @@
 #include <linux/cpuidle.h>
 #include <linux/cpufreq.h>
 #include <linux/cpu.h>
+#include <linux/console.h>
 
 #include <linux/mm.h>
 
@@ -255,6 +256,9 @@ void __init xen_early_init(void)
 		xen_start_info->flags |= SIF_INITDOMAIN|SIF_PRIVILEGED;
 	else
 		xen_start_info->flags &= ~(SIF_INITDOMAIN|SIF_PRIVILEGED);
+
+	if (!console_set_on_cmdline && !xen_initial_domain())
+		add_preferred_console("hvc", 0, NULL);
 }
 
 static int __init xen_guest_init(void)
Signature · 1 line
2.1.4
#10 lore raw

PATCH v2 3/3 xen/arm: allow console=hvc0 to be omitted for guests

Quoted 11 lines · Julien Grall

From: Ard Biesheuvel <[email protected]>

This patch registers hvc0 as the preferred console if no console has been specified explicitly on the kernel command line.

The purpose is to allow platform agnostic kernels and boot images (such as distro installers) to boot in a Xen/ARM domU without the need to modify the command line by hand.

Acked-by on v2 3/3
#11 lore raw

Re: [PATCH v2 3/3] xen/arm: allow console=hvc0 to be omitted for guests

In reply to Julien Grall
Quoted 11 lines · Julien Grall

From: Ard Biesheuvel <[email protected]>

This patch registers hvc0 as the preferred console if no console has been specified explicitly on the kernel command line.

The purpose is to allow platform agnostic kernels and boot images (such as distro installers) to boot in a Xen/ARM domU without the need to modify the command line by hand.

#12 lore raw

PATCH v2 3/3 xen/arm: allow console=hvc0 to be omitted for guests

In reply to Julien Grall
Quoted 8 lines · Julien Grall

From: Ard Biesheuvel <[email protected]>

This patch registers hvc0 as the preferred console if no console has been specified explicitly on the kernel command line.

The purpose is to allow platform agnostic kernels and boot images (such as distro installers) to boot in a Xen/ARM domU without the need to modify the command line by hand.

How does this interact with DT chosen stdout-path?

Is there a node for hvc0?

Rob

Quoted 37 lines
---
 arch/arm/xen/enlighten.c | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/xen/enlighten.c +4 -1
index 1660432..904bd2d 100644
@@ -24,6 +24,7 @@
 #include <linux/cpuidle.h>
 #include <linux/cpufreq.h>
 #include <linux/cpu.h>
+#include <linux/console.h>
 
 #include <linux/mm.h>
 
@@ -255,6 +256,9 @@ void __init xen_early_init(void)
                xen_start_info->flags |= SIF_INITDOMAIN|SIF_PRIVILEGED;
        else
                xen_start_info->flags &= ~(SIF_INITDOMAIN|SIF_PRIVILEGED);
+
+       if (!console_set_on_cmdline && !xen_initial_domain())
+               add_preferred_console("hvc", 0, NULL);
 }
 
 static int __init xen_guest_init(void)
--

2.1.4

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#13 lore raw

PATCH v2 3/3 xen/arm: allow console=hvc0 to be omitted for guests

Quoted 11 lines · Rob Herring
Quoted 8 lines · Julien Grall

From: Ard Biesheuvel <[email protected]>

This patch registers hvc0 as the preferred console if no console has been specified explicitly on the kernel command line.

The purpose is to allow platform agnostic kernels and boot images (such as distro installers) to boot in a Xen/ARM domU without the need to modify the command line by hand.

How does this interact with DT chosen stdout-path?

I think it shouldn't any more than the existing calls from e.g. the 8250 driver to preferred_console do.

Quoted 1 line

Is there a node for hvc0?

Not a direct one, it is inferred from the presence of the general Xen node. I did vaguely consider handling a stdout-path pointing to that -- but it seemed a bit of an abuse.

Ian.

#14 lore raw

PATCH v2 3/3 xen/arm: allow console=hvc0 to be omitted for guests

Quoted 13 lines · Ian Campbell
Quoted 11 lines · Rob Herring
Quoted 8 lines · Julien Grall

From: Ard Biesheuvel <[email protected]>

This patch registers hvc0 as the preferred console if no console has been specified explicitly on the kernel command line.

The purpose is to allow platform agnostic kernels and boot images (such as distro installers) to boot in a Xen/ARM domU without the need to modify the command line by hand.

How does this interact with DT chosen stdout-path?

Quoted 7 lines

I think it shouldn't any more than the existing calls from e.g. the 8250 driver to preferred_console do.

Quoted 1 line

Is there a node for hvc0?

Not a direct one, it is inferred from the presence of the general Xen node.

Xen PV consoles, including hvc0, as all the other Xen PV devices are advertised on xenstore.

Quoted 2 lines

I did vaguely consider handling a stdout-path pointing to that -- but it seemed a bit of an abuse.

#15 lore raw

PATCH v2 3/3 xen/arm: allow console=hvc0 to be omitted for guests

Quoted 17 lines · Stefano Stabellini
Quoted 16 lines · Ian Campbell
Quoted 11 lines · Rob Herring
Quoted 8 lines · Julien Grall

From: Ard Biesheuvel <[email protected]>

This patch registers hvc0 as the preferred console if no console has been specified explicitly on the kernel command line.

The purpose is to allow platform agnostic kernels and boot images (such as distro installers) to boot in a Xen/ARM domU without the need to modify the command line by hand.

How does this interact with DT chosen stdout-path?

I think it shouldn't any more than the existing calls from e.g. the 8250 driver to preferred_console do.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Is there a node for hvc0?

Not a direct one, it is inferred from the presence of the general Xen node.

Xen PV consoles, including hvc0, as all the other Xen PV devices are advertised on xenstore.

Do we actually use the xenstore node for hvc0? I thought we got it from hvmparams (so the primary it can be used before xenstore is up)

Quoted 5 lines
Quoted 4 lines

I did vaguely consider handling a stdout-path pointing to that -- but it seemed a bit of an abuse.

#16 lore raw

PATCH v2 3/3 xen/arm: allow console=hvc0 to be omitted for guests

Quoted 20 lines · Ian Campbell
Quoted 19 lines · Stefano Stabellini
Quoted 18 lines · Ian Campbell
Quoted 11 lines · Rob Herring
Quoted 8 lines · Julien Grall

From: Ard Biesheuvel <[email protected]>

This patch registers hvc0 as the preferred console if no console has been specified explicitly on the kernel command line.

The purpose is to allow platform agnostic kernels and boot images (such as distro installers) to boot in a Xen/ARM domU without the need to modify the command line by hand.

How does this interact with DT chosen stdout-path?

I think it shouldn't any more than the existing calls from e.g. the 8250 driver to preferred_console do.

Quoted 1 line

Is there a node for hvc0?

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Not a direct one, it is inferred from the presence of the general Xen node.

Xen PV consoles, including hvc0, as all the other Xen PV devices are advertised on xenstore.

Do we actually use the xenstore node for hvc0? I thought we got it from hvmparams (so the primary it can be used before xenstore is up)

We always assume that at least one PV console is available and the first one is a bit special because it can be setup before the xenstore driver for early boot messages and debugging purposes. However even the first console is advertised on xenstore.

#17 lore raw

Re: [PATCH v2 3/3] xen/arm: allow console=hvc0 to be omitted for guests

In reply to Ian Campbell
Quoted 20 lines · Ian Campbell
Quoted 19 lines · Stefano Stabellini
Quoted 18 lines · Ian Campbell
Quoted 11 lines · Rob Herring
Quoted 8 lines · Julien Grall

From: Ard Biesheuvel <[email protected]>

This patch registers hvc0 as the preferred console if no console has been specified explicitly on the kernel command line.

The purpose is to allow platform agnostic kernels and boot images (such as distro installers) to boot in a Xen/ARM domU without the need to modify the command line by hand.

How does this interact with DT chosen stdout-path?

I think it shouldn't any more than the existing calls from e.g. the 8250 driver to preferred_console do.

Quoted 1 line

Is there a node for hvc0?

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Not a direct one, it is inferred from the presence of the general Xen node.

Xen PV consoles, including hvc0, as all the other Xen PV devices are advertised on xenstore.

Do we actually use the xenstore node for hvc0? I thought we got it from hvmparams (so the primary it can be used before xenstore is up)

We always assume that at least one PV console is available and the first one is a bit special because it can be setup before the xenstore driver for early boot messages and debugging purposes. However even the first console is advertised on xenstore.

#18 lore raw

Re: [PATCH v2 3/3] xen/arm: allow console=hvc0 to be omitted for guests

In reply to Stefano Stabellini
Quoted 17 lines · Stefano Stabellini
Quoted 16 lines · Ian Campbell
Quoted 11 lines · Rob Herring
Quoted 8 lines · Julien Grall

From: Ard Biesheuvel <[email protected]>

This patch registers hvc0 as the preferred console if no console has been specified explicitly on the kernel command line.

The purpose is to allow platform agnostic kernels and boot images (such as distro installers) to boot in a Xen/ARM domU without the need to modify the command line by hand.

How does this interact with DT chosen stdout-path?

I think it shouldn't any more than the existing calls from e.g. the 8250 driver to preferred_console do.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Is there a node for hvc0?

Not a direct one, it is inferred from the presence of the general Xen node.

Xen PV consoles, including hvc0, as all the other Xen PV devices are advertised on xenstore.

Do we actually use the xenstore node for hvc0? I thought we got it from hvmparams (so the primary it can be used before xenstore is up)

Quoted 5 lines
Quoted 4 lines

I did vaguely consider handling a stdout-path pointing to that -- but it seemed a bit of an abuse.

#19 lore raw

Re: [PATCH v2 3/3] xen/arm: allow console=hvc0 to be omitted for guests

In reply to Ian Campbell
Quoted 13 lines · Ian Campbell
Quoted 11 lines · Rob Herring
Quoted 8 lines · Julien Grall

From: Ard Biesheuvel <[email protected]>

This patch registers hvc0 as the preferred console if no console has been specified explicitly on the kernel command line.

The purpose is to allow platform agnostic kernels and boot images (such as distro installers) to boot in a Xen/ARM domU without the need to modify the command line by hand.

How does this interact with DT chosen stdout-path?

Quoted 7 lines

I think it shouldn't any more than the existing calls from e.g. the 8250 driver to preferred_console do.

Quoted 1 line

Is there a node for hvc0?

Not a direct one, it is inferred from the presence of the general Xen node.

Xen PV consoles, including hvc0, as all the other Xen PV devices are advertised on xenstore.

Quoted 2 lines

I did vaguely consider handling a stdout-path pointing to that -- but it seemed a bit of an abuse.

#20 lore raw

Re: [PATCH v2 3/3] xen/arm: allow console=hvc0 to be omitted for guests

In reply to Rob Herring
Quoted 11 lines · Rob Herring
Quoted 8 lines · Julien Grall

From: Ard Biesheuvel <[email protected]>

This patch registers hvc0 as the preferred console if no console has been specified explicitly on the kernel command line.

The purpose is to allow platform agnostic kernels and boot images (such as distro installers) to boot in a Xen/ARM domU without the need to modify the command line by hand.

How does this interact with DT chosen stdout-path?

I think it shouldn't any more than the existing calls from e.g. the 8250 driver to preferred_console do.

Quoted 1 line

Is there a node for hvc0?

Not a direct one, it is inferred from the presence of the general Xen node. I did vaguely consider handling a stdout-path pointing to that -- but it seemed a bit of an abuse.

Ian.

#21 lore raw

Re: [PATCH v2 3/3] xen/arm: allow console=hvc0 to be omitted for guests

In reply to Julien Grall
Quoted 8 lines · Julien Grall

From: Ard Biesheuvel <[email protected]>

This patch registers hvc0 as the preferred console if no console has been specified explicitly on the kernel command line.

The purpose is to allow platform agnostic kernels and boot images (such as distro installers) to boot in a Xen/ARM domU without the need to modify the command line by hand.

How does this interact with DT chosen stdout-path?

Is there a node for hvc0?

Rob

Quoted 37 lines
---
 arch/arm/xen/enlighten.c | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/xen/enlighten.c +4 -1
index 1660432..904bd2d 100644
@@ -24,6 +24,7 @@
 #include <linux/cpuidle.h>
 #include <linux/cpufreq.h>
 #include <linux/cpu.h>
+#include <linux/console.h>
 
 #include <linux/mm.h>
 
@@ -255,6 +256,9 @@ void __init xen_early_init(void)
                xen_start_info->flags |= SIF_INITDOMAIN|SIF_PRIVILEGED;
        else
                xen_start_info->flags &= ~(SIF_INITDOMAIN|SIF_PRIVILEGED);
+
+       if (!console_set_on_cmdline && !xen_initial_domain())
+               add_preferred_console("hvc", 0, NULL);
 }
 
 static int __init xen_guest_init(void)
--

2.1.4

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#22 lore raw

PATCH v2 3/3 xen/arm: allow console=hvc0 to be omitted for guests

In reply to Julien Grall

From: Ard Biesheuvel <[email protected]>

This patch registers hvc0 as the preferred console if no console has been specified explicitly on the kernel command line.

The purpose is to allow platform agnostic kernels and boot images (such as distro installers) to boot in a Xen/ARM domU without the need to modify the command line by hand.

---
 arch/arm/xen/enlighten.c | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/xen/enlighten.c +4 -0
index 1660432..904bd2d 100644
@@ -24,6 +24,7 @@
 #include <linux/cpuidle.h>
 #include <linux/cpufreq.h>
 #include <linux/cpu.h>
+#include <linux/console.h>
 
 #include <linux/mm.h>
 
@@ -255,6 +256,9 @@ void __init xen_early_init(void)
 		xen_start_info->flags |= SIF_INITDOMAIN|SIF_PRIVILEGED;
 	else
 		xen_start_info->flags &= ~(SIF_INITDOMAIN|SIF_PRIVILEGED);
+
+	if (!console_set_on_cmdline && !xen_initial_domain())
+		add_preferred_console("hvc", 0, NULL);
 }
 
 static int __init xen_guest_init(void)
Signature · 1 line
2.1.4
#23 lore raw

v2 cover arm/arm64: Detect Xen support earlier

In reply to Julien Grall

Hello,

Ping? Any comments from ARM's maintainers on theses patches (at least #2)?

Regards,

Quoted 32 lines · Julien Grall

Hello,

This small patch series moves the detection of running on Xen earlier. This is required in order to support earlyprintk via Xen and selecting preferred console.

Actually, the last patch of this patch series adds HVC0 as preferred console when running on Xen. The patch [1] was previously separetly sent by Ard.

For the maintainers, does this patch series should go in upstream via the ARM tree or Xen tree?

Regards,

[1] https://patches.linaro.org/44633/

Ard Biesheuvel (1):
xen/arm: allow console=hvc0 to be omitted for guests

Julien Grall (1):
arm/xen: Correctly check if the event channel interrupt is present

Stefano Stabellini (1):
arm,arm64/xen: move Xen initialization earlier

 arch/arm/include/asm/xen/hypervisor.h |  8 +++++
 arch/arm/kernel/setup.c               |  2 ++
 arch/arm/xen/enlighten.c              | 62 ++++++++++++++++++++++-------------
 arch/arm64/kernel/setup.c             |  2 ++
 4 files changed, 51 insertions(+), 23 deletions(-)
Signature · 1 line
Julien Grall
#24 lore raw

v2 cover arm/arm64: Detect Xen support earlier

Quoted 3 lines · Julien Grall

Hello,

Ping? Any comments from ARM's maintainers on theses patches (at least #2)?

I couldn't care less :)

The arm64 part is boring in the good sense of the word.

Will

#25 lore raw

v2 cover arm/arm64: Detect Xen support earlier

Quoted 8 lines · Will Deacon
Quoted 3 lines · Julien Grall

Hello,

Ping? Any comments from ARM's maintainers on theses patches (at least #2)?

I couldn't care less :)

The arm64 part is boring in the good sense of the word.

I will still need a ack from you or Catalin because it's touching arch/arm64/setup.c

Regards,

Signature · 1 line
Julien Grall
#26 lore raw

v2 cover arm/arm64: Detect Xen support earlier

In reply to Will Deacon
Quoted 8 lines · Will Deacon
Quoted 3 lines · Julien Grall

Hello,

Ping? Any comments from ARM's maintainers on theses patches (at least #2)?

I couldn't care less :)

The arm64 part is boring in the good sense of the word.

May Julien take that as an Acked-by? ;-)

Given this is all about Xen really I suppose it makes most sense to take it via the Xen tree.

Russell, does that work for you? (arch/arm bits are in patch #2 if you want to take a look)

Ian.

#27 lore raw

v2 cover arm/arm64: Detect Xen support earlier

Quoted 11 lines · Ian Campbell
Quoted 8 lines · Will Deacon
Quoted 3 lines · Julien Grall

Hello,

Ping? Any comments from ARM's maintainers on theses patches (at least #2)?

I couldn't care less :)

The arm64 part is boring in the good sense of the word.

May Julien take that as an Acked-by? ;-)

For the two lines under arch/arm64, sure!

Quoted 2 lines

Given this is all about Xen really I suppose it makes most sense to take it via the Xen tree.

Fine by me.

Will

#28 lore raw
In reply to Ian Campbell
Quoted 11 lines · Ian Campbell
Quoted 8 lines · Will Deacon
Quoted 3 lines · Julien Grall

Hello,

Ping? Any comments from ARM's maintainers on theses patches (at least #2)?

I couldn't care less :)

The arm64 part is boring in the good sense of the word.

May Julien take that as an Acked-by? ;-)

For the two lines under arch/arm64, sure!

Quoted 2 lines

Given this is all about Xen really I suppose it makes most sense to take it via the Xen tree.

Fine by me.

Will

#29 lore raw
In reply to Will Deacon
Quoted 8 lines · Will Deacon
Quoted 3 lines · Julien Grall

Hello,

Ping? Any comments from ARM's maintainers on theses patches (at least #2)?

I couldn't care less :)

The arm64 part is boring in the good sense of the word.

May Julien take that as an Acked-by? ;-)

Given this is all about Xen really I suppose it makes most sense to take it via the Xen tree.

Russell, does that work for you? (arch/arm bits are in patch #2 if you want to take a look)

Ian.