Skip to contentSkip to conversation

arc: do not export symbols in troubleshoot.c

PATCH In review Davidlohr Bueso 2 participants 3 messages Feb 18, 2015 – Feb 19, 2015 Synopsys ARC architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arc: do not export symbols in troubleshoot.c

print_task_path_n_nm() is local to this file, its only user being show_regs(). Mark the function static and avoid the EXPORT_SYMBOL.

---

Compile tested only.

 arch/arc/kernel/troubleshoot.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arc/kernel/troubleshoot.c +1 -2
index 1badf9b..e00a018 100644
@@ -52,7 +52,7 @@ static void show_callee_regs(struct callee_regs *cregs)
 	print_reg_file(&(cregs->r13), 13);
 }
 
-void print_task_path_n_nm(struct task_struct *tsk, char *buf)
+static void print_task_path_n_nm(struct task_struct *tsk, char *buf)
 {
 	struct path path;
 	char *path_nm = NULL;
@@ -77,7 +77,6 @@ void print_task_path_n_nm(struct task_struct *tsk, char *buf)
 done:
 	pr_info("Path: %s\n", path_nm);
 }
-EXPORT_SYMBOL(print_task_path_n_nm);
 
 static void show_faulting_vma(unsigned long address, char *buf)
 {
Signature · 1 line
2.1.4
#1 lore raw
Quoted 8 lines · Davidlohr Bueso

print_task_path_n_nm() is local to this file, its only user being show_regs(). Mark the function static and avoid the EXPORT_SYMBOL.

---

Compile tested only.

What am I saying! not tested. Got confused with another patch :)

Acked-by
#2 lore raw
Quoted 11 lines · Davidlohr Bueso
Quoted 8 lines · Davidlohr Bueso
Quoted 8 lines

print_task_path_n_nm() is local to this file, its only user being show_regs(). Mark the function static and avoid the EXPORT_SYMBOL.

---

Compile tested only.

What am I saying! not tested. Got confused with another patch :)

And I got excited that core kernel developers are now starting to compile for ARC :-) I'm sure we will get there.

Thx for the patch David.

-Vineet