HID: hid-lg4ff: Fix "undefined reference" build issue with CONFIG_USB disabled.
PATCH 1/1 HID: hid-lg4ff: Fix "undefined reference" build issue with CONFIG_USB disabled.
Fix "undefined reference" build issue with CONFIG_USB disabled.
--- drivers/hid/hid-lg4ff.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-)
drivers/hid/hid-lg4ff.c +9 -8
@@ -569,19 +569,20 @@ static const struct lg4ff_compat_mode_switch *lg4ff_get_mode_switch_command(consstatic int lg4ff_switch_compatibility_mode (struct hid_device *hid,const struct lg4ff_compat_mode_switch *s) { -struct usb_device *usbdev =hid_to_usb_dev (hid); -struct usbhid_device *usbhid = hid->driver_data; +struct list_head *report_list = &hid->report_enum[HID_OUTPUT_REPORT ].report_list; + struct hid_report *report = list_entry(report_list->next, struct hid_report, list); +__s32 *value = report->field[0 ]->value;u8 i;for (i =0 ; i < s->cmd_count; i++) { -int xferd, ret; -u8 data[7 ]; +u8 j; -memcpy (data, s->cmd + (7 *i),7 ); - ret =usb_interrupt_msg (usbdev, usbhid->urbout->pipe, data,7 , &xferd,USB_CTRL_SET_TIMEOUT ); -if (ret) -return ret; +for (j =0 ; j <7 ; j++) + value[j] = s->cmd[j + (7 *i)]; + +hid_hw_request (hid, report,HID_REQ_SET_REPORT ); } +hid_hw_wait (hid);return 0 ; }
Signature · 1 line
2.3.0
Quoted 1 line
Fix "undefined reference" build issue with
CONFIG_USBdisabled.
Just a newbie question... for a family of devices (the wheels) which can only be attached via USB, wouldn't the better approach be to fix the dependancy?
Are there any other devices provided for by 'hid-logitech' which use any other transport (HID over Bluetooth or the like)?
Simon.
Quoted 8 lines · On Wed, 18 Feb 2015, [email protected] wrote:
Quoted 1 line
Fix "undefined reference" build issue with
CONFIG_USBdisabled.Just a newbie question... for a family of devices (the wheels) which can only be attached via USB, wouldn't the better approach be to fix the dependancy?
Are there any other devices provided for by 'hid-logitech' which use any other transport (HID over Bluetooth or the like)?
Using only HID API (and let it call to the transport driver) is much cleaner way and helps a lot with avoiding code duplication, etc.
Signature · 2 lines
Jiri Kosina SUSE Labs
Jiri Kosina
AppliedQuoted 3 lines · Michal Malý
Fix "undefined reference" build issue with
CONFIG_USBdisabled.Signed-off-by Michal Malý <[email protected]>
Applied, thanks.
Signature · 6 lines
Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html