drm: Adding edp1.4 specific dpcd macros
Subsystems (2)
PATCH 1/1 drm: Adding edp1.4 specific dpcd macros
Adding dpcd macros related to edp1.4 and link rates
v2: Added DP_SUPPORTED_LINK_RATES macros
--- include/drm/drm_dp_helper.h | 8 ++++++++ 1 file changed, 8 insertions(+)
include/drm/drm_dp_helper.h +8 -0
@@ -92,6 +92,9 @@# define DP_MSA_TIMING_PAR_IGNORED (1 << 6)/* eDP */ # define DP_OUI_SUPPORT (1 << 7) +#define DP_SUPPORTED_LINK_RATES 0x010/*eDP 1.4*/ +#define DP_MAX_SUPPORTED_RATES 0x8 +#define DP_I2C_SPEED_CAP 0x00c/* DPI */ # define DP_I2C_SPEED_1K 0x01# define DP_I2C_SPEED_5K 0x02
@@ -101,6 +104,7 @@# define DP_I2C_SPEED_1M 0x20#define DP_EDP_CONFIGURATION_CAP 0x00d/* XXX 1.2? */ +# define DP_DPCD_DISPLAY_CONTROL_CAPABLE (1 << 3)/* edp v1.2 or higher */ #define DP_TRAINING_AUX_RD_INTERVAL 0x00e/* XXX 1.2? */ /* Multiple stream transport */
@@ -221,6 +225,8 @@# define DP_UP_REQ_EN (1 << 1)# define DP_UPSTREAM_IS_SRC (1 << 2) +#define DP_LINK_RATE_SET 0x115 +#define DP_PSR_EN_CFG 0x170/* XXX 1.2? */ # define DP_PSR_ENABLE (1 << 0)# define DP_PSR_MAIN_LINK_ACTIVE (1 << 1)
@@ -332,6 +338,8 @@# define DP_SET_POWER_D3 0x2# define DP_SET_POWER_MASK 0x3 +#define DP_EDP_DPCD_REV 0x700 +#define DP_SIDEBAND_MSG_DOWN_REQ_BASE 0x1000/* 1.2 MST */ #define DP_SIDEBAND_MSG_UP_REP_BASE 0x1200/* 1.2 MST */ #define DP_SIDEBAND_MSG_DOWN_REP_BASE 0x1400/* 1.2 MST */
Signature · 6 lines
1.7.10.4 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Task id: 5793 -------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV -7 277/277 270/277
ILK 313/313 313/313 SNB 309/309 309/309 IVB 382/382 382/382 BYT 296/296 296/296 HSW 425/425 425/425 BDW -1 318/318 317/318 -------------------------------------Detailed------------------------------------- Platform Test drm-intel-nightly Series Applied *PNV igt_gem_evict_everything_minor-normal PASS(2) DMESG_WARN(1)PASS(1) *PNV igt_gem_fence_thrash_bo-write-verify-none NRUN(1)PASS(5) FAIL(1)PASS(1) *PNV igt_gem_fence_thrash_bo-write-verify-x PASS(6) FAIL(1)PASS(1) *PNV igt_gem_fence_thrash_bo-write-verify-y NO_RESULT(1)PASS(5) FAIL(1)PASS(1) *PNV igt_gem_set_tiling_vs_blt_tiled-to-tiled PASS(2) FAIL(1)PASS(1) *PNV igt_gem_set_tiling_vs_blt_tiled-to-untiled PASS(3) FAIL(1)PASS(1) PNV igt_gem_userptr_blits_coherency-sync NO_RESULT(1)CRASH(3)PASS(4) CRASH(2) *BDW igt_gem_gtt_hog PASS(11) DMESG_WARN(1)PASS(1)
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list [email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Just some formatting issues that need to be cleaned up. Otherwise the definitions look correct according to the eDP 1.4 spec.
-T
Quoted 14 lines · Sonika Jindal
Adding dpcd macros related to edp1.4 and link rates
v2: Added
DP_SUPPORTED_LINK_RATESmacrosSigned-off-by Sonika Jindal <[email protected]>--- include/drm/drm_dp_helper.h | 8 ++++++++ 1 file changed, 8 insertions(+)include/drm/drm_dp_helper.h +0
-0
include/drm/drm_dp_helper.h line 97
Quoted 6 lines
include/drm/drm_dp_helper.h +3
-0@@ -92,6 +92,9 @@# define DP_MSA_TIMING_PAR_IGNORED (1 << 6)/* eDP */ # define DP_OUI_SUPPORT (1 << 7) +#define DP_SUPPORTED_LINK_RATES 0x010/*eDP 1.4*/ +#define DP_MAX_SUPPORTED_RATES 0x8 +
Extra blank line
include/drm/drm_dp_helper.h line 107
Quoted 8 lines
include/drm/drm_dp_helper.h +1
-0#define DP_I2C_SPEED_CAP 0x00c/* DPI */ # define DP_I2C_SPEED_1K 0x01# define DP_I2C_SPEED_5K 0x02@@ -101,6 +104,7 @@# define DP_I2C_SPEED_1M 0x20#define DP_EDP_CONFIGURATION_CAP 0x00d/* XXX 1.2? */ +# define DP_DPCD_DISPLAY_CONTROL_CAPABLE (1 << 3)/* edp v1.2 or higher */
Remove the space between # and define.
include/drm/drm_dp_helper.h line 229
Quoted 9 lines
include/drm/drm_dp_helper.h +2
-0#define DP_TRAINING_AUX_RD_INTERVAL 0x00e/* XXX 1.2? */ /* Multiple stream transport */ @@ -221,6 +225,8 @@# define DP_UP_REQ_EN (1 << 1)# define DP_UPSTREAM_IS_SRC (1 << 2) +#define DP_LINK_RATE_SET 0x115 +
Extra blank line
include/drm/drm_dp_helper.h line 342
Quoted 9 lines
include/drm/drm_dp_helper.h +2
-0#define DP_PSR_EN_CFG 0x170/* XXX 1.2? */ # define DP_PSR_ENABLE (1 << 0)# define DP_PSR_MAIN_LINK_ACTIVE (1 << 1)@@ -332,6 +338,8 @@# define DP_SET_POWER_D3 0x2# define DP_SET_POWER_MASK 0x3 +#define DP_EDP_DPCD_REV 0x700 +
Extra blank line
include/drm/drm_dp_helper.h line 345
Quoted 3 lines
include/drm/drm_dp_helper.h +0
-0#define DP_SIDEBAND_MSG_DOWN_REQ_BASE 0x1000/* 1.2 MST */ #define DP_SIDEBAND_MSG_UP_REP_BASE 0x1200/* 1.2 MST */ #define DP_SIDEBAND_MSG_DOWN_REP_BASE 0x1400/* 1.2 MST */
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 2 lines · Todd Previte
Just some formatting issues that need to be cleaned up. Otherwise the definitions look correct according to the eDP 1.4 spec.
Actually the formatting seems to be in line with the rest of that particular file.
BR,
Jani.
Quoted 62 lines
-T
Quoted 14 lines · Sonika Jindal
Adding dpcd macros related to edp1.4 and link rates
v2: Added
DP_SUPPORTED_LINK_RATESmacrosSigned-off-by Sonika Jindal <[email protected]>--- include/drm/drm_dp_helper.h | 8 ++++++++ 1 file changed, 8 insertions(+)include/drm/drm_dp_helper.h +0
-0include/drm/drm_dp_helper.h line 97
Quoted 6 lines
include/drm/drm_dp_helper.h +3
-0@@ -92,6 +92,9 @@# define DP_MSA_TIMING_PAR_IGNORED (1 << 6)/* eDP */ # define DP_OUI_SUPPORT (1 << 7) +#define DP_SUPPORTED_LINK_RATES 0x010/*eDP 1.4*/ +#define DP_MAX_SUPPORTED_RATES 0x8 +Extra blank line
include/drm/drm_dp_helper.h line 107
Quoted 8 lines
include/drm/drm_dp_helper.h +1
-0#define DP_I2C_SPEED_CAP 0x00c/* DPI */ # define DP_I2C_SPEED_1K 0x01# define DP_I2C_SPEED_5K 0x02@@ -101,6 +104,7 @@# define DP_I2C_SPEED_1M 0x20#define DP_EDP_CONFIGURATION_CAP 0x00d/* XXX 1.2? */ +# define DP_DPCD_DISPLAY_CONTROL_CAPABLE (1 << 3)/* edp v1.2 or higher */ Remove the space between # and define.
include/drm/drm_dp_helper.h line 229
Quoted 9 lines
include/drm/drm_dp_helper.h +2
-0#define DP_TRAINING_AUX_RD_INTERVAL 0x00e/* XXX 1.2? */ /* Multiple stream transport */ @@ -221,6 +225,8 @@# define DP_UP_REQ_EN (1 << 1)# define DP_UPSTREAM_IS_SRC (1 << 2) +#define DP_LINK_RATE_SET 0x115 +Extra blank line
include/drm/drm_dp_helper.h line 342
Quoted 9 lines
include/drm/drm_dp_helper.h +2
-0#define DP_PSR_EN_CFG 0x170/* XXX 1.2? */ # define DP_PSR_ENABLE (1 << 0)# define DP_PSR_MAIN_LINK_ACTIVE (1 << 1)@@ -332,6 +338,8 @@# define DP_SET_POWER_D3 0x2# define DP_SET_POWER_MASK 0x3 +#define DP_EDP_DPCD_REV 0x700 +Extra blank line
include/drm/drm_dp_helper.h line 345
Quoted 3 lines
include/drm/drm_dp_helper.h +0
-0#define DP_SIDEBAND_MSG_DOWN_REQ_BASE 0x1000/* 1.2 MST */ #define DP_SIDEBAND_MSG_UP_REP_BASE 0x1200/* 1.2 MST */ #define DP_SIDEBAND_MSG_DOWN_REP_BASE 0x1400/* 1.2 MST */ _______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Todd Previte
Reviewed-byQuoted 8 lines · Jani Nikula
Quoted 2 lines · Todd Previte
Just some formatting issues that need to be cleaned up. Otherwise the definitions look correct according to the eDP 1.4 spec.
Actually the formatting seems to be in line with the rest of that particular file.
BR,
Jani.
Interesting. Looks like there's some inconsistency in that header then. But if the formatting isn't an issue, it's otherwise correct.
Quoted 53 lines
Quoted 53 lines
-T
Quoted 14 lines · Sonika Jindal
Adding dpcd macros related to edp1.4 and link rates
v2: Added
DP_SUPPORTED_LINK_RATESmacrosSigned-off-by Sonika Jindal <[email protected]>--- include/drm/drm_dp_helper.h | 8 ++++++++ 1 file changed, 8 insertions(+)include/drm/drm_dp_helper.h +0
-0include/drm/drm_dp_helper.h line 97
Quoted 6 lines
include/drm/drm_dp_helper.h +3
-0@@ -92,6 +92,9 @@# define DP_MSA_TIMING_PAR_IGNORED (1 << 6)/* eDP */ # define DP_OUI_SUPPORT (1 << 7) +#define DP_SUPPORTED_LINK_RATES 0x010/*eDP 1.4*/ +#define DP_MAX_SUPPORTED_RATES 0x8 +Extra blank line
include/drm/drm_dp_helper.h line 107
Quoted 8 lines
include/drm/drm_dp_helper.h +1
-0#define DP_I2C_SPEED_CAP 0x00c/* DPI */ # define DP_I2C_SPEED_1K 0x01# define DP_I2C_SPEED_5K 0x02@@ -101,6 +104,7 @@# define DP_I2C_SPEED_1M 0x20#define DP_EDP_CONFIGURATION_CAP 0x00d/* XXX 1.2? */ +# define DP_DPCD_DISPLAY_CONTROL_CAPABLE (1 << 3)/* edp v1.2 or higher */ Remove the space between # and define.
include/drm/drm_dp_helper.h line 229
Quoted 9 lines
include/drm/drm_dp_helper.h +2
-0#define DP_TRAINING_AUX_RD_INTERVAL 0x00e/* XXX 1.2? */ /* Multiple stream transport */ @@ -221,6 +225,8 @@# define DP_UP_REQ_EN (1 << 1)# define DP_UPSTREAM_IS_SRC (1 << 2) +#define DP_LINK_RATE_SET 0x115 +Extra blank line
include/drm/drm_dp_helper.h line 342
Quoted 9 lines
include/drm/drm_dp_helper.h +2
-0#define DP_PSR_EN_CFG 0x170/* XXX 1.2? */ # define DP_PSR_ENABLE (1 << 0)# define DP_PSR_MAIN_LINK_ACTIVE (1 << 1)@@ -332,6 +338,8 @@# define DP_SET_POWER_D3 0x2# define DP_SET_POWER_MASK 0x3 +#define DP_EDP_DPCD_REV 0x700 +Extra blank line
Quoted 7 lines
Quoted 7 lines
include/drm/drm_dp_helper.h line 345
Quoted 3 lines
include/drm/drm_dp_helper.h +0
-0#define DP_SIDEBAND_MSG_DOWN_REQ_BASE 0x1000/* 1.2 MST */ #define DP_SIDEBAND_MSG_UP_REP_BASE 0x1200/* 1.2 MST */ #define DP_SIDEBAND_MSG_DOWN_REP_BASE 0x1400/* 1.2 MST */ _______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Daniel Vetter
AppliedAside: reply-all seems to not work (or maybe you have reply-to-list as default), dri-devel was lost. Readded.
Quoted 8 lines · Todd Previte
Quoted 6 lines · Jani Nikula
Quoted 2 lines · Todd Previte
Just some formatting issues that need to be cleaned up. Otherwise the definitions look correct according to the eDP 1.4 spec.
Actually the formatting seems to be in line with the rest of that particular file.
Quoted 6 lines
Quoted 2 lines
BR,
Jani.Interesting. Looks like there's some inconsistency in that header then. But if the formatting isn't an issue, it's otherwise correct.
Reviewed-by Todd Previte <[email protected]>
Queued to drm-misc, thanks for patch&review.
-Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx