Convert simple_strtoul to kstrtoul
Subsystems (2)
PATCH v3 1/1 Convert simple_strtoul to kstrtoul
This patch fixes the checkpatch.pl warning:simple_strtoul is obsolete, use kstrtoul instead.
When the string is not converted(parsing error), the strings pointed to by ep and parport[n] are the same. This parsing error results in kstrtoul returning a non-zero value.
---
Changes in v3:
-Removed few changes made in previous commit which were introducing new checkpatch.pl warnings.
drivers/staging/media/parport/bw-qcam.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/media/parport/bw-qcam.c +1 -3
@@ -1106,10 +1106,8 @@ static int accept_bwqcam(struct parport *port)if (parport[0 ] &&strncmp (parport[0 ],"auto" ,4 ) !=0 ) {/* user gave parport parameters */ for (n =0 ; n <MAX_CAMS && parport[n]; n++) { -char *ep;unsigned long r; - r =simple_strtoul (parport[n], &ep,0 ); -if (ep == parport[n]) { +if (kstrtoul (parport[n],0 , &r)) {printk (KERN_ERR "bw-qcam: bad port specifier \"%s\"\n" , parport[n]);
Signature · 1 line
1.9.1
Hi,
Is this patch alright? Now, there are now additional warnings introduced
by the change I made.
Quoted 39 lines · Navya Sri Nizamkari
This patch fixes the checkpatch.pl warning:
simple_strtoulis obsolete, use kstrtoul instead.When the string is not converted(parsing error), the strings pointed to by ep and parport[n] are the same. This parsing error results in kstrtoul returning a non-zero value.
Signed-off-by Navya Sri Nizamkari <[email protected]>---
Changes in v3:
-Removed few changes made in previous commit which were introducing new
checkpatch.pl warnings.drivers/staging/media/parport/bw-qcam.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/staging/media/parport/bw-qcam.c +1
-3@@ -1106,10 +1106,8 @@ static int accept_bwqcam(struct parport *port)if (parport[0 ] &&strncmp (parport[0 ],"auto" ,4 ) !=0 ) {/* user gave parport parameters */ for (n =0 ; n <MAX_CAMS && parport[n]; n++) { -char *ep;unsigned long r; - r =simple_strtoul (parport[n], &ep,0 ); -if (ep == parport[n]) { +if (kstrtoul (parport[n],0 , &r)) { printk(KERN_ERR "bw-qcam: bad port specifier \"%s\"\n",parport[n]);Signature · 1 line
1.9.1
Quoted 3 lines · Navya Sri Nizamkari
Hi,
Is this patch alright? Now, there are now additional warnings introduced by the change I made.
What warnings?
julia
Quoted 53 lines
On Thursday, February 19, 2015 at 11:40:18 PM UTC+5:30, Navya Sri Nizamkari wrote:
This patch fixes the checkpatch.pl warning: simple_strtoul is obsolete, use kstrtoul instead. When the string is not converted(parsing error), the strings pointed to by ep and parport[n] are the same. This parsing error results in kstrtoul returning a non-zero value. Signed-off-by: Navya Sri Nizamkari <[email protected]> --- Changes in v3: -Removed few changes made in previous commit which were introducing new checkpatch.pl warnings. drivers/staging/media/parport/bw-qcam.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/media/parport/bw-qcam.c b/drivers/staging/media/parport/bw-qcam.c index 67b9da1..6c9b400 100644 --- a/drivers/staging/media/parport/bw-qcam.c +++ b/drivers/staging/media/parport/bw-qcam.c @@ -1106,10 +1106,8 @@ static int accept_bwqcam(struct parport *port) if (parport[0] && strncmp(parport[0], "auto", 4) != 0) { /* user gave parport parameters */ for (n = 0; n < MAX_CAMS && parport[n]; n++) { - char *ep; unsigned long r; - r = simple_strtoul(parport[n], &ep, 0); - if (ep == parport[n]) { + if (kstrtoul(parport[n], 0, &r)) { printk(KERN_ERR "bw-qcam: bad port specifier \"%s\"\n", parport[n]); -- 1.9.1--
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/c4bae1a8-b908-47ae-b7e5- e293248a7691%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Quoted 10 lines · Julia Lawall
Quoted 2 lines · Navya Sri Nizamkari
Hi,
Is this patch alright? Now, there are now additional warningsintroduced
Quoted 1 line
by the change I made.
What warnings?
Quoted 8 lines
julia
drivers/staging/media/parport/bw-qcam.c static int accept_bwqcam(struct parport *port)
Quoted 3 lines
drivers/staging/media/parport/bw-qcam.c +1
-2- r =simple_strtoul (parport[n], &ep,0 ); -if (ep == parport[n]) { +if (kstrtoul (parport[n],0 ,&r)) {In the first patch I sent, there was no space after the ',' in kstrtoul. I
was talking about the new warnings this created.So, I sent a another one.
Navya
Quoted 15 lines · Navya Sri Nizamkari
On Friday, February 20, 2015 at 11:07:58 PM UTC+5:30, Julia Lawall wrote:
On Fri, 20 Feb 2015, Navya Sri Nizamkari wrote:> Hi,
> Is this patch alright? Now, there are now additional warnings introduced
> by the change I made.What warnings?
julia
Quoted 7 lines
> - r =
simple_strtoul(parport[n], &ep, 0);
> - if (ep == parport[n]) { > + if (kstrtoul(parport[n],0,&r)) {In the first patch I sent, there was no space after the ',' in kstrtoul. I was talking about the new warnings this created.So, I sent a another one.
OK. Patches should not generate new checkpatch warnings.
julia
Hi Navya,
Quoted 4 lines · Navya Sri Nizamkari
This patch fixes the checkpatch.pl warning:
simple_strtoulis obsolete, use kstrtoul instead.When the string is not converted(parsing error), the strings pointed to by ep and parport[n] are the same. This parsing error results in kstrtoul returning a non-zero value.
When you write changelogs restrict the length of the line to 80 characters, so that the patch looks uniformly aligned throughout.
On another note, the patch is fixing an issue that is not specific to ep and parport[n]. It looks at replacing strtoul() with kstrtoul() in places where there are checks for parsing error in string parsing. Make the explanation more generic because its not specific to this file. Ideally if any one else finds such a usage elsewhere, they can change it the same way. Hence under such circumstances avoid using file specific parameters in the changelog.
And try to link the usage of strtoul() with kstrtoul(); you replace strtoul() with kstrtoul() in the error handling part here because both check for similar errors while parsing strings. Ideally kstrtoul() error check should be a superset of strtoul(). Else this patch would have been wrong.
But hold onto these points for a similar cleanup on another driver. See below.
Quoted 7 lines
Signed-off-by Navya Sri Nizamkari <[email protected]>---
Changes in v3:
-Removed few changes made in previous commit which were introducing new checkpatch.pl warnings.drivers/staging/media/parport/bw-qcam.c | 4 +---
Refer to the mail that Arnd sent out. He has listed the drivers that are not in mainline. So avoid sending patches against the following drivers, since they will soon be removed from staging-next as well.
drivers/staging/line6/ (moved to sound/usb)drivers/staging/media/parport/drivers/staging/media/tlg2300/drivers/staging/media/vino/
Regards
Preeti U Murthy
Quoted 19 lines
1 file changed, 1 insertion(+), 3 deletions(-)drivers/staging/media/parport/bw-qcam.c +1
-3@@ -1106,10 +1106,8 @@ static int accept_bwqcam(struct parport *port)if (parport[0 ] &&strncmp (parport[0 ],"auto" ,4 ) !=0 ) {/* user gave parport parameters */ for (n =0 ; n <MAX_CAMS && parport[n]; n++) { -char *ep;unsigned long r; - r =simple_strtoul (parport[n], &ep,0 ); -if (ep == parport[n]) { +if (kstrtoul (parport[n],0 , &r)) {printk (KERN_ERR "bw-qcam: bad port specifier \"%s\"\n" , parport[n]);
Hi,
I've made changes according to your feedback and sent in another patch. Is i2o going to be removed too?
Thanks,
Navya.
Quoted 68 lines · Preeti U Murthy
Hi Navya,
Quoted 4 lines · Navya Sri Nizamkari
This patch fixes the checkpatch.pl warning:
simple_strtoulis obsolete, use kstrtoul instead.When the string is not converted(parsing error), the strings pointed to by ep and parport[n] are the same. This parsing error results in kstrtoul returning a non-zero value.
When you write changelogs restrict the length of the line to 80 characters, so that the patch looks uniformly aligned throughout.
On another note, the patch is fixing an issue that is not specific to ep and parport[n]. It looks at replacing
strtoul()withkstrtoul()in places where there are checks for parsing error in string parsing. Make the explanation more generic because its not specific to this file. Ideally if any one else finds such a usage elsewhere, they can change it the same way. Hence under such circumstances avoid using file specific parameters in the changelog.And try to link the usage of
strtoul()withkstrtoul(); you replacestrtoul()withkstrtoul()in the error handling part here because both check for similar errors while parsing strings. Ideallykstrtoul()error check should be a superset ofstrtoul(). Else this patch would have been wrong.But hold onto these points for a similar cleanup on another driver. See below.
Quoted 7 lines
Signed-off-by Navya Sri Nizamkari <[email protected]>---
Changes in v3:
-Removed few changes made in previous commit which were introducing new checkpatch.pl warnings.drivers/staging/media/parport/bw-qcam.c | 4 +---Refer to the mail that Arnd sent out. He has listed the drivers that are not in mainline. So avoid sending patches against the following drivers, since they will soon be removed from staging-next as well.
drivers/staging/line6/(moved tosound/usb)drivers/staging/media/parport/drivers/staging/media/tlg2300/drivers/staging/media/vino/Regards
Preeti U MurthyQuoted 19 lines
1 file changed, 1 insertion(+), 3 deletions(-)drivers/staging/media/parport/bw-qcam.c +1
-3@@ -1106,10 +1106,8 @@ static int accept_bwqcam(struct parport *port)if (parport[0 ] &&strncmp (parport[0 ],"auto" ,4 ) !=0 ) {/* user gave parport parameters */ for (n =0 ; n <MAX_CAMS && parport[n]; n++) { -char *ep;unsigned long r; - r =simple_strtoul (parport[n], &ep,0 ); -if (ep == parport[n]) { +if (kstrtoul (parport[n],0 , &r)) {printk (KERN_ERR "bw-qcam: bad port specifier \"%s\"\n" , parport[n]);