checkpatch: CHECK: No space is necessary after a cast
Hi Joe,
we have come across a checkpatch false-positive:
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
static void batadv_recv_handler_init(void)
{
int i;
for (i = 0; i < ARRAY_SIZE(batadv_rx_handler); i++)
batadv_rx_handler[i] = batadv_recv_unhandled_packet;
for (i = BATADV_UNICAST_MIN; i <= BATADV_UNICAST_MAX; i++)
batadv_rx_handler[i] = batadv_recv_unhandled_unicast_packet;
/* compile time checks for sizes */
BUILD_BUG_ON(sizeof(struct batadv_bla_claim_dst) != 6);
BUILD_BUG_ON(sizeof(struct batadv_ogm_packet) != 24);
BUILD_BUG_ON(sizeof(struct batadv_icmp_header) != 20);
..
}<<<<<
The following warnings are triggered:
CHECK: No space is necessary after a cast
#440: FILE: main.c:440:
+ BUILD_BUG_ON(sizeof(struct batadv_bla_claim_dst) != 6);
CHECK: No space is necessary after a cast
#441: FILE: main.c:441:
+ BUILD_BUG_ON(sizeof(struct batadv_ogm_packet) != 24);
CHECK: No space is necessary after a cast
#442: FILE: main.c:442:
+ BUILD_BUG_ON(sizeof(struct batadv_icmp_header) != 20);
Can you make a suggestion / patch for checkpatch to better handle this case ?
Thanks,
Marek
Joe Perches
maintainerQuoted 1 line · Marek Lindner
Hi Joe,
Hi Marek
Quoted 1 line
we have come across a checkpatch false-positive:
[]
Quoted 4 lines
BUILD_BUG_ON(sizeof(struct batadv_bla_claim_dst) != 6);CHECK: No space is necessary after a cast
#440: FILE: main.c:440:
+BUILD_BUG_ON(sizeof(struct batadv_bla_claim_dst) != 6);
[]
Quoted 1 line
Can you make a suggestion / patch for checkpatch to better handle this case ?
The "sizeof" test in the current script doesn't work.
I believe the patch below works with no false positives but <shrug> it's perl regexes against odd coding styles and weird macros, who knows for sure...
I did run it against drivers/, net/ and include/
Give this a try:
--- scripts/checkpatch.pl | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
scripts/checkpatch.pl +9 -3
@@ -2552,9 +2552,15 @@ sub process { } } - if ($line =~ /^\+.*(\w+\s*)?\(\s*$Type\s*\)[ \t]+(?!$Assignment|$Arithmetic|[,;:\?\(\{\}\[\<\>]|&&|\|\||\\$)/ && - (!defined($1) || $1 !~ /sizeof\s*/)) { - if (CHK("SPACING", +# check for space after cast like "(int) foo" or "(struct foo) bar" +# avoid checking a few false positives: +# "sizeof(<type>)" or "__alignof__(<type>)" +# function pointer declarations like "(*foo)(int) = bar;" +# structure definitions like "(struct foo) { 0 };" +# multiline macros that define functions + if ($line =~ /^\+(.*)\(\s*$Type\s*\)([ \t]++)((?![={]|\\$))/ && + (!defined($1) || $1 !~ /\b(?:sizeof|__alignof__)\s*$/)) { + if (CHK("SPACING", "No space is necessary after a cast\n" . $herecurr) && $fix) { $fixed[$fixlinenr] =~
Quoted 9 lines · On Thursday, February 19, 2015 11:55:41 Joe Perches wrote:
Quoted 2 lines
Can you make a suggestion / patch for checkpatch to better handle this case ?
The "sizeof" test in the current script doesn't work.
I believe the patch below works with no false positives but <shrug> it's perl regexes against odd coding styles and weird macros, who knows for sure...
I did run it against
drivers/,net/andinclude/
Your perl-regex-fu does the trick!
Thanks,
Marek
Joe Perches
maintainerPATCH 1/1 checkpatch: Improve "no space is necessary after a cast" test
The "no space is necessary after a cast" sizeof exclusion doesn't work properly.
The test reports a false positive for code like:
BUILD_BUG_ON(sizeof(struct batadv_bla_claim_dst) != 6);
Make it work, simplify the exclusions, and add some comments.
--- scripts/checkpatch.pl | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)
scripts/checkpatch.pl +10 -3
@@ -2552,9 +2552,16 @@ sub process { } } - if ($line =~ /^\+.*(\w+\s*)?\(\s*$Type\s*\)[ \t]+(?!$Assignment|$Arithmetic|[,;:\?\(\{\}\[\<\>]|&&|\|\||\\$)/ && - (!defined($1) || $1 !~ /sizeof\s*/)) { - if (CHK("SPACING", +# check for space after cast like "(int) foo" or "(struct foo) bar" +# avoid checking a few false positives: +# "sizeof(<type>)" or "__alignof__(<type>)" +# function pointer declarations like "(*foo)(int) = bar;" +# structure definitions like "(struct foo) { 0 };" +# multiline macros that define functions +# known attributes or the __attribute__ keyword + if ($line =~ /^\+(.*)\(\s*$Type\s*\)([ \t]++)((?![={]|\\$|$Attribute|__attribute__))/ && + (!defined($1) || $1 !~ /\b(?:sizeof|__alignof__)\s*$/)) { + if (CHK("SPACING", "No space is necessary after a cast\n" . $herecurr) && $fix) { $fixed[$fixlinenr] =~