Skip to contentSkip to conversation

Staging: drivers: dma: ste_dma40: fixed trailing statements

PATCH In review Hatice ERTÜRK 2 participants 2 messages Feb 19, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: drivers: dma: ste_dma40: fixed trailing statements

ERROR: trailing statements should be on next line
chackpatch.pl error in ste_dma40.c

---
 drivers/dma/ste_dma40.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/dma/ste_dma40.c +4 -2
index 796c070..308795e 100644
@@ -2372,9 +2372,11 @@ static struct dma_chan *d40_xlate(struct of_phandle_args *dma_spec,
 
 	switch (D40_DT_FLAGS_MODE(flags)) {
 	case 0:
-		cfg.mode = STEDMA40_MODE_LOGICAL; break;
+		cfg.mode = STEDMA40_MODE_LOGICAL;
+		break;
 	case 1:
-		cfg.mode = STEDMA40_MODE_PHYSICAL; break;
+		cfg.mode = STEDMA40_MODE_PHYSICAL;
+		break;
 	}
 
 	switch (D40_DT_FLAGS_DIR(flags)) {
Signature · 1 line
1.9.1
#1 lore raw
Quoted 2 lines · Hatice ERTÜRK

ERROR: trailing statements should be on next line
chackpatch.pl error in ste_dma40.c

Again, say what you have done rather than just repeating the chckpatch message.

julia

Quoted 33 lines
---
 drivers/dma/ste_dma40.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/dma/ste_dma40.c +4 -2
index 796c070..308795e 100644
@@ -2372,9 +2372,11 @@ static struct dma_chan *d40_xlate(struct of_phandle_args *dma_spec,
 
 	switch (D40_DT_FLAGS_MODE(flags)) {
 	case 0:
-		cfg.mode = STEDMA40_MODE_LOGICAL; break;
+		cfg.mode = STEDMA40_MODE_LOGICAL;
+		break;
 	case 1:
-		cfg.mode = STEDMA40_MODE_PHYSICAL; break;
+		cfg.mode = STEDMA40_MODE_PHYSICAL;
+		break;
 	}
 
 	switch (D40_DT_FLAGS_DIR(flags)) {
Signature · 8 lines
1.9.1

-- 
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1424376441-29634-1-git-send-email-haticeerturk27%40gmail.com.
For more options, visit https://groups.google.com/d/optout.