Fix C++11 compilation error with rte_pci.h
PATCH 1/1 Fix C++11 compilation error with rte_pci.h
In C++11 concatenated string literals need to have a space in between. Found while trying to compile with clang++-3.4.
Sample error message:dpdk/include/rte_pci.h:96:26: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
--- lib/librte_eal/common/include/rte_pci.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
lib/librte_eal/common/include/rte_pci.h +2 -2
@@ -93,10 +93,10 @@ extern struct pci_device_list pci_device_list; /**< Global list of PCI devices.#define SYSFS_PCI_DEVICES "/sys/bus/pci/devices"/** Formatting string for PCI device identifier: Ex: 0000:00:01.0 */ -#define PCI_PRI_FMT "%.4"PRIx16":%.2"PRIx8":%.2"PRIx8".%"PRIx8 +#define PCI_PRI_FMT "%.4" PRIx16 ":%.2" PRIx8 ":%.2" PRIx8 ".%" PRIx8/** Short formatting string, without domain, for PCI device: Ex: 00:01.0 */ -#define PCI_SHORT_PRI_FMT "%.2"PRIx8":%.2"PRIx8".%"PRIx8 +#define PCI_SHORT_PRI_FMT "%.2" PRIx8 ":%.2" PRIx8 ".%" PRIx8/** Nb. of values in PCI device identifier format string. */ #define PCI_FMT_NVAL 4
Signature · 1 line
1.7.9.5
A message that is not in the archive (sent off-list or not yet received): 1424379569-15851-1-git-send-email-stefan.puiu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
PATCH 1/1 Fix compilation error when compiling with clang-3.4 in C++11 mode: in C++11 concatenated string literals need to have a space in between.
From: Stefan Puiu <[email protected]>
Sample error message:dpdk/include/rte_pci.h:96:26: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
--- lib/librte_eal/common/include/rte_pci.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
lib/librte_eal/common/include/rte_pci.h +2 -2
@@ -93,10 +93,10 @@ extern struct pci_device_list pci_device_list; /**< Global list of PCI devices.#define SYSFS_PCI_DEVICES "/sys/bus/pci/devices"/** Formatting string for PCI device identifier: Ex: 0000:00:01.0 */ -#define PCI_PRI_FMT "%.4"PRIx16":%.2"PRIx8":%.2"PRIx8".%"PRIx8 +#define PCI_PRI_FMT "%.4" PRIx16 ":%.2" PRIx8 ":%.2" PRIx8 ".%" PRIx8/** Short formatting string, without domain, for PCI device: Ex: 00:01.0 */ -#define PCI_SHORT_PRI_FMT "%.2"PRIx8":%.2"PRIx8".%"PRIx8 +#define PCI_SHORT_PRI_FMT "%.2" PRIx8 ":%.2" PRIx8 ".%" PRIx8/** Nb. of values in PCI device identifier format string. */ #define PCI_FMT_NVAL 4
Signature · 1 line
1.7.9.5
A message that is not in the archive (sent off-list or not yet received): 1424379569-15851-2-git-send-email-stefan.puiu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Re: [PATCH] Fix compilation error when compiling with clang-3.4 in C++11 mode: in C++11 concatenated string literals need to have a space in between.
Hi Stefan,
Quoted 9 lines
-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Stefan Puiu
Sent: Thursday, February 19, 2015 8:59 PM
To: [email protected]
Cc: Stefan Puiu
Subject: [dpdk-dev] [PATCH] Fix compilation error when compiling with clang-3.4 in C++11 mode: in C++11 concatenated string literals need to have a space in between.
Quoted 5 lines
From: Stefan Puiu <[email protected]>
Sample error message:
dpdk/include/rte_pci.h:96:26: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
You forgot to include "Signed-off".
Pablo
Quoted 25 lines
--- lib/librte_eal/common/include/rte_pci.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)lib/librte_eal/common/include/rte_pci.h +0
-0@@ -93,10 +93,10 @@ extern struct pci_device_list pci_device_list; /**<Global list of PCI devices.
#defineSYSFS_PCI_DEVICES"/sys/bus/pci/devices"/** Formatting string for PCI device identifier: Ex: 0000:00:01.0 */
lib/librte_eal/common/include/rte_pci.h +2
-3-#define PCI_PRI_FMT "%.4"PRIx16":%.2"PRIx8":%.2"PRIx8".%"PRIx8 +#define PCI_PRI_FMT "%.4" PRIx16 ":%.2" PRIx8 ":%.2" PRIx8 ".%" PRIx8/** Short formatting string, without domain, for PCI device: Ex: 00:01.0 */ -#define PCI_SHORT_PRI_FMT "%.2"PRIx8":%.2"PRIx8".%"PRIx8 +#define PCI_SHORT_PRI_FMT "%.2" PRIx8 ":%.2" PRIx8 ".%" PRIx8/** Nb. of values in PCI device identifier format string. */ #define PCI_FMT_NVAL 4 --1.7.9.5
A message that is not in the archive (sent off-list or not yet received): E115CCD9D858EF4F90C690B0DCB4D89727261905-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org
Re: [PATCH] Fix compilation error when compiling with clang-3.4 in C++11 mode: in C++11 concatenated string literals need to have a space in between.
Hi Pablo,
Quoted 11 lines · Pablo
Hi Stefan,
Quoted 9 lines
-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Stefan Puiu
Sent: Thursday, February 19, 2015 8:59 PM
To: [email protected]
Cc: Stefan Puiu
Subject: [dpdk-dev] [PATCH] Fix compilation error when compiling with clang-3.4 in C++11 mode: in C++11 concatenated string literals need to have a space in between.
Quoted 7 lines
Quoted 5 lines
From: Stefan Puiu <[email protected]>
Sample error message:
dpdk/include/rte_pci.h:96:26: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]You forgot to include "Signed-off".
Oops, you're right. I'll resend. Thanks for looking over this.
Stefan.
Quoted 28 lines
Pablo
Quoted 25 lines
--- lib/librte_eal/common/include/rte_pci.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)lib/librte_eal/common/include/rte_pci.h +0
-0@@ -93,10 +93,10 @@ extern struct pci_device_list pci_device_list; /**<Global list of PCI devices.
#defineSYSFS_PCI_DEVICES"/sys/bus/pci/devices"/** Formatting string for PCI device identifier: Ex: 0000:00:01.0 */
lib/librte_eal/common/include/rte_pci.h +2
-3-#define PCI_PRI_FMT "%.4"PRIx16":%.2"PRIx8":%.2"PRIx8".%"PRIx8 +#define PCI_PRI_FMT "%.4" PRIx16 ":%.2" PRIx8 ":%.2" PRIx8 ".%" PRIx8/** Short formatting string, without domain, for PCI device: Ex: 00:01.0 */ -#define PCI_SHORT_PRI_FMT "%.2"PRIx8":%.2"PRIx8".%"PRIx8 +#define PCI_SHORT_PRI_FMT "%.2" PRIx8 ":%.2" PRIx8 ".%" PRIx8/** Nb. of values in PCI device identifier format string. */ #define PCI_FMT_NVAL 4 --1.7.9.5