Cleanup and fix touch_down implementation
cover Cleanup and fix touch_down implementation
Hi Jiri,
This set is based on your for-3.20/upstream-fixes branch.
If pen comes in proximity while touch is down, we force touch up before sending pen events. This idea has been implemented for Tablet PCs. But other tablets that support both pen and touch are not fully considered.
Ping Cheng (2):
HID: wacom: do not send pen events before touch is up/forced out
HID: wacom: rely on actual touch down count to decide touch_down
drivers/hid/wacom_wac.c | 81 ++++++++++++++++++++++++++++++------------------- 1 file changed, 49 insertions(+), 32 deletions(-)
Signature · 1 line
1.9.1
Quoted 4 lines · Ping Cheng
Hi Jiri,
This set is based on your for-3.20/upstream-fixes branch.
Quoted 8 lines
If pen comes in proximity while touch is down, we force touch up before sending pen events. This idea has been implemented for Tablet PCs. But other tablets that support both pen and touch are not fully considered.
Ping Cheng (2):
HID: wacom: do not send pen events before touch is up/forced out
HID: wacom: rely on actual touch down count to decidetouch_down
Ping, looking at the code, I think this both should go into 4.0 still (i.e. not postponed for the next merge window), as it's purely fixes.
Could you please confirm that for me?
Thanks,
Signature · 2 lines
Jiri Kosina SUSE Labs
Quoted 11 lines · Jiri Kosina
Quoted 9 lines · Ping Cheng
Hi Jiri,
This set is based on your for-3.20/upstream-fixes branch.
If pen comes in proximity while touch is down, we force touch up before sending pen events. This idea has been implemented for Tablet PCs. But other tablets that support both pen and touch are not fully considered.
Quoted 8 lines
Quoted 3 lines
Ping Cheng (2):
HID: wacom: do not send pen events before touch is up/forced out
HID: wacom: rely on actual touch down count to decidetouch_downPing, looking at the code, I think this both should go into 4.0 still (i.e. not postponed for the next merge window), as it's purely fixes.
Could you please confirm that for me?
Sure, they can go to 4.0.
Thank you.
Ping
Quoted 8 lines · Ping Cheng
Quoted 8 lines
Quoted 7 lines
before sending pen events. This idea has been implemented for Tablet PCs. But other tablets that support both pen and touch are not fully considered.
Ping Cheng (2):
HID: wacom: do not send pen events before touch is up/forced out
HID: wacom: rely on actual touch down count to decidetouch_down
Quoted 6 lines
Quoted 4 lines
Ping, looking at the code, I think this both should go into 4.0 still (i.e. not postponed for the next merge window), as it's purely fixes.
Could you please confirm that for me?
Sure, they can go to 4.0.
The question rather is "do they absolutely have to?" :)
Thanks,
Signature · 2 lines
Jiri Kosina SUSE Labs
Quoted 10 lines · Jiri Kosina
Quoted 8 lines · Ping Cheng
Quoted 8 lines
Quoted 7 lines
before sending pen events. This idea has been implemented for Tablet PCs. But other tablets that support both pen and touch are not fully considered.
Ping Cheng (2):
HID: wacom: do not send pen events before touch is up/forced out
HID: wacom: rely on actual touch down count to decidetouch_down
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Ping, looking at the code, I think this both should go into 4.0 still (i.e. not postponed for the next merge window), as it's purely fixes.
Could you please confirm that for me?
Sure, they can go to 4.0.
The question rather is "do they absolutely have to?" :)
I patched them under for-3.20/upstream-fixes in hope of merging them sooner. Sounds like getting in 4.0 is quicker.
Anyway, the sooner we can get them merged upstream, the better, since they are bug fixes.
Cheers,
PIng
Jiri Kosina
AppliedQuoted 9 lines · Ping Cheng
Hi Jiri,
This set is based on your for-3.20/upstream-fixes branch.
If pen comes in proximity while touch is down, we force touch up before sending pen events. This idea has been implemented for Tablet PCs. But other tablets that support both pen and touch are not fully considered.
Quoted 6 lines
Ping Cheng (2):
HID: wacom: do not send pen events before touch is up/forced out
HID: wacom: rely on actual touch down count to decidetouch_downdrivers/hid/wacom_wac.c | 81 ++++++++++++++++++++++++++++++------------------- 1 file changed, 49 insertions(+), 32 deletions(-)
Applied, thanks.
Signature · 2 lines
Jiri Kosina SUSE Labs