Skip to contentSkip to conversation

Staging: rtl8192u: ieee80211: ieee80211_crypt: removed commented out include

PATCH In review Tolga Ceylan 2 participants 5 messages Feb 21, 2015 – Mar 7, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 Staging: rtl8192u: ieee80211: ieee80211_crypt: removed commented out include

Removed a commented out header include

---
 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c +0 -1
index 5533221..b41aec1 100644
@@ -11,7 +11,6 @@
  *
  */
 
-//#include <linux/config.h>
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/slab.h>
Signature · 1 line
2.3.0
#1 lore raw

PATCH 2/3 Staging: rtl8192u: ieee80211: dot11d: added parenthesis to RESET_CIE_WATCHDOG macro

Added parenthesis to RESET_CIE_WATCHDOG macro to resolve checkpatch error.

---
 drivers/staging/rtl8192u/ieee80211/dot11d.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192u/ieee80211/dot11d.h +1 -1
index bd75e29..8ae673b 100644
@@ -53,7 +53,7 @@ typedef struct _RT_DOT11D_INFO {
 
 #define CIE_WATCHDOG_TH 1
 #define GET_CIE_WATCHDOG(__pIeeeDev) (GET_DOT11D_INFO(__pIeeeDev)->CountryIeWatchdog)
-#define RESET_CIE_WATCHDOG(__pIeeeDev) GET_CIE_WATCHDOG(__pIeeeDev) = 0
+#define RESET_CIE_WATCHDOG(__pIeeeDev) (GET_CIE_WATCHDOG(__pIeeeDev) = 0)
 #define UPDATE_CIE_WATCHDOG(__pIeeeDev) (++GET_CIE_WATCHDOG(__pIeeeDev))
 
 #define IS_DOT11D_STATE_DONE(__pIeeeDev) (GET_DOT11D_INFO(__pIeeeDev)->State == DOT11D_STATE_DONE)
Signature · 1 line
2.3.0
#2 lore raw

PATCH 3/3 Staging: rtl8192u: ieee80211: rtl819x_TS: replaced C99 comments with C89

In reply to Tolga Ceylan

Replaced C99 comments with C89 while maintaining less than 80 char lines. Removed commented out struct member: DLRecord.

---
 drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)
drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h +8 -7
index 7ed7243..811e6e3 100644
@@ -1,14 +1,14 @@
 #ifndef _TSTYPE_H_
 #define _TSTYPE_H_
 #include "rtl819x_Qos.h"
-#define TS_SETUP_TIMEOUT	60  // In millisecond
+#define TS_SETUP_TIMEOUT	60  /* In millisecond */
 #define TS_INACT_TIMEOUT	60
 #define TS_ADDBA_DELAY		60
 
 #define TOTAL_TS_NUM		16
 #define TCLAS_NUM		4
 
-// This define the Tx/Rx directions
+/* This define the Tx/Rx directions */
 typedef enum _TR_SELECT {
 	TX_DIR = 0,
 	RX_DIR = 1,
@@ -28,9 +28,10 @@ typedef struct _TS_COMMON_INFO{
 typedef struct _TX_TS_RECORD{
 	TS_COMMON_INFO		TsCommonInfo;
 	u16				TxCurSeq;
-	BA_RECORD			TxPendingBARecord;	// For BA Originator
-	BA_RECORD			TxAdmittedBARecord;	// For BA Originator
-//	QOS_DL_RECORD		DLRecord;
+	/* For BA Originator */
+	BA_RECORD			TxPendingBARecord;
+	/* For BA Originator */
+	BA_RECORD			TxAdmittedBARecord;
 	u8				bAddBaReqInProgress;
 	u8				bAddBaReqDelayed;
 	u8				bUsingBa;
@@ -44,11 +45,11 @@ typedef struct _RX_TS_RECORD {
 	u16				RxTimeoutIndicateSeq;
 	struct list_head		RxPendingPktList;
 	struct timer_list		RxPktPendingTimer;
-	BA_RECORD			RxAdmittedBARecord;	 // For BA Recipient
+	/* For BA Recipient */
+	BA_RECORD			RxAdmittedBARecord;
 	u16				RxLastSeqNum;
 	u8				RxLastFragNum;
 	u8				num;
-//	QOS_DL_RECORD		DLRecord;
 } RX_TS_RECORD, *PRX_TS_RECORD;
 
 
Signature · 1 line
2.3.0
#3 lore raw

Re: [PATCH 3/3] Staging: rtl8192u: ieee80211: rtl819x_TS: replaced C99 comments with C89

Quoted 7 lines · Tolga Ceylan

Replaced C99 comments with C89 while maintaining less than 80 char lines. Removed commented out struct member: DLRecord.

---
 drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

Also doesn't apply :(