Skip to contentSkip to conversation

xfce4-session: Make package MACHINE specific

PATCH In review Ash Charles 2 participants 5 messages Feb 22, 2015 – Feb 23, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfce4-session: Make package MACHINE specific

Because the xfce4-session recipe has a machine-specific pkg_postinst_, the package itself must be considered machine specific.

---
 meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.1.bb | 2 ++
 1 file changed, 2 insertions(+)
meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.1.bb +2 -0
index 74289fb..f804487 100644
@@ -5,6 +5,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=9ac2e7cff1ddaf48b6eab6028f23ef88"
 DEPENDS = "virtual/libx11 libsm libxfce4util libxfce4ui gtk+ libwnck dbus dbus-glib xfconf"
 RDEPENDS_${PN} = "netbase xinit dbus-x11 iceauth upower"
 
+PACKAGE_ARCH = "${MACHINE_ARCH}"
+
 inherit xfce update-alternatives
 
 SRC_URI[md5sum] = "1757657c1d590aa6274b7b7cbba33352"
Signature · 1 line
2.1.0
#1 lore raw
Quoted 22 lines · Ash Charles

Because the xfce4-session recipe has a machine-specific pkg_postinst_, the package itself must be considered machine specific.

---
 meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.1.bb | 2 ++
 1 file changed, 2 insertions(+)
meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.1.bb +2 -1
index 74289fb..f804487 100644
@@ -5,6 +5,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=9ac2e7cff1ddaf48b6eab6028f23ef88"
 DEPENDS = "virtual/libx11 libsm libxfce4util libxfce4ui gtk+ libwnck dbus dbus-glib xfconf"
 RDEPENDS_${PN} = "netbase xinit dbus-x11 iceauth upower"
 
+PACKAGE_ARCH = "${MACHINE_ARCH}"
+
 inherit xfce update-alternatives
 
 SRC_URI[md5sum] = "1757657c1d590aa6274b7b7cbba33352"
--
Quoted 2 lines

2.1.0

Have you tried to remove postinst - is it still necessary?

Andreas

#2 lore raw

Hi Andreas,

Good question. I just tried removing it and didn't see an error when building the package but it is not clear if this was trying to deal with a runtime or build-time error. Do you happen to remember? I tracked through the commit history but I think this has been in the recipe since it was first added.

--Ash

Quoted 28 lines · Andreas Müller
Quoted 22 lines · Ash Charles

Because the xfce4-session recipe has a machine-specific pkg_postinst_, the package itself must be considered machine specific.

---
 meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.1.bb | 2 ++
 1 file changed, 2 insertions(+)
meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.1.bb +2 -1
index 74289fb..f804487 100644
@@ -5,6 +5,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=9ac2e7cff1ddaf48b6eab6028f23ef88"
 DEPENDS = "virtual/libx11 libsm libxfce4util libxfce4ui gtk+ libwnck dbus dbus-glib xfconf"
 RDEPENDS_${PN} = "netbase xinit dbus-x11 iceauth upower"
 
+PACKAGE_ARCH = "${MACHINE_ARCH}"
+
 inherit xfce update-alternatives
 
 SRC_URI[md5sum] = "1757657c1d590aa6274b7b7cbba33352"
--
Quoted 2 lines

2.1.0

Have you tried to remove postinst - is it still necessary?

Andreas

#3 lore raw
Quoted 9 lines · Ash Charles

Hi Andreas,

Good question. I just tried removing it and didn't see an error when building the package but it is not clear if this was trying to deal with a runtime or build-time error. Do you happen to remember? I tracked through the commit history but I think this has been in the recipe since it was first added.

--Ash

It is a runtime error: When you start XFCE a error/warning pops up telling something <MachineName> missing. I can't remember exactly. I even don't know if this error comes up once on first start or on every start. Could you give that a try? Maybe this quirk is no more required.

Andreas

#4 lore raw
Quoted 6 lines · Andreas Müller

It is a runtime error: When you start XFCE a error/warning pops up telling something <MachineName> missing. I can't remember exactly. I even don't know if this error comes up once on first start or on every start. Could you give that a try? Maybe this quirk is no more required.

I tested it out this morning on an Overo but didn't see the error message even without the pkg_postinst. As such, I sent a new patch "xfce4-session: Remove unneeded pkg_postinst" (sorry, forgot to thread it here) instead---the patch on this thread should be dropped.

--Ash