omap3: ARM Cortex-A8 errata workarounds config option
PATCH 1/1 omap3: ARM Cortex-A8 errata workarounds config option
Workarounds applied in omap3_setup_aux_cr are only necessary for ARM core revisions prior to r3p2 (such as OMAP35xx but apparently not OMAP36xx and DM37xx) and require similar workarounds in the kernel, or it will cause numerous segmentation faults. This allows (when the option is not used) properly booting kernels that do not include the workaround.
Follow-up to the discussion from July 2013:
http://lists.denx.de/pipermail/u-boot/2013-July/158377.html
--- README | 8 ++++++++ arch/arm/cpu/armv7/omap3/board.c | 2 ++ include/configs/am3517_crane.h | 2 ++ include/configs/am3517_evm.h | 2 ++ include/configs/cm_t35.h | 2 ++ include/configs/cm_t3517.h | 2 ++ include/configs/dig297.h | 2 ++ include/configs/mcx.h | 2 ++ include/configs/nokia_rx51.h | 2 ++ include/configs/omap3_evm_common.h | 2 ++ include/configs/omap3_logic.h | 2 ++ include/configs/omap3_mvblx.h | 2 ++ include/configs/omap3_pandora.h | 2 ++ include/configs/omap3_sdp3430.h | 2 ++ include/configs/omap3_zoom1.h | 2 ++ include/configs/tam3517-common.h | 2 ++ include/configs/tao3530.h | 2 ++ include/configs/ti_omap3_common.h | 2 ++ include/configs/tricorder.h | 2 ++ 19 files changed, 44 insertions(+)
README +8 -0
@@ -621,6 +621,14 @@ The following options need to be configured: exists, unlike the similar options in the Linux kernel. Do not set these options unless they apply! + CONFIG_SYS_ARM_CORTEXA8_ERRATA + + Enables workarounds for ARM Cortex-A8 errata 454179, 430973 + and 621766. This is only necessary for ARM core revisions prior + to r3p2. Enabling those workarounds requires to enable the same + workarounds in the kernel, or it will cause multiple + segmentation faults. This is currently only effective on OMAP3. + - Driver Model Driver model is a new framework for devices in U-Boot introduced in early 2014. U-Boot is being progressively
arch/arm/cpu/armv7/omap3/board.c +2 -0
@@ -246,8 +246,10 @@ void s_init(void)try_unlock_memory (); +#ifdef CONFIG_SYS_ARM_CORTEXA8_ERRATA /* Errata workarounds */ omap3_setup_aux_cr (); +#endif #ifndef CONFIG_SYS_L2CACHE_OFF /* Invalidate L2-cache from secure mode */
include/configs/am3517_crane.h +2 -0
@@ -31,6 +31,8 @@#define CONFIG_DISPLAY_CPUINFO 1#define CONFIG_DISPLAY_BOARDINFO 1 +#define CONFIG_SYS_ARM_CORTEXA8_ERRATA +/* Clock Defines */ #define V_OSCK 26000000/* Clock output from T2 */ #define V_SCLK (V_OSCK >> 1)
include/configs/am3517_evm.h +2 -0
@@ -31,6 +31,8 @@#define CONFIG_DISPLAY_CPUINFO 1#define CONFIG_DISPLAY_BOARDINFO 1 +#define CONFIG_SYS_ARM_CORTEXA8_ERRATA +/* Clock Defines */ #define V_OSCK 26000000/* Clock output from T2 */ #define V_SCLK (V_OSCK >> 1)
include/configs/cm_t35.h +2 -0
@@ -38,6 +38,8 @@#define CONFIG_DISPLAY_CPUINFO #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_SYS_ARM_CORTEXA8_ERRATA +/* Clock Defines */ #define V_OSCK 26000000/* Clock output from T2 */ #define V_SCLK (V_OSCK >> 1)
include/configs/cm_t3517.h +2 -0
@@ -38,6 +38,8 @@#define CONFIG_DISPLAY_CPUINFO #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_SYS_ARM_CORTEXA8_ERRATA +/* Clock Defines */ #define V_OSCK 26000000/* Clock output from T2 */ #define V_SCLK (V_OSCK >> 1)
include/configs/dig297.h +2 -0
@@ -44,6 +44,8 @@#define CONFIG_DISPLAY_CPUINFO #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_SYS_ARM_CORTEXA8_ERRATA +/* Clock Defines */ #define V_OSCK 26000000/* Clock output from T2 */ #define V_SCLK (V_OSCK >> 1)
include/configs/mcx.h +2 -0
@@ -43,6 +43,8 @@#define CONFIG_DISPLAY_CPUINFO #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_SYS_ARM_CORTEXA8_ERRATA +/* Clock Defines */ #define V_OSCK 26000000/* Clock output from T2 */ #define V_SCLK (V_OSCK >> 1)
include/configs/nokia_rx51.h +2 -0
@@ -52,6 +52,8 @@#define CONFIG_DISPLAY_CPUINFO #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_SYS_ARM_CORTEXA8_ERRATA +/* Clock Defines */ #define V_OSCK 26000000/* Clock output from T2 */ #define V_SCLK (V_OSCK >> 1)
include/configs/omap3_evm_common.h +2 -0
@@ -21,6 +21,8 @@#define CONFIG_OMAP3_EVM /* This is a OMAP3 EVM */ #define CONFIG_TWL4030_POWER /* with TWL4030 PMIC */ +#define CONFIG_SYS_ARM_CORTEXA8_ERRATA +/* * Clock related definitions */
include/configs/omap3_logic.h +2 -0
@@ -32,6 +32,8 @@#define CONFIG_DISPLAY_CPUINFO #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_SYS_ARM_CORTEXA8_ERRATA +/* Clock Defines */ #define V_OSCK 26000000/* Clock output from T2 */ #define V_SCLK (V_OSCK >> 1)
include/configs/omap3_mvblx.h +2 -0
@@ -35,6 +35,8 @@#define CONFIG_DISPLAY_CPUINFO 1#define CONFIG_DISPLAY_BOARDINFO 1 +#define CONFIG_SYS_ARM_CORTEXA8_ERRATA +/* Clock Defines */ #define V_OSCK 26000000/* Clock output from T2 */ #define V_SCLK (V_OSCK >> 1)
include/configs/omap3_pandora.h +2 -0
@@ -29,6 +29,8 @@#define CONFIG_DISPLAY_CPUINFO 1#define CONFIG_DISPLAY_BOARDINFO 1 +#define CONFIG_SYS_ARM_CORTEXA8_ERRATA +/* Clock Defines */ #define V_OSCK 26000000/* Clock output from T2 */ #define V_SCLK (V_OSCK >> 1)
include/configs/omap3_sdp3430.h +2 -0
@@ -41,6 +41,8 @@#define CONFIG_DISPLAY_CPUINFO 1#define CONFIG_DISPLAY_BOARDINFO 1 +#define CONFIG_SYS_ARM_CORTEXA8_ERRATA +/* Clock Defines */ #define V_OSCK 26000000/* Clock output from T2 */ #define V_SCLK (V_OSCK >> 1)
include/configs/omap3_zoom1.h +2 -0
@@ -38,6 +38,8 @@#define CONFIG_DISPLAY_CPUINFO 1#define CONFIG_DISPLAY_BOARDINFO 1 +#define CONFIG_SYS_ARM_CORTEXA8_ERRATA +#define CONFIG_MISC_INIT_R #define CONFIG_REVISION_TAG 1
include/configs/tam3517-common.h +2 -0
@@ -33,6 +33,8 @@#define CONFIG_DISPLAY_CPUINFO #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_SYS_ARM_CORTEXA8_ERRATA +/* Clock Defines */ #define V_OSCK 26000000/* Clock output from T2 */ #define V_SCLK (V_OSCK >> 1)
include/configs/tao3530.h +2 -0
@@ -35,6 +35,8 @@#define CONFIG_DISPLAY_CPUINFO #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_SYS_ARM_CORTEXA8_ERRATA +/* Clock Defines */ #define V_OSCK 26000000/* Clock output from T2 */ #define V_SCLK (V_OSCK >> 1)
include/configs/ti_omap3_common.h +2 -0
@@ -25,6 +25,8 @@/* The chip has SDRC controller */ #define CONFIG_SDRC +#define CONFIG_SYS_ARM_CORTEXA8_ERRATA +/* Clock Defines */ #define V_OSCK 26000000/* Clock output from T2 */ #define V_SCLK (V_OSCK >> 1)
include/configs/tricorder.h +2 -0
@@ -43,6 +43,8 @@#define CONFIG_SILENT_CONSOLE #define CONFIG_ZERO_BOOTDELAY_CHECK +#define CONFIG_SYS_ARM_CORTEXA8_ERRATA +/* Clock Defines */ #define V_OSCK 26000000/* Clock output from T2 */ #define V_SCLK (V_OSCK >> 1)
Signature · 1 line
1.9.1
PATCH 1/1 omap3: ARM Cortex-A8 errata workarounds config option
Hi Paul,
Quoted 3 lines · Paul Kocialkowski
Workarounds applied in
omap3_setup_aux_crare only necessary for ARM core revisions prior to r3p2 (such as OMAP35xx but apparently not OMAP36xx and DM37xx)
If this is true, I can see some (potential) problems with the patch. Please, check out my thoughts on this below.
Quoted 54 lines
and require similar workarounds in the kernel, or it will cause numerous segmentation faults. This allows (when the option is not used) properly booting kernels that do not include the workaround.
Follow-up to the discussion from July 2013:
http://lists.denx.de/pipermail/u-boot/2013-July/158377.htmlSigned-off-by Paul Kocialkowski <[email protected]>--- README | 8 ++++++++ arch/arm/cpu/armv7/omap3/board.c | 2 ++ include/configs/am3517_crane.h | 2 ++ include/configs/am3517_evm.h | 2 ++ include/configs/cm_t35.h | 2 ++ include/configs/cm_t3517.h | 2 ++ include/configs/dig297.h | 2 ++ include/configs/mcx.h | 2 ++ include/configs/nokia_rx51.h | 2 ++ include/configs/omap3_evm_common.h | 2 ++ include/configs/omap3_logic.h | 2 ++ include/configs/omap3_mvblx.h | 2 ++ include/configs/omap3_pandora.h | 2 ++ include/configs/omap3_sdp3430.h | 2 ++ include/configs/omap3_zoom1.h | 2 ++ include/configs/tam3517-common.h | 2 ++ include/configs/tao3530.h | 2 ++ include/configs/ti_omap3_common.h | 2 ++ include/configs/tricorder.h | 2 ++ 19 files changed, 44 insertions(+)README +8
-0@@ -621,6 +621,14 @@ The following options need to be configured: exists, unlike the similar options in the Linux kernel. Do not set these options unless they apply! + CONFIG_SYS_ARM_CORTEXA8_ERRATA + + Enables workarounds for ARM Cortex-A8 errata 454179, 430973 + and 621766. This is only necessary for ARM core revisions prior + to r3p2. Enabling those workarounds requires to enable the same + workarounds in the kernel, or it will cause multiple + segmentation faults. This is currently only effective on OMAP3. + - Driver Model Driver model is a new framework for devices in U-Boot introduced in early 2014. U-Boot is being progressivelyarch/arm/cpu/armv7/omap3/board.c +0
-0
arch/arm/cpu/armv7/omap3/board.c void s_init(void) · line 251
Quoted 6 lines
arch/arm/cpu/armv7/omap3/board.c +1
-0@@ -246,8 +246,10 @@ void s_init(void)try_unlock_memory (); +#ifdef CONFIG_SYS_ARM_CORTEXA8_ERRATA /* Errata workarounds */ omap3_setup_aux_cr ();
Can we have the revision dynamically checked instead of/along with introducing a config option?
We have boards, OMAP3 based, which are supported by the same board file and the same config file, see below.
Quoted 4 lines
arch/arm/cpu/armv7/omap3/board.c +1
-0+#endif #ifndef CONFIG_SYS_L2CACHE_OFF /* Invalidate L2-cache from secure mode */
[...]
include/configs/cm_t35.h line 41
Quoted 9 lines
include/configs/cm_t35.h +1
-0@@ -38,6 +38,8 @@#define CONFIG_DISPLAY_CPUINFO #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_SYS_ARM_CORTEXA8_ERRATA
This config file is used for both cm-t35 and cm-t3730. cm-t35 has OMAP3530, but cm-t3730 has DM3730. The same U-Boot binary is used for both boards.
Quoted 4 lines
include/configs/cm_t35.h +1
-0+/* Clock Defines */ #define V_OSCK 26000000/* Clock output from T2 */ #define V_SCLK (V_OSCK >> 1)
[...]
Signature · 2 lines
Regards, Igor.
PATCH 1/1 omap3: ARM Cortex-A8 errata workarounds config option
Quoted 6 lines
Quoted 3 lines
Workarounds applied in
omap3_setup_aux_crare only necessary for ARM core revisions prior to r3p2 (such as OMAP35xx but apparently not OMAP36xx and DM37xx)If this is true, I can see some (potential) problems with the patch. Please, check out my thoughts on this below.
In any case, those workarounds were already enabled before, so it won't cause any regression. As it is now, the patch doesn't change anything, it just opens up the possibility of not using CONFIG_SYS_ARM_CORTEXA8_ERRATA for a board that doesn't need the workarounds and has them disabled in the kernel.
Quoted 57 lines
Quoted 57 lines
and require similar workarounds in the kernel, or it will cause numerous segmentation faults. This allows (when the option is not used) properly booting kernels that do not include the workaround.
Follow-up to the discussion from July 2013:
http://lists.denx.de/pipermail/u-boot/2013-July/158377.htmlSigned-off-by Paul Kocialkowski <[email protected]>--- README | 8 ++++++++ arch/arm/cpu/armv7/omap3/board.c | 2 ++ include/configs/am3517_crane.h | 2 ++ include/configs/am3517_evm.h | 2 ++ include/configs/cm_t35.h | 2 ++ include/configs/cm_t3517.h | 2 ++ include/configs/dig297.h | 2 ++ include/configs/mcx.h | 2 ++ include/configs/nokia_rx51.h | 2 ++ include/configs/omap3_evm_common.h | 2 ++ include/configs/omap3_logic.h | 2 ++ include/configs/omap3_mvblx.h | 2 ++ include/configs/omap3_pandora.h | 2 ++ include/configs/omap3_sdp3430.h | 2 ++ include/configs/omap3_zoom1.h | 2 ++ include/configs/tam3517-common.h | 2 ++ include/configs/tao3530.h | 2 ++ include/configs/ti_omap3_common.h | 2 ++ include/configs/tricorder.h | 2 ++ 19 files changed, 44 insertions(+)README +8
-0@@ -621,6 +621,14 @@ The following options need to be configured: exists, unlike the similar options in the Linux kernel. Do not set these options unless they apply! + CONFIG_SYS_ARM_CORTEXA8_ERRATA + + Enables workarounds for ARM Cortex-A8 errata 454179, 430973 + and 621766. This is only necessary for ARM core revisions prior + to r3p2. Enabling those workarounds requires to enable the same + workarounds in the kernel, or it will cause multiple + segmentation faults. This is currently only effective on OMAP3. + - Driver Model Driver model is a new framework for devices in U-Boot introduced in early 2014. U-Boot is being progressivelyarch/arm/cpu/armv7/omap3/board.c +0
-0@@ -246,8 +246,10 @@ void s_init(void)try_unlock_memory ();
Quoted 8 lines
arch/arm/cpu/armv7/omap3/board.c void s_init(void) · line 251
Quoted 3 lines
arch/arm/cpu/armv7/omap3/board.c +1
-0+#ifdef CONFIG_SYS_ARM_CORTEXA8_ERRATA /* Errata workarounds */ omap3_setup_aux_cr ();Can we have the revision dynamically checked instead of/along with introducing a config option?
We have boards, OMAP3 based, which are supported by the same board file and the same config file, see below.
After carefully looking at it, I think dynamically checking the revision might be the cleanest way to do this.
I was afraid that, in the case where the workarounds are disabled in u-boot but enabled in Linux, the same various segmentation faults would happen, but they apparently don't, as I just tested.
Thus, checking the revision should work best. According to the code in Linux, this only affects r1p* ARM core revisions, so that's what I'll be checking against.
Thanks for your comments!
Quoted 21 lines
Quoted 4 lines
arch/arm/cpu/armv7/omap3/board.c +1
-0+#endif #ifndef CONFIG_SYS_L2CACHE_OFF /* Invalidate L2-cache from secure mode */ [...]
include/configs/cm_t35.h line 41
Quoted 9 lines
include/configs/cm_t35.h +1
-0@@ -38,6 +38,8 @@#define CONFIG_DISPLAY_CPUINFO #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_SYS_ARM_CORTEXA8_ERRATA This config file is used for both cm-t35 and cm-t3730. cm-t35 has OMAP3530, but cm-t3730 has DM3730. The same U-Boot binary is used for both boards.
Quoted 7 lines
Quoted 4 lines
include/configs/cm_t35.h +1
-0+/* Clock Defines */ #define V_OSCK 26000000/* Clock output from T2 */ #define V_SCLK (V_OSCK >> 1)[...]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150222/4a3247fc/attachment.sig>
PATCH 1/1 omap3: ARM Cortex-A8 errata workarounds config option
Le dimanche 22 f?vrier 2015 ? 16:45 +0100, Paul Kocialkowski a ?crit :
Quoted 82 lines
Quoted 6 lines
Quoted 3 lines
Workarounds applied in
omap3_setup_aux_crare only necessary for ARM core revisions prior to r3p2 (such as OMAP35xx but apparently not OMAP36xx and DM37xx)If this is true, I can see some (potential) problems with the patch. Please, check out my thoughts on this below.
In any case, those workarounds were already enabled before, so it won't cause any regression. As it is now, the patch doesn't change anything, it just opens up the possibility of not using
CONFIG_SYS_ARM_CORTEXA8_ERRATAfor a board that doesn't need the workarounds and has them disabled in the kernel.Quoted 57 lines
Quoted 57 lines
and require similar workarounds in the kernel, or it will cause numerous segmentation faults. This allows (when the option is not used) properly booting kernels that do not include the workaround.
Follow-up to the discussion from July 2013:
http://lists.denx.de/pipermail/u-boot/2013-July/158377.htmlSigned-off-by Paul Kocialkowski <[email protected]>--- README | 8 ++++++++ arch/arm/cpu/armv7/omap3/board.c | 2 ++ include/configs/am3517_crane.h | 2 ++ include/configs/am3517_evm.h | 2 ++ include/configs/cm_t35.h | 2 ++ include/configs/cm_t3517.h | 2 ++ include/configs/dig297.h | 2 ++ include/configs/mcx.h | 2 ++ include/configs/nokia_rx51.h | 2 ++ include/configs/omap3_evm_common.h | 2 ++ include/configs/omap3_logic.h | 2 ++ include/configs/omap3_mvblx.h | 2 ++ include/configs/omap3_pandora.h | 2 ++ include/configs/omap3_sdp3430.h | 2 ++ include/configs/omap3_zoom1.h | 2 ++ include/configs/tam3517-common.h | 2 ++ include/configs/tao3530.h | 2 ++ include/configs/ti_omap3_common.h | 2 ++ include/configs/tricorder.h | 2 ++ 19 files changed, 44 insertions(+)README +8
-0@@ -621,6 +621,14 @@ The following options need to be configured: exists, unlike the similar options in the Linux kernel. Do not set these options unless they apply! + CONFIG_SYS_ARM_CORTEXA8_ERRATA + + Enables workarounds for ARM Cortex-A8 errata 454179, 430973 + and 621766. This is only necessary for ARM core revisions prior + to r3p2. Enabling those workarounds requires to enable the same + workarounds in the kernel, or it will cause multiple + segmentation faults. This is currently only effective on OMAP3. + - Driver Model Driver model is a new framework for devices in U-Boot introduced in early 2014. U-Boot is being progressivelyarch/arm/cpu/armv7/omap3/board.c +0
-0@@ -246,8 +246,10 @@ void s_init(void)try_unlock_memory ();Quoted 8 lines
arch/arm/cpu/armv7/omap3/board.c void s_init(void) · line 251
Quoted 3 lines
arch/arm/cpu/armv7/omap3/board.c +1
-0+#ifdef CONFIG_SYS_ARM_CORTEXA8_ERRATA /* Errata workarounds */ omap3_setup_aux_cr ();Can we have the revision dynamically checked instead of/along with introducing a config option?
We have boards, OMAP3 based, which are supported by the same board file and the same config file, see below.After carefully looking at it, I think dynamically checking the revision might be the cleanest way to do this.
Quoted 7 lines
I was afraid that, in the case where the workarounds are disabled in u-boot but enabled in Linux, the same various segmentation faults would happen, but they apparently don't, as I just tested.
Thus, checking the revision should work best. According to the code in Linux, this only affects r1p* ARM core revisions, so that's what I'll be checking against.
Looking at the Linux code more closely, it shows that erratum 430973 only affects r1p* and erratum 458693 only affects r2p0.
Now in U-Boot, everything is mixed together and while erratum 458693 is not mentionned, it does set the L1NEON bit to 1 like the workaround for erratum 458693 does in Linux.
What do you think I should do here? Follow the Linux way (split it up) or settle on applying both things for revisions <= r2p0.
Quoted 28 lines
Thanks for your comments!
Quoted 26 lines
Quoted 4 lines
arch/arm/cpu/armv7/omap3/board.c +1
-0+#endif #ifndef CONFIG_SYS_L2CACHE_OFF /* Invalidate L2-cache from secure mode */ [...]
include/configs/cm_t35.h line 41
Quoted 9 lines
include/configs/cm_t35.h +1
-0@@ -38,6 +38,8 @@#define CONFIG_DISPLAY_CPUINFO #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_SYS_ARM_CORTEXA8_ERRATA This config file is used for both cm-t35 and cm-t3730. cm-t35 has OMAP3530, but cm-t3730 has DM3730. The same U-Boot binary is used for both boards.
Quoted 4 lines
include/configs/cm_t35.h +1
-0+/* Clock Defines */ #define V_OSCK 26000000/* Clock output from T2 */ #define V_SCLK (V_OSCK >> 1)
Quoted 7 lines
Quoted 2 lines
[...]
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150222/5a781468/attachment.sig>
PATCH 1/1 omap3: ARM Cortex-A8 errata workarounds config option
In reply to Paul KocialkowskiLe dimanche 22 f?vrier 2015 ? 16:45 +0100, Paul Kocialkowski a ?crit :
Quoted 82 lines
Quoted 6 lines
Quoted 3 lines
Workarounds applied in
omap3_setup_aux_crare only necessary for ARM core revisions prior to r3p2 (such as OMAP35xx but apparently not OMAP36xx and DM37xx)If this is true, I can see some (potential) problems with the patch. Please, check out my thoughts on this below.
In any case, those workarounds were already enabled before, so it won't cause any regression. As it is now, the patch doesn't change anything, it just opens up the possibility of not using
CONFIG_SYS_ARM_CORTEXA8_ERRATAfor a board that doesn't need the workarounds and has them disabled in the kernel.Quoted 57 lines
Quoted 57 lines
and require similar workarounds in the kernel, or it will cause numerous segmentation faults. This allows (when the option is not used) properly booting kernels that do not include the workaround.
Follow-up to the discussion from July 2013:
http://lists.denx.de/pipermail/u-boot/2013-July/158377.htmlSigned-off-by Paul Kocialkowski <[email protected]>--- README | 8 ++++++++ arch/arm/cpu/armv7/omap3/board.c | 2 ++ include/configs/am3517_crane.h | 2 ++ include/configs/am3517_evm.h | 2 ++ include/configs/cm_t35.h | 2 ++ include/configs/cm_t3517.h | 2 ++ include/configs/dig297.h | 2 ++ include/configs/mcx.h | 2 ++ include/configs/nokia_rx51.h | 2 ++ include/configs/omap3_evm_common.h | 2 ++ include/configs/omap3_logic.h | 2 ++ include/configs/omap3_mvblx.h | 2 ++ include/configs/omap3_pandora.h | 2 ++ include/configs/omap3_sdp3430.h | 2 ++ include/configs/omap3_zoom1.h | 2 ++ include/configs/tam3517-common.h | 2 ++ include/configs/tao3530.h | 2 ++ include/configs/ti_omap3_common.h | 2 ++ include/configs/tricorder.h | 2 ++ 19 files changed, 44 insertions(+)README +8
-0@@ -621,6 +621,14 @@ The following options need to be configured: exists, unlike the similar options in the Linux kernel. Do not set these options unless they apply! + CONFIG_SYS_ARM_CORTEXA8_ERRATA + + Enables workarounds for ARM Cortex-A8 errata 454179, 430973 + and 621766. This is only necessary for ARM core revisions prior + to r3p2. Enabling those workarounds requires to enable the same + workarounds in the kernel, or it will cause multiple + segmentation faults. This is currently only effective on OMAP3. + - Driver Model Driver model is a new framework for devices in U-Boot introduced in early 2014. U-Boot is being progressivelyarch/arm/cpu/armv7/omap3/board.c +0
-0@@ -246,8 +246,10 @@ void s_init(void)try_unlock_memory ();Quoted 8 lines
arch/arm/cpu/armv7/omap3/board.c void s_init(void) · line 251
Quoted 3 lines
arch/arm/cpu/armv7/omap3/board.c +1
-0+#ifdef CONFIG_SYS_ARM_CORTEXA8_ERRATA /* Errata workarounds */ omap3_setup_aux_cr ();Can we have the revision dynamically checked instead of/along with introducing a config option?
We have boards, OMAP3 based, which are supported by the same board file and the same config file, see below.After carefully looking at it, I think dynamically checking the revision might be the cleanest way to do this.
Quoted 7 lines
I was afraid that, in the case where the workarounds are disabled in u-boot but enabled in Linux, the same various segmentation faults would happen, but they apparently don't, as I just tested.
Thus, checking the revision should work best. According to the code in Linux, this only affects r1p* ARM core revisions, so that's what I'll be checking against.
Looking at the Linux code more closely, it shows that erratum 430973 only affects r1p* and erratum 458693 only affects r2p0.
Now in U-Boot, everything is mixed together and while erratum 458693 is not mentionned, it does set the L1NEON bit to 1 like the workaround for erratum 458693 does in Linux.
What do you think I should do here? Follow the Linux way (split it up) or settle on applying both things for revisions <= r2p0.
Quoted 28 lines
Thanks for your comments!
Quoted 26 lines
Quoted 4 lines
arch/arm/cpu/armv7/omap3/board.c +1
-0+#endif #ifndef CONFIG_SYS_L2CACHE_OFF /* Invalidate L2-cache from secure mode */ [...]
include/configs/cm_t35.h line 41
Quoted 9 lines
include/configs/cm_t35.h +1
-0@@ -38,6 +38,8 @@#define CONFIG_DISPLAY_CPUINFO #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_SYS_ARM_CORTEXA8_ERRATA This config file is used for both cm-t35 and cm-t3730. cm-t35 has OMAP3530, but cm-t3730 has DM3730. The same U-Boot binary is used for both boards.
Quoted 4 lines
include/configs/cm_t35.h +1
-0+/* Clock Defines */ #define V_OSCK 26000000/* Clock output from T2 */ #define V_SCLK (V_OSCK >> 1)
Quoted 7 lines
Quoted 2 lines
[...]
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150222/1572486e/attachment.sig>
PATCH v2 1/1 omap3: Variant and revision checks for ARM Cortex-A8 errata workarounds
Not every version and revision of the Cortex-A8 ARM core requires the same errata workarounds. In addition, enabling those requires to have similar workarounds enabled in the kernel or it will cause numerous segmentation faults.
This enables those workarounds when they are needed, according to what is done in Linux.
Follow-up to the discussion from July 2013:
http://lists.denx.de/pipermail/u-boot/2013-July/158377.html
--- arch/arm/cpu/armv7/omap3/board.c | 27 +++++++++++++++++++++------ 1 file changed, 21 insertions(+), 6 deletions(-)
arch/arm/cpu/armv7/omap3/board.c +21 -6
@@ -431,14 +431,29 @@ static void omap3_update_aux_cr_secure(u32 set_bits, u32 clear_bits)static void omap3_setup_aux_cr (void ) { -/* Workaround for Cortex-A8 errata: #454179 #430973 -* Set "IBE" bit -* Set "Disable Branch Size Mispredicts" bit -* Workaround for erratum #621766 +u32 id, revision, variant; +u32 bits =0 ; + + asmvolatile ("mrc p15, 0, %0, c0, c0, 0" :"=r" (id)); + + variant = (id &0xf00000 ) >>20 ; + revision = id &0x0f ; + +/* Workaround for Cortex-A8 erratum: #454179 #430973 +* Set IBE bit +* Set Disable Branch Size Mispredicts (DBSM) bit +*/ +if (variant <2 ) + bits |= (1 <<6 ) | (1 <<7 ); + +/* Workaround for Cortex-A8 erratum #621766 * Enable L1NEON bit -* ACR |= (IBE | DBSM | L1NEON) => ACR |= 0xE0 */ -omap3_update_aux_cr_secure (0xE0 ,0 ); +if (variant ==2 && revision ==0 ) + bits |= (1 <<5 ); + +if (bits !=0 ) +omap3_update_aux_cr_secure (bits,0 ); }#ifndef CONFIG_SYS_L2CACHE_OFF
Signature · 1 line
1.9.1
PATCH v2 1/1 omap3: Variant and revision checks for ARM Cortex-A8 errata workarounds
Hi Paul,
Quoted 6 lines · Paul Kocialkowski
Not every version and revision of the Cortex-A8 ARM core requires the same errata workarounds. In addition, enabling those requires to have similar workarounds enabled in the kernel or it will cause numerous segmentation faults.
This enables those workarounds when they are needed, according to what is done in Linux.
Conceptually, I'm fine with the patch, but I did not look down into the erratas and how it should be handled...
Quoted 3 lines
Follow-up to the discussion from July 2013:
http://lists.denx.de/pipermail/u-boot/2013-July/158377.html
You've missed the s-o-b.
Quoted 15 lines
--- arch/arm/cpu/armv7/omap3/board.c | 27 +++++++++++++++++++++------ 1 file changed, 21 insertions(+), 6 deletions(-)arch/arm/cpu/armv7/omap3/board.c +0
-3@@ -431,14 +431,29 @@ static void omap3_update_aux_cr_secure(u32 set_bits, u32 clear_bits)static void omap3_setup_aux_cr (void ) { -/* Workaround for Cortex-A8 errata: #454179 #430973 -* Set "IBE" bit -* Set "Disable Branch Size Mispredicts" bit
arch/arm/cpu/armv7/omap3/board.c static void omap3_update_aux_cr_secure(u32 set_bits, u32 clear_bits) · line 442
Quoted 10 lines
arch/arm/cpu/armv7/omap3/board.c +9
-1-* Workaround for erratum #621766 +u32 id, revision, variant; +u32 bits =0 ; + + asmvolatile ("mrc p15, 0, %0, c0, c0, 0" :"=r" (id)); + + variant = (id &0xf00000 ) >>20 ; + revision = id &0x0f ; + +/* Workaround for Cortex-A8 erratum: #454179 #430973
While on this, I would also fix the multi-line comment...
arch/arm/cpu/armv7/omap3/board.c static void omap3_update_aux_cr_secure(u32 set_bits, u32 clear_bits) · line 449
Quoted 7 lines
arch/arm/cpu/armv7/omap3/board.c +7
-0+* Set IBE bit +* Set Disable Branch Size Mispredicts (DBSM) bit +*/ +if (variant <2 ) + bits |= (1 <<6 ) | (1 <<7 ); + +/* Workaround for Cortex-A8 erratum #621766
Also here.
Quoted 13 lines
arch/arm/cpu/armv7/omap3/board.c +5
-2* Enable L1NEON bit -* ACR |= (IBE | DBSM | L1NEON) => ACR |= 0xE0 */ -omap3_update_aux_cr_secure (0xE0 ,0 ); +if (variant ==2 && revision ==0 ) + bits |= (1 <<5 ); + +if (bits !=0 ) +omap3_update_aux_cr_secure (bits,0 ); }#ifndef CONFIG_SYS_L2CACHE_OFF
Signature · 2 lines
Regards, Igor.
PATCH v2 1/1 omap3: Variant and revision checks for ARM Cortex-A8 errata workarounds
Le lundi 23 f?vrier 2015 ? 13:09 +0200, Igor Grinberg a ?crit :
Quoted 7 lines
Hi Paul,
Quoted 4 lines · Paul Kocialkowski
Not every version and revision of the Cortex-A8 ARM core requires the same errata workarounds. In addition, enabling those requires to have similar workarounds enabled in the kernel or it will cause numerous segmentation faults.
Quoted 5 lines
Quoted 2 lines
This enables those workarounds when they are needed, according to what is done in Linux.
Conceptually, I'm fine with the patch, but I did not look down into the erratas and how it should be handled...
I was only able to find information about erratum 430973 which according to the kernel sources only affects r1p* (arch/arm/mm/proc-v7.S) but nothing regarding 454179 (disable branch size mispredicts) and 621766.
However, for 621766, the same L1NEON bit is set in the workaround for erratum 458693 as found on the kernel tree (arch/arm/mm/proc-v7.S) which is said to only affect r2p0.
It seems like information about those errata is not really accessible to the public, or I just couldn't find it.
I would appreciate it if someone could test this on an omap35xx board (supposedly with an ARM core id different than mine) just to check that it's running fine.
Then again, I did not change the workarounds for these errata (with regard to the code currently in U-Boot), only excluded cases were they should not be necessary. The reason why these workarounds are necessary is out of the scope of this patch.
Quoted 4 lines
Quoted 2 lines
Follow-up to the discussion from July 2013:
http://lists.denx.de/pipermail/u-boot/2013-July/158377.htmlYou've missed the s-o-b.
I will make a v3 anyways.
Quoted 19 lines
Quoted 19 lines
--- arch/arm/cpu/armv7/omap3/board.c | 27 +++++++++++++++++++++------ 1 file changed, 21 insertions(+), 6 deletions(-)arch/arm/cpu/armv7/omap3/board.c +3
-4@@ -431,14 +431,29 @@ static void omap3_update_aux_cr_secure(u32 set_bits, u32 clear_bits)static void omap3_setup_aux_cr (void ) { -/* Workaround for Cortex-A8 errata: #454179 #430973 -* Set "IBE" bit -* Set "Disable Branch Size Mispredicts" bit -* Workaround for erratum #621766 +u32 id, revision, variant; +u32 bits =0 ; +
Quoted 8 lines
arch/arm/cpu/armv7/omap3/board.c static void omap3_update_aux_cr_secure(u32 set_bits, u32 clear_bits) · line 442
Quoted 6 lines
arch/arm/cpu/armv7/omap3/board.c +6
-0+ asmvolatile ("mrc p15, 0, %0, c0, c0, 0" :"=r" (id)); + + variant = (id &0xf00000 ) >>20 ; + revision = id &0x0f ; + +/* Workaround for Cortex-A8 erratum: #454179 #430973 While on this, I would also fix the multi-line comment...
Will do.
Quoted 21 lines
arch/arm/cpu/armv7/omap3/board.c static void omap3_update_aux_cr_secure(u32 set_bits, u32 clear_bits) · line 449
Quoted 7 lines
arch/arm/cpu/armv7/omap3/board.c +7
-0+* Set IBE bit +* Set Disable Branch Size Mispredicts (DBSM) bit +*/ +if (variant <2 ) + bits |= (1 <<6 ) | (1 <<7 ); + +/* Workaround for Cortex-A8 erratum #621766 Also here.
Quoted 11 lines
arch/arm/cpu/armv7/omap3/board.c +5
-2* Enable L1NEON bit -* ACR |= (IBE | DBSM | L1NEON) => ACR |= 0xE0 */ -omap3_update_aux_cr_secure (0xE0 ,0 ); +if (variant ==2 && revision ==0 ) + bits |= (1 <<5 ); + +if (bits !=0 ) +omap3_update_aux_cr_secure (bits,0 ); }
Quoted 3 lines
arch/arm/cpu/armv7/omap3/board.c static void omap3_update_aux_cr_secure(u32 set_bits, u32 clear_bits) · line 459
Quoted 2 lines
arch/arm/cpu/armv7/omap3/board.c +0
-0#ifndef CONFIG_SYS_L2CACHE_OFF
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150223/da00e89a/attachment.sig>
PATCH 1/1 omap3: Variant and revision checks for ARM Cortex-A8 errata workarounds
Not every version and revision of the Cortex-A8 ARM core requires the same errata workarounds. In addition, enabling those requires to have similar workarounds enabled in the kernel or it will cause numerous segmentation faults.
This enables those workarounds when they are needed, according to what is done in Linux.
Follow-up to the discussion from July 2013:
http://lists.denx.de/pipermail/u-boot/2013-July/158377.html
--- arch/arm/cpu/armv7/omap3/board.c | 29 +++++++++++++++++++++++------ 1 file changed, 23 insertions(+), 6 deletions(-)
arch/arm/cpu/armv7/omap3/board.c +23 -6
@@ -431,14 +431,31 @@ static void omap3_update_aux_cr_secure(u32 set_bits, u32 clear_bits)static void omap3_setup_aux_cr (void ) { -/* Workaround for Cortex-A8 errata: #454179 #430973 -* Set "IBE" bit -* Set "Disable Branch Size Mispredicts" bit -* Workaround for erratum #621766 +u32 id, revision, variant; +u32 bits =0 ; + + asmvolatile ("mrc p15, 0, %0, c0, c0, 0" :"=r" (id)); + + variant = (id &0xf00000 ) >>20 ; + revision = id &0x0f ; + +/* +* Workaround for Cortex-A8 errata #454179, #430973 +* Set IBE bit +* Set Disable Branch Size Mispredicts (DBSM) bit +*/ +if (variant <2 ) + bits |= (1 <<6 ) | (1 <<7 ); + +/* +* Workaround for Cortex-A8 erratum #621766 * Enable L1NEON bit -* ACR |= (IBE | DBSM | L1NEON) => ACR |= 0xE0 */ -omap3_update_aux_cr_secure (0xE0 ,0 ); +if (variant ==2 && revision ==0 ) + bits |= (1 <<5 ); + +if (bits !=0 ) +omap3_update_aux_cr_secure (bits,0 ); }#ifndef CONFIG_SYS_L2CACHE_OFF
Signature · 1 line
1.9.1
PATCH 1/1 omap3: Variant and revision checks for ARM Cortex-A8 errata workarounds
Quoted 11 lines · Paul Kocialkowski
Not every version and revision of the Cortex-A8 ARM core requires the same errata workarounds. In addition, enabling those requires to have similar workarounds enabled in the kernel or it will cause numerous segmentation faults.
This enables those workarounds when they are needed, according to what is done in Linux.
Follow-up to the discussion from July 2013:
http://lists.denx.de/pipermail/u-boot/2013-July/158377.htmlSigned-off-by Paul Kocialkowski <[email protected]>
Nishanth, any comments here, since you've been thinking about errata stuff lately? Thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150223/90fa0b94/attachment.sig>
PATCH 1/1 omap3: Variant and revision checks for ARM Cortex-A8 errata workarounds
Quoted 12 lines · Tom Rini
Quoted 10 lines · Paul Kocialkowski
Not every version and revision of the Cortex-A8 ARM core requires the same errata workarounds. In addition, enabling those requires to have similar workarounds enabled in the kernel or it will cause numerous segmentation faults.
This enables those workarounds when they are needed, according to what is done in Linux.
Follow-up to the discussion from July 2013:
http://lists.denx.de/pipermail/u-boot/2013-July/158377.html
Quoted 7 lines
Quoted 1 line
Signed-off-by Paul Kocialkowski <[email protected]>Nishanth, any comments here, since you've been thinking about errata stuff lately? Thanks!
Reviewed-by Tom Rini <[email protected]>
I would probably go with v7 start code triggering the logic. even though the secure logic is probably unique..
something like CONFIG_ARM_ARCH_CP15_ERRATA or like
Signature · 3 lines
--- Regards, Nishanth Menon
PATCH 1/1 omap3: Variant and revision checks for ARM Cortex-A8 errata workarounds
Le lundi 23 f?vrier 2015 ? 16:43 -0600, Nishanth Menon a ?crit :
Quoted 15 lines · Tom Rini
Quoted 14 lines · Paul Kocialkowski
Quoted 12 lines
Not every version and revision of the Cortex-A8 ARM core requires the same errata workarounds. In addition, enabling those requires to have similar workarounds enabled in the kernel or it will cause numerous segmentation faults.
This enables those workarounds when they are needed, according to what is done in Linux.
Follow-up to the discussion from July 2013:
http://lists.denx.de/pipermail/u-boot/2013-July/158377.htmlSigned-off-by Paul Kocialkowski <[email protected]>
Quoted 8 lines
Quoted 5 lines
Nishanth, any comments here, since you've been thinking about errata stuff lately? Thanks!
Reviewed-by Tom Rini <[email protected]>I would probably go with v7 start code triggering the logic. even though the secure logic is probably unique..
It does seem like the secure logic is specific to the OMAP, even though the GP part (omap3_gp_romcode_call) seems to be generic.
I don't think it would fit well in common v7 code and overall, I don't think I have sufficient knowledge of those issues to take the decision to move that code around.
Hence, I'll keep my proposal to what it is now, and let someone else move the code around in the future if they feel the need to.
Quoted 1 line
something like
CONFIG_ARM_ARCH_CP15_ERRATAor like
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150224/72d4782e/attachment.sig>
PATCH 1/1 omap3: Variant and revision checks for ARM Cortex-A8 errata workarounds
Quoted 28 lines · Paul Kocialkowski
Le lundi 23 f?vrier 2015 ? 16:43 -0600, Nishanth Menon a ?crit :
Quoted 15 lines · Tom Rini
Quoted 14 lines · Paul Kocialkowski
Quoted 12 lines
Not every version and revision of the Cortex-A8 ARM core requires the same errata workarounds. In addition, enabling those requires to have similar workarounds enabled in the kernel or it will cause numerous segmentation faults.
This enables those workarounds when they are needed, according to what is done in Linux.
Follow-up to the discussion from July 2013:
http://lists.denx.de/pipermail/u-boot/2013-July/158377.htmlSigned-off-by Paul Kocialkowski <[email protected]>Quoted 8 lines
Quoted 5 lines
Nishanth, any comments here, since you've been thinking about errata stuff lately? Thanks!
Reviewed-by Tom Rini <[email protected]>I would probably go with v7 start code triggering the logic. even though the secure logic is probably unique..
It does seem like the secure logic is specific to the OMAP, even though the GP part (
omap3_gp_romcode_call) seems to be generic.
Quoted 6 lines
I don't think it would fit well in common v7 code and overall, I don't think I have sufficient knowledge of those issues to take the decision to move that code around.
Hence, I'll keep my proposal to what it is now, and let someone else move the code around in the future if they feel the need to.
Do you mind if i took a shot at it? would be great if you could test the same.
Signature · 3 lines
--- Regards, Nishanth Menon
PATCH 1/1 omap3: Variant and revision checks for ARM Cortex-A8 errata workarounds
Le mardi 24 f?vrier 2015 ? 09:22 -0600, Nishanth Menon a ?crit :
Quoted 29 lines · Paul Kocialkowski
Quoted 28 lines
Le lundi 23 f?vrier 2015 ? 16:43 -0600, Nishanth Menon a ?crit :
Quoted 15 lines · Tom Rini
Quoted 14 lines · Paul Kocialkowski
Quoted 12 lines
Not every version and revision of the Cortex-A8 ARM core requires the same errata workarounds. In addition, enabling those requires to have similar workarounds enabled in the kernel or it will cause numerous segmentation faults.
This enables those workarounds when they are needed, according to what is done in Linux.
Follow-up to the discussion from July 2013:
http://lists.denx.de/pipermail/u-boot/2013-July/158377.htmlSigned-off-by Paul Kocialkowski <[email protected]>Quoted 8 lines
Quoted 5 lines
Nishanth, any comments here, since you've been thinking about errata stuff lately? Thanks!
Reviewed-by Tom Rini <[email protected]>I would probably go with v7 start code triggering the logic. even though the secure logic is probably unique..
It does seem like the secure logic is specific to the OMAP, even though the GP part (
omap3_gp_romcode_call) seems to be generic.
Quoted 8 lines
Quoted 6 lines
I don't think it would fit well in common v7 code and overall, I don't think I have sufficient knowledge of those issues to take the decision to move that code around.
Hence, I'll keep my proposal to what it is now, and let someone else move the code around in the future if they feel the need to.
Do you mind if i took a shot at it? would be great if you could test the same.
Alright, please go ahead! I'm available to test any patch on my omap
3630 device.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150224/fd7d65d7/attachment.sig>
PATCH 1/1 omap3: Variant and revision checks for ARM Cortex-A8 errata workarounds
Quoted 34 lines · Paul Kocialkowski
Le mardi 24 f?vrier 2015 ? 09:22 -0600, Nishanth Menon a ?crit :
Quoted 33 lines · Paul Kocialkowski
Quoted 32 lines
Le lundi 23 f?vrier 2015 ? 16:43 -0600, Nishanth Menon a ?crit :
Quoted 15 lines · Tom Rini
Quoted 14 lines · Paul Kocialkowski
Quoted 12 lines
Not every version and revision of the Cortex-A8 ARM core requires the same errata workarounds. In addition, enabling those requires to have similar workarounds enabled in the kernel or it will cause numerous segmentation faults.
This enables those workarounds when they are needed, according to what is done in Linux.
Follow-up to the discussion from July 2013:
http://lists.denx.de/pipermail/u-boot/2013-July/158377.htmlSigned-off-by Paul Kocialkowski <[email protected]>Quoted 8 lines
Quoted 5 lines
Nishanth, any comments here, since you've been thinking about errata stuff lately? Thanks!
Reviewed-by Tom Rini <[email protected]>I would probably go with v7 start code triggering the logic. even though the secure logic is probably unique..
It does seem like the secure logic is specific to the OMAP, even though the GP part (
omap3_gp_romcode_call) seems to be generic.I don't think it would fit well in common v7 code and overall, I don't think I have sufficient knowledge of those issues to take the decision to move that code around.
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
Hence, I'll keep my proposal to what it is now, and let someone else move the code around in the future if they feel the need to.
Do you mind if i took a shot at it? would be great if you could test the same.
Alright, please go ahead! I'm available to test any patch on my omap 3630 device.
Alright, the series should now include OMAP3 as well.. Sorry about confusion when list blocked me for too many cc folks etc.. anyways..
https://patchwork.ozlabs.org/patch/443261/
https://patchwork.ozlabs.org/patch/443264/
https://patchwork.ozlabs.org/patch/443268/
https://patchwork.ozlabs.org/patch/443265/
https://patchwork.ozlabs.org/patch/443263/
https://patchwork.ozlabs.org/patch/443262/
https://patchwork.ozlabs.org/patch/443267/
https://patchwork.ozlabs.org/patch/443266/
https://patchwork.ozlabs.org/patch/443260/
Signature · 2 lines
Regards, Nishanth Menon