virtio: Add default_txconf
PATCH 1/1 virtio: Add default_txconf
When I tried to launch test-pmd on KVM guest of Fedora21, I got following error:
Configuring Port 0 (socket 0)
Fail to configure port 0 tx queues
EAL: Error - exiting with code: 1
Cause: Start ports failed
I found that the error caused here, and actual error message was "TX checksum offload not supported":
http://dpdk.org/browse/dpdk/tree/lib/librte_pmd_virtio/virtio_rxtx.c#n425
This patch adds default_txconf on virtio pmd, to avoid the error.
--- lib/librte_pmd_virtio/virtio_ethdev.c | 3 +++ 1 file changed, 3 insertions(+)
lib/librte_pmd_virtio/virtio_ethdev.c +3 -0
@@ -1188,6 +1188,9 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) dev_info->min_rx_bufsize =VIRTIO_MIN_RX_BUFSIZE ; dev_info->max_rx_pktlen =VIRTIO_MAX_RX_PKTLEN ; dev_info->max_mac_addrs =VIRTIO_MAX_MAC_ADDRS ; + dev_info->default_txconf = (struct rte_eth_txconf ) { + .txq_flags =ETH_TXQ_FLAGS_NOOFFLOADS + }; }/*
Signature · 1 line
2.1.0
A message that is not in the archive (sent off-list or not yet received): 1424677885-24171-1-git-send-email-syuu-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org
De Lara Guarch, Pablo
Acked-byQuoted 42 lines
-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Takuya ASADA
Sent: Monday, February 23, 2015 7:51 AM
To: [email protected]
Subject: [dpdk-dev] [PATCH] virtio: Adddefault_txconfWhen I tried to launch test-pmd on KVM guest of Fedora21, I got following error:
Configuring Port 0 (socket 0)
Fail to configure port 0 tx queues
EAL: Error - exiting with code: 1
Cause: Start ports failedI found that the error caused here, and actual error message was "TX checksum offload not supported":
http://dpdk.org/browse/dpdk/tree/lib/librte_pmd_virtio/virtio_rxtx.c#n425This patch adds
default_txconfon virtio pmd, to avoid the error.--- lib/librte_pmd_virtio/virtio_ethdev.c | 3 +++ 1 file changed, 3 insertions(+)lib/librte_pmd_virtio/virtio_ethdev.c +3
-0@@ -1188,6 +1188,9 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) dev_info->min_rx_bufsize = VIRTIO_MIN_RX_BUFSIZE; dev_info->max_rx_pktlen =VIRTIO_MAX_RX_PKTLEN ; dev_info->max_mac_addrs =VIRTIO_MAX_MAC_ADDRS ; + dev_info->default_txconf = (struct rte_eth_txconf ) { + .txq_flags =ETH_TXQ_FLAGS_NOOFFLOADS + }; }
Quoted 3 lines
/*
--
2.1.0
A message that is not in the archive (sent off-list or not yet received): E115CCD9D858EF4F90C690B0DCB4D89727267B50-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org
Thomas Monjalon
AppliedQuoted 12 lines
Quoted 12 lines
When I tried to launch test-pmd on KVM guest of Fedora21, I got following error:
Configuring Port 0 (socket 0)
Fail to configure port 0 tx queues
EAL: Error - exiting with code: 1
Cause: Start ports failedI found that the error caused here, and actual error message was "TX checksum offload not supported":
http://dpdk.org/browse/dpdk/tree/lib/librte_pmd_virtio/virtio_rxtx.c#n425
Quoted 5 lines
Quoted 3 lines
This patch adds
default_txconfon virtio pmd, to avoid the error.Acked-by Pablo de Lara <[email protected]>
Applied, thanks