Skip to contentSkip to conversation

xfce4-session: Remove unneeded pkg_postinst

PATCH In review Ash Charles 2 participants 2 messages Feb 23, 2015 – Feb 25, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfce4-session: Remove unneeded pkg_postinst

The pkg_postinst inherited from previous versions of this recipe no longer seems necessary; no error message seen at runtime in a quick test. As it made the generated packages unnecessarily machine-specific, remove this post-install step. Based on the ensuring discussion, this supersedes the original patch [1].

[1] http://lists.openembedded.org/pipermail/openembedded-devel/2015-February/100454.html

---
 meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.1.bb | 5 -----
 1 file changed, 5 deletions(-)
meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.1.bb +0 -5
index 74289fb..aa82a7c 100644
@@ -17,11 +17,6 @@ ALTERNATIVE_${PN} = "x-session-manager"
 ALTERNATIVE_TARGET[x-session-manager] = "${bindir}/xfce4-session"
 ALTERNATIVE_PRIORITY_${PN} = "100"
 
-# protect from frightening message that xfce might not work correctly
-pkg_postinst_${PN} () {
-    echo 127.0.0.1    ${MACHINE} >> /etc/hosts
-}
-
 PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES','systemd','systemd','consolekit',d)}"
 PACKAGECONFIG[systemd] = "--enable-systemd, --disable-systemd, polkit, systemd"
 PACKAGECONFIG[consolekit] = ",,,consolekit"
Signature · 1 line
2.1.0
Tested-by on v1 1/1
#1 lore raw
Quoted 30 lines · Ash Charles

The pkg_postinst inherited from previous versions of this recipe no longer seems necessary; no error message seen at runtime in a quick test. As it made the generated packages unnecessarily machine-specific, remove this post-install step. Based on the ensuring discussion, this supersedes the original patch [1].

[1] http://lists.openembedded.org/pipermail/openembedded-devel/2015-February/100454.html

---
 meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.1.bb | 5 -----
 1 file changed, 5 deletions(-)
meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.1.bb +0 -6
index 74289fb..aa82a7c 100644
@@ -17,11 +17,6 @@ ALTERNATIVE_${PN} = "x-session-manager"
 ALTERNATIVE_TARGET[x-session-manager] = "${bindir}/xfce4-session"
 ALTERNATIVE_PRIORITY_${PN} = "100"
 
-# protect from frightening message that xfce might not work correctly
-pkg_postinst_${PN} () {
-    echo 127.0.0.1    ${MACHINE} >> /etc/hosts
-}
-
 PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES','systemd','systemd','consolekit',d)}"
 PACKAGECONFIG[systemd] = "--enable-systemd, --disable-systemd, polkit, systemd"
 PACKAGECONFIG[consolekit] = ",,,consolekit"
--
Quoted 2 lines

2.1.0