Skip to contentSkip to conversation

Staging: rtl8723au: core: Delete space

PATCH In review Hatice ERTÜRK 2 participants 2 messages Feb 23, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: rtl8723au: core: Delete space

This Error found with checkpatch.pl

ERROR: else should follow close brace '}'

---
 drivers/staging/rtl8723au/core/rtw_xmit.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/rtl8723au/core/rtw_xmit.c +1 -2
index bece9b3..8124d9e 100644
@@ -914,8 +914,7 @@ static int rtw_make_wlanhdr(struct rtw_adapter *padapter, u8 *hdr,
 
 			if (psta->qos_option)
 				qos_option = true;
-		}
-		else {
+		} else {
 			RT_TRACE(_module_rtl871x_xmit_c_, _drv_err_, ("fw_state:%x is not allowed to xmit frame\n", get_fwstate(pmlmepriv)));
 			res = _FAIL;
 			goto exit;
Signature · 1 line
1.9.1
#1 lore raw
Quoted 8 lines · Hatice ERTÜRK

This Error found with checkpatch.pl

ERROR: else should follow close brace '}'

---
 drivers/staging/rtl8723au/core/rtw_xmit.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Patch is good, but the commit message isn't correct. You are not deleting space, but placing else on the same line as the closing bracket.

Cheers,
Jes

Quoted 15 lines
drivers/staging/rtl8723au/core/rtw_xmit.c +1 -2
index bece9b3..8124d9e 100644
@@ -914,8 +914,7 @@ static int rtw_make_wlanhdr(struct rtw_adapter *padapter, u8 *hdr,
 
 			if (psta->qos_option)
 				qos_option = true;
-		}
-		else {
+		} else {
 			RT_TRACE(_module_rtl871x_xmit_c_, _drv_err_, ("fw_state:%x is not allowed to xmit frame\n", get_fwstate(pmlmepriv)));
 			res = _FAIL;
 			goto exit;