Skip to contentSkip to conversation

qmp-commands.hx: Fix several typos

PATCH Superseded Alberto Garcia 2 participants 4 messages Feb 23, 2015 – Feb 24, 2015

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qmp-commands.hx: Fix several typos

---
 qmp-commands.hx | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
qmp-commands.hx +3 -3
index a85d847..52741ed 100644
@@ -1,5 +1,5 @@
 HXCOMM QMP dispatch table and documentation
-HXCOMM Text between SQMP and EQMP is copied to the QMP documention file and
+HXCOMM Text between SQMP and EQMP is copied to the QMP documentation file and
 HXCOMM does not show up in the other formats.
 
 SQMP
@@ -1767,7 +1767,7 @@ Arguments:
 
 - "protocol": protocol name (json-string)
 - "password": password (json-string)
-- "connected": [ keep | disconnect | fail ] (josn-string, optional)
+- "connected": [ keep | disconnect | fail ] (json-string, optional)
 
 Example:
 
@@ -2922,7 +2922,7 @@ Channels are described by a json-object, each one contain the following:
 - "channel-id": channel id.  Usually "0", might be different needed when
                 multiple channels of the same type exist, such as multiple
                 display channels in a multihead setup (json-int)
-- "tls": whevener the channel is encrypted (json-bool)
+- "tls": whenever the channel is encrypted (json-bool)
 
 Example:
 
Signature · 1 line
2.1.4
Reviewed-by on v1 1/1
#1 lore raw

qmp-commands.hx Channels are described by a json-object, each one contain the following: · line 2925

Quoted 12 lines · Alberto Garcia
---
 qmp-commands.hx | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
qmp-commands.hx +1 -1
@@ -2922,7 +2922,7 @@ Channels are described by a json-object, each one contain the following:
 - "channel-id": channel id.  Usually "0", might be different needed when
                 multiple channels of the same type exist, such as multiple
                 display channels in a multihead setup (json-int)
-- "tls": whevener the channel is encrypted (json-bool)
+- "tls": whenever the channel is encrypted (json-bool)

Might be nicer as 'whether' rather than 'whenever'.

But as your version is strictly better than an obvious typo,

Signature · 2 lines
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org
#2 lore raw
Quoted 4 lines · Eric Blake
Quoted 2 lines

-- "tls": whevener the channel is encrypted (json-bool) +- "tls": whenever the channel is encrypted (json-bool)

Might be nicer as 'whether' rather than 'whenever'.

Oh, you're right. Feel free to change it, or do you want me to resubmit the patch?

Berto

#3 lore raw
Quoted 9 lines · Alberto Garcia
Quoted 4 lines · Eric Blake
Quoted 2 lines

-- "tls": whevener the channel is encrypted (json-bool) +- "tls": whenever the channel is encrypted (json-bool)

Might be nicer as 'whether' rather than 'whenever'.

Oh, you're right. Feel free to change it, or do you want me to resubmit the patch?

Up to the trivial tree maintainer, but if it were me, I'd resend a v2 to make his life easier.

Signature · 2 lines
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org