Skip to contentSkip to conversation

Hal8188ERateAdaptive.c : Expression is always false because 'else if' condition matches previous condition at line 404.

PATCH In review Ameen Ali 2 participants 2 messages Feb 24, 2015 Staging

lore
Share & tools
lore

Ameen Ali

author
#0 lore raw

PATCH 3/3 Hal8188ERateAdaptive.c : Expression is always false because 'else if' condition matches previous condition at line 404.

else if at line 406 has the same condition as the else if at line 404.

---
 drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c +1 -1
index 3c651d5..944cf7b 100644
@@ -403,7 +403,7 @@ static int odm_ARFBRefresh_8188E(struct odm_dm_struct *dm_odm, struct odm_ra_inf
 			pRaInfo->PTModeSS = 3;
 		else if (pRaInfo->HighestRate > 0x0b)
 			pRaInfo->PTModeSS = 2;
-		else if (pRaInfo->HighestRate > 0x0b)
+		else if (pRaInfo->HighestRate > 0x5)
 			pRaInfo->PTModeSS = 1;
 		else
 			pRaInfo->PTModeSS = 0;
Signature · 1 line
2.1.0
#1 lore raw
Quoted 2 lines · Ameen Ali

else if at line 406 has the same condition as the else if at line 404.

The changelog should really say why you think 0x5 is correct. Could you update and resend?

regards,
dan carpenter