Skip to contentSkip to conversation

Staging: media: replace printk(KERN_DEBUG ..) with pr_debug

PATCH In review aybuke ozdemir 2 participants 2 messages Feb 24, 2015 – Feb 25, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: media: replace printk(KERN_DEBUG ..) with pr_debug

This patch fixes "Prefer [subsystem eg: netdev]_dbg([subsystem]dev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG" checkpatch.pl warning in c-qcam.c

---
 drivers/staging/media/parport/c-qcam.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/parport/c-qcam.c +1 -1
index b9010bd..96a511e 100644
@@ -220,7 +220,7 @@ static int qc_detect(struct qcam *qcam)
 	    && qcam->pport->probe_info[0].model
 	    && !strcmp(qcam->pdev->port->probe_info[0].model,
 		       "Color QuickCam 2.0")) {
-		printk(KERN_DEBUG "QuickCam: Found by IEEE1284 probe.\n");
+		pr_debug("QuickCam: Found by IEEE1284 probe.\n");
 		return 1;
 	}
 
Signature · 1 line
1.9.1
#1 lore raw

drivers/staging/media/parport/c-qcam.c static int qc_detect(struct qcam *qcam)

Quoted 14 lines · aybuke ozdemir

This patch fixes "Prefer [subsystem eg: netdev]_dbg([subsystem]dev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG" checkpatch.pl warning in c-qcam.c

---
 drivers/staging/media/parport/c-qcam.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/parport/c-qcam.c +0 -0
index b9010bd..96a511e 100644
@@ -220,7 +220,7 @@ static int qc_detect(struct qcam *qcam)

I suspect that if you look through the field of the qcam structure, you can find one rgat contains a device-typed field, allowing you to use dev_debug.

julia

Quoted 18 lines
drivers/staging/media/parport/c-qcam.c +1 -1
 	    && qcam->pport->probe_info[0].model
 	    && !strcmp(qcam->pdev->port->probe_info[0].model,
 		       "Color QuickCam 2.0")) {
-		printk(KERN_DEBUG "QuickCam: Found by IEEE1284 probe.\n");
+		pr_debug("QuickCam: Found by IEEE1284 probe.\n");
 		return 1;
 	}
 
Signature · 8 lines
1.9.1

-- 
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1424821014-12100-1-git-send-email-aybuke.147%40gmail.com.
For more options, visit https://groups.google.com/d/optout.