spi: dw: revisit FIFO size detection again
PATCH v2 1/1 spi: dw: revisit FIFO size detection again
The commit d297933cc7fc (spi: dw: Fix detecting FIFO depth) tries to fix the logic of the FIFO detection based on the description on the comments. However, there is a slight difference between numbers in TX Level and TX FIFO size.
So, by specification the FIFO size would be in a range 2-256 bytes. From TX Level prospective it means we can set threshold in the range 0-(FIFO size - 1) bytes. Hence there are currently two issues:
a) FIFO size 2 bytes is actually skipped since TX Level is 1 bit and could be
either 0 or 1 byte;
b) FIFO size is incorrectly decreased by 1 which already done by meaning of TX Level register.
This patch fixes it eventually right.
---
Changelog v2:
- address Alex' comment
drivers/spi/spi-dw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/spi/spi-dw.c +2 -2
@@ -494,14 +494,14 @@ static void spi_hw_init(struct device *dev, struct dw_spi *dws)if (!dws->fifo_len) {u32 fifo; -for (fifo =2 ; fifo <=256 ; fifo++) { +for (fifo =1 ; fifo <256 ; fifo++) {dw_writew (dws,DW_SPI_TXFLTR , fifo);if (fifo !=dw_readw (dws,DW_SPI_TXFLTR ))break ; }dw_writew (dws,DW_SPI_TXFLTR ,0 ); - dws->fifo_len = (fifo ==2 ) ?0 : fifo -1 ; + dws->fifo_len = (fifo ==1 ) ?0 : fifo;dev_dbg (dev,"Detected FIFO size: %u bytes\n" , dws->fifo_len); } }
Signature · 6 lines
2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 1424857176-4711-1-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/[email protected]
Mark Brown
AppliedQuoted 3 lines · Andy Shevchenko
The commit
d297933cc7fc(spi: dw: Fix detecting FIFO depth) tries to fix the logic of the FIFO detection based on the description on the comments. However, there is a slight difference between numbers in TX Level and TX FIFO size.
Applied, thanks.