Skip to contentSkip to conversation

Hal8188ERateAdaptive.c : Expression is always false because 'else if' condition matches previous condition at line 404.

PATCH In review Ameen Ali 2 participants 2 messages Feb 25, 2015 – Mar 20, 2015 Staging

lore
Share & tools
lore

Ameen Ali

author
#0 lore raw

PATCH 3/3 Hal8188ERateAdaptive.c : Expression is always false because 'else if' condition matches previous condition at line 404.

else if at line 406 has the same condition as the else if at line 404. i chosed 0x5 because it's half 0xb (just a rate controller)

---
 drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c +1 -1
index 3c651d5..944cf7b 100644
@@ -403,7 +403,7 @@ static int odm_ARFBRefresh_8188E(struct odm_dm_struct *dm_odm, struct odm_ra_inf
 			pRaInfo->PTModeSS = 3;
 		else if (pRaInfo->HighestRate > 0x0b)
 			pRaInfo->PTModeSS = 2;
-		else if (pRaInfo->HighestRate > 0x0b)
+		else if (pRaInfo->HighestRate > 0x5)
 			pRaInfo->PTModeSS = 1;
 		else
 			pRaInfo->PTModeSS = 0;
Signature · 1 line
2.1.0
maintainer
#1 lore raw
Quoted 6 lines · Ameen Ali

else if at line 406 has the same condition as the else if at line 404. i chosed 0x5 because it's half 0xb (just a rate controller)

---
 drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

How do you know this is correct?

Also, we need a blank line before the signed-off-by line and your subject should give us a chance to know what driver is being changed, as well as the subsystem.

Also, where are patches 1/3 and 2/3?

thanks,

greg k-h