Skip to contentSkip to conversation

hwmon: (it87) No need to skip fan4 for IT8603

PATCH In review Guenter Roeck 2 participants 2 messages Feb 25, 2015 – Feb 26, 2015

Subsystems (2)
lore
Share & tools
lore

Guenter Roeck

author maintainer
#0 lore raw

PATCH v2 5/5 hwmon: (it87) No need to skip fan4 for IT8603

IT8603 supports only three fans, so it is not necessary to skip fan4.

---
v2: Patch added to series

 drivers/hwmon/it87.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/hwmon/it87.c +0 -4
index 691067b..ab12dc2 100644
@@ -1932,10 +1932,6 @@ static int __init it87_find(unsigned short *address,
 		sio_data->skip_in |= (1 << 5); /* No VIN5 */
 		sio_data->skip_in |= (1 << 6); /* No VIN6 */
 
-		/* no fan4 */
-		sio_data->skip_pwm |= (1 << 3);
-		sio_data->skip_fan |= (1 << 3);
-
 		sio_data->internal |= (1 << 1); /* in7 is VSB */
 		sio_data->internal |= (1 << 3); /* in9 is AVCC */
 
Signature · 7 lines
2.1.0


_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Reviewed-by on v2 5/5
#1 lore raw

Hi Guenter,

Quoted 14 lines · Guenter Roeck

IT8603 supports only three fans, so it is not necessary to skip fan4.

---
v2: Patch added to series

 drivers/hwmon/it87.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/hwmon/it87.c +0 -0
index 691067b..ab12dc2 100644

drivers/hwmon/it87.c static int __init it87_find(unsigned short *address, · line 1937

Quoted 10 lines
drivers/hwmon/it87.c +0 -4
@@ -1932,10 +1932,6 @@ static int __init it87_find(unsigned short *address,
 		sio_data->skip_in |= (1 << 5); /* No VIN5 */
 		sio_data->skip_in |= (1 << 6); /* No VIN6 */
 
-		/* no fan4 */
-		sio_data->skip_pwm |= (1 << 3);
-		sio_data->skip_fan |= (1 << 3);
-
 		sio_data->internal |= (1 << 1); /* in7 is VSB */
 		sio_data->internal |= (1 << 3); /* in9 is AVCC */
 

Looks good to me, good catch. Ruik, your ack would be appreciated.

Signature · 7 lines
Jean Delvare
SUSE L3 Support

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors