Skip to contentSkip to conversation

rtlwifi: rtl8192cu: Add case in rtl92cu_get_hw_reg

PATCH In review Taehee Yoo 2 participants 5 messages Feb 25, 2015 Networking drivers (wireless)

lore
Share & tools
lore

Taehee Yoo

author
#0 lore raw

PATCH 1/1 rtlwifi: rtl8192cu: Add case in rtl92cu_get_hw_reg

rtl_op_stop get wowlan state but rtl92cu_get_hw_reg has not process.

---
 drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/net/wireless/rtlwifi/rtl8192cu/hw.c +6 -0
index fe4b699..f6ad959 100644
@@ -1589,6 +1589,12 @@ void rtl92cu_get_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
 	case HW_VAR_DATA_FILTER:
 		*((u16 *) (val)) = rtl_read_word(rtlpriv, REG_RXFLTMAP2);
 		break;
+	case HAL_DEF_WOWLAN:
+		if (ppsc->wo_wlan_mode)
+			*((bool *)(val)) = true;
+		else
+			*((bool *)(val)) = false;
+		break;
 	default:
 		RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
 			 "switch case not processed\n");
Signature · 1 line
1.9.1
#1 lore raw
Quoted 3 lines · Taehee Yoo

rtl_op_stop get wowlan state but rtl92cu_get_hw_reg has not process.

Has this been tested? I am not aware that the RTL8192CU firmware could handle WOWLAN.

Larry

Quoted 22 lines
---
  drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 6 ++++++
  1 file changed, 6 insertions(+)
drivers/net/wireless/rtlwifi/rtl8192cu/hw.c +6 -0
index fe4b699..f6ad959 100644
@@ -1589,6 +1589,12 @@ void rtl92cu_get_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
  	case HW_VAR_DATA_FILTER:
  		*((u16 *) (val)) = rtl_read_word(rtlpriv, REG_RXFLTMAP2);
  		break;
+	case HAL_DEF_WOWLAN:
+		if (ppsc->wo_wlan_mode)
+			*((bool *)(val)) = true;
+		else
+			*((bool *)(val)) = false;
+		break;
  	default:
  		RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
  			 "switch case not processed\n");
author
#2 lore raw

2015-02-26 3:33 GMT+09:00 Larry Finger <[email protected]>:

Quoted 29 lines · Taehee Yoo
Quoted 4 lines

rtl_op_stop get wowlan state but rtl92cu_get_hw_reg has not process.

Has this been tested? I am not aware that the RTL8192CU firmware could handle WOWLAN.

Larry

Quoted 16 lines
---
  drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 6 ++++++
  1 file changed, 6 insertions(+)
drivers/net/wireless/rtlwifi/rtl8192cu/hw.c +2 -0
index fe4b699..f6ad959 100644
@@ -1589,6 +1589,12 @@ void rtl92cu_get_hw_reg(struct ieee80211_hw *hw, u8
 variable, u8 *val)
        case HW_VAR_DATA_FILTER:
                *((u16 *) (val)) = rtl_read_word(rtlpriv, REG_RXFLTMAP2);
                break;
+       case HAL_DEF_WOWLAN:
+               if (ppsc->wo_wlan_mode)
Quoted 9 lines
Quoted 8 lines
drivers/net/wireless/rtlwifi/rtl8192cu/hw.c +4 -0
+                       *((bool *)(val)) = true;
+               else
+                       *((bool *)(val)) = false;
+               break;
        default:
                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
                         "switch case not processed\n");

As far as i know, rtl8192cu is not support WOWLAN.
in rtl8192cu, this code is no effect. so, It is care of unnecessary debug message.

#3 lore raw
Quoted 40 lines · On 02/25/2015 12:59 PM, ap420073 . wrote:

2015-02-26 3:33 GMT+09:00 Larry Finger <[email protected]>:

Quoted 29 lines · Taehee Yoo
Quoted 4 lines

rtl_op_stop get wowlan state but rtl92cu_get_hw_reg has not process.

Has this been tested? I am not aware that the RTL8192CU firmware could handle WOWLAN.

Larry

Quoted 16 lines
---
   drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 6 ++++++
   1 file changed, 6 insertions(+)
drivers/net/wireless/rtlwifi/rtl8192cu/hw.c +2 -0
index fe4b699..f6ad959 100644
@@ -1589,6 +1589,12 @@ void rtl92cu_get_hw_reg(struct ieee80211_hw *hw, u8
 variable, u8 *val)
         case HW_VAR_DATA_FILTER:
                 *((u16 *) (val)) = rtl_read_word(rtlpriv, REG_RXFLTMAP2);
                 break;
+       case HAL_DEF_WOWLAN:
+               if (ppsc->wo_wlan_mode)
Quoted 9 lines
Quoted 8 lines
drivers/net/wireless/rtlwifi/rtl8192cu/hw.c +4 -0
+                       *((bool *)(val)) = true;
+               else
+                       *((bool *)(val)) = false;
+               break;
         default:
                 RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
                          "switch case not processed\n");
Quoted 3 lines

As far as i know, rtl8192cu is not support WOWLAN.
in rtl8192cu, this code is no effect. so, It is care of unnecessary debug message.

That is what I thought. In that case, the new code should be

	case HAL_DEF_WOWLAN:
		break;

Larry

author
#4 lore raw

2015-02-26 4:12 GMT+09:00 Larry Finger <[email protected]>:

Quoted 52 lines · On 02/25/2015 12:59 PM, ap420073 . wrote:
Quoted 46 lines

2015-02-26 3:33 GMT+09:00 Larry Finger <[email protected]>:

Quoted 34 lines · Taehee Yoo
Quoted 5 lines

rtl_op_stop get wowlan state but rtl92cu_get_hw_reg has not process.

Has this been tested? I am not aware that the RTL8192CU firmware could handle WOWLAN.

Larry

Quoted 18 lines
---
   drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 6 ++++++
   1 file changed, 6 insertions(+)
drivers/net/wireless/rtlwifi/rtl8192cu/hw.c +0 -0
index fe4b699..f6ad959 100644
@@ -1589,6 +1589,12 @@ void rtl92cu_get_hw_reg(struct ieee80211_hw *hw,

u8
variable, u8 *val)

         case HW_VAR_DATA_FILTER:
                 *((u16 *) (val)) = rtl_read_word(rtlpriv,
REG_RXFLTMAP2);
                 break;
drivers/net/wireless/rtlwifi/rtl8192cu/hw.c +2 -0
+       case HAL_DEF_WOWLAN:
+               if (ppsc->wo_wlan_mode)
Quoted 9 lines

drivers/net/wireless/rtlwifi/rtl8192cu/hw.c void rtl92cu_get_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val) · line 1600

Quoted 8 lines
drivers/net/wireless/rtlwifi/rtl8192cu/hw.c +4 -0
+                       *((bool *)(val)) = true;
+               else
+                       *((bool *)(val)) = false;
+               break;
         default:
                 RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
                          "switch case not processed\n");
Quoted 3 lines

As far as i know, rtl8192cu is not support WOWLAN.
in rtl8192cu, this code is no effect. so, It is care of unnecessary debug message.

Quoted 7 lines

That is what I thought. In that case, the new code should be

        case HAL_DEF_WOWLAN:
                break;

Larry

Thanks!
I would send a new code.