Skip to contentSkip to conversation

bridge: Show state names in the 'link help' print

PATCH In review Vadim Kochan 2 participants 3 messages Feb 26, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bridge: Show state names in the 'link help' print

From: Vadim Kochan <[email protected]>

---
 bridge/link.c | 6 ++++++
 1 file changed, 6 insertions(+)
bridge/link.c +6 -0
index a7bd85f..7f1ec70 100644
@@ -228,6 +228,12 @@ static void usage(void)
 	fprintf(stderr,	"                               [ flood {on | off} ]\n");
 	fprintf(stderr, "                               [ hwmode {vepa | veb} ]\n");
 	fprintf(stderr, "       bridge link show [dev DEV]\n");
+	fprintf(stderr, "\n");
+	fprintf(stderr, "STATE := { 0 | disabled   |\n");
+	fprintf(stderr, "           1 | listening  |\n");
+	fprintf(stderr, "           2 | learning   |\n");
+	fprintf(stderr, "           3 | forwarding |\n");
+	fprintf(stderr, "           4 | blocking }\n");
 	exit(-1);
 }
 
Signature · 1 line
2.2.2
#1 lore raw
Quoted 14 lines · On Thu, 26 Feb 2015 01:56:33 +0200 Vadim Kochan <[email protected]> wrote:

From: Vadim Kochan <[email protected]>

---
 bridge/link.c | 6 ++++++
 1 file changed, 6 insertions(+)
bridge/link.c +0 -0
index a7bd85f..7f1ec70 100644
@@ -228,6 +228,12 @@ static void usage(void)
 	fprintf(stderr,	"                               [ flood {on | off} ]\n");
 	fprintf(stderr, "                               [ hwmode {vepa | veb} ]\n");

bridge/link.c static void usage(void) · line 239

Quoted 10 lines
bridge/link.c +6 -0
 	fprintf(stderr, "       bridge link show [dev DEV]\n");
+	fprintf(stderr, "\n");
+	fprintf(stderr, "STATE := { 0 | disabled   |\n");
+	fprintf(stderr, "           1 | listening  |\n");
+	fprintf(stderr, "           2 | learning   |\n");
+	fprintf(stderr, "           3 | forwarding |\n");
+	fprintf(stderr, "           4 | blocking }\n");
 	exit(-1);
 }
 

that is too wordy for help. put it in docs if needed.

#2 lore raw
Quoted 21 lines · Stephen Hemminger
Quoted 18 lines · On Thu, 26 Feb 2015 01:56:33 +0200 Vadim Kochan <[email protected]> wrote:

From: Vadim Kochan <[email protected]>

---
 bridge/link.c | 6 ++++++
 1 file changed, 6 insertions(+)
bridge/link.c +3 -0
index a7bd85f..7f1ec70 100644
@@ -228,6 +228,12 @@ static void usage(void)
 	fprintf(stderr,	"                               [ flood {on | off} ]\n");
 	fprintf(stderr, "                               [ hwmode {vepa | veb} ]\n");
 	fprintf(stderr, "       bridge link show [dev DEV]\n");
+	fprintf(stderr, "\n");
+	fprintf(stderr, "STATE := { 0 | disabled   |\n");
+	fprintf(stderr, "           1 | listening  |\n");
Quoted 8 lines

bridge/link.c static void usage(void) · line 239

Quoted 6 lines
bridge/link.c +3 -0
+	fprintf(stderr, "           2 | learning   |\n");
+	fprintf(stderr, "           3 | forwarding |\n");
+	fprintf(stderr, "           4 | blocking }\n");
 	exit(-1);
 }
 

that is too wordy for help. put it in docs if needed.

Hm, I assumed this might be useful for fast looking for state names from the shell just by 'link help'...