sched/deadline: don't need to check throttled status when switched to dl
PATCH 1/1 sched/deadline: don't need to check throttled status when switched to dl
After commit 40767b0dc768 ("sched/deadline: Fix deadline parameter modification handling"), deadline task throttled status is cleared each time switch from dl, so throttled status always unset when switch back, there is no need to check throttled status, this patch drop the check.
--- kernel/sched/deadline.c | 8 -------- 1 file changed, 8 deletions(-)
kernel/sched/deadline.c +0 -8
@@ -1697,14 +1697,6 @@ static void switched_to_dl(struct rq *rq, struct task_struct *p) {int check_resched =1 ; -/* -* If p is throttled, don't consider the possibility -* of preempting rq->curr, the check will be done right -* after its runtime will get replenished. -*/ -if (unlikely (p->dl.dl_throttled)) -return ; -if (task_on_rq_queued (p) && rq->curr != p) {#ifdef CONFIG_SMP if (p->nr_cpus_allowed > 1 && rq->dl.overloaded &&
Signature · 1 line
1.9.1
Ping Juri,
Quoted 32 lines · Wanpeng Li
After commit
40767b0dc768("sched/deadline: Fix deadline parameter modification handling"), deadline task throttled status is cleared each time switch from dl, so throttled status always unset when switch back, there is no need to check throttled status, this patch drop the check.Signed-off-by Wanpeng Li <[email protected]>---
kernel/sched/deadline.c| 8 --------1 file changed, 8 deletions(-)kernel/sched/deadline.c +0
-8@@ -1697,14 +1697,6 @@ static void switched_to_dl(struct rq *rq, struct task_struct *p) {int check_resched =1 ; -/* -* If p is throttled, don't consider the possibility -* of preempting rq->curr, the check will be done right -* after its runtime will get replenished. -*/ -if (unlikely (p->dl.dl_throttled)) -return ; -if (task_on_rq_queued (p) && rq->curr != p) {#ifdef CONFIG_SMP if (p->nr_cpus_allowed > 1 && rq->dl.overloaded &&Signature · 1 line
1.9.1
Juri Lelli
Acked-byQuoted 1 line · Wanpeng Li
Ping Juri,
Yeah, I looked at it this morning. Looks good, thanks!
Quoted 8 lines · Wanpeng Li
Quoted 7 lines
After commit
40767b0dc768("sched/deadline: Fix deadline parameter modification handling"), deadline task throttled status is cleared each time switch from dl, so throttled status always unset when switch back, there is no need to check throttled status, this patch drop the check.Signed-off-by Wanpeng Li <[email protected]>
Quoted 26 lines
Quoted 25 lines
---
kernel/sched/deadline.c| 8 --------1 file changed, 8 deletions(-)kernel/sched/deadline.c +0
-8@@ -1697,14 +1697,6 @@ static void switched_to_dl(struct rq *rq, struct task_struct *p) {int check_resched =1 ; -/* -* If p is throttled, don't consider the possibility -* of preempting rq->curr, the check will be done right -* after its runtime will get replenished. -*/ -if (unlikely (p->dl.dl_throttled)) -return ; -if (task_on_rq_queued (p) && rq->curr != p) {#ifdef CONFIG_SMP if (p->nr_cpus_allowed > 1 && rq->dl.overloaded &&Signature · 1 line
1.9.1
Quoted 12 lines · Juri Lelli
Quoted 1 line · Wanpeng Li
Ping Juri,
Yeah, I looked at it this morning. Looks good, thanks!
Quoted 7 lines · Wanpeng Li
Quoted 6 lines
After commit
40767b0dc768("sched/deadline: Fix deadline parameter modification handling"), deadline task throttled status is cleared each time switch from dl, so throttled status always unset when switch back, there is no need to check throttled status, this patch drop the check.
Quoted 3 lines
Quoted 1 line
Quoted 1 line
Signed-off-by Wanpeng Li <[email protected]>Acked-by Juri Lelli <[email protected]>
Thanks for your review. ;-)
Regards,
Wanpeng Li
Quoted 27 lines
Quoted 27 lines
Quoted 26 lines
---
kernel/sched/deadline.c| 8 --------1 file changed, 8 deletions(-)kernel/sched/deadline.c +0
-8@@ -1697,14 +1697,6 @@ static void switched_to_dl(struct rq *rq, struct task_struct *p) {int check_resched =1 ; -/* -* If p is throttled, don't consider the possibility -* of preempting rq->curr, the check will be done right -* after its runtime will get replenished. -*/ -if (unlikely (p->dl.dl_throttled)) -return ; -if (task_on_rq_queued (p) && rq->curr != p) {#ifdef CONFIG_SMP if (p->nr_cpus_allowed > 1 && rq->dl.overloaded &&Signature · 1 line
1.9.1