Skip to contentSkip to conversation

Staging: rtl872au: merged consecutive string fragments.

PATCH In review Melike Yurtoglu 2 participants 2 messages Feb 26, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: rtl872au: merged consecutive string fragments.

WARNING: Consecutive strings are generally better as a single string That was found by running checkpatch.

---
 drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c +1 -1
index 9e1304f..dda9c6e 100644
@@ -1966,7 +1966,7 @@ static int cfg80211_rtw_connect(struct wiphy *wiphy, struct net_device *ndev,
 	struct security_priv *psecuritypriv = &padapter->securitypriv;
 	struct rtw_queue *queue = &pmlmepriv->scanned_queue;
 
-	DBG_8723A("=>" "%s(%s)\n", __func__, ndev->name);
+	DBG_8723A("=> %s(%s)\n", __func__, ndev->name);
 	DBG_8723A("privacy =%d, key =%p, key_len =%d, key_idx =%d\n",
 		  sme->privacy, sme->key, sme->key_len, sme->key_idx);
 
Signature · 1 line
1.8.3.2
#1 lore raw
Quoted 13 lines · Melike Yurtoglu

WARNING: Consecutive strings are generally better as a single string That was found by running checkpatch.

---
 drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c +0 -0
index 9e1304f..dda9c6e 100644

drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c static int cfg80211_rtw_connect(struct wiphy *wiphy, struct net_device *ndev, · line 1969

Quoted 5 lines
drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c +1 -1
@@ -1966,7 +1966,7 @@ static int cfg80211_rtw_connect(struct wiphy *wiphy, struct net_device *ndev,
 	struct security_priv *psecuritypriv = &padapter->securitypriv;
 	struct rtw_queue *queue = &pmlmepriv->scanned_queue;
 
-	DBG_8723A("=>" "%s(%s)\n", __func__, ndev->name);
+	DBG_8723A("=> %s(%s)\n", __func__, ndev->name);

The original code didn't have a space between => and the function name.

julia

Quoted 13 lines
drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c +0 -1
 	DBG_8723A("privacy =%d, key =%p, key_len =%d, key_idx =%d\n",
 		  sme->privacy, sme->key, sme->key_len, sme->key_idx);
 
--

1.8.3.2

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1424934979-14299-1-git-send-email-aysemelikeyurtoglu%40gmail.com.
For more options, visit https://groups.google.com/d/optout.