Skip to contentSkip to conversation

ARM: TLV320AIC23 SoC Audio Codec: Fix errors reported related to input routing signals.

PATCH In review Gabriel Dobato 3 participants 3 messages Feb 26, 2015 – Feb 27, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: TLV320AIC23 SoC Audio Codec: Fix errors reported related to input routing signals.

From: dobatog <[email protected]>

The following patch, based on stable v3.19, corrects the errors that are reported in the boot trace in reference to the Input Signals of the audio codec TLV320AIC23:

tlv320aic23-codec 1-001a: Control not supported for path LLINEIN -> [NULL] -> Line Input tlv320aic23-codec 1-001a: ASoC: no dapm match for LLINEIN --> NULL --> Line Input tlv320aic23-codec 1-001a: ASoC: Failed to add route LLINEIN -> NULL -> Line Input tlv320aic23-codec 1-001a: Control not supported for path RLINEIN -> [NULL] -> Line Input tlv320aic23-codec 1-001a: ASoC: no dapm match for RLINEIN --> NULL --> Line Input tlv320aic23-codec 1-001a: ASoC: Failed to add route RLINEIN -> NULL -> Line Input tlv320aic23-codec 1-001a: Control not supported for path MICIN -> [NULL] -> Mic Input tlv320aic23-codec 1-001a: ASoC: no dapm match for MICIN --> NULL --> Mic Input tlv320aic23-codec 1-001a: ASoC: Failed to add route MICIN -> NULL -> Mic Input

I am trying to set the sound system in a CM-510 (Compulab - SoM) based board with DT, using Simple-Card-Audio and the TLV320AIC23 audio codec included in the SoM . I faced this problem and thanks to the help of Sebastian Hesselbarth who noticed the possible error located in the structure snd_soc_dapm_route tlv320aic23_intercon[] , now errors are not reported.

Tested on CM-510 (Compulab SoM Board).

---
 sound/soc/codecs/tlv320aic23.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
sound/soc/codecs/tlv320aic23.c +3 -3
index cc17e7e..891f3aa 100644
@@ -174,10 +174,10 @@ static const struct snd_soc_dapm_route tlv320aic23_intercon[] = {
 	{"ROUT", NULL, "Output Mixer"},
 
 	/* Inputs */
-	{"Line Input", "NULL", "LLINEIN"},
-	{"Line Input", "NULL", "RLINEIN"},
+	{"Line Input", NULL, "LLINEIN"},
+	{"Line Input", NULL, "RLINEIN"},
 
-	{"Mic Input", "NULL", "MICIN"},
+	{"Mic Input", NULL, "MICIN"},
 
 	/* input mux */
 	{"Capture Source", "Line", "Line Input"},
Signature · 1 line
1.9.1
Tested-by on v1 1/1
#1 lore raw
Quoted 14 lines · Gabriel Dobato

From: dobatog <[email protected]>

The following patch, based on stable v3.19, corrects the errors that are reported in the boot trace in reference to the Input Signals of the audio codec TLV320AIC23:

tlv320aic23-codec 1-001a: Control not supported for path LLINEIN -> [NULL] -> Line Input tlv320aic23-codec 1-001a: ASoC: no dapm match for LLINEIN --> NULL --> Line Input tlv320aic23-codec 1-001a: ASoC: Failed to add route LLINEIN -> NULL -> Line Input tlv320aic23-codec 1-001a: Control not supported for path RLINEIN -> [NULL] -> Line Input tlv320aic23-codec 1-001a: ASoC: no dapm match for RLINEIN --> NULL --> Line Input tlv320aic23-codec 1-001a: ASoC: Failed to add route RLINEIN -> NULL -> Line Input tlv320aic23-codec 1-001a: Control not supported for path MICIN -> [NULL] -> Mic Input tlv320aic23-codec 1-001a: ASoC: no dapm match for MICIN --> NULL --> Mic Input tlv320aic23-codec 1-001a: ASoC: Failed to add route MICIN -> NULL -> Mic Input

Quoted 3 lines

I am trying to set the sound system in a CM-510 (Compulab - SoM) based board with DT, using Simple-Card-Audio and the TLV320AIC23 audio codec included in the SoM . I faced this problem and thanks to the help of Sebastian Hesselbarth who noticed the possible error located in the structure snd_soc_dapm_route tlv320aic23_intercon[] , now errors are not reported.

Tested on CM-510 (Compulab SoM Board).

Quoted 1 line

I believe you need to use your real name here and in the From: line.

Signature · 2 lines
Thanks.
-- Max
#2 lore raw
In reply to Gabriel Dobato
Quoted 14 lines · Gabriel Dobato

From: dobatog <[email protected]>

The following patch, based on stable v3.19, corrects the errors that are reported in the boot trace in reference to the Input Signals of the audio codec TLV320AIC23:

tlv320aic23-codec 1-001a: Control not supported for path LLINEIN -> [NULL] -> Line Input tlv320aic23-codec 1-001a: ASoC: no dapm match for LLINEIN --> NULL --> Line Input tlv320aic23-codec 1-001a: ASoC: Failed to add route LLINEIN -> NULL -> Line Input tlv320aic23-codec 1-001a: Control not supported for path RLINEIN -> [NULL] -> Line Input tlv320aic23-codec 1-001a: ASoC: no dapm match for RLINEIN --> NULL --> Line Input tlv320aic23-codec 1-001a: ASoC: Failed to add route RLINEIN -> NULL -> Line Input tlv320aic23-codec 1-001a: Control not supported for path MICIN -> [NULL] -> Mic Input tlv320aic23-codec 1-001a: ASoC: no dapm match for MICIN --> NULL --> Mic Input tlv320aic23-codec 1-001a: ASoC: Failed to add route MICIN -> NULL -> Mic Input

Quoted 5 lines

I am trying to set the sound system in a CM-510 (Compulab - SoM) based board with DT, using Simple-Card-Audio and the TLV320AIC23 audio codec included in the SoM . I faced this problem and thanks to the help of Sebastian Hesselbarth who noticed the possible error located in the structure snd_soc_dapm_route tlv320aic23_intercon[] , now errors are not reported.

Tested on CM-510 (Compulab SoM Board).

Hi,

The patch itself looks good, but the commit message needs some work.

The subject line should be something like "ASoC: tlv320aic23: ..." to indicate that this is for the ASoC subsystem and the tlv320aic23 driver.

The commit message should be line-wrapped at around 76 characters.

Signed-off-by and From tag need to have your full name.

- Lars