Staging: iio: Fix coding style issues
cover Staging: iio: Fix coding style issues
This patchset fixes the following coding style issues found by checkpatch.pl:
- Missing blank line after declaration.
- Space before tabs.
Haneen Mohammed (2):
Staging: iio: Add blank line after declaration
Staging: iio: Remove space before tabs
drivers/iio/accel/mma8452.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Signature · 1 line
1.9.1
PATCH 1/2 Staging: iio: Add blank line after declaration
This patch fixes missing blank line after declaration issue addressed by checkpatch.pl.
--- drivers/iio/accel/mma8452.c | 1 + 1 file changed, 1 insertion(+)
drivers/iio/accel/mma8452.c +1 -0
@@ -75,6 +75,7 @@ static int mma8452_drdy(struct mma8452_data *data)static int mma8452_read (struct mma8452_data *data,__be16 buf[3 ]) {int ret =mma8452_drdy (data); +if (ret <0 )return ret; return i2c_smbus_read_i2c_block_data(data->client,
Signature · 1 line
1.9.1
Re: [Outreachy kernel] [PATCH 1/2] Staging: iio: Add blank line after declaration
Quoted 13 lines · Haneen Mohammed
This patch fixes missing blank line after declaration issue addressed by checkpatch.pl.
Signed-off-by Haneen Mohammed <[email protected]>--- drivers/iio/accel/mma8452.c | 1 + 1 file changed, 1 insertion(+)drivers/iio/accel/mma8452.c +0
-0
drivers/iio/accel/mma8452.c static int mma8452_drdy(struct mma8452_data *data) · line 81
Quoted 7 lines
drivers/iio/accel/mma8452.c +1
-0@@ -75,6 +75,7 @@ static int mma8452_drdy(struct mma8452_data *data)static int mma8452_read (struct mma8452_data *data,__be16 buf[3 ]) {int ret =mma8452_drdy (data); +if (ret <0 )return ret; return i2c_smbus_read_i2c_block_data(data->client,
We received this kind of fixes in the past. But as you can see this is more than a declaration there.
We prefer that function call and error checking should be not separated by blank lines.
So, NACK for this patch. Thanks a lot for taking your time to do this.
Daniel.