mfd: kempld-core: Fix callback return value check
PATCH 1/1 mfd: kempld-core: Fix callback return value check
On success, callback function returns 0. So invert the if condition check so that we can break out of loop.
Signed-off-by Ameya Palande <[email protected]>
--- drivers/mfd/kempld-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mfd/kempld-core.c +1 -1
@@ -739,7 +739,7 @@ static int __init kempld_init(void)for (id = kempld_dmi_table; id->matches[0 ].slot !=DMI_NONE ; id++)if (strstr (id->ident, force_device_id)) -if (id->callback && id->callback (id)) +if (id->callback && !id->callback (id))break ;if (id->matches[0 ].slot ==DMI_NONE )return -ENODEV ;
Signature · 1 line
1.8.3.1
Lee Jones
AppliedQuoted 8 lines · Ameya Palande
On success, callback function returns 0. So invert the if condition check so that we can break out of loop.
Signed-off-by Ameya Palande <[email protected]>--- drivers/mfd/kempld-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Quoted 13 lines
drivers/mfd/kempld-core.c +1
-1@@ -739,7 +739,7 @@ static int __init kempld_init(void)for (id = kempld_dmi_table; id->matches[0 ].slot !=DMI_NONE ; id++)if (strstr (id->ident, force_device_id)) -if (id->callback && id->callback (id)) +if (id->callback && !id->callback (id))break ;if (id->matches[0 ].slot ==DMI_NONE )return -ENODEV ;
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog