Skip to contentSkip to conversation

powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

PATCH Superseded Aneesh Bansal 2 participants 14 messages Feb 25, 2015 – Mar 10, 2015 1 message not in the archive

Subsystems (2)

v4 of 8 Superseded Latest is v8 →

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/2 powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Secure Boot Target is added for NAND for P3041. Changes:
In PowerPC, the core begins execution from address 0xFFFFFFFC. In case of secure boot, this default address maps to Boot ROM. The Boot ROM code requires that the bootloader(U-boot) must lie in 0 to 3.5G address space i.e. 0x0 - 0xDFFFFFFF.

In case of NAND Secure Boot, CONFIG_SYS_RAMBOOT is enabled and CPC is configured as SRAM. U-Boot binary will be located on this SRAM at location 0xBFF40000 with entry point as 0xBFFFFFFC.

---
Changes in v4:
- Created a patch set.

 Makefile                                   |  4 ++++
 arch/powerpc/cpu/mpc85xx/cpu_init.c        | 17 +++++++++++++++++
 board/freescale/common/p_corenet/tlb.c     | 18 +++++++++++++++++-
 board/freescale/corenet_ds/MAINTAINERS     |  5 +++++
 configs/P3041DS_NAND_SECURE_BOOT_defconfig |  4 ++++
 include/configs/corenet_ds.h               |  9 +++++++++
 6 files changed, 56 insertions(+), 1 deletion(-)
 create mode 100644 configs/P3041DS_NAND_SECURE_BOOT_defconfig
Makefile +4 -0
index bd4abab..acfaa23 100644
@@ -719,8 +719,12 @@ ALL-$(CONFIG_ONENAND_U_BOOT) += u-boot-onenand.bin
 ifeq ($(CONFIG_SPL_FSL_PBL),y)
 ALL-$(CONFIG_RAMBOOT_PBL) += u-boot-with-spl-pbl.bin
 else
+ifneq ($(CONFIG_SECURE_BOOT), y)
+# For Secure Boot The Image needs to be signed and Header must also
+# be included. So The image has to be built explicitly
 ALL-$(CONFIG_RAMBOOT_PBL) += u-boot.pbl
 endif
+endif
 ALL-$(CONFIG_SPL) += spl/u-boot-spl.bin
 ALL-$(CONFIG_SPL_FRAMEWORK) += u-boot.img
 ALL-$(CONFIG_TPL) += tpl/u-boot-tpl.bin
arch/powerpc/cpu/mpc85xx/cpu_init.c +17 -0
index 4cf8853..ef56cc0 100644
@@ -843,6 +843,23 @@ int cpu_init_r(void)
 	setup_mp();
 #endif
 
+#if defined(CONFIG_SYS_RAMBOOT) && defined(CONFIG_SYS_INIT_L3_ADDR) && \
+	defined(CONFIG_SECURE_BOOT)
+	/* Disable the TLB Created for L3 and create the TLB required for
+	 * PCIE (CONFIG_SYS_PCIE1_MEM_VIRT) which was not created earlier.
+	 */
+	int tlb_index;
+	tlb_index = find_tlb_idx((void *)CONFIG_BPTR_VIRT_ADDR, 1);
+	if (tlb_index != -1) {
+		disable_tlb(tlb_index);
+
+		set_tlb(1, CONFIG_SYS_PCIE1_MEM_VIRT,
+			CONFIG_SYS_PCIE1_MEM_PHYS,
+			MAS3_SW|MAS3_SR, MAS2_I|MAS2_G,
+			0, tlb_index, BOOKE_PAGESZ_1G, 1);
+	}
+#endif
+
 #ifdef CONFIG_SYS_FSL_ERRATUM_ESDHC13
 	{
 		if (SVR_MAJ(svr) < 3) {
board/freescale/common/p_corenet/tlb.c +17 -1
index 8148e46..1b60cfb 100644
@@ -42,7 +42,9 @@ struct fsl_e_tlb_entry tlb_table[] = {
 
 	/* TLB 1 */
 	/* *I*** - Covers boot page */
-#if defined(CONFIG_SYS_RAMBOOT) && defined(CONFIG_SYS_INIT_L3_ADDR)
+	/* In Case of Secure RAM Boot L3 address is defined at 0xbff00000 */
+#if defined(CONFIG_SYS_RAMBOOT) && defined(CONFIG_SYS_INIT_L3_ADDR) && \
+	!defined(CONFIG_SECURE_BOOT)
 	/*
 	 * *I*G - L3SRAM. When L3 is used as 1M SRAM, the address of the
 	 * SRAM is at 0xfff00000, it covered the 0xfffff000.
@@ -76,11 +78,25 @@ struct fsl_e_tlb_entry tlb_table[] = {
 		      MAS3_SX|MAS3_SR, MAS2_W|MAS2_G,
 		      0, 2, BOOKE_PAGESZ_256M, 1),
 
+#if defined(CONFIG_SYS_RAMBOOT) && defined(CONFIG_SYS_INIT_L3_ADDR) && \
+	defined(CONFIG_SECURE_BOOT)
+	/* In case of Secure Boot, L3 is used as 1M SRAM
+	 * and the address of the SRAM is at 0xbff00000.
+	 * The PCIE TLB entry conflicts with the above entry.
+	 * So, the entry for PCIE is not created at this point of time.
+	 * It will be created later on in cpu_init_r()
+	 * when U-Boot has relocated to DDR
+	 */
+	SET_TLB_ENTRY(1, CONFIG_SYS_INIT_L3_ADDR, CONFIG_SYS_INIT_L3_ADDR,
+		      MAS3_SX|MAS3_SW|MAS3_SR, MAS2_I|MAS2_G,
+		      0, 3, BOOKE_PAGESZ_1M, 1),
+#else
 	/* *I*G* - PCI */
 	SET_TLB_ENTRY(1, CONFIG_SYS_PCIE1_MEM_VIRT, CONFIG_SYS_PCIE1_MEM_PHYS,
 		      MAS3_SW|MAS3_SR, MAS2_I|MAS2_G,
 		      0, 3, BOOKE_PAGESZ_1G, 1),
 
+#endif
 	/* *I*G* - PCI */
 	SET_TLB_ENTRY(1, CONFIG_SYS_PCIE1_MEM_VIRT + 0x40000000,
 		      CONFIG_SYS_PCIE1_MEM_PHYS + 0x40000000,
board/freescale/corenet_ds/MAINTAINERS +5 -0
index 745847c..6855446 100644
@@ -28,3 +28,8 @@ F:	configs/P5040DS_NAND_defconfig
 F:	configs/P5040DS_SDCARD_defconfig
 F:	configs/P5040DS_SPIFLASH_defconfig
 F:	configs/P5040DS_SECURE_BOOT_defconfig
+
+CORENET_DS_SECURE_BOOT BOARD
+M:	Aneesh Bansal <[email protected]>
+S:	Maintained
+F:	configs/P3041DS_NAND_SECURE_BOOT_defconfig
configs/P3041DS_NAND_SECURE_BOOT_defconfig new file +4 -0
new file mode 100644
index 0000000..e810b1c
@@ -0,0 +1,4 @@
+CONFIG_SYS_EXTRA_OPTIONS="RAMBOOT_PBL,NAND,SECURE_BOOT,SYS_TEXT_BASE=0xBFF40000"
+CONFIG_PPC=y
+CONFIG_MPC85xx=y
+CONFIG_TARGET_P3041DS=y
include/configs/corenet_ds.h +9 -0
index 225ffdd..64c6890 100644
@@ -16,6 +16,14 @@
 #include "../board/freescale/common/ics307_clk.h"
 
 #ifdef CONFIG_RAMBOOT_PBL
+#ifdef CONFIG_SECURE_BOOT
+#define CONFIG_RAMBOOT_TEXT_BASE	CONFIG_SYS_TEXT_BASE
+#define CONFIG_RESET_VECTOR_ADDRESS	0xbffffffc
+#define CONFIG_BPTR_VIRT_ADDR		0xbffff000
+#ifdef CONFIG_NAND
+#define CONFIG_RAMBOOT_NAND
+#endif
+#else
 #define CONFIG_RAMBOOT_TEXT_BASE	CONFIG_SYS_TEXT_BASE
 #define CONFIG_RESET_VECTOR_ADDRESS	0xfffffffc
 #define CONFIG_SYS_FSL_PBL_PBI board/freescale/corenet_ds/pbi.cfg
@@ -29,6 +37,7 @@
 #define CONFIG_SYS_FSL_PBL_RCW board/freescale/corenet_ds/rcw_p5040ds.cfg
 #endif
 #endif
+#endif
 
 #ifdef CONFIG_SRIO_PCIE_BOOT_SLAVE
 /* Set 1M boot space */
Signature · 1 line
1.8.1.4
#1 lore raw

PATCH v4 1/2 powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

[Reposting comment on v4 as York requested]

Quoted 14 lines · Aneesh Bansal
arch/powerpc/cpu/mpc85xx/cpu_init.c +6 -0
index 4cf8853..ef56cc0 100644
@@ -843,6 +843,23 @@ int cpu_init_r(void)
 	setup_mp();
 #endif
 
+#if defined(CONFIG_SYS_RAMBOOT) && defined(CONFIG_SYS_INIT_L3_ADDR) && \
+	defined(CONFIG_SECURE_BOOT)
+	/* Disable the TLB Created for L3 and create the TLB required for
+	 * PCIE (CONFIG_SYS_PCIE1_MEM_VIRT) which was not created earlier.
+	 */
+	int tlb_index;

arch/powerpc/cpu/mpc85xx/cpu_init.c int cpu_init_r(void) · line 861

Quoted 10 lines
arch/powerpc/cpu/mpc85xx/cpu_init.c +10 -0
+	tlb_index = find_tlb_idx((void *)CONFIG_BPTR_VIRT_ADDR, 1);
+	if (tlb_index != -1) {
+		disable_tlb(tlb_index);
+
+		set_tlb(1, CONFIG_SYS_PCIE1_MEM_VIRT,
+			CONFIG_SYS_PCIE1_MEM_PHYS,
+			MAS3_SW|MAS3_SR, MAS2_I|MAS2_G,
+			0, tlb_index, BOOKE_PAGESZ_1G, 1);
+	}
+#endif

Why are you assuming in generic 85xx code that the TLB for PCIE1 needs to be created? e500mc should have enough TLB1 entries that you don't need to share (or if it's due to address conflicts, a board may have PCI at a different address), and PCI may not exist at all on some boards.

-Scott

#2 lore raw

PATCH v4 1/2 powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 44 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Thursday, February 26, 2015 3:43 AM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495; Gupta Ruchika-R66431
Subject: Re: [U-Boot, 1/2, v4] powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

[Reposting comment on v4 as York requested]

arch/powerpc/cpu/mpc85xx/cpu_init.c int cpu_init_r(void) · line 846

Quoted 10 lines · Aneesh Bansal
arch/powerpc/cpu/mpc85xx/cpu_init.c +1 -0
index 4cf8853..ef56cc0 100644
@@ -843,6 +843,23 @@ int cpu_init_r(void)
 	setup_mp();
 #endif
 
+#if defined(CONFIG_SYS_RAMBOOT) &&

defined(CONFIG_SYS_INIT_L3_ADDR) && \

arch/powerpc/cpu/mpc85xx/cpu_init.c int cpu_init_r(void)

Quoted 3 lines
arch/powerpc/cpu/mpc85xx/cpu_init.c +3 -0
+	defined(CONFIG_SECURE_BOOT)
+	/* Disable the TLB Created for L3 and create the TLB required for
+	 * PCIE (CONFIG_SYS_PCIE1_MEM_VIRT) which was not created

earlier.

arch/powerpc/cpu/mpc85xx/cpu_init.c int cpu_init_r(void) · line 861

Quoted 12 lines
arch/powerpc/cpu/mpc85xx/cpu_init.c +12 -0
+	 */
+	int tlb_index;
+	tlb_index = find_tlb_idx((void *)CONFIG_BPTR_VIRT_ADDR, 1);
+	if (tlb_index != -1) {
+		disable_tlb(tlb_index);
+
+		set_tlb(1, CONFIG_SYS_PCIE1_MEM_VIRT,
+			CONFIG_SYS_PCIE1_MEM_PHYS,
+			MAS3_SW|MAS3_SR, MAS2_I|MAS2_G,
+			0, tlb_index, BOOKE_PAGESZ_1G, 1);
+	}
+#endif

Why are you assuming in generic 85xx code that the TLB for PCIE1 needs to be created? e500mc should have enough TLB1 entries that you don't need to share (or if it's due to address conflicts, a board may have PCI at a different address), and PCI may not exist at all on some boards.

Quoted 1 line

-Scott

TLB's are created in freescale/common/p_corenet/tlb.c
In case of Secure Boot, L3 is used as 1M SRAM and the address of the SRAM is at 0xbff00000. The PCIE TLB entry conflicts with the above entry and so the entry for PCIE was not created at that point of time.
This is why it is being created here in cpu_init_r() when U-Boot has relocated to DDR and the TLB entry for SRAM is not required.
Proper comments have been added in tlb.c to explain why it is being done.
If address for PCI is changed than this also will have to be taken care of. The code is protected by relevant macros (CONFIG_SYS_RAMBOOT, CONFIG_SYS_INIT_L3_ADDR, CONFIG_SECURE_BOOT)

#3 lore raw

PATCH v4 1/2 powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 44 lines · On Thu, 2015-02-26 at 22:35 -0600, Bansal Aneesh-B39320 wrote:
Quoted 44 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Thursday, February 26, 2015 3:43 AM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495; Gupta Ruchika-R66431
Subject: Re: [U-Boot, 1/2, v4] powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

[Reposting comment on v4 as York requested]

arch/powerpc/cpu/mpc85xx/cpu_init.c int cpu_init_r(void) · line 846

Quoted 10 lines · Aneesh Bansal
arch/powerpc/cpu/mpc85xx/cpu_init.c +1 -0
index 4cf8853..ef56cc0 100644
@@ -843,6 +843,23 @@ int cpu_init_r(void)
 	setup_mp();
 #endif
 
+#if defined(CONFIG_SYS_RAMBOOT) &&

defined(CONFIG_SYS_INIT_L3_ADDR) && \

arch/powerpc/cpu/mpc85xx/cpu_init.c int cpu_init_r(void)

Quoted 3 lines
arch/powerpc/cpu/mpc85xx/cpu_init.c +3 -0
+	defined(CONFIG_SECURE_BOOT)
+	/* Disable the TLB Created for L3 and create the TLB required for
+	 * PCIE (CONFIG_SYS_PCIE1_MEM_VIRT) which was not created

earlier.

arch/powerpc/cpu/mpc85xx/cpu_init.c int cpu_init_r(void) · line 861

Quoted 12 lines
arch/powerpc/cpu/mpc85xx/cpu_init.c +12 -0
+	 */
+	int tlb_index;
+	tlb_index = find_tlb_idx((void *)CONFIG_BPTR_VIRT_ADDR, 1);
+	if (tlb_index != -1) {
+		disable_tlb(tlb_index);
+
+		set_tlb(1, CONFIG_SYS_PCIE1_MEM_VIRT,
+			CONFIG_SYS_PCIE1_MEM_PHYS,
+			MAS3_SW|MAS3_SR, MAS2_I|MAS2_G,
+			0, tlb_index, BOOKE_PAGESZ_1G, 1);
+	}
+#endif

Why are you assuming in generic 85xx code that the TLB for PCIE1 needs to be created? e500mc should have enough TLB1 entries that you don't need to share (or if it's due to address conflicts, a board may have PCI at a different address), and PCI may not exist at all on some boards.

Quoted 3 lines
Quoted 1 line

-Scott

TLB's are created in freescale/common/p_corenet/tlb.c

Which doesn't apply to all 85xx boards (even custom corenet-based boards might not use it -- or if that's not the case, it should be moved out of the board directory). It's also not obvious to anyone modifying that tlb.c file or the address of PCIE1 that this would be affected.

Quoted 1 line

In case of Secure Boot, L3 is used as 1M SRAM and the address of the SRAM is at 0xbff00000.

Is this hardcoded into the silicon, or determined by PBI or something similar? If it's not hardcoded, can we choose a less problematic address?

If it is hardcoded, and we don't want to change the PCIE1 virtual address, at least create defines for the entry to be created once SRAM goes away, rather than hardcoding PCIE1 here.

-Scott

#4 lore raw

PATCH v4 1/2 powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 64 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Friday, February 27, 2015 10:22 AM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495; Gupta Ruchika-R66431
Subject: Re: [U-Boot, 1/2, v4] powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 36 lines · On Thu, 2015-02-26 at 22:35 -0600, Bansal Aneesh-B39320 wrote:
Quoted 36 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Thursday, February 26, 2015 3:43 AM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495; Gupta Ruchika-R66431
Subject: Re: [U-Boot, 1/2, v4] powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

[Reposting comment on v4 as York requested]

arch/powerpc/cpu/mpc85xx/cpu_init.c int cpu_init_r(void) · line 846

Quoted 10 lines · Aneesh Bansal
arch/powerpc/cpu/mpc85xx/cpu_init.c +1 -0
index 4cf8853..ef56cc0 100644
@@ -843,6 +843,23 @@ int cpu_init_r(void)
 	setup_mp();
 #endif
 
+#if defined(CONFIG_SYS_RAMBOOT) &&

defined(CONFIG_SYS_INIT_L3_ADDR) && \

arch/powerpc/cpu/mpc85xx/cpu_init.c int cpu_init_r(void)

Quoted 3 lines
arch/powerpc/cpu/mpc85xx/cpu_init.c +3 -0
+	defined(CONFIG_SECURE_BOOT)
+	/* Disable the TLB Created for L3 and create the TLB required for
+	 * PCIE (CONFIG_SYS_PCIE1_MEM_VIRT) which was not created

earlier.

Quoted 10 lines
arch/powerpc/cpu/mpc85xx/cpu_init.c +10 -0
+	 */
+	int tlb_index;
+	tlb_index = find_tlb_idx((void *)CONFIG_BPTR_VIRT_ADDR, 1);
+	if (tlb_index != -1) {
+		disable_tlb(tlb_index);
+
+		set_tlb(1, CONFIG_SYS_PCIE1_MEM_VIRT,
+			CONFIG_SYS_PCIE1_MEM_PHYS,
+			MAS3_SW|MAS3_SR, MAS2_I|MAS2_G,
+			0, tlb_index, BOOKE_PAGESZ_1G, 1);
Quoted 8 lines
Quoted 8 lines

arch/powerpc/cpu/mpc85xx/cpu_init.c int cpu_init_r(void) · line 861

Quoted 2 lines
arch/powerpc/cpu/mpc85xx/cpu_init.c +2 -0
+	}
+#endif

Why are you assuming in generic 85xx code that the TLB for PCIE1 needs to be created? e500mc should have enough TLB1 entries that you don't need to share (or if it's due to address conflicts, a board may have PCI at a different address), and PCI may not exist at all on

some boards.

Quoted 4 lines
Quoted 2 lines

-Scott

TLB's are created in freescale/common/p_corenet/tlb.c

Which doesn't apply to all 85xx boards (even custom corenet-based boards might not use it -- or if that's not the case, it should be moved out of the board directory). It's also not obvious to anyone modifying that tlb.c file or the address of PCIE1 that this would be affected.

Quoted 5 lines
Quoted 1 line

In case of Secure Boot, L3 is used as 1M SRAM and the address of the

SRAM is at 0xbff00000.

Is this hardcoded into the silicon, or determined by PBI or something similar? If it's not hardcoded, can we choose a less problematic address?

It is not hardcoded but we have a restriction of choosing the address within 0 - 3.5G. 0xbff00000 seemed to be the least problematic at this point of time.

Quoted 4 lines

If it is hardcoded, and we don't want to change the PCIE1 virtual address, at least create defines for the entry to be created once SRAM goes away, rather than hardcoding PCIE1 here.

Are you suggesting something like this in cpu_init_r() set_tlb(1, CONFIG_SECBOOT_TLB_VIRT_ADDR,

	CONFIG_SECBOOT_TLB_PHYS_ADDR,
	CONFIG_SECBOOT_TLB_PERM, CONFIG_SECBOOT_TLB_ATTR,
	0, tlb_index, CONFIG_SECBOOT_TLB_PAGESZ, 1);

I plan to define these macros in tlb.c where we have added the code for these TLBS creation

#define CONFIG_SECBOOT_TLB_VIRT_ADDR CONFIG_SYS_PCIE1_MEM_VIRT
#define CONFIG_SECBOOT_TLB_PHYS_ADDR CONFIG_SYS_PCIE1_MEM_PHYS
#define CONFIG_SECBOOT_TLB_PERM MAS3_SW|MAS3_SR
#define CONFIG_SECBOOT_TLB_ATTR MAS2_I|MAS2_G
#define CONFIG_SECBOOT_TLB_PAGESZ BOOKE_PAGESZ_1G

Quoted 2 lines

-Scott

A message that is not in the archive (sent off-list or not yet received): DM2PR0301MB1312F158483C1E890256AF58F0150@DM2PR0301MB1312.namprd03.prod.outlook.com

#6 lore raw

PATCH v4 1/2 powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 67 lines · On Thu, 2015-02-26 at 23:46 -0600, Bansal Aneesh-B39320 wrote:

Regards,
Aneesh Bansal

Quoted 62 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Friday, February 27, 2015 10:22 AM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495; Gupta Ruchika-R66431
Subject: Re: [U-Boot, 1/2, v4] powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 35 lines · On Thu, 2015-02-26 at 22:35 -0600, Bansal Aneesh-B39320 wrote:
Quoted 35 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Thursday, February 26, 2015 3:43 AM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495; Gupta Ruchika-R66431
Subject: Re: [U-Boot, 1/2, v4] powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

[Reposting comment on v4 as York requested]

arch/powerpc/cpu/mpc85xx/cpu_init.c int cpu_init_r(void) · line 846

Quoted 10 lines · Aneesh Bansal
arch/powerpc/cpu/mpc85xx/cpu_init.c +1 -0
index 4cf8853..ef56cc0 100644
@@ -843,6 +843,23 @@ int cpu_init_r(void)
 	setup_mp();
 #endif
 
+#if defined(CONFIG_SYS_RAMBOOT) &&

defined(CONFIG_SYS_INIT_L3_ADDR) && \

arch/powerpc/cpu/mpc85xx/cpu_init.c int cpu_init_r(void)

Quoted 3 lines
arch/powerpc/cpu/mpc85xx/cpu_init.c +3 -0
+	defined(CONFIG_SECURE_BOOT)
+	/* Disable the TLB Created for L3 and create the TLB required for
+	 * PCIE (CONFIG_SYS_PCIE1_MEM_VIRT) which was not created

earlier.

Quoted 9 lines
arch/powerpc/cpu/mpc85xx/cpu_init.c +9 -0
+	 */
+	int tlb_index;
+	tlb_index = find_tlb_idx((void *)CONFIG_BPTR_VIRT_ADDR, 1);
+	if (tlb_index != -1) {
+		disable_tlb(tlb_index);
+
+		set_tlb(1, CONFIG_SYS_PCIE1_MEM_VIRT,
+			CONFIG_SYS_PCIE1_MEM_PHYS,
+			MAS3_SW|MAS3_SR, MAS2_I|MAS2_G,
Quoted 8 lines
Quoted 8 lines

arch/powerpc/cpu/mpc85xx/cpu_init.c int cpu_init_r(void) · line 861

Quoted 3 lines
arch/powerpc/cpu/mpc85xx/cpu_init.c +3 -0
+			0, tlb_index, BOOKE_PAGESZ_1G, 1);
+	}
+#endif

Why are you assuming in generic 85xx code that the TLB for PCIE1 needs to be created? e500mc should have enough TLB1 entries that you don't need to share (or if it's due to address conflicts, a board may have PCI at a different address), and PCI may not exist at all on

some boards.

Quoted 4 lines
Quoted 2 lines

-Scott

TLB's are created in freescale/common/p_corenet/tlb.c

Which doesn't apply to all 85xx boards (even custom corenet-based boards might not use it -- or if that's not the case, it should be moved out of the board directory). It's also not obvious to anyone modifying that tlb.c file or the address of PCIE1 that this would be affected.

Note that on b4860qds, it's SRIO2_MEM_VIRT that conflicts with 0xbff00000, not PCIE1_MEM_VIRT.

Quoted 9 lines
Quoted 7 lines
Quoted 2 lines

In case of Secure Boot, L3 is used as 1M SRAM and the address of the

SRAM is at 0xbff00000.

Is this hardcoded into the silicon, or determined by PBI or something similar? If it's not hardcoded, can we choose a less problematic address?

It is not hardcoded but we have a restriction of choosing the address within 0 - 3.5G. 0xbff00000 seemed to be the least problematic at this point of time.

Where does the 3.5G limitation come from? Even if the physical address needs to be elsewhere due to bootrom constraints, we should be able to map it wherever we want in the TLB once U-Boot takes control.

Quoted 1 line
Quoted 1 line

If it is hardcoded, and we don't want to change the PCIE1 virtual address,

Actually it's PCIE2 that conflicts -- U-Boot just happens to use one big TLB entry to cover multiple PCIEs.

Quoted 9 lines
Quoted 4 lines

at
least create defines for the entry to be created once SRAM goes away, rather than hardcoding PCIE1 here.

Are you suggesting something like this in cpu_init_r() set_tlb(1, CONFIG_SECBOOT_TLB_VIRT_ADDR,

	CONFIG_SECBOOT_TLB_PHYS_ADDR,
	CONFIG_SECBOOT_TLB_PERM, CONFIG_SECBOOT_TLB_ATTR,
	0, tlb_index, CONFIG_SECBOOT_TLB_PAGESZ, 1);

If you can't remove the 3.5G limitation, yes.

Quoted 7 lines

I plan to define these macros in tlb.c where we have added the code for these TLBS creation

#define CONFIG_SECBOOT_TLB_VIRT_ADDR CONFIG_SYS_PCIE1_MEM_VIRT
#define CONFIG_SECBOOT_TLB_PHYS_ADDR CONFIG_SYS_PCIE1_MEM_PHYS
#define CONFIG_SECBOOT_TLB_PERM MAS3_SW|MAS3_SR
#define CONFIG_SECBOOT_TLB_ATTR MAS2_I|MAS2_G
#define CONFIG_SECBOOT_TLB_PAGESZ BOOKE_PAGESZ_1G

No, they are board-specific and need to be defined in the same place that the rest of the address map is defined (which I see you did in the v5 patch).

-Scott

#7 lore raw

PATCH v4 1/2 powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 76 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Thursday, March 05, 2015 2:41 AM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495; Gupta Ruchika-R66431
Subject: Re: [U-Boot, 1/2, v4] powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 34 lines · On Thu, 2015-02-26 at 23:46 -0600, Bansal Aneesh-B39320 wrote:

Regards,
Aneesh Bansal

Quoted 29 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Friday, February 27, 2015 10:22 AM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495; Gupta Ruchika-R66431
Subject: Re: [U-Boot, 1/2, v4] powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 20 lines · On Thu, 2015-02-26 at 22:35 -0600, Bansal Aneesh-B39320 wrote:
Quoted 20 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Thursday, February 26, 2015 3:43 AM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495; Gupta Ruchika-R66431
Subject: Re: [U-Boot, 1/2, v4] powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

[Reposting comment on v4 as York requested]

Quoted 9 lines · Aneesh Bansal
arch/powerpc/cpu/mpc85xx/cpu_init.c +0 -0
index 4cf8853..ef56cc0 100644
@@ -843,6 +843,23 @@ int cpu_init_r(void)
 	setup_mp();
 #endif
 
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

arch/powerpc/cpu/mpc85xx/cpu_init.c int cpu_init_r(void) · line 846

Quoted 1 line
arch/powerpc/cpu/mpc85xx/cpu_init.c +1 -0
+#if defined(CONFIG_SYS_RAMBOOT) &&

defined(CONFIG_SYS_INIT_L3_ADDR) && \

arch/powerpc/cpu/mpc85xx/cpu_init.c int cpu_init_r(void) · line 848

Quoted 2 lines
arch/powerpc/cpu/mpc85xx/cpu_init.c +2 -0
+	defined(CONFIG_SECURE_BOOT)
+	/* Disable the TLB Created for L3 and create the TLB required

for

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

arch/powerpc/cpu/mpc85xx/cpu_init.c int cpu_init_r(void) · line 849

Quoted 1 line
arch/powerpc/cpu/mpc85xx/cpu_init.c +1 -0
+	 * PCIE (CONFIG_SYS_PCIE1_MEM_VIRT) which was not

created

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

earlier.

arch/powerpc/cpu/mpc85xx/cpu_init.c int cpu_init_r(void)

Quoted 3 lines
arch/powerpc/cpu/mpc85xx/cpu_init.c +3 -0
+	 */
+	int tlb_index;
+	tlb_index = find_tlb_idx((void *)CONFIG_BPTR_VIRT_ADDR,

1);

Quoted 21 lines
Quoted 21 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
arch/powerpc/cpu/mpc85xx/cpu_init.c +7 -0
+	if (tlb_index != -1) {
+		disable_tlb(tlb_index);
+
+		set_tlb(1, CONFIG_SYS_PCIE1_MEM_VIRT,
+			CONFIG_SYS_PCIE1_MEM_PHYS,
+			MAS3_SW|MAS3_SR, MAS2_I|MAS2_G,
+			0, tlb_index, BOOKE_PAGESZ_1G, 1);
Quoted 8 lines
Quoted 8 lines

arch/powerpc/cpu/mpc85xx/cpu_init.c int cpu_init_r(void) · line 861

Quoted 2 lines
arch/powerpc/cpu/mpc85xx/cpu_init.c +2 -0
+	}
+#endif

Why are you assuming in generic 85xx code that the TLB for PCIE1 needs to be created? e500mc should have enough TLB1 entries that you don't need to share (or if it's due to address conflicts, a board may have PCI at a different address), and PCI may not exist at all on

some boards.

Quoted 4 lines
Quoted 2 lines

-Scott

TLB's are created in freescale/common/p_corenet/tlb.c

Quoted 9 lines
Quoted 4 lines
Quoted 4 lines

Which doesn't apply to all 85xx boards (even custom corenet-based boards might not use it -- or if that's not the case, it should be moved out of the board directory). It's also not obvious to anyone modifying that tlb.c file or the address of PCIE1 that this would be

affected.

Note that on b4860qds, it's SRIO2_MEM_VIRT that conflicts with 0xbff00000, not PCIE1_MEM_VIRT.

This is taken care now in v5, where we have defined the addresses in corenet_ds.h. So this will not impact other platforms like B4860.

Quoted 9 lines
Quoted 6 lines
Quoted 6 lines
Quoted 3 lines

In case of Secure Boot, L3 is used as 1M SRAM and the address of the

SRAM is at 0xbff00000.

Is this hardcoded into the silicon, or determined by PBI or something

similar?

Quoted 2 lines
Quoted 2 lines

If it's not hardcoded, can we choose a less problematic address?

Quoted 8 lines
Quoted 1 line

It is not hardcoded but we have a restriction of choosing the address within

0 - 3.5G.

Quoted 1 line

0xbff00000 seemed to be the least problematic at this point of time.

Where does the 3.5G limitation come from? Even if the physical address needs to be elsewhere due to bootrom constraints, we should be able to map it wherever we want in the TLB once U-Boot takes control.

The 3.5G limitation comes from BootROM in case of secure Boot. Initially U-Boot has to run from CPC configured as SRAM with address Within 3.5G. Once U-boot has relocated to DDR, we have removed the Corresponding TLB entry.

Quoted 35 lines
Quoted 2 lines
Quoted 2 lines

If it is hardcoded, and we don't want to change the PCIE1 virtual address,

Actually it's PCIE2 that conflicts -- U-Boot just happens to use one big TLB entry to cover multiple PCIEs.

Quoted 9 lines
Quoted 4 lines

at
least create defines for the entry to be created once SRAM goes away, rather than hardcoding PCIE1 here.

Are you suggesting something like this in cpu_init_r() set_tlb(1, CONFIG_SECBOOT_TLB_VIRT_ADDR,

	CONFIG_SECBOOT_TLB_PHYS_ADDR,
	CONFIG_SECBOOT_TLB_PERM, CONFIG_SECBOOT_TLB_ATTR,
	0, tlb_index, CONFIG_SECBOOT_TLB_PAGESZ, 1);

If you can't remove the 3.5G limitation, yes.

Quoted 4 lines

I plan to define these macros in tlb.c where we have added the code for these TLBS creation

#define CONFIG_SECBOOT_TLB_VIRT_ADDR

CONFIG_SYS_PCIE1_MEM_VIRT

Quoted 1 line

#define CONFIG_SECBOOT_TLB_PHYS_ADDR

CONFIG_SYS_PCIE1_MEM_PHYS

Quoted 3 lines

#define CONFIG_SECBOOT_TLB_PERM MAS3_SW|MAS3_SR
#define CONFIG_SECBOOT_TLB_ATTR MAS2_I|MAS2_G
#define CONFIG_SECBOOT_TLB_PAGESZ BOOKE_PAGESZ_1G

No, they are board-specific and need to be defined in the same place that the rest of the address map is defined (which I see you did in the v5 patch).

-Scott

#8 lore raw

PATCH v4 1/2 powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 8 lines · On Thu, 2015-03-05 at 01:26 -0600, Bansal Aneesh-B39320 wrote:
Quoted 8 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Thursday, March 05, 2015 2:41 AM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495; Gupta Ruchika-R66431
Subject: Re: [U-Boot, 1/2, v4] powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 8 lines
Quoted 4 lines

Where does the 3.5G limitation come from? Even if the physical address needs to be elsewhere due to bootrom constraints, we should be able to map it wherever we want in the TLB once U-Boot takes control.

The 3.5G limitation comes from BootROM in case of secure Boot. Initially U-Boot has to run from CPC configured as SRAM with address Within 3.5G. Once U-boot has relocated to DDR, we have removed the Corresponding TLB entry.

Again, you could relocate the virtual address of L3 much earlier.

-Scott

#9 lore raw

PATCH v4 1/2 powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 22 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Thursday, March 05, 2015 10:38 PM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495; Gupta Ruchika-R66431
Subject: Re: [U-Boot, 1/2, v4] powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 11 lines · On Thu, 2015-03-05 at 01:26 -0600, Bansal Aneesh-B39320 wrote:
Quoted 11 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Thursday, March 05, 2015 2:41 AM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495; Gupta Ruchika-R66431
Subject: Re: [U-Boot, 1/2, v4] powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Where does the 3.5G limitation come from? Even if the physical address needs to be elsewhere due to bootrom constraints, we should be able to map it wherever we want in the TLB once U-Boot takes

control.

Quoted 1 line
Quoted 1 line
Quoted 9 lines
Quoted 4 lines

The 3.5G limitation comes from BootROM in case of secure Boot. Initially U-Boot has to run from CPC configured as SRAM with address Within 3.5G. Once U-boot has relocated to DDR, we have removed the Corresponding TLB entry.

Again, you could relocate the virtual address of L3 much earlier.

-Scott

Are you suggesting the following:

1.  PBI Commands to configure CPC as SRAM with address 0xBFF0_0000.
2.  Compile U-boot with TEXT BASE as 0xFFF40000.
3.  Copy the U-boot from NAND via PBI commands to CPC (SRAM) on address 0xBFF4_0000
4.  The BootROM will validate the U-boot and transfer the control to 0xBFFF_FFFC.
5.  When U-boot is executing, then in the last 4K code, when shifting from AS=0 to AS=1, 
      we change the address of SRAM from 0xBFF0_0000 to 0xFFF0_0000. (Similar to what is done for NOR Boot)

- Aneesh

#10 lore raw

PATCH v4 1/2 powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 31 lines · On Tue, 2015-03-10 at 03:50 -0500, Bansal Aneesh-B39320 wrote:
Quoted 22 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Thursday, March 05, 2015 10:38 PM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495; Gupta Ruchika-R66431
Subject: Re: [U-Boot, 1/2, v4] powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 11 lines · On Thu, 2015-03-05 at 01:26 -0600, Bansal Aneesh-B39320 wrote:
Quoted 11 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Thursday, March 05, 2015 2:41 AM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495; Gupta Ruchika-R66431
Subject: Re: [U-Boot, 1/2, v4] powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Where does the 3.5G limitation come from? Even if the physical address needs to be elsewhere due to bootrom constraints, we should be able to map it wherever we want in the TLB once U-Boot takes

control.

Quoted 1 line
Quoted 1 line
Quoted 9 lines
Quoted 4 lines

The 3.5G limitation comes from BootROM in case of secure Boot. Initially U-Boot has to run from CPC configured as SRAM with address Within 3.5G. Once U-boot has relocated to DDR, we have removed the Corresponding TLB entry.

Again, you could relocate the virtual address of L3 much earlier.

-Scott

Quoted 7 lines

Are you suggesting the following:

1.  PBI Commands to configure CPC as SRAM with address 0xBFF0_0000.
2.  Compile U-boot with TEXT BASE as 0xFFF40000.
3.  Copy the U-boot from NAND via PBI commands to CPC (SRAM) on address 0xBFF4_0000
4.  The BootROM will validate the U-boot and transfer the control to 0xBFFF_FFFC.
5.  When U-boot is executing, then in the last 4K code, when shifting from AS=0 to AS=1, 
      we change the address of SRAM from 0xBFF0_0000 to 0xFFF0_0000. (Similar to what is done for NOR Boot)

Something like that, except in step 5 it would only be changing the virtual address, not the physical address (unless you can do a similar trick as NOR does, to have the L3 cache repeat and cover both addresses at once).

-Scott

#11 lore raw

PATCH v4 1/2 powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 52 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Tuesday, March 10, 2015 10:34 PM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495; Gupta Ruchika-R66431; Kushwaha Prabhakar-B32579
Subject: Re: [U-Boot, 1/2, v4] powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 30 lines · On Tue, 2015-03-10 at 03:50 -0500, Bansal Aneesh-B39320 wrote:
Quoted 30 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Thursday, March 05, 2015 10:38 PM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495; Gupta Ruchika-R66431
Subject: Re: [U-Boot, 1/2, v4] powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 8 lines · On Thu, 2015-03-05 at 01:26 -0600, Bansal Aneesh-B39320 wrote:
Quoted 8 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Thursday, March 05, 2015 2:41 AM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495; Gupta Ruchika-R66431
Subject: Re: [U-Boot, 1/2, v4] powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 4 lines
Quoted 4 lines

Where does the 3.5G limitation come from? Even if the physical address needs to be elsewhere due to bootrom constraints, we should be able to map it wherever we want in the TLB once U-Boot takes

control.

Quoted 5 lines
Quoted 1 line

The 3.5G limitation comes from BootROM in case of secure Boot. Initially U-Boot has to run from CPC configured as SRAM with address Within 3.5G. Once U-boot has relocated to DDR, we have removed the Corresponding TLB entry.

Again, you could relocate the virtual address of L3 much earlier.

Quoted 7 lines
Quoted 2 lines

-Scott

Are you suggesting the following:

1.  PBI Commands to configure CPC as SRAM with address 0xBFF0_0000.
2.  Compile U-boot with TEXT BASE as 0xFFF40000.
3.  Copy the U-boot from NAND via PBI commands to CPC (SRAM) on

address 0xBFF4_0000 4. The BootROM will validate the U-boot and transfer

the control to 0xBFFF_FFFC.

Quoted 1 line

5. When U-boot is executing, then in the last 4K code, when shifting from

AS=0 to AS=1,

Quoted 9 lines
Quoted 2 lines
      we change the address of SRAM from 0xBFF0_0000 to 0xFFF0_0000.

(Similar to what is done for NOR Boot)

Something like that, except in step 5 it would only be changing the virtual address, not the physical address (unless you can do a similar trick as NOR does, to have the L3 cache repeat and cover both addresses at once).

-Scott

The problems that I see here are:
1. Can SRAM address be changed without disabling and re-configuring CPC as SRAM ?
2. Assuming that above is possible,

We are executing from CPC configured as SRAM with address as 0xBFF0_0000. (Because of 3.5 G Limitation)
We create a LAW for 0xFFF0_0000 to map to CPC and
change the address of SRAM in CPC controller from BFF0_0000 to 0xFFF0_0000. (If it is possible... need to check this)
But now the Code which was executing is executing from 0xBFFx_xxxx. So the CPC controller will reject this since configured address for SRAM is different. NOR can have two addresses as IFC controller ignores the upper bit but this is not possible with CPC.

To avoid this, even if we create a TLB Entry to map the virtual address 0xBFFx_xxxx to 0xFFFx_xxxx, then we have a race condition. Which step to do first? Creation of TLB entry or changing the address of SRAM in CPC controller.
Because the current execution PC is 0xBFFx_xxxx (CPC as SRAM)

-Aneesh

#12 lore raw

PATCH v4 1/2 powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 55 lines · On Tue, 2015-03-10 at 12:52 -0500, Bansal Aneesh-B39320 wrote:
Quoted 55 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Tuesday, March 10, 2015 10:34 PM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495; Gupta Ruchika-R66431; Kushwaha Prabhakar-B32579
Subject: Re: [U-Boot, 1/2, v4] powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 30 lines · On Tue, 2015-03-10 at 03:50 -0500, Bansal Aneesh-B39320 wrote:
Quoted 30 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Thursday, March 05, 2015 10:38 PM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495; Gupta Ruchika-R66431
Subject: Re: [U-Boot, 1/2, v4] powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 8 lines · On Thu, 2015-03-05 at 01:26 -0600, Bansal Aneesh-B39320 wrote:
Quoted 8 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Thursday, March 05, 2015 2:41 AM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495; Gupta Ruchika-R66431
Subject: Re: [U-Boot, 1/2, v4] powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 4 lines
Quoted 4 lines

Where does the 3.5G limitation come from? Even if the physical address needs to be elsewhere due to bootrom constraints, we should be able to map it wherever we want in the TLB once U-Boot takes

control.

Quoted 5 lines
Quoted 1 line

The 3.5G limitation comes from BootROM in case of secure Boot. Initially U-Boot has to run from CPC configured as SRAM with address Within 3.5G. Once U-boot has relocated to DDR, we have removed the Corresponding TLB entry.

Again, you could relocate the virtual address of L3 much earlier.

Quoted 7 lines
Quoted 2 lines

-Scott

Are you suggesting the following:

1.  PBI Commands to configure CPC as SRAM with address 0xBFF0_0000.
2.  Compile U-boot with TEXT BASE as 0xFFF40000.
3.  Copy the U-boot from NAND via PBI commands to CPC (SRAM) on

address 0xBFF4_0000 4. The BootROM will validate the U-boot and transfer

the control to 0xBFFF_FFFC.

Quoted 1 line

5. When U-boot is executing, then in the last 4K code, when shifting from

AS=0 to AS=1,

Quoted 2 lines
      we change the address of SRAM from 0xBFF0_0000 to 0xFFF0_0000.

(Similar to what is done for NOR Boot)

Quoted 8 lines
Quoted 6 lines

Something like that, except in step 5 it would only be changing the virtual address, not the physical address (unless you can do a similar trick as NOR does, to have the L3 cache repeat and cover both addresses at once).

-Scott

The problems that I see here are:
1. Can SRAM address be changed without disabling and re-configuring CPC as SRAM ?

Again, I'm only talking about changing the virtual address.

Quoted 7 lines

2. Assuming that above is possible,

We are executing from CPC configured as SRAM with address as 0xBFF0_0000. (Because of 3.5 G Limitation)
We create a LAW for 0xFFF0_0000 to map to CPC and
change the address of SRAM in CPC controller from BFF0_0000 to 0xFFF0_0000. (If it is possible... need to check this)
But now the Code which was executing is executing from 0xBFFx_xxxx. So the CPC controller will reject this since configured address for SRAM is different. NOR can have two addresses as IFC controller ignores the upper bit but this is not possible with CPC.

...and this is why.

Quoted 1 line

To avoid this, even if we create a TLB Entry to map the virtual address 0xBFFx_xxxx to 0xFFFx_xxxx, then we have a race condition. Which step to do first?

Why is there a race condition? You can have two virtual addresses pointing at the same physical address.

-Scott

#13 lore raw

PATCH v4 1/2 powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 75 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Tuesday, March 10, 2015 11:29 PM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495; Gupta Ruchika-R66431; Kushwaha Prabhakar-B32579
Subject: Re: [U-Boot, 1/2, v4] powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 54 lines · On Tue, 2015-03-10 at 12:52 -0500, Bansal Aneesh-B39320 wrote:
Quoted 54 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Tuesday, March 10, 2015 10:34 PM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495; Gupta Ruchika-R66431; Kushwaha Prabhakar-B32579
Subject: Re: [U-Boot, 1/2, v4] powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 31 lines · On Tue, 2015-03-10 at 03:50 -0500, Bansal Aneesh-B39320 wrote:
Quoted 31 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Thursday, March 05, 2015 10:38 PM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495; Gupta Ruchika-R66431
Subject: Re: [U-Boot, 1/2, v4] powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 9 lines · On Thu, 2015-03-05 at 01:26 -0600, Bansal Aneesh-B39320 wrote:
Quoted 9 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Thursday, March 05, 2015 2:41 AM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495; Gupta Ruchika-R66431
Subject: Re: [U-Boot, 1/2, v4] powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 4 lines
Quoted 4 lines

Where does the 3.5G limitation come from? Even if the physical address needs to be elsewhere due to bootrom constraints, we should be able to map it wherever we want in the TLB once U-Boot takes

control.

Quoted 5 lines
Quoted 1 line

The 3.5G limitation comes from BootROM in case of secure Boot. Initially U-Boot has to run from CPC configured as SRAM with address Within 3.5G. Once U-boot has relocated to DDR, we have removed the Corresponding TLB entry.

Again, you could relocate the virtual address of L3 much earlier.

Quoted 8 lines
Quoted 2 lines

-Scott

Are you suggesting the following:

1.  PBI Commands to configure CPC as SRAM with address 0xBFF0_0000.
2.  Compile U-boot with TEXT BASE as 0xFFF40000.
3.  Copy the U-boot from NAND via PBI commands to CPC (SRAM) on

address 0xBFF4_0000 4. The BootROM will validate the U-boot and transfer

the control to 0xBFFF_FFFC.

Quoted 2 lines

5. When U-boot is executing, then in the last 4K code, when shifting from

Quoted 7 lines
Quoted 7 lines

AS=0 to AS=1,

Quoted 2 lines
      we change the address of SRAM from 0xBFF0_0000 to 0xFFF0_0000.

(Similar to what is done for NOR Boot)

Something like that, except in step 5 it would only be changing the virtual address, not the physical address (unless you can do a similar trick as NOR does, to have the L3 cache repeat and cover both

addresses at once).

Quoted 1 line
Quoted 1 line
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

-Scott

The problems that I see here are:
1. Can SRAM address be changed without disabling and re-configuring CPC

as SRAM ?

Again, I'm only talking about changing the virtual address.

If we just change the virtual address to 0xFFF0_0000, how will it work? The SRAM address configured in CPC controller is 0xBFF0_0000. So, won't the CPC controller reject fetches with address 0xFFFx_xxxx.

Quoted 12 lines
Quoted 6 lines

2. Assuming that above is possible,

We are executing from CPC configured as SRAM with address as 0xBFF0_0000. (Because of 3.5 G Limitation) We create a LAW for 0xFFF0_0000 to map to CPC and change the address of SRAM in CPC controller from BFF0_0000 to 0xFFF0_0000. (If it is possible... need to check

this) But now the Code which was executing is executing from 0xBFFx_xxxx. So the CPC controller will reject this since configured address for SRAM is different.

Quoted 1 line

NOR can have two addresses as IFC controller ignores the upper bit but this

is not possible with CPC.

Quoted 9 lines

...and this is why.

Quoted 1 line

To avoid this, even if we create a TLB Entry to map the virtual address

0xBFFx_xxxx to 0xFFFx_xxxx, then we have a race condition. Which step to do first?

Why is there a race condition? You can have two virtual addresses pointing at the same physical address.

We can have two virtual addresses pointing to same physical address but we can't have two addresses for SRAM in CPC controller. CPC controller will accept fetches with only one address 0xBFFx_xxxx or 0xFFFx_xxxx.
This is not a problem with NOR because IFC controller neglects the upper bits in address and hence having two virtual address was not an issue.

The code is currently executing from PC 0xBFFx_xxxx and CPC is configured with SRAM address 0xBFFx_xxxx. If SRAM address in CPC is changed to 0xFFFx_xxxx before creation of TLB entry for virtual address 0xFFFx_xxxx, Then the CPC controller will reject fetches for address 0xBFFx_xxxx when PC moves to next instruction.

If TLB entry is created to change the virtual address to 0xFFFx_xxxx, then CPC being still configured with address 0xBFFx_xxxx will reject fetches for address 0xFFFx_xxxx.

Quoted 2 lines

-Scott

#14 lore raw

PATCH v4 1/2 powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 79 lines · On Tue, 2015-03-10 at 13:27 -0500, Bansal Aneesh-B39320 wrote:
Quoted 79 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Tuesday, March 10, 2015 11:29 PM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495; Gupta Ruchika-R66431; Kushwaha Prabhakar-B32579
Subject: Re: [U-Boot, 1/2, v4] powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 54 lines · On Tue, 2015-03-10 at 12:52 -0500, Bansal Aneesh-B39320 wrote:
Quoted 54 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Tuesday, March 10, 2015 10:34 PM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495; Gupta Ruchika-R66431; Kushwaha Prabhakar-B32579
Subject: Re: [U-Boot, 1/2, v4] powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 31 lines · On Tue, 2015-03-10 at 03:50 -0500, Bansal Aneesh-B39320 wrote:
Quoted 31 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Thursday, March 05, 2015 10:38 PM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495; Gupta Ruchika-R66431
Subject: Re: [U-Boot, 1/2, v4] powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 9 lines · On Thu, 2015-03-05 at 01:26 -0600, Bansal Aneesh-B39320 wrote:
Quoted 9 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Thursday, March 05, 2015 2:41 AM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495; Gupta Ruchika-R66431
Subject: Re: [U-Boot, 1/2, v4] powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041

Quoted 4 lines
Quoted 4 lines

Where does the 3.5G limitation come from? Even if the physical address needs to be elsewhere due to bootrom constraints, we should be able to map it wherever we want in the TLB once U-Boot takes

control.

Quoted 5 lines
Quoted 1 line

The 3.5G limitation comes from BootROM in case of secure Boot. Initially U-Boot has to run from CPC configured as SRAM with address Within 3.5G. Once U-boot has relocated to DDR, we have removed the Corresponding TLB entry.

Again, you could relocate the virtual address of L3 much earlier.

Quoted 8 lines
Quoted 2 lines

-Scott

Are you suggesting the following:

1.  PBI Commands to configure CPC as SRAM with address 0xBFF0_0000.
2.  Compile U-boot with TEXT BASE as 0xFFF40000.
3.  Copy the U-boot from NAND via PBI commands to CPC (SRAM) on

address 0xBFF4_0000 4. The BootROM will validate the U-boot and transfer

the control to 0xBFFF_FFFC.

Quoted 2 lines

5. When U-boot is executing, then in the last 4K code, when shifting from

Quoted 7 lines
Quoted 7 lines

AS=0 to AS=1,

Quoted 2 lines
      we change the address of SRAM from 0xBFF0_0000 to 0xFFF0_0000.

(Similar to what is done for NOR Boot)

Something like that, except in step 5 it would only be changing the virtual address, not the physical address (unless you can do a similar trick as NOR does, to have the L3 cache repeat and cover both

addresses at once).

Quoted 5 lines
Quoted 3 lines

-Scott

The problems that I see here are:
1. Can SRAM address be changed without disabling and re-configuring CPC

Quoted 7 lines
Quoted 4 lines

as SRAM ?

Again, I'm only talking about changing the virtual address.

If we just change the virtual address to 0xFFF0_0000, how will it work? The SRAM address configured in CPC controller is 0xBFF0_0000. So, won't the CPC controller reject fetches with address 0xFFFx_xxxx.

It's a virtual address. The CPC will never see it.

Quoted 5 lines
Quoted 3 lines

Why is there a race condition? You can have two virtual addresses pointing at the same physical address.

We can have two virtual addresses pointing to same physical address but we can't have two addresses for SRAM in CPC controller.

And you don't need to.

-Scott