pinentry: fix ncurses' unsafe header path
PATCH 1/1 pinentry: fix ncurses' unsafe header path
pinentry sets the NCURSES_INCLUDE variable in the Makefile to /usr/include/ncurses and that causes problems when cross-compiling because it fails with an error like this one:
Making all in curses
make[3]: Entering directory `/br/output/build/pinentry-0.9.0/curses' /br/output/host/usr/bin/mips64el-ctng_n64-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/ncursesw -I../pinentry -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Wall -D_LARGEFILE_SOURCE
-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -Wall -Wcast-align
-Wshadow -Wstrict-prototypes -Wno-pointer-sign -c pinentry-curses.c mips64el-ctng_n64-linux-gnu-gcc: ERROR: unsafe header/library path used in cross-compilation: '/usr/include/ncursesw'
make[3]: *** [pinentry-curses.o] Error 1
Fixes:
http://autobuild.buildroot.net/results/5b9/5b9b53a37f7cf4bab4d989f852726a0f0885605f/
--- package/pinentry/pinentry.mk | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
package/pinentry/pinentry.mk +1 -0
@@ -21,6 +21,7 @@ endif # pinentry-ncurses backend ifeq ($(BR2_PACKAGE_PINENTRY_NCURSES),y) +PINENTRY_CONF_ENV += inetutils_cv_includedir_ncurses=$(STAGING_DIR)/usr/include/ncurses PINENTRY_CONF_OPTS += --enable-ncurses PINENTRY_DEPENDENCIES += ncurses else
Signature · 1 line
1.7.1
PATCH 1/1 pinentry: fix ncurses' unsafe header path
Quoted 31 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Vicente" == Vicente Olivert Riera <[email protected]> writes:
pinentry sets the
NCURSES_INCLUDEvariable in theMakefileto/usr/include/ncursesand that causes problems when cross-compiling because it fails with an error like this one:Making all in curses
make[3]: Entering directory `/br/output/build/pinentry-0.9.0/curses' /br/output/host/usr/bin/mips64el-ctng_n64-linux-gnu-gcc -DHAVE_CONFIG_H(quoted diff) +0
-4-I. -I.. -I/usr/include/ncursesw -I../pinentry -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Wall -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -Wall -Wcast-align -Wshadow -Wstrict-prototypes -Wno-pointer-sign -c pinentry-curses.cmips64el-ctng_n64-linux-gnu-gcc: ERROR: unsafe header/library path used in cross-compilation: '
/usr/include/ncursesw'
make[3]: *** [pinentry-curses.o] Error 1Fixes:
http://autobuild.buildroot.net/results/5b9/5b9b53a37f7cf4bab4d989f852726a0f0885605f/
Signed-off-by Vicente Olivert Riera <[email protected]>--- package/pinentry/pinentry.mk | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)package/pinentry/pinentry.mk +0
-0
package/pinentry/pinentry.mk endif · line 24
Quoted 4 lines
package/pinentry/pinentry.mk +1
-0@@ -21,6 +21,7 @@ endif # pinentry-ncurses backend ifeq ($(BR2_PACKAGE_PINENTRY_NCURSES),y) +PINENTRY_CONF_ENV += inetutils_cv_includedir_ncurses=$(STAGING_DIR)/usr/include/ncurses
Thanks, but we don't actually install anything under $(STAGING_DIR)/usr/include/ncurses (it is directly in $(STAGING_DIR)/usr/include). Looking at the configure script, the documented way of not adding a special -I for ncurses is simply to pass --with-ncurses-include-dir=none so I've changed it to use that instead.
Signature · 1 line
Bye, Peter Korsgaard