[PATCH 0/3]
cover [PATCH 0/3]
This patchset delete space and adds const.
Melike Yurtoglu (3):
Staging: lustre: Added const
Staging: lustre: Removed space prohibited
Staging: lustre: Deleted space prohibited between function name and
open parenthesis
drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Signature · 1 line
1.8.3.2
PATCH 1/3 Staging: lustre: Added const
WARNING: struct file_operations should normally be const. That was found by running checkpatch.
--- drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c +1 -1
@@ -1083,7 +1083,7 @@ void ptlrpc_lprocfs_register_service(struct proc_dir_entry *entry, .data = svc}, {NULL} }; -static struct file_operations req_history_fops = { +static const struct file_operations req_history_fops = { .owner =THIS_MODULE , .open = ptlrpc_lprocfs_svc_req_history_open, .read = seq_read,
Signature · 1 line
1.8.3.2
PATCH 2/3 Staging: lustre: Removed space prohibited
In reply to Melike YurtogluWARNING: space prohibited before that ','
Removed space prohibited. That was found by running checkpatch.
--- drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c +1 -1
@@ -54,7 +54,7 @@ static struct ll_rpc_opcode { { OST_SETATTR, "ost_setattr" }, { OST_READ, "ost_read" }, { OST_WRITE, "ost_write" }, - { OST_CREATE , "ost_create" }, + { OST_CREATE, "ost_create" }, { OST_DESTROY, "ost_destroy" }, { OST_GET_INFO, "ost_get_info" }, { OST_CONNECT, "ost_connect" },
Signature · 1 line
1.8.3.2
Re: [Outreachy kernel] [PATCH 2/3] Staging: lustre: Removed space prohibited
Quoted 13 lines · Melike Yurtoglu
WARNING: space prohibited before that ','
Removed space prohibited. That was found by running checkpatch.Signed-off-by Melike Yurtoglu <[email protected]>--- drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c +0
-0
drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c static struct ll_rpc_opcode { · line 57
Quoted 5 lines
drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c +1
-1@@ -54,7 +54,7 @@ static struct ll_rpc_opcode { { OST_SETATTR, "ost_setattr" }, { OST_READ, "ost_read" }, { OST_WRITE, "ost_write" }, - { OST_CREATE , "ost_create" }, + { OST_CREATE, "ost_create" },
I think it would be better to improve all of the spacing issues in this structure. At least the read and write strings look badly placed.
julia
Quoted 13 lines
drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c +0
-1{ OST_DESTROY, "ost_destroy" }, { OST_GET_INFO, "ost_get_info" }, { OST_CONNECT, "ost_connect" }, --1.8.3.2
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1425069731-30165-3-git-send-email-aysemelikeyurtoglu%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
PATCH 3/3 Staging: lustre: Deleted space prohibited between function name and open parenthesis
In reply to Melike YurtogluWARNING: space prohibited between function name and open parenthesis '(' Remove unnecessary space between function name and opening parenthesis. That was found by running checkpatch
--- drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c +1 -1
@@ -181,7 +181,7 @@ static const char *ll_eopcode2str(__u32 opcode)return ll_eopcode_table[opcode].opname; } -#if defined (CONFIG_PROC_FS ) +#if defined(CONFIG_PROC_FS ) static void ptlrpc_lprocfs_register(struct proc_dir_entry *root, char *dir, char *name, struct proc_dir_entry **procroot_ret,
Signature · 1 line
1.8.3.2