Staging: lustre: lustre: ldlm: Fix externs should be avoided in .c
PATCH 1/1 Staging: lustre: lustre: ldlm: Fix externs should be avoided in .c
This patch moves extern declaration from ldlm_lockd.c to ldlm_internal.h. Issue addressed by checkpatch.pl.
--- drivers/staging/lustre/lustre/ldlm/ldlm_internal.h | 3 +++ drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c | 2 -- 2 files changed, 3 insertions(+), 2 deletions(-)
drivers/staging/lustre/lustre/ldlm/ldlm_internal.h +3 -0
@@ -177,6 +177,9 @@ int ldlm_bl_to_thread_list(struct ldlm_namespace *ns,void ldlm_handle_bl_callback (struct ldlm_namespace *ns,struct ldlm_lock_desc *ld,struct ldlm_lock *lock); +extern struct kmem_cache *ldlm_resource_slab; + +extern struct kmem_cache *ldlm_lock_slab;/* ldlm_extent.c */ void ldlm_extent_add_lock (struct ldlm_resource *res,struct ldlm_lock *lock);
drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c +0 -2
@@ -55,8 +55,6 @@ static char *ldlm_cpts;module_param (ldlm_cpts, charp,0444 );MODULE_PARM_DESC (ldlm_cpts,"CPU partitions ldlm threads should run on" ); -extern struct kmem_cache *ldlm_resource_slab; -extern struct kmem_cache *ldlm_lock_slab;static struct mutex ldlm_ref_mutex;static int ldlm_refcount;
Signature · 1 line
1.9.1
PATCH v2 1/1 Staging: lustre: lustre: ldlm: Fix externs should be avoided in .c
This patch moves extern declaration to ldlm_internal.h. Remove prototype from ldlm_lockd.c and ldlm_lock.c. Issue addressed by checkpatch.pl.
--- drivers/staging/lustre/lustre/ldlm/ldlm_internal.h | 4 ++++ drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 2 -- drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c | 2 -- 3 files changed, 4 insertions(+), 4 deletions(-)
drivers/staging/lustre/lustre/ldlm/ldlm_internal.h +4 -0
@@ -177,6 +177,10 @@ int ldlm_bl_to_thread_list(struct ldlm_namespace *ns,void ldlm_handle_bl_callback (struct ldlm_namespace *ns,struct ldlm_lock_desc *ld,struct ldlm_lock *lock); +extern struct kmem_cache *ldlm_resource_slab; + +/* ldlm_lockd.c & ldlm_lock.c */ +extern struct kmem_cache *ldlm_lock_slab;/* ldlm_extent.c */ void ldlm_extent_add_lock (struct ldlm_resource *res,struct ldlm_lock *lock);
drivers/staging/lustre/lustre/ldlm/ldlm_lock.c +0 -2
@@ -151,8 +151,6 @@ char *ldlm_it2str(int it) }EXPORT_SYMBOL (ldlm_it2str); -extern struct kmem_cache *ldlm_lock_slab; -void ldlm_register_intent (struct ldlm_namespace *ns,ldlm_res_policy arg) {
drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c +0 -2
@@ -55,8 +55,6 @@ static char *ldlm_cpts;module_param (ldlm_cpts, charp,0444 );MODULE_PARM_DESC (ldlm_cpts,"CPU partitions ldlm threads should run on" ); -extern struct kmem_cache *ldlm_resource_slab; -extern struct kmem_cache *ldlm_lock_slab;static struct mutex ldlm_ref_mutex;static int ldlm_refcount;
Signature · 1 line
1.9.1
I think that Staging: lustre: would be sufficient for the subject line.
julia
Quoted 62 lines · Haneen Mohammed
This patch moves extern declaration to
ldlm_internal.h. Remove prototype fromldlm_lockd.candldlm_lock.c. Issue addressed by checkpatch.pl.Signed-off-by Haneen Mohammed <[email protected]>--- drivers/staging/lustre/lustre/ldlm/ldlm_internal.h | 4 ++++ drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 2 -- drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c | 2 -- 3 files changed, 4 insertions(+), 4 deletions(-)drivers/staging/lustre/lustre/ldlm/ldlm_internal.h +4
-0@@ -177,6 +177,10 @@ int ldlm_bl_to_thread_list(struct ldlm_namespace *ns,void ldlm_handle_bl_callback (struct ldlm_namespace *ns,struct ldlm_lock_desc *ld,struct ldlm_lock *lock); +extern struct kmem_cache *ldlm_resource_slab; + +/* ldlm_lockd.c & ldlm_lock.c */ +extern struct kmem_cache *ldlm_lock_slab;/* ldlm_extent.c */ void ldlm_extent_add_lock (struct ldlm_resource *res,struct ldlm_lock *lock);drivers/staging/lustre/lustre/ldlm/ldlm_lock.c +0
-2@@ -151,8 +151,6 @@ char *ldlm_it2str(int it) }EXPORT_SYMBOL (ldlm_it2str); -extern struct kmem_cache *ldlm_lock_slab; -void ldlm_register_intent (struct ldlm_namespace *ns,ldlm_res_policy arg) {drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c +0
-3@@ -55,8 +55,6 @@ static char *ldlm_cpts;module_param (ldlm_cpts, charp,0444 );MODULE_PARM_DESC (ldlm_cpts,"CPU partitions ldlm threads should run on" ); -extern struct kmem_cache *ldlm_resource_slab; -extern struct kmem_cache *ldlm_lock_slab;static struct mutex ldlm_ref_mutex;static int ldlm_refcount; --1.9.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1425113778-17230-1-git-send-email-hamohammed.sa%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
Greg KH
maintainerQuoted 10 lines · Haneen Mohammed
This patch moves extern declaration to
ldlm_internal.h. Remove prototype fromldlm_lockd.candldlm_lock.c. Issue addressed by checkpatch.pl.Signed-off-by Haneen Mohammed <[email protected]>--- drivers/staging/lustre/lustre/ldlm/ldlm_internal.h | 4 ++++ drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 2 -- drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c | 2 -- 3 files changed, 4 insertions(+), 4 deletions(-)
What changed between v1 and v2? Please fix up and resend v3.
thanks,
greg k-h