virtio_console: init work unconditionally
Subsystems (3)
Michael S. Tsirkin
maintainerPATCH 1/1 virtio_console: init work unconditionally
when multiport is off, we don't initialize config work, but we then cancel uninitialized control_work on freeze.
Signed-off-by Michael S. Tsirkin <[email protected]>
--- drivers/char/virtio_console.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/char/virtio_console.c +2 -1
@@ -2040,12 +2040,13 @@ static int virtcons_probe(struct virtio_device *vdev)virtio_device_ready (portdev->vdev); +INIT_WORK (&portdev->control_work, &control_work_handler); +if (multiport) {unsigned int nr_added_bufs;spin_lock_init (&portdev->c_ivq_lock);spin_lock_init (&portdev->c_ovq_lock); -INIT_WORK (&portdev->control_work, &control_work_handler); nr_added_bufs =fill_queue (portdev->c_ivq, &portdev->c_ivq_lock);
Signature · 1 line
MST
Quoted 4 lines · Michael S. Tsirkin
when multiport is off, we don't initialize config work, but we then cancel uninitialized
control_workon freeze.Signed-off-by Michael S. Tsirkin <[email protected]>
Reviewed-by Amit Shah <[email protected]>
Amit
Quoted 4 lines · Michael S. Tsirkin
when multiport is off, we don't initialize config work, but we then cancel uninitialized
control_workon freeze.Signed-off-by Michael S. Tsirkin <[email protected]>
Reviewed-by Amit Shah <[email protected]>
Amit
Rusty Russell
AppliedQuoted 7 lines · Amit Shah
Quoted 4 lines · Michael S. Tsirkin
when multiport is off, we don't initialize config work, but we then cancel uninitialized
control_workon freeze.Signed-off-by Michael S. Tsirkin <[email protected]>Reviewed-by Amit Shah <[email protected]>
Thanks, applied.
Cheers,
Rusty.
Rusty Russell
AppliedQuoted 7 lines · Amit Shah
Quoted 4 lines · Michael S. Tsirkin
when multiport is off, we don't initialize config work, but we then cancel uninitialized
control_workon freeze.Signed-off-by Michael S. Tsirkin <[email protected]>Reviewed-by Amit Shah <[email protected]>
Thanks, applied.
Cheers,
Rusty.