Skip to contentSkip to conversation

Staging: dgnc: replace EXTRA_CFLAGS

PATCH Superseded Matteo Semenzato 2 participants 6 messages Mar 1, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: dgnc: replace EXTRA_CFLAGS

From: Matteo Semenzato <[email protected]>

This patch fixes the following warning:
Use of EXTRA_CFLAGS is deprecated, please use `ccflags-y instead.

---
 drivers/staging/dgnc/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/dgnc/Makefile +1 -1
index b69f7b6..d70323e 100644
@@ -1,4 +1,4 @@
-EXTRA_CFLAGS += -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\"
+ccflags-y += -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\"
 
 obj-$(CONFIG_DGNC) += dgnc.o
 
Signature · 1 line
2.3.1
maintainer
#1 lore raw
Quoted 15 lines · Matteo Semenzato

From: Matteo Semenzato <[email protected]>

This patch fixes the following warning:
Use of EXTRA_CFLAGS is deprecated, please use `ccflags-y instead.

---
 drivers/staging/dgnc/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/dgnc/Makefile +0 -0
index b69f7b6..d70323e 100644

drivers/staging/dgnc/Makefile line 1

Quoted 2 lines
drivers/staging/dgnc/Makefile +1 -1
@@ -1,4 +1,4 @@
-EXTRA_CFLAGS += -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\"
+ccflags-y += -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\"

Please fix the code to not need these flags at all.

thanks,

greg k-h

#2 lore raw

PATCH v2 1/1 Staging: dgnc: replace EXTRA_CFLAGS

In reply to Matteo Semenzato

From: Matteo Semenzato <[email protected]>

This patch removes EXTRA_CFLAGS from the Makefile and defines DDG_PART in dgnc_driver.h

---
 drivers/staging/dgnc/Makefile      | 2 --
 drivers/staging/dgnc/dgnc_driver.h | 1 +
 2 files changed, 1 insertion(+), 2 deletions(-)
drivers/staging/dgnc/Makefile +0 -2
index b69f7b6..995c874 100644
@@ -1,5 +1,3 @@
-EXTRA_CFLAGS += -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\"
-
 obj-$(CONFIG_DGNC) += dgnc.o
 
 dgnc-objs :=   dgnc_cls.o dgnc_driver.o\
drivers/staging/dgnc/dgnc_driver.h +1 -0
index a8157eb..0b718a8 100644
@@ -46,6 +46,7 @@
 #define	PROCSTR		"dgnc"			/* /proc entries	 */
 #define	DEVSTR		"/dev/dg/dgnc"		/* /dev entries		 */
 #define	DRVSTR		"dgnc"			/* Driver name string	 */
+#define DG_PART		"40002369_F"
 
 #define TRC_TO_CONSOLE 1
 
Signature · 1 line
2.3.1
maintainer
#3 lore raw
Quoted 26 lines · Matteo Semenzato

From: Matteo Semenzato <[email protected]>

This patch removes EXTRA_CFLAGS from the Makefile and defines DDG_PART in dgnc_driver.h

---
 drivers/staging/dgnc/Makefile      | 2 --
 drivers/staging/dgnc/dgnc_driver.h | 1 +
 2 files changed, 1 insertion(+), 2 deletions(-)
drivers/staging/dgnc/Makefile +0 -2
index b69f7b6..995c874 100644
@@ -1,5 +1,3 @@
-EXTRA_CFLAGS += -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\"
-
 obj-$(CONFIG_DGNC) += dgnc.o
 
 dgnc-objs :=   dgnc_cls.o dgnc_driver.o\
drivers/staging/dgnc/dgnc_driver.h +0 -0
index a8157eb..0b718a8 100644

drivers/staging/dgnc/dgnc_driver.h line 49

Quoted 4 lines
drivers/staging/dgnc/dgnc_driver.h +1 -0
@@ -46,6 +46,7 @@
 #define	PROCSTR		"dgnc"			/* /proc entries	 */
 #define	DEVSTR		"/dev/dg/dgnc"		/* /dev entries		 */
 #define	DRVSTR		"dgnc"			/* Driver name string	 */
+#define DG_PART		"40002369_F"

Why do we need this define?

And why doesn't it use the same formatting as the other ones in this list?

#4 lore raw

Il giorno dom, 01/03/2015 alle 09.26 -0800, Greg KH ha scritto:

Quoted 34 lines · Matteo Semenzato
Quoted 26 lines

From: Matteo Semenzato <[email protected]>

This patch removes EXTRA_CFLAGS from the Makefile and defines DDG_PART in dgnc_driver.h

---
 drivers/staging/dgnc/Makefile      | 2 --
 drivers/staging/dgnc/dgnc_driver.h | 1 +
 2 files changed, 1 insertion(+), 2 deletions(-)
drivers/staging/dgnc/Makefile +0 -2
index b69f7b6..995c874 100644
@@ -1,5 +1,3 @@
-EXTRA_CFLAGS += -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\"
-
 obj-$(CONFIG_DGNC) += dgnc.o
 
 dgnc-objs :=   dgnc_cls.o dgnc_driver.o\
drivers/staging/dgnc/dgnc_driver.h +0 -0
index a8157eb..0b718a8 100644

drivers/staging/dgnc/dgnc_driver.h line 49

Quoted 4 lines
drivers/staging/dgnc/dgnc_driver.h +1 -0
@@ -46,6 +46,7 @@
 #define	PROCSTR		"dgnc"			/* /proc entries	 */
 #define	DEVSTR		"/dev/dg/dgnc"		/* /dev entries		 */
 #define	DRVSTR		"dgnc"			/* Driver name string	 */
+#define DG_PART		"40002369_F"

Why do we need this define?

Quoted 2 lines

And why doesn't it use the same formatting as the other ones in this list?

DG_PART is being used in dgnc_mgmt.c and dgnc_sysfs.c

maintainer
#5 lore raw
Quoted 35 lines · Matteo Semenzato

Il giorno dom, 01/03/2015 alle 09.26 -0800, Greg KH ha scritto:

Quoted 34 lines · Matteo Semenzato
Quoted 26 lines

From: Matteo Semenzato <[email protected]>

This patch removes EXTRA_CFLAGS from the Makefile and defines DDG_PART in dgnc_driver.h

---
 drivers/staging/dgnc/Makefile      | 2 --
 drivers/staging/dgnc/dgnc_driver.h | 1 +
 2 files changed, 1 insertion(+), 2 deletions(-)
drivers/staging/dgnc/Makefile +0 -2
index b69f7b6..995c874 100644
@@ -1,5 +1,3 @@
-EXTRA_CFLAGS += -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\"
-
 obj-$(CONFIG_DGNC) += dgnc.o
 
 dgnc-objs :=   dgnc_cls.o dgnc_driver.o\
drivers/staging/dgnc/dgnc_driver.h +0 -0
index a8157eb..0b718a8 100644

drivers/staging/dgnc/dgnc_driver.h line 49

Quoted 4 lines
drivers/staging/dgnc/dgnc_driver.h +1 -0
@@ -46,6 +46,7 @@
 #define	PROCSTR		"dgnc"			/* /proc entries	 */
 #define	DEVSTR		"/dev/dg/dgnc"		/* /dev entries		 */
 #define	DRVSTR		"dgnc"			/* Driver name string	 */
+#define DG_PART		"40002369_F"

Why do we need this define?

Quoted 4 lines
Quoted 2 lines

And why doesn't it use the same formatting as the other ones in this list?

DG_PART is being used in dgnc_mgmt.c and dgnc_sysfs.c

What it is being used for? Can it be removed? Is it just there for informational purposes or does the code actually do something based on the value?

thanks,

greg k-h