Skip to contentSkip to conversation

net: designware: don't depend on CONFIG_OFTREE

PATCH Applied Lucas Stach 2 participants 4 messages Mar 1, 2015 – Mar 2, 2015

Subsystems (4)
Network drivers Arm (32-bit) Arm sub-architectures PXA2xx/PXA3xx support
lore
Share & tools
lore

Lucas Stach

author
#0 lore raw

PATCH 1/3 net: designware: don't depend on CONFIG_OFTREE

This driver is written in a way that is should also work without DT, but it had a compile time dependency on CONFIG_OFTREE.

Fixes:
drivers/built-in.o: In function `dwc_probe_dt':
drivers/net/designware.c:413: undefined reference to `of_get_phy_mode'

Signed-off-by Lucas Stach <[email protected]>
---
 drivers/net/designware.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/net/designware.c +3 -0
index 49ed0b192231..29a6047c7f1a 100644
@@ -406,6 +406,9 @@ static void dwc_version(struct device_d *dev, u32 hwid)
 
 static int dwc_probe_dt(struct device_d *dev, struct dw_eth_dev *priv)
 {
+	if (!IS_ENABLED(CONFIG_OFTREE))
+		return -ENODEV;
+
 	priv->phy_addr = -1;
 	priv->interface = of_get_phy_mode(dev->device_node);
Signature · 7 lines
2.1.0


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
author
#1 lore raw

PATCH 2/3 menu: depend on !CONFIG_SHELL_NONE

It doesn't make much sense to have the menuframework but no shell.

Fixes:
In function menu_action_command': undefined reference to run_command'

Signed-off-by Lucas Stach <[email protected]>
---
 common/Kconfig | 1 +
 1 file changed, 1 insertion(+)
common/Kconfig +1 -0
index d4373431aae8..cf197076dbab 100644
@@ -414,6 +414,7 @@ config AUTO_COMPLETE
 config MENU
 	bool
 	prompt "Menu Framework"
+	depends on !SHELL_NONE
 	select PROCESS_ESCAPE_SEQUENCE
 	help
 	  a menu framework that allow us to create list menu to simplify
Signature · 7 lines
2.1.0


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
author
#2 lore raw

PATCH 3/3 ARM: MIOA701: select POLLER

In reply to Lucas Stach

Fixes:
In function gpio0_poweroff_probe': undefined reference to poller_register'

Signed-off-by Lucas Stach <[email protected]>
---
 arch/arm/mach-pxa/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-pxa/Kconfig +1 -0
index a45e01a70222..67d1f4b5a9d4 100644
@@ -64,6 +64,7 @@ config MACH_MIOA701
 	bool "Mitac Mio A701"
 	select BCH_CONST_PARAMS
 	select PWM
+	select POLLER
 	help
 	  Say Y here if you are using a Mitac Mio A701 smartphone
Signature · 7 lines
2.1.0


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Applied
#3 lore raw
In reply to Lucas Stach
Quoted 11 lines · Lucas Stach

This driver is written in a way that is should also work without DT, but it had a compile time dependency on CONFIG_OFTREE.

Fixes:
drivers/built-in.o: In function `dwc_probe_dt':
drivers/net/designware.c:413: undefined reference to `of_get_phy_mode'

Signed-off-by Lucas Stach <[email protected]>
---
 drivers/net/designware.c | 3 +++
 1 file changed, 3 insertions(+)

Applied, thanks

Sascha

Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox