Skip to contentSkip to conversation

arm: mvf600: Add Freescale Vybrid MVF600 CPU and MVF600TWR board support

PATCH Superseded Alison Wang 4 participants 26 messages May 21, 2013 – May 28, 2013 2 messages not in the archive

Subsystems (5)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v3 cover arm: mvf600: Add Freescale Vybrid MVF600 CPU and MVF600TWR board support

This series contain the support for Freescale Vybrid MVF600 CPU and MVF600TWR board.

Vybird devices are built on an asymmetrical-multiprocessing architecture using ARM cores. The families in the Vybrid portfolio span entry-level, single core Cortex-A class SoCs all the way to dual heterogeneous core SoCs with multiple communication and connectivity options.

Part of the Vybrid platform, MVF600 is a dual-core eMPU combining the ARM Cortex A5 and Cortex M4 cores.

MVF600 shares some IPs with i.MX family, such as FEC,ESDHC,WATCHDOG,I2C,ASRC and ESAI. MVF600 also shares some IPs with ColdFire family, such as eDMA and DSPI. MVF600 still has its own IPs, such as PIT,SAI,UART,QSPI and DCU.

More documents for this soc can be found at:
http://www.freescale.com/webapp/sps/site/prod_summary.jsp?code=VF6xx&fsrch=1&sr=5
http://www.freescale.com/webapp/sps/site/homepage.jsp?code=VYBRID

The u-boot runs on Cortex A5 core.

Changes in v3:
- Rename the common functions and enums
- Move the structure definitions to imx-regs.h
- Define PAD_CTL_PUE with PKE enabled
- Remove the changes for FEC_RCNTRL_RGMII / FEC_RCNTRL_RMII / FEC_RCNTRL_MII_MODE bits, as they are already set in fec_reg_setup()
- Replace BOOT_FROM by BOOT_OFFSET
- Enable CONFIG_OF_LIBFDT option
- Add useful define instead of raw number
- Use clrsetbits_le32 to set the single bits
- Move setup_iomux_enet() to board_early_init_f and remove board_eth_init()
- Remove redundant define
- Move CONFIG_IOMUX_SHARE_CONF_REG to imx-regs.h

Changes in v2:
- Remove vybrid-common directory
- Rename directory name 'vybrid' to 'mvf600'
- Add generic.c file
- Rewrite get_reset_cause() to make it readable
- Remove reset_cpu(), and use the function in imx_watchdog.c
- Rewrite timer.c file
- Use vybrid_get_clock(VYBRID_UART_CLK) instead of vybrid_get_uartclk()
- Remove lowlevel_init.S, and add clock_init() in board_early_init_f()
- Remove useless CONFIG_SYS_ defines
- Move CONFIG_MACH_TYPE to board configuration file
- Define C structures and access C structures to set/read registers
- Remove useless errata
- Remove useless macros
- Rename directory 'arch-vybrid' to 'arch-mvf600'
- Use common iomux-v3 code
- Use common FEC driver fec_mxc.c
- Add watchdog support
- Add an entry to MAINTAINERS file
- Rename directory name 'vybird' to 'mvf600twr'
- Use standard method to set gd->ram_size
- Rewrite board_mmc_getcd() function
- Remove useless undef
- Remove hardcoded IP addresses and MAC addresses
- Move CONFIG_MACH_TYPE to board configuration file

----------------------------------------------------------------
Alison Wang (6):
arm: mvf600: Add Vybrid MVF600 CPU support
arm: mvf600: Add IOMUX support for Vybrid MVF600
net: fec_mxc: Add support for Vybrid MVF600
arm: mvf600: Add watchdog support for Vybrid MVF600
arm: mvf600: Add uart support for Vybrid MVF600
arm: mvf600: Add basic support for Vybrid MVF600TWR board

 MAINTAINERS                                 |   4 ++
 Makefile                                    |   2 +-
 arch/arm/cpu/armv7/mvf600/Makefile          |  42 +++++++++++
 arch/arm/cpu/armv7/mvf600/generic.c         | 324 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 arch/arm/cpu/armv7/mvf600/timer.c           | 103 ++++++++++++++++++++++++++
 arch/arm/imx-common/Makefile                |   2 +-
 arch/arm/imx-common/iomux-v3.c              |   6 ++
 arch/arm/include/asm/arch-mvf600/clock.h    |  39 ++++++++++
 arch/arm/include/asm/arch-mvf600/crm_regs.h | 225 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 arch/arm/include/asm/arch-mvf600/imx-regs.h | 411 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 arch/arm/include/asm/arch-mvf600/mvf_pins.h |  92 ++++++++++++++++++++++++
 arch/arm/include/asm/imx-common/iomux-v3.h  |  18 +++++
 board/freescale/mvf600twr/Makefile          |  39 ++++++++++
 board/freescale/mvf600twr/imximage.cfg      |  33 +++++++++
 board/freescale/mvf600twr/mvf600twr.c       | 413 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 boards.cfg                                  |   1 +
 drivers/net/fec_mxc.c                       |   4 +-
 drivers/serial/Makefile                     |   1 +
 drivers/serial/serial_lpuart.c              | 132 ++++++++++++++++++++++++++++++++++
 drivers/watchdog/Makefile                   |   2 +-
 include/configs/mvf600twr.h                 | 140 ++++++++++++++++++++++++++++++++++++
 21 files changed, 2027 insertions(+), 6 deletions(-)
 create mode 100644 arch/arm/cpu/armv7/mvf600/Makefile
 create mode 100644 arch/arm/cpu/armv7/mvf600/generic.c
 create mode 100644 arch/arm/cpu/armv7/mvf600/timer.c
 create mode 100644 arch/arm/include/asm/arch-mvf600/clock.h
 create mode 100644 arch/arm/include/asm/arch-mvf600/crm_regs.h
 create mode 100644 arch/arm/include/asm/arch-mvf600/imx-regs.h
 create mode 100644 arch/arm/include/asm/arch-mvf600/mvf_pins.h
 create mode 100644 board/freescale/mvf600twr/Makefile
 create mode 100644 board/freescale/mvf600twr/imximage.cfg
 create mode 100644 board/freescale/mvf600twr/mvf600twr.c
 create mode 100644 drivers/serial/serial_lpuart.c
 create mode 100644 include/configs/mvf600twr.h
#1 lore raw

PATCH v3 1/6 arm: mvf600: Add Vybrid MVF600 CPU support

This patch adds generic codes to support Freescale's Vybrid MVF600 CPU.

It aligns Vybrid MVF600 platform with i.MX platform. As there are some differences between MVF600 and i.MX platforms, the specific codes are in the arch/arm/cpu/armv7/mvf600 directory.

---
Changes in v3:
- Rename the common functions and enums
- Move the structure definitions to imx-regs.h

Changes in v2:
- Remove vybrid-common directory
- Rename directory name 'vybrid' to 'mvf600'
- Add generic.c file
- Rewrite get_reset_cause() to make it readable
- Remove reset_cpu(), and use the function in imx_watchdog.c
- Rewrite timer.c file
- Use vybrid_get_clock(VYBRID_UART_CLK) instead of vybrid_get_uartclk()
- Remove lowlevel_init.S, and add clock_init() in board_early_init_f()
- Remove useless CONFIG_SYS_ defines
- Move CONFIG_MACH_TYPE to board configuration file
- Define C structures and access C structures to set/read registers
- Remove useless errata
- Remove useless macros
- Rename directory 'arch-vybrid' to 'arch-mvf600'

 Makefile                                    |   2 +-
 arch/arm/cpu/armv7/mvf600/Makefile          |  42 +++
 arch/arm/cpu/armv7/mvf600/generic.c         | 324 ++++++++++++++++++++++
 arch/arm/cpu/armv7/mvf600/timer.c           | 103 +++++++
 arch/arm/include/asm/arch-mvf600/clock.h    |  39 +++
 arch/arm/include/asm/arch-mvf600/crm_regs.h | 225 +++++++++++++++
 arch/arm/include/asm/arch-mvf600/imx-regs.h | 411 ++++++++++++++++++++++++++++
 arch/arm/include/asm/arch-mvf600/mvf_pins.h |  92 +++++++
 8 files changed, 1237 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/cpu/armv7/mvf600/Makefile
 create mode 100644 arch/arm/cpu/armv7/mvf600/generic.c
 create mode 100644 arch/arm/cpu/armv7/mvf600/timer.c
 create mode 100644 arch/arm/include/asm/arch-mvf600/clock.h
 create mode 100644 arch/arm/include/asm/arch-mvf600/crm_regs.h
 create mode 100644 arch/arm/include/asm/arch-mvf600/imx-regs.h
 create mode 100644 arch/arm/include/asm/arch-mvf600/mvf_pins.h
Makefile +1 -1
index c52f0f1..9df2138 100644
@@ -341,7 +341,7 @@ ifneq ($(CONFIG_AM33XX)$(CONFIG_OMAP34XX)$(CONFIG_OMAP44XX)$(CONFIG_OMAP54XX)$(C
 LIBS-y += $(CPUDIR)/omap-common/libomap-common.o
 endif
 
-ifneq (,$(filter $(SOC), mx25 mx27 mx5 mx6 mx31 mx35 mxs))
+ifneq (,$(filter $(SOC), mx25 mx27 mx5 mx6 mx31 mx35 mxs mvf600))
 LIBS-y += arch/$(ARCH)/imx-common/libimx-common.o
 endif
 
arch/arm/cpu/armv7/mvf600/Makefile new file +42 -0

42 lines not on this page · raw message

arch/arm/cpu/armv7/mvf600/generic.c new file +324 -0

324 lines not on this page · raw message

arch/arm/cpu/armv7/mvf600/timer.c new file +103 -0

103 lines not on this page · raw message

arch/arm/include/asm/arch-mvf600/clock.h new file +39 -0
new file mode 100644
index 0000000..04e418c
@@ -0,0 +1,39 @@
+/*
+ * Copyright 2013 Freescale Semiconductor, Inc.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#ifndef __ASM_ARCH_CLOCK_H
+#define __ASM_ARCH_CLOCK_H
+
+#include <common.h>
+
+enum mxc_clock {
+	MXC_ARM_CLK = 0,
+	MXC_BUS_CLK,
+	MXC_IPG_CLK,
+	MXC_UART_CLK,
+	MXC_ESDHC_CLK,
+	MXC_FEC_CLK,
+};
+
+void enable_ocotp_clk(unsigned char enable);
+unsigned int mxc_get_clock(enum mxc_clock clk);
+
+#define imx_get_fecclk() mxc_get_clock(MXC_FEC_CLK)
+
+#endif /* __ASM_ARCH_CLOCK_H */
arch/arm/include/asm/arch-mvf600/crm_regs.h new file +225 -0

225 lines not on this page · raw message

arch/arm/include/asm/arch-mvf600/imx-regs.h new file +411 -0

411 lines not on this page · raw message

arch/arm/include/asm/arch-mvf600/mvf_pins.h new file +92 -0

92 lines not on this page · raw message

Signature · 1 line
1.8.0
#2 lore raw

PATCH v3 1/6 arm: mvf600: Add Vybrid MVF600 CPU support

arch/arm/cpu/armv7/mvf600/generic.c line 44

Quoted 11 lines · Alison Wang
arch/arm/cpu/armv7/mvf600/generic.c new file +11 -0
+#ifdef CONFIG_MXC_OCOTP
+void enable_ocotp_clk(unsigned char enable)
+{
+	struct ccm_reg *ccm = (struct ccm_reg *)CCM_BASE_ADDR;
+	u32 reg;
+
+	reg = readl(&ccm->ccgr6);
+	if (enable)
+		reg |= CCM_CCGR6_OCOTP_CTRL_MASK;
+	else
+		reg |= ~CCM_CCGR6_OCOTP_CTRL_MASK;

Don't you mean: reg &= ~CCM_CCGR6_OCOTP_CTRL_MASK; ?

#3 lore raw

PATCH v3 1/6 arm: mvf600: Add Vybrid MVF600 CPU support

Hi, Fabio,

Quoted 10 lines

-----Original Message-----
From: Estevam Fabio-R49496
Sent: Tuesday, May 21, 2013 9:48 PM
To: Wang Huan-B18965
Cc: sbabic at denx.de; u-boot at lists.denx.de; Liu Hui-R64343; Estevam Fabio- R49496
Subject: Re: [PATCH v3 1/6] arm: mvf600: Add Vybrid MVF600 CPU support

On 05/21/2013 06:02 AM, Alison Wang wrote:

Quoted 12 lines

arch/arm/cpu/armv7/mvf600/generic.c line 44

Quoted 10 lines
arch/arm/cpu/armv7/mvf600/generic.c new file +10 -0
+#ifdef CONFIG_MXC_OCOTP
+void enable_ocotp_clk(unsigned char enable) {
+	struct ccm_reg *ccm = (struct ccm_reg *)CCM_BASE_ADDR;
+	u32 reg;
+
+	reg = readl(&ccm->ccgr6);
+	if (enable)
+		reg |= CCM_CCGR6_OCOTP_CTRL_MASK;
+	else
+		reg |= ~CCM_CCGR6_OCOTP_CTRL_MASK;

Don't you mean: reg &= ~CCM_CCGR6_OCOTP_CTRL_MASK; ?

[Alison Wang] Yes. I will change. Thanks.

Best Regards,
Alison Wang

#4 lore raw

PATCH v3 1/6 arm: mvf600: Add Vybrid MVF600 CPU support

In reply to Alison Wang

Hi Alison,

Quoted 37 lines · Alison Wang

This patch adds generic codes to support Freescale's Vybrid MVF600 CPU.

It aligns Vybrid MVF600 platform with i.MX platform. As there are some differences between MVF600 and i.MX platforms, the specific codes are in the arch/arm/cpu/armv7/mvf600 directory.

---
Changes in v3:
- Rename the common functions and enums
- Move the structure definitions to imx-regs.h

Changes in v2:
- Remove vybrid-common directory
- Rename directory name 'vybrid' to 'mvf600'
- Add generic.c file
- Rewrite get_reset_cause() to make it readable
- Remove reset_cpu(), and use the function in imx_watchdog.c
- Rewrite timer.c file
- Use vybrid_get_clock(VYBRID_UART_CLK) instead of vybrid_get_uartclk()
- Remove lowlevel_init.S, and add clock_init() in board_early_init_f()
- Remove useless CONFIG_SYS_ defines
- Move CONFIG_MACH_TYPE to board configuration file
- Define C structures and access C structures to set/read registers
- Remove useless errata
- Remove useless macros
- Rename directory 'arch-vybrid' to 'arch-mvf600'

 Makefile                                    |   2 +-
 arch/arm/cpu/armv7/mvf600/Makefile          |  42 +++
 arch/arm/cpu/armv7/mvf600/generic.c         | 324 ++++++++++++++++++++++
 arch/arm/cpu/armv7/mvf600/timer.c           | 103 +++++++
 arch/arm/include/asm/arch-mvf600/clock.h    |  39 +++
 arch/arm/include/asm/arch-mvf600/crm_regs.h | 225 +++++++++++++++
 arch/arm/include/asm/arch-mvf600/imx-regs.h | 411
 ++++++++++++++++++++++++++++
 arch/arm/include/asm/arch-mvf600/mvf_pins.h |  92 +++++++
Quoted 8 lines
 8 files changed, 1237 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/cpu/armv7/mvf600/Makefile
 create mode 100644 arch/arm/cpu/armv7/mvf600/generic.c
 create mode 100644 arch/arm/cpu/armv7/mvf600/timer.c
 create mode 100644 arch/arm/include/asm/arch-mvf600/clock.h
 create mode 100644 arch/arm/include/asm/arch-mvf600/crm_regs.h
 create mode 100644 arch/arm/include/asm/arch-mvf600/imx-regs.h
 create mode 100644 arch/arm/include/asm/arch-mvf600/mvf_pins.h

[...]

Since this includes support for OCOTP on this SoC, the following hunks should also be added:

doc/README.mxc_ocotp:
---
on MXC

This IP can be found on the following SoCs:
+ - Vybrid MVF600,
- i.MX6.

Note that this IP is different from albeit similar to the IPs of the same name
---

doc/README.mvf600:
---
+U-Boot for Freescale Vybrid MVF600
+
+This file contains information for the port of U-Boot to the Freescale Vybrid +MVF600 SoC.
+
+1. CONVENTIONS FOR FUSE ASSIGNMENTS
+-----------------------------------
+
+1.1 MAC Address: It is stored in fuse bank 4, with the 16 msbs in word 2 and the
+ 32 lsbs in word 3.
---

You can also add the definition of the fuses for UID if any, like uid_low/high in struct fuse_bank0_regs in arch/arm/include/asm/arch-mx6/imx-regs.h.

Best regards,
Beno?t

#5 lore raw

PATCH v3 1/6 arm: mvf600: Add Vybrid MVF600 CPU support

Hi, Benoit,

Quoted 37 lines · Alison Wang

This patch adds generic codes to support Freescale's Vybrid MVF600 CPU.

It aligns Vybrid MVF600 platform with i.MX platform. As there are some differences between MVF600 and i.MX platforms, the specific codes are in the arch/arm/cpu/armv7/mvf600 directory.

---
Changes in v3:
- Rename the common functions and enums
- Move the structure definitions to imx-regs.h

Changes in v2:
- Remove vybrid-common directory
- Rename directory name 'vybrid' to 'mvf600'
- Add generic.c file
- Rewrite get_reset_cause() to make it readable
- Remove reset_cpu(), and use the function in imx_watchdog.c
- Rewrite timer.c file
- Use vybrid_get_clock(VYBRID_UART_CLK) instead of vybrid_get_uartclk()
- Remove lowlevel_init.S, and add clock_init() in board_early_init_f()
- Remove useless CONFIG_SYS_ defines
- Move CONFIG_MACH_TYPE to board configuration file
- Define C structures and access C structures to set/read registers
- Remove useless errata
- Remove useless macros
- Rename directory 'arch-vybrid' to 'arch-mvf600'

 Makefile                                    |   2 +-
 arch/arm/cpu/armv7/mvf600/Makefile          |  42 +++
 arch/arm/cpu/armv7/mvf600/generic.c         | 324 ++++++++++++++++++++++
 arch/arm/cpu/armv7/mvf600/timer.c           | 103 +++++++
 arch/arm/include/asm/arch-mvf600/clock.h    |  39 +++
 arch/arm/include/asm/arch-mvf600/crm_regs.h | 225 +++++++++++++++
 arch/arm/include/asm/arch-mvf600/imx-regs.h | 411
 ++++++++++++++++++++++++++++
 arch/arm/include/asm/arch-mvf600/mvf_pins.h |  92 +++++++
Quoted 8 lines
 8 files changed, 1237 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/cpu/armv7/mvf600/Makefile
 create mode 100644 arch/arm/cpu/armv7/mvf600/generic.c
 create mode 100644 arch/arm/cpu/armv7/mvf600/timer.c
 create mode 100644 arch/arm/include/asm/arch-mvf600/clock.h
 create mode 100644 arch/arm/include/asm/arch-mvf600/crm_regs.h
 create mode 100644 arch/arm/include/asm/arch-mvf600/imx-regs.h
 create mode 100644 arch/arm/include/asm/arch-mvf600/mvf_pins.h

[...]

Since this includes support for OCOTP on this SoC, the following hunks should also be added:

doc/README.mxc_ocotp:
---
on MXC

This IP can be found on the following SoCs:
+ - Vybrid MVF600,
- i.MX6.

Note that this IP is different from albeit similar to the IPs of the same name
---

doc/README.mvf600:
---
+U-Boot for Freescale Vybrid MVF600
+
+This file contains information for the port of U-Boot to the Freescale Vybrid +MVF600 SoC.
+
+1. CONVENTIONS FOR FUSE ASSIGNMENTS
+-----------------------------------
+
+1.1 MAC Address: It is stored in fuse bank 4, with the 16 msbs in word 2 and the
+ 32 lsbs in word 3.
---

You can also add the definition of the fuses for UID if any, like uid_low/high in struct fuse_bank0_regs in arch/arm/include/asm/arch-mx6/imx-regs.h.

[Alison Wang] OK. I will add them. Thanks.

Best regards,
Alison Wang

#6 lore raw

PATCH v3 1/6 arm: mvf600: Add Vybrid MVF600 CPU support

In reply to Alison Wang

Hi Alison,

On Tuesday, May 21, 2013 11:02:56 AM, Alison Wang wrote:

[...]

Quoted 112 lines
arch/arm/include/asm/arch-mvf600/mvf_pins.h new file +31 -0
new file mode 100644
index 0000000..0fd89af
@@ -0,0 +1,92 @@
+/*
+ * Copyright 2013 Freescale Semiconductor, Inc.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#ifndef __ASM_ARCH_MVF_PINS_H__
+#define __ASM_ARCH_MVF_PINS_H__
+
+#include <asm/imx-common/iomux-v3.h>
+
+enum {
+	MVF600_PAD_PTA6__RMII0_CLKIN		= IOMUX_PAD(0x0000, 0x0000, 2, 0x0000, 0, 0),
+	MVF600_PAD_PTB4__UART1_TX		= IOMUX_PAD(0x0068, 0x0068, 2, 0x0380, 0, 0),
+	MVF600_PAD_PTB5__UART1_RX		= IOMUX_PAD(0x006C, 0x006C, 2, 0x037C, 0, 0),
+	MVF600_PAD_PTC1__RMII0_MDIO		= IOMUX_PAD(0x00B8, 0x00B8, 1, 0x0000, 0, 0),
+	MVF600_PAD_PTC0__RMII0_MDC		= IOMUX_PAD(0x00B4, 0x00B4, 1, 0x0000, 0, 0),
+	MVF600_PAD_PTC2__RMII0_CRS_DV		= IOMUX_PAD(0x00BC, 0x00BC, 1, 0x0000, 0,

0),

arch/arm/include/asm/arch-mvf600/mvf_pins.h new file +9 -0
+	MVF600_PAD_PTC3__RMII0_RD1		= IOMUX_PAD(0x00C0, 0x00C0, 1, 0x0000, 0, 0),
+	MVF600_PAD_PTC4__RMII0_RD0		= IOMUX_PAD(0x00C4, 0x00C4, 1, 0x0000, 0, 0),
+	MVF600_PAD_PTC5__RMII0_RXER		= IOMUX_PAD(0x00C8, 0x00C8, 1, 0x0000, 0, 0),
+	MVF600_PAD_PTC6__RMII0_TD1		= IOMUX_PAD(0x00CC, 0x00CC, 1, 0x0000, 0, 0),
+	MVF600_PAD_PTC7__RMII0_TD0		= IOMUX_PAD(0x00D0, 0x00D0, 1, 0x0000, 0, 0),
+	MVF600_PAD_PTC8__RMII0_TXEN		= IOMUX_PAD(0x00D4, 0x00D4, 1, 0x0000, 0, 0),
+	MVF600_PAD_PTA24__ESDHC1_CLK		= IOMUX_PAD(0x0038, 0x0038, 5, 0x0000, 0, 0),
+	MVF600_PAD_PTA25__ESDHC1_CMD		= IOMUX_PAD(0x003C, 0x003C, 5, 0x0000, 0, 0),
+	MVF600_PAD_PTA26__ESDHC1_DAT0		= IOMUX_PAD(0x0040, 0x0040, 5, 0x0000, 0,

0),

arch/arm/include/asm/arch-mvf600/mvf_pins.h new file +1 -0
+	MVF600_PAD_PTA27__ESDHC1_DAT1		= IOMUX_PAD(0x0044, 0x0044, 5, 0x0000, 0,

0),

arch/arm/include/asm/arch-mvf600/mvf_pins.h new file +1 -0
+	MVF600_PAD_PTA28__ESDHC1_DAT2		= IOMUX_PAD(0x0048, 0x0048, 5, 0x0000, 0,

0),

arch/arm/include/asm/arch-mvf600/mvf_pins.h new file +1 -0
+	MVF600_PAD_PTA29__ESDHC1_DAT3		= IOMUX_PAD(0x004C, 0x004C, 5, 0x0000, 0,

0),

arch/arm/include/asm/arch-mvf600/mvf_pins.h new file +19 -0
+	MVF600_PAD_DDR_A15__DDR_A_15		= IOMUX_PAD(0x0220, 0x0220, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_A14__DDR_A_14		= IOMUX_PAD(0x0224, 0x0224, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_A13__DDR_A_13		= IOMUX_PAD(0x0228, 0x0228, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_A12__DDR_A_12		= IOMUX_PAD(0x022c, 0x022c, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_A11__DDR_A_11		= IOMUX_PAD(0x0230, 0x0230, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_A10__DDR_A_10		= IOMUX_PAD(0x0234, 0x0234, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_A9__DDR_A_9		= IOMUX_PAD(0x0238, 0x0238, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_A8__DDR_A_8		= IOMUX_PAD(0x023c, 0x023c, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_A7__DDR_A_7		= IOMUX_PAD(0x0240, 0x0240, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_A6__DDR_A_6		= IOMUX_PAD(0x0244, 0x0244, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_A5__DDR_A_5		= IOMUX_PAD(0x0248, 0x0248, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_A4__DDR_A_4		= IOMUX_PAD(0x024c, 0x024c, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_A3__DDR_A_3		= IOMUX_PAD(0x0250, 0x0250, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_A2__DDR_A_2		= IOMUX_PAD(0x0254, 0x0254, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_A1__DDR_A_1		= IOMUX_PAD(0x0258, 0x0258, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_BA2__DDR_BA_2		= IOMUX_PAD(0x0260, 0x0260, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_BA1__DDR_BA_1		= IOMUX_PAD(0x0264, 0x0264, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_BA0__DDR_BA_0		= IOMUX_PAD(0x0268, 0x0268, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_CAS__DDR_CAS_B		= IOMUX_PAD(0x026c, 0x026c, 0, 0x0000, 0,

0),

arch/arm/include/asm/arch-mvf600/mvf_pins.h new file +1 -0
+	MVF600_PAD_DDR_CKE__DDR_CKE_0		= IOMUX_PAD(0x0270, 0x0270, 0, 0x0000, 0,

0),

arch/arm/include/asm/arch-mvf600/mvf_pins.h new file +1 -0
+	MVF600_PAD_DDR_CLK__DDR_CLK_0		= IOMUX_PAD(0x0274, 0x0274, 0, 0x0000, 0,

0),

arch/arm/include/asm/arch-mvf600/mvf_pins.h new file +1 -0
+	MVF600_PAD_DDR_CS__DDR_CS_B_0		= IOMUX_PAD(0x0278, 0x0278, 0, 0x0000, 0,

0),

arch/arm/include/asm/arch-mvf600/mvf_pins.h new file +17 -0
+	MVF600_PAD_DDR_D15__DDR_D_15		= IOMUX_PAD(0x027c, 0x027c, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_D14__DDR_D_14		= IOMUX_PAD(0x0280, 0x0280, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_D13__DDR_D_13		= IOMUX_PAD(0x0284, 0x0284, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_D12__DDR_D_12		= IOMUX_PAD(0x0288, 0x0288, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_D11__DDR_D_11		= IOMUX_PAD(0x028c, 0x028c, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_D10__DDR_D_10		= IOMUX_PAD(0x0290, 0x0290, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_D9__DDR_D_9		= IOMUX_PAD(0x0294, 0x0294, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_D8__DDR_D_8		= IOMUX_PAD(0x0298, 0x0298, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_D7__DDR_D_7		= IOMUX_PAD(0x029c, 0x029c, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_D6__DDR_D_6		= IOMUX_PAD(0x02a0, 0x02a0, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_D5__DDR_D_5		= IOMUX_PAD(0x02a4, 0x02a4, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_D4__DDR_D_4		= IOMUX_PAD(0x02a8, 0x02a8, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_D3__DDR_D_3		= IOMUX_PAD(0x02ac, 0x02ac, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_D2__DDR_D_2		= IOMUX_PAD(0x02b0, 0x02b0, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_D1__DDR_D_1		= IOMUX_PAD(0x02b4, 0x02b4, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_D0__DDR_D_0		= IOMUX_PAD(0x02b8, 0x02b8, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_DQM1__DDR_DQM_1		= IOMUX_PAD(0x02bc, 0x02bc, 0, 0x0000, 0,

0),

arch/arm/include/asm/arch-mvf600/mvf_pins.h new file +1 -0
+	MVF600_PAD_DDR_DQM0__DDR_DQM_0		= IOMUX_PAD(0x02c0, 0x02c0, 0, 0x0000, 0,

0),

arch/arm/include/asm/arch-mvf600/mvf_pins.h new file +1 -0
+	MVF600_PAD_DDR_DQS1__DDR_DQS_1		= IOMUX_PAD(0x02c4, 0x02c4, 0, 0x0000, 0,

0),

arch/arm/include/asm/arch-mvf600/mvf_pins.h new file +1 -0
+	MVF600_PAD_DDR_DQS0__DDR_DQS_0		= IOMUX_PAD(0x02c8, 0x02c8, 0, 0x0000, 0,

0),

arch/arm/include/asm/arch-mvf600/mvf_pins.h new file +1 -0
+	MVF600_PAD_DDR_RAS__DDR_RAS_B		= IOMUX_PAD(0x02cc, 0x02cc, 0, 0x0000, 0,

0),

arch/arm/include/asm/arch-mvf600/mvf_pins.h new file +2 -0
+	MVF600_PAD_DDR_WE__DDR_WE_B		= IOMUX_PAD(0x02d0, 0x02d0, 0, 0x0000, 0, 0),
+	MVF600_PAD_DDR_ODT1__DDR_ODT_0		= IOMUX_PAD(0x02d4, 0x02d4, 0, 0x0000, 0,

0),

arch/arm/include/asm/arch-mvf600/mvf_pins.h new file +1 -0
+	MVF600_PAD_DDR_ODT0__DDR_ODT_1		= IOMUX_PAD(0x02d8, 0x02d8, 0, 0x0000, 0,

0),

arch/arm/include/asm/arch-mvf600/mvf_pins.h line 92

Quoted 3 lines
arch/arm/include/asm/arch-mvf600/mvf_pins.h new file +3 -0
+};
+
+#endif	/* __ASM_ARCH_MVF_PINS_H__ */

These definitions won't work as expected without your "[PATCH v3 2/6] arm:
mvf600: Add IOMUX support for Vybrid MVF600", so 1/6 and 2/6 should probably be swapped because of this dependency.

Best regards,
Beno?t

#7 lore raw

PATCH v3 1/6 arm: mvf600: Add Vybrid MVF600 CPU support

Hi, Benoit,

On Tuesday, May 21, 2013 11:02:56 AM, Alison Wang wrote:

[...]

Quoted 112 lines
arch/arm/include/asm/arch-mvf600/mvf_pins.h new file +31 -0
new file mode 100644
index 0000000..0fd89af
@@ -0,0 +1,92 @@
+/*
+ * Copyright 2013 Freescale Semiconductor, Inc.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#ifndef __ASM_ARCH_MVF_PINS_H__
+#define __ASM_ARCH_MVF_PINS_H__
+
+#include <asm/imx-common/iomux-v3.h>
+
+enum {
+     MVF600_PAD_PTA6__RMII0_CLKIN            = IOMUX_PAD(0x0000, 0x0000, 2, 0x0000, 0, 0),
+     MVF600_PAD_PTB4__UART1_TX               = IOMUX_PAD(0x0068, 0x0068, 2, 0x0380, 0, 0),
+     MVF600_PAD_PTB5__UART1_RX               = IOMUX_PAD(0x006C, 0x006C, 2, 0x037C, 0, 0),
+     MVF600_PAD_PTC1__RMII0_MDIO             = IOMUX_PAD(0x00B8, 0x00B8, 1, 0x0000, 0, 0),
+     MVF600_PAD_PTC0__RMII0_MDC              = IOMUX_PAD(0x00B4, 0x00B4, 1, 0x0000, 0, 0),
+     MVF600_PAD_PTC2__RMII0_CRS_DV           = IOMUX_PAD(0x00BC, 0x00BC, 1, 0x0000, 0,

0),

arch/arm/include/asm/arch-mvf600/mvf_pins.h new file +9 -0
+     MVF600_PAD_PTC3__RMII0_RD1              = IOMUX_PAD(0x00C0, 0x00C0, 1, 0x0000, 0, 0),
+     MVF600_PAD_PTC4__RMII0_RD0              = IOMUX_PAD(0x00C4, 0x00C4, 1, 0x0000, 0, 0),
+     MVF600_PAD_PTC5__RMII0_RXER             = IOMUX_PAD(0x00C8, 0x00C8, 1, 0x0000, 0, 0),
+     MVF600_PAD_PTC6__RMII0_TD1              = IOMUX_PAD(0x00CC, 0x00CC, 1, 0x0000, 0, 0),
+     MVF600_PAD_PTC7__RMII0_TD0              = IOMUX_PAD(0x00D0, 0x00D0, 1, 0x0000, 0, 0),
+     MVF600_PAD_PTC8__RMII0_TXEN             = IOMUX_PAD(0x00D4, 0x00D4, 1, 0x0000, 0, 0),
+     MVF600_PAD_PTA24__ESDHC1_CLK            = IOMUX_PAD(0x0038, 0x0038, 5, 0x0000, 0, 0),
+     MVF600_PAD_PTA25__ESDHC1_CMD            = IOMUX_PAD(0x003C, 0x003C, 5, 0x0000, 0, 0),
+     MVF600_PAD_PTA26__ESDHC1_DAT0           = IOMUX_PAD(0x0040, 0x0040, 5, 0x0000, 0,

0),
+ MVF600_PAD_PTA27__ESDHC1_DAT1 = IOMUX_PAD(0x0044, 0x0044, 5, 0x0000, 0,
0),
+ MVF600_PAD_PTA28__ESDHC1_DAT2 = IOMUX_PAD(0x0048, 0x0048, 5, 0x0000, 0,
0),
+ MVF600_PAD_PTA29__ESDHC1_DAT3 = IOMUX_PAD(0x004C, 0x004C, 5, 0x0000, 0,
0),

arch/arm/include/asm/arch-mvf600/mvf_pins.h new file +19 -0
+     MVF600_PAD_DDR_A15__DDR_A_15            = IOMUX_PAD(0x0220, 0x0220, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_A14__DDR_A_14            = IOMUX_PAD(0x0224, 0x0224, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_A13__DDR_A_13            = IOMUX_PAD(0x0228, 0x0228, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_A12__DDR_A_12            = IOMUX_PAD(0x022c, 0x022c, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_A11__DDR_A_11            = IOMUX_PAD(0x0230, 0x0230, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_A10__DDR_A_10            = IOMUX_PAD(0x0234, 0x0234, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_A9__DDR_A_9              = IOMUX_PAD(0x0238, 0x0238, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_A8__DDR_A_8              = IOMUX_PAD(0x023c, 0x023c, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_A7__DDR_A_7              = IOMUX_PAD(0x0240, 0x0240, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_A6__DDR_A_6              = IOMUX_PAD(0x0244, 0x0244, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_A5__DDR_A_5              = IOMUX_PAD(0x0248, 0x0248, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_A4__DDR_A_4              = IOMUX_PAD(0x024c, 0x024c, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_A3__DDR_A_3              = IOMUX_PAD(0x0250, 0x0250, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_A2__DDR_A_2              = IOMUX_PAD(0x0254, 0x0254, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_A1__DDR_A_1              = IOMUX_PAD(0x0258, 0x0258, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_BA2__DDR_BA_2            = IOMUX_PAD(0x0260, 0x0260, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_BA1__DDR_BA_1            = IOMUX_PAD(0x0264, 0x0264, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_BA0__DDR_BA_0            = IOMUX_PAD(0x0268, 0x0268, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_CAS__DDR_CAS_B           = IOMUX_PAD(0x026c, 0x026c, 0, 0x0000, 0,

0),
+ MVF600_PAD_DDR_CKE__DDR_CKE_0 = IOMUX_PAD(0x0270, 0x0270, 0, 0x0000, 0,
0),
+ MVF600_PAD_DDR_CLK__DDR_CLK_0 = IOMUX_PAD(0x0274, 0x0274, 0, 0x0000, 0,
0),
+ MVF600_PAD_DDR_CS__DDR_CS_B_0 = IOMUX_PAD(0x0278, 0x0278, 0, 0x0000, 0,
0),

arch/arm/include/asm/arch-mvf600/mvf_pins.h new file +17 -0
+     MVF600_PAD_DDR_D15__DDR_D_15            = IOMUX_PAD(0x027c, 0x027c, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_D14__DDR_D_14            = IOMUX_PAD(0x0280, 0x0280, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_D13__DDR_D_13            = IOMUX_PAD(0x0284, 0x0284, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_D12__DDR_D_12            = IOMUX_PAD(0x0288, 0x0288, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_D11__DDR_D_11            = IOMUX_PAD(0x028c, 0x028c, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_D10__DDR_D_10            = IOMUX_PAD(0x0290, 0x0290, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_D9__DDR_D_9              = IOMUX_PAD(0x0294, 0x0294, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_D8__DDR_D_8              = IOMUX_PAD(0x0298, 0x0298, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_D7__DDR_D_7              = IOMUX_PAD(0x029c, 0x029c, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_D6__DDR_D_6              = IOMUX_PAD(0x02a0, 0x02a0, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_D5__DDR_D_5              = IOMUX_PAD(0x02a4, 0x02a4, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_D4__DDR_D_4              = IOMUX_PAD(0x02a8, 0x02a8, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_D3__DDR_D_3              = IOMUX_PAD(0x02ac, 0x02ac, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_D2__DDR_D_2              = IOMUX_PAD(0x02b0, 0x02b0, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_D1__DDR_D_1              = IOMUX_PAD(0x02b4, 0x02b4, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_D0__DDR_D_0              = IOMUX_PAD(0x02b8, 0x02b8, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_DQM1__DDR_DQM_1          = IOMUX_PAD(0x02bc, 0x02bc, 0, 0x0000, 0,

0),
+ MVF600_PAD_DDR_DQM0__DDR_DQM_0 = IOMUX_PAD(0x02c0, 0x02c0, 0, 0x0000, 0,
0),
+ MVF600_PAD_DDR_DQS1__DDR_DQS_1 = IOMUX_PAD(0x02c4, 0x02c4, 0, 0x0000, 0,
0),
+ MVF600_PAD_DDR_DQS0__DDR_DQS_0 = IOMUX_PAD(0x02c8, 0x02c8, 0, 0x0000, 0,
0),
+ MVF600_PAD_DDR_RAS__DDR_RAS_B = IOMUX_PAD(0x02cc, 0x02cc, 0, 0x0000, 0,
0),

arch/arm/include/asm/arch-mvf600/mvf_pins.h new file +2 -0
+     MVF600_PAD_DDR_WE__DDR_WE_B             = IOMUX_PAD(0x02d0, 0x02d0, 0, 0x0000, 0, 0),
+     MVF600_PAD_DDR_ODT1__DDR_ODT_0          = IOMUX_PAD(0x02d4, 0x02d4, 0, 0x0000, 0,

0),
+ MVF600_PAD_DDR_ODT0__DDR_ODT_1 = IOMUX_PAD(0x02d8, 0x02d8, 0, 0x0000, 0,
0),

arch/arm/include/asm/arch-mvf600/mvf_pins.h line 92

Quoted 3 lines
arch/arm/include/asm/arch-mvf600/mvf_pins.h new file +3 -0
+};
+
+#endif       /* __ASM_ARCH_MVF_PINS_H__ */

These definitions won't work as expected without your "[PATCH v3 2/6] arm:
mvf600: Add IOMUX support for Vybrid MVF600", so 1/6 and 2/6 should probably be swapped because of this dependency.
[Alison Wang] You are right. I will swap them. Thanks.

Best regards,
Alison Wang

#8 lore raw

PATCH v3 2/6 arm: mvf600: Add IOMUX support for Vybrid MVF600

In reply to Alison Wang

This patch adds the IOMUX support for Vybrid MVF600 platform.

There is a little difference for IOMUXC module between MVF600 and i.MX platform, the muxmode and pad configuration share one 32bit register on MVF600, but they are two independent registers on I.MX platform. A CONFIG_IOMUX_SHARE_CONFIG_REG was introduced to fit this difference.

---
Changes in v3:
- Define PAD_CTL_PUE with PKE enabled

Changes in v2:
- Use common iomux-v3 code

 arch/arm/imx-common/Makefile               |  2 +-
 arch/arm/imx-common/iomux-v3.c             |  6 ++++++
 arch/arm/include/asm/imx-common/iomux-v3.h | 18 ++++++++++++++++++
 3 files changed, 25 insertions(+), 1 deletion(-)
arch/arm/imx-common/Makefile +1 -1
index 8bba8a5..3378931 100644
@@ -27,7 +27,7 @@ include $(TOPDIR)/config.mk
 
 LIB     = $(obj)libimx-common.o
 
-ifeq ($(SOC),$(filter $(SOC),mx25 mx35 mx5 mx6))
+ifeq ($(SOC),$(filter $(SOC),mx25 mx35 mx5 mx6 mvf600))
 COBJS-y	= iomux-v3.o
 endif
 ifeq ($(SOC),$(filter $(SOC),mx5 mx6))
arch/arm/imx-common/iomux-v3.c +6 -0
index 7fe5ce7..35880c7 100644
@@ -48,8 +48,14 @@ void imx_iomux_v3_setup_pad(iomux_v3_cfg_t pad)
 	if (sel_input_ofs)
 		__raw_writel(sel_input, base + sel_input_ofs);
 
+#ifdef CONFIG_IOMUX_SHARE_CONF_REG
+	if (!(pad_ctrl & NO_PAD_CTRL))
+		__raw_writel((mux_mode << PAD_MUX_MODE_SHIFT) | pad_ctrl,
+			base + pad_ctrl_ofs);
+#else
 	if (!(pad_ctrl & NO_PAD_CTRL) && pad_ctrl_ofs)
 		__raw_writel(pad_ctrl, base + pad_ctrl_ofs);
+#endif
 }
 
 void imx_iomux_v3_setup_multiple_pads(iomux_v3_cfg_t const *pad_list,
arch/arm/include/asm/imx-common/iomux-v3.h +18 -0
index 0b4e763..012d66a 100644
@@ -121,6 +121,24 @@ typedef u64 iomux_v3_cfg_t;
 #define PAD_CTL_DSE_40ohm	(6 << 3)
 #define PAD_CTL_DSE_34ohm	(7 << 3)
 
+#elif defined(CONFIG_MVF600)
+
+#define PAD_MUX_MODE_SHIFT	20
+
+#define	PAD_CTL_PUS_47K_UP	(1 << 4)
+#define	PAD_CTL_PUS_100K_UP	(2 << 4)
+#define PAD_CTL_PUE		(1 << 2 | PAD_CTL_PKE)
+#define	PAD_CTL_PKE		(1 << 3)
+
+#define PAD_CTL_SPEED_HIGH	(3 << 12)
+#define PAD_CTL_SPEED_MED	(1 << 12)
+
+#define PAD_CTL_DSE_20ohm	(7 << 6)
+#define PAD_CTL_DSE_25ohm	(6 << 6)
+#define PAD_CTL_DSE_50ohm	(3 << 6)
+
+#define PAD_CTL_OBE_IBE_ENABLE	(3 << 0)
+
 #else
 
 #define PAD_CTL_DVS		(1 << 13)
Signature · 1 line
1.8.0
#9 lore raw

PATCH v3 2/6 arm: mvf600: Add IOMUX support for Vybrid MVF600

Hi Alison,

Quoted 58 lines · Alison Wang

This patch adds the IOMUX support for Vybrid MVF600 platform.

There is a little difference for IOMUXC module between MVF600 and i.MX platform, the muxmode and pad configuration share one 32bit register on MVF600, but they are two independent registers on I.MX platform. A CONFIG_IOMUX_SHARE_CONFIG_REG was introduced to fit this difference.

---
Changes in v3:
- Define PAD_CTL_PUE with PKE enabled

Changes in v2:
- Use common iomux-v3 code

 arch/arm/imx-common/Makefile               |  2 +-
 arch/arm/imx-common/iomux-v3.c             |  6 ++++++
 arch/arm/include/asm/imx-common/iomux-v3.h | 18 ++++++++++++++++++
 3 files changed, 25 insertions(+), 1 deletion(-)
arch/arm/imx-common/Makefile +1 -1
index 8bba8a5..3378931 100644
@@ -27,7 +27,7 @@ include $(TOPDIR)/config.mk
 
 LIB     = $(obj)libimx-common.o
 
-ifeq ($(SOC),$(filter $(SOC),mx25 mx35 mx5 mx6))
+ifeq ($(SOC),$(filter $(SOC),mx25 mx35 mx5 mx6 mvf600))
 COBJS-y	= iomux-v3.o
 endif
 ifeq ($(SOC),$(filter $(SOC),mx5 mx6))
arch/arm/imx-common/iomux-v3.c +6 -0
index 7fe5ce7..35880c7 100644
@@ -48,8 +48,14 @@ void imx_iomux_v3_setup_pad(iomux_v3_cfg_t pad)
 	if (sel_input_ofs)
 		__raw_writel(sel_input, base + sel_input_ofs);
 
+#ifdef CONFIG_IOMUX_SHARE_CONF_REG
+	if (!(pad_ctrl & NO_PAD_CTRL))
+		__raw_writel((mux_mode << PAD_MUX_MODE_SHIFT) | pad_ctrl,
+			base + pad_ctrl_ofs);
+#else
 	if (!(pad_ctrl & NO_PAD_CTRL) && pad_ctrl_ofs)
 		__raw_writel(pad_ctrl, base + pad_ctrl_ofs);
+#endif
 }
 
 void imx_iomux_v3_setup_multiple_pads(iomux_v3_cfg_t const *pad_list,
arch/arm/include/asm/imx-common/iomux-v3.h +0 -0
index 0b4e763..012d66a 100644

arch/arm/include/asm/imx-common/iomux-v3.h typedef u64 iomux_v3_cfg_t; · line 129

Quoted 9 lines
arch/arm/include/asm/imx-common/iomux-v3.h +6 -0
@@ -121,6 +121,24 @@ typedef u64 iomux_v3_cfg_t;
 #define PAD_CTL_DSE_40ohm	(6 << 3)
 #define PAD_CTL_DSE_34ohm	(7 << 3)
 
+#elif defined(CONFIG_MVF600)
+
+#define PAD_MUX_MODE_SHIFT	20
+
+#define	PAD_CTL_PUS_47K_UP	(1 << 4)
+#define	PAD_CTL_PUS_100K_UP	(2 << 4)

PAD_CTL_PUE should be bitwise-OR-ed to the two values above to make it easy to use, just like you added PAD_CTL_PKE to PAD_CTL_PUE below.

arch/arm/include/asm/imx-common/iomux-v3.h typedef u64 iomux_v3_cfg_t; · line 140

Quoted 11 lines
arch/arm/include/asm/imx-common/iomux-v3.h +11 -0
+#define PAD_CTL_PUE		(1 << 2 | PAD_CTL_PKE)
+#define	PAD_CTL_PKE		(1 << 3)
+
+#define PAD_CTL_SPEED_HIGH	(3 << 12)
+#define PAD_CTL_SPEED_MED	(1 << 12)
+
+#define PAD_CTL_DSE_20ohm	(7 << 6)
+#define PAD_CTL_DSE_25ohm	(6 << 6)
+#define PAD_CTL_DSE_50ohm	(3 << 6)
+
+#define PAD_CTL_OBE_IBE_ENABLE	(3 << 0)

Please organize those definitions by decreasing offset value and increasing value in order to follow the reference manual order for easier review:
PAD_MUX_MODE_SHIFT, then PAD_CTL_SPEED_MED, PAD_CTL_SPEED_HIGH, PAD_CTL_DSE_50ohm, PAD_CTL_DSE_25ohm, PAD_CTL_DSE_20ohm, PAD_CTL_PUS_47K_UP, PAD_CTL_PUS_100K_UP, PAD_CTL_PKE, PAD_CTL_PUE, and PAD_CTL_OBE_IBE_ENABLE.

Also, the spaces/tabs are still not correct in those definitions. They should be:
#define<1 space>NAME<1 or more tabs to align column>value

arch/arm/include/asm/imx-common/iomux-v3.h typedef u64 iomux_v3_cfg_t; · line 144

Quoted 4 lines
arch/arm/include/asm/imx-common/iomux-v3.h +1 -0
+
 #else
 
 #define PAD_CTL_DVS		(1 << 13)

Best regards,
Beno?t

#10 lore raw

PATCH v3 3/6 net: fec_mxc: Add support for Vybrid MVF600

In reply to Alison Wang

This patch adds FEC support for Vybrid MVF600 platform.

In function fec_open(), RCR register is only set as RGMII mode. But RCR register should be set as RMII mode for MVF600 platform. This configuration is already done in fec_reg_setup(), so this piece of code could just leave untouched the FEC_RCNTRL_RGMII / FEC_RCNTRL_RMII / FEC_RCNTRL_MII_MODE bits.

---
Changes in v3:
- Remove the changes for FEC_RCNTRL_RGMII / FEC_RCNTRL_RMII / FEC_RCNTRL_MII_MODE bits, as they are already set in fec_reg_setup()

Changes in v2:
- Use common FEC driver fec_mxc.c

 drivers/net/fec_mxc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/net/fec_mxc.c +1 -3
index 4dbcdca..da95e28 100644
@@ -516,9 +516,7 @@ static int fec_open(struct eth_device *edev)
 #ifdef FEC_QUIRK_ENET_MAC
 	{
 		u32 ecr = readl(&fec->eth->ecntrl) & ~FEC_ECNTRL_SPEED;
-		u32 rcr = (readl(&fec->eth->r_cntrl) &
-				~(FEC_RCNTRL_RMII | FEC_RCNTRL_RMII_10T)) |
-				FEC_RCNTRL_RGMII | FEC_RCNTRL_MII_MODE;
+		u32 rcr = readl(&fec->eth->r_cntrl) & ~FEC_RCNTRL_RMII_10T;
 		if (speed == _1000BASET)
 			ecr |= FEC_ECNTRL_SPEED;
 		else if (speed != _100BASET)
Signature · 1 line
1.8.0
#11 lore raw

PATCH v3 3/6 net: fec_mxc: Add support for Vybrid MVF600

Hi Alison,

Quoted 25 lines · Alison Wang

This patch adds FEC support for Vybrid MVF600 platform.

In function fec_open(), RCR register is only set as RGMII mode. But RCR register should be set as RMII mode for MVF600 platform. This configuration is already done in fec_reg_setup(), so this piece of code could just leave untouched the FEC_RCNTRL_RGMII / FEC_RCNTRL_RMII / FEC_RCNTRL_MII_MODE bits.

---
Changes in v3:
- Remove the changes for FEC_RCNTRL_RGMII / FEC_RCNTRL_RMII / FEC_RCNTRL_MII_MODE bits, as they are already set in fec_reg_setup()

Changes in v2:
- Use common FEC driver fec_mxc.c

 drivers/net/fec_mxc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/net/fec_mxc.c +0 -0
index 4dbcdca..da95e28 100644

drivers/net/fec_mxc.c static int fec_open(struct eth_device *edev) · line 522

Quoted 10 lines
drivers/net/fec_mxc.c +1 -3
@@ -516,9 +516,7 @@ static int fec_open(struct eth_device *edev)
 #ifdef FEC_QUIRK_ENET_MAC
 	{
 		u32 ecr = readl(&fec->eth->ecntrl) & ~FEC_ECNTRL_SPEED;
-		u32 rcr = (readl(&fec->eth->r_cntrl) &
-				~(FEC_RCNTRL_RMII | FEC_RCNTRL_RMII_10T)) |
-				FEC_RCNTRL_RGMII | FEC_RCNTRL_MII_MODE;
+		u32 rcr = readl(&fec->eth->r_cntrl) & ~FEC_RCNTRL_RMII_10T;
 		if (speed == _1000BASET)
 			ecr |= FEC_ECNTRL_SPEED;
 		else if (speed != _100BASET)

Best regards,
Beno?t

#12 lore raw

PATCH v3 4/6 arm: mvf600: Add watchdog support for Vybrid MVF600

In reply to Alison Wang

This patch adds watchdog support for Vybrid MVF600 platform.

---
Changes in v3: None

Changes in v2:
- Add watchdog support
- Use reset_cpu() in imx_watchdog.c

 drivers/watchdog/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/Makefile +1 -1
index 13e7c37..40946df 100644
@@ -27,7 +27,7 @@ LIB	:= $(obj)libwatchdog.o
 
 COBJS-$(CONFIG_AT91SAM9_WATCHDOG) += at91sam9_wdt.o
 COBJS-$(CONFIG_FTWDT010_WATCHDOG) += ftwdt010_wdt.o
-ifneq (,$(filter $(SOC), mx31 mx35 mx5 mx6))
+ifneq (,$(filter $(SOC), mx31 mx35 mx5 mx6 mvf600))
 COBJS-y += imx_watchdog.o
 endif
 COBJS-$(CONFIG_TNETV107X_WATCHDOG) += tnetv107x_wdt.o
Signature · 1 line
1.8.0
#13 lore raw

PATCH v3 5/6 arm: mvf600: Add uart support for Vybrid MVF600

In reply to Alison Wang

This patch adds lpuart support for Vybrid MVF600 platform.

---
Changes in v3:
- Move the structure definition to imx-regs.h

Changes in v2:
- Define C structures and access C structures to set/read registers
- Change the names to reuse this driver on other platforms

 drivers/serial/Makefile        |   1 +
 drivers/serial/serial_lpuart.c | 132 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 133 insertions(+)
 create mode 100644 drivers/serial/serial_lpuart.c
drivers/serial/Makefile +1 -0
index fbc4e97..bb6559b 100644
@@ -52,6 +52,7 @@ COBJS-$(CONFIG_XILINX_UARTLITE) += serial_xuartlite.o
 COBJS-$(CONFIG_SANDBOX_SERIAL) += sandbox.o
 COBJS-$(CONFIG_SCIF_CONSOLE) += serial_sh.o
 COBJS-$(CONFIG_ZYNQ_SERIAL) += serial_zynq.o
+COBJS-$(CONFIG_FSL_LPUART) += serial_lpuart.o
 
 ifndef CONFIG_SPL_BUILD
 COBJS-$(CONFIG_USB_TTY) += usbtty.o
drivers/serial/serial_lpuart.c new file +132 -0

132 lines not on this page · raw message

Signature · 1 line
1.8.0
#14 lore raw

PATCH v3 6/6 arm: mvf600: Add basic support for Vybrid MVF600TWR board

In reply to Alison Wang

MVF600TWR is a board based on Vybrid MVF600 SoC.

This patch adds basic support for Vybrid MVF600TWR board.

---
Changes in v3:
- Replace BOOT_FROM by BOOT_OFFSET
- Enable CONFIG_OF_LIBFDT option
- Add useful define instead of raw number
- Use clrsetbits_le32 to set the single bits
- Move setup_iomux_enet() to board_early_init_f and remove board_eth_init()
- Remove redundant define
- Move CONFIG_IOMUX_SHARE_CONF_REG to imx-regs.h

Changes in v2:
- Add an entry to MAINTAINERS file
- Rename directory name 'vybird' to 'mvf600twr'
- Use standard method to set gd->ram_size
- Rewrite board_mmc_getcd() function
- Remove useless undef
- Remove hardcoded IP addresses and MAC addresses
- Remove useless CONFIG_SYS_ defines
- Define C structures and access C structures to set/read registers
- Move CONFIG_MACH_TYPE to board configuration file
- Use common iomux-v3 code

 MAINTAINERS                            |   4 +
 board/freescale/mvf600twr/Makefile     |  39 ++++
 board/freescale/mvf600twr/imximage.cfg |  33 +++
 board/freescale/mvf600twr/mvf600twr.c  | 413 +++++++++++++++++++++++++++++++++
 boards.cfg                             |   1 +
 include/configs/mvf600twr.h            | 140 +++++++++++
 6 files changed, 630 insertions(+)
 create mode 100644 board/freescale/mvf600twr/Makefile
 create mode 100644 board/freescale/mvf600twr/imximage.cfg
 create mode 100644 board/freescale/mvf600twr/mvf600twr.c
 create mode 100644 include/configs/mvf600twr.h
MAINTAINERS +4 -0
index c05433a..d32ac66 100644
@@ -1057,6 +1057,10 @@ Eric Nelson <[email protected]>
 	nitrogen6s		i.MX6S		512MB
 	nitrogen6s1g		i.MX6S		1GB
 
+Alison Wang <[email protected]>
+
+	mvf600twr	MVF600
+
 -------------------------------------------------------------------------
 
 Unknown / orphaned boards:
board/freescale/mvf600twr/Makefile new file +39 -0
new file mode 100644
index 0000000..7416228
@@ -0,0 +1,39 @@
+#
+# Copyright 2013 Freescale Semiconductor, Inc.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+include $(TOPDIR)/config.mk
+
+LIB	= $(obj)lib$(BOARD).o
+
+COBJS	:= $(BOARD).o
+
+SRCS	:= $(COBJS:.o=.c)
+OBJS	:= $(addprefix $(obj),$(COBJS))
+
+$(LIB):	$(obj).depend $(OBJS)
+	$(call cmd_link_o_target, $(OBJS))
+
+#########################################################################
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#########################################################################
board/freescale/mvf600twr/imximage.cfg new file +33 -0
new file mode 100644
index 0000000..b00d4c1
@@ -0,0 +1,33 @@
+/*
+ * Copyright 2013 Freescale Semiconductor, Inc.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not write to the Free Software
+ * Foundation Inc. 51 Franklin Street Fifth Floor Boston,
+ * MA 02110-1301 USA
+ *
+ * Refer docs/README.imxmage for more details about how-to configure
+ * and create imximage boot image
+ *
+ * The syntax is taken as close as possible with the kwbimage
+ */
+#include <asm/imx-common/imximage.cfg>
+
+/* image version */
+IMAGE_VERSION	2
+
+/* Boot Offset 0x400, valid for both SD and NAND boot */
+BOOT_OFFSET	FLASH_OFFSET_STANDARD
board/freescale/mvf600twr/mvf600twr.c new file +413 -0

413 lines not on this page · raw message

boards.cfg +1 -0
index 2f39f26..60c1920 100644
@@ -262,6 +262,7 @@ mx6qsabrelite                arm         armv7       mx6qsabrelite       freesca
 mx6qsabresd                  arm         armv7       mx6qsabresd         freescale      mx6		mx6qsabresd:IMX_CONFIG=board/freescale/imx/ddr/mx6q_4x_mt41j128.cfg
 mx6slevk                     arm         armv7       mx6slevk            freescale      mx6		mx6slevk:IMX_CONFIG=board/freescale/mx6slevk/imximage.cfg,MX6SL
 titanium                     arm         armv7       titanium            freescale      mx6		titanium:IMX_CONFIG=board/freescale/titanium/imximage.cfg
+mvf600twr                    arm         armv7       mvf600twr           freescale      mvf600          mvf600twr:IMX_CONFIG=board/freescale/mvf600twr/imximage.cfg
 eco5pk                       arm         armv7       eco5pk              8dtech         omap3
 nitrogen6dl                  arm         armv7       nitrogen6x          boundary       mx6		nitrogen6x:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6dl.cfg,MX6DL,DDR_MB=1024
 nitrogen6dl2g                arm         armv7       nitrogen6x          boundary       mx6		nitrogen6x:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6dl2g.cfg,MX6DL,DDR_MB=2048
include/configs/mvf600twr.h new file +140 -0

140 lines not on this page · raw message

Signature · 1 line
1.8.0
#15 lore raw

PATCH v3 6/6 arm: mvf600: Add basic support for Vybrid MVF600TWR board

Hi Alison,

Quoted 7 lines · Alison Wang

MVF600TWR is a board based on Vybrid MVF600 SoC.

This patch adds basic support for Vybrid MVF600TWR board.

[...]

Quoted 35 lines
include/configs/mvf600twr.h new file +29 -0
new file mode 100644
index 0000000..1cfb9f6
@@ -0,0 +1,140 @@
+/*
+ * Copyright 2013 Freescale Semiconductor, Inc.
+ *
+ * Configuration settings for the Freescale Vybrid mvf600twr board.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.	See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#ifndef __CONFIG_H
+#define __CONFIG_H
+
+#include <asm/arch/imx-regs.h>
+#include <config_cmd_default.h>
+
+#define CONFIG_MVF600
+

[...]

include/configs/mvf600twr.h line 80

Quoted 9 lines
include/configs/mvf600twr.h new file +9 -0
+#define CONFIG_CMD_PING
+#define CONFIG_CMD_DHCP
+#define CONFIG_CMD_MII
+#define CONFIG_CMD_NET
+#define CONFIG_FEC_MXC
+#define CONFIG_MII
+#define IMX_FEC_BASE			ENET_BASE_ADDR
+#define CONFIG_FEC_XCV_TYPE		RMII
+#define CONFIG_ETHPRIME			"FEC"

You don't need to define this one with only 1 Ethernet interface defined. But isn't the MVF600 a dual-Ethernet SoC?

Quoted 12 lines
include/configs/mvf600twr.h new file +12 -0
+#define CONFIG_FEC_MXC_PHYADDR          0
+#define CONFIG_PHYLIB
+#define CONFIG_PHY_MICREL
+
+#define CONFIG_BOOTDELAY		3
+
+#define CONFIG_SYS_TEXT_BASE		0x3f008000
+
+/* Miscellaneous configurable options */
+#define CONFIG_SYS_LONGHELP		/* undef to save memory */
+#define CONFIG_SYS_HUSH_PARSER		/* use "hush" command parser */
+#define CONFIG_SYS_PROMPT_HUSH_PS2	"> "

include/configs/mvf600twr.h line 102

Quoted 10 lines
include/configs/mvf600twr.h new file +10 -0
+#define CONFIG_SYS_PROMPT		"Vybrid U-Boot > "
+#undef CONFIG_AUTO_COMPLETE
+#define CONFIG_SYS_CBSIZE		256	/* Console I/O Buffer Size */
+#define CONFIG_SYS_PBSIZE		\
+			(CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)
+#define CONFIG_SYS_MAXARGS		16	/* max number of command args */
+#define CONFIG_SYS_BARGSIZE		CONFIG_SYS_CBSIZE
+
+#define CONFIG_SYS_MEMTEST_START	0x80010000
+#define CONFIG_SYS_MEMTEST_END		0x87C00000

You now have to #define CONFIG_CMD_MEMTEST for those to be useful.

Quoted 39 lines
include/configs/mvf600twr.h new file +38 -1
+
+#define CONFIG_SYS_LOAD_ADDR		0x80010000
+
+#define CONFIG_SYS_HZ			1000
+
+/*
+ * Stack sizes
+ * The stack sizes are set up in start.S using the settings below
+ */
+#define CONFIG_STACKSIZE		(128 * 1024)	/* regular stack */
+
+/* Physical memory map */
+#define CONFIG_NR_DRAM_BANKS		1
+#define PHYS_SDRAM			(0x80000000)
+#define PHYS_SDRAM_SIZE			(128 * 1024 * 1024)
+
+#define CONFIG_SYS_SDRAM_BASE		PHYS_SDRAM
+#define CONFIG_SYS_INIT_RAM_ADDR	IRAM_BASE_ADDR
+#define CONFIG_SYS_INIT_RAM_SIZE	IRAM_SIZE
+
+#define CONFIG_SYS_INIT_SP_OFFSET \
+	(CONFIG_SYS_INIT_RAM_SIZE - GENERATED_GBL_DATA_SIZE)
+#define CONFIG_SYS_INIT_SP_ADDR \
+	(CONFIG_SYS_INIT_RAM_ADDR + CONFIG_SYS_INIT_SP_OFFSET)
+
+/* FLASH and environment organization */
+#define CONFIG_SYS_NO_FLASH
+
+#define CONFIG_ENV_SIZE			(8 * 1024)
+#define CONFIG_ENV_IS_IN_MMC
+
+#define CONFIG_ENV_OFFSET		(12 * 64 * 1024)
+#define CONFIG_SYS_MMC_ENV_DEV		0
+
+#define CONFIG_OF_LIBFDT
+#define CONFIG_CMD_BOOTZ
+
+#endif
--
Quoted 1 line

1.8.0

Best regards,
Beno?t

A message that is not in the archive (sent off-list or not yet received): 81BA6E5E0BC2344391CABCEE22D1B6D8335B27@039-SN1MPN1-003.039d.mgd.msft.net

#17 lore raw

PATCH v3 6/6 arm: mvf600: Add basic support for Vybrid MVF600TWR board

Hi Alison,

Quoted 73 lines · On Wednesday, May 22, 2013 5:17:41 AM, Wang Huan-B18965 wrote:

Hi, Benoit,

Quoted 59 lines

-----Original Message-----
From: Beno?t Th?baudeau [mailto:benoit.thebaudeau at advansee.com]
Sent: Wednesday, May 22, 2013 1:29 AM
To: Wang Huan-B18965
Cc: sbabic at denx.de; u-boot at lists.denx.de; TsiChung Liew; Jin Zhengxiong- R64188; Estevam Fabio-R49496
Subject: Re: [U-Boot] [PATCH v3 6/6] arm: mvf600: Add basic support for Vybrid MVF600TWR board

Hi Alison,

Quoted 7 lines · Alison Wang

MVF600TWR is a board based on Vybrid MVF600 SoC.

This patch adds basic support for Vybrid MVF600TWR board.

[...]

Quoted 34 lines
include/configs/mvf600twr.h new file +29 -0
new file mode 100644 index 0000000..1cfb9f6
@@ -0,0 +1,140 @@
+/*
+ * Copyright 2013 Freescale Semiconductor, Inc.
+ *
+ * Configuration settings for the Freescale Vybrid mvf600twr board.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.	See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#ifndef __CONFIG_H
+#define __CONFIG_H
+
+#include <asm/arch/imx-regs.h>
+#include <config_cmd_default.h>
+
+#define CONFIG_MVF600
+

[...]

Quoted 12 lines

include/configs/mvf600twr.h line 80

Quoted 9 lines
include/configs/mvf600twr.h new file +9 -0
+#define CONFIG_CMD_PING
+#define CONFIG_CMD_DHCP
+#define CONFIG_CMD_MII
+#define CONFIG_CMD_NET
+#define CONFIG_FEC_MXC
+#define CONFIG_MII
+#define IMX_FEC_BASE			ENET_BASE_ADDR
+#define CONFIG_FEC_XCV_TYPE		RMII
+#define CONFIG_ETHPRIME			"FEC"

You don't need to define this one with only 1 Ethernet interface defined. But isn't the MVF600 a dual-Ethernet SoC?

Quoted 2 lines

[Alison Wang] Yes, MVF600 is a dual-Ethernet SoC. I will change it to "FEC0". Thanks.

CONFIG_ETHPRIME should just be removed if you are not going to enable the 2nd FEC in U-Boot. But if you plan to enable the 2nd FEC, which will have to be done now or later for a dual-Ethernet SoC, then you have to:
- remove CONFIG_FEC_MXC_PHYADDR and IMX_FEC_BASE,
- define CONFIG_ETHPRIME to "FEC0",
- call fecmxc_initialize_multi() once for each FEC instead of calling fecmxc_initialize() from cpu_eth_init() in generic.c (you can define ENET1_BASE_ADDR and ENET2_BASE_ADDR instead of ENET_BASE_ADDR in imx-regs.h, and CONFIG_FEC1_MXC_PHYADDR and CONFIG_FEC2_MXC_PHYADDR instead of CONFIG_FEC_MXC_PHYADDR in mvf600twr.h, then pass them to fecmxc_initialize_multi() from cpu_eth_init(), with 0 and 1 as the IDs),
- add support for the 2nd FEC in imx_get_mac_from_fuse(),
- update doc/README.mvf600 to say which fuses are used for the MAC address of the 2nd FEC.

[...]

Best regards,
Beno?t

#18 lore raw

PATCH v3 6/6 arm: mvf600: Add basic support for Vybrid MVF600TWR board

Hi, Benoit,

Quoted 97 lines · On Wednesday, May 22, 2013 5:17:41 AM, Wang Huan-B18965 wrote:
Quoted 24 lines

Hi, Benoit,

Quoted 22 lines

-----Original Message-----
From: Beno?t Th?baudeau [mailto:benoit.thebaudeau at advansee.com]
Sent: Wednesday, May 22, 2013 1:29 AM
To: Wang Huan-B18965
Cc: sbabic at denx.de; u-boot at lists.denx.de; TsiChung Liew; Jin Zhengxiong- R64188; Estevam Fabio-R49496
Subject: Re: [U-Boot] [PATCH v3 6/6] arm: mvf600: Add basic support for Vybrid MVF600TWR board

Hi Alison,

Quoted 7 lines · Alison Wang

MVF600TWR is a board based on Vybrid MVF600 SoC.

This patch adds basic support for Vybrid MVF600TWR board.

[...]

Quoted 10 lines
Quoted 10 lines

include/configs/mvf600twr.h line 4

Quoted 10 lines
(quoted diff) +0 -0

b/include/configs/mvf600twr.h new file mode 100644 index 0000000..1cfb9f6

include/configs/mvf600twr.h new file +4 -0
@@ -0,0 +1,140 @@
+/*
+ * Copyright 2013 Freescale Semiconductor, Inc.
+ *
+ * Configuration settings for the Freescale Vybrid mvf600twr

board.

Quoted 3 lines
Quoted 3 lines

include/configs/mvf600twr.h line 7

Quoted 3 lines
include/configs/mvf600twr.h new file +3 -0
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License

as

Quoted 1 line
Quoted 1 line

include/configs/mvf600twr.h line 8

Quoted 1 line
include/configs/mvf600twr.h new file +1 -0
+ * published by the Free Software Foundation; either version 2

of

Quoted 5 lines
Quoted 5 lines

include/configs/mvf600twr.h line 13

Quoted 5 lines
include/configs/mvf600twr.h new file +5 -0
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be
+useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty

of

Quoted 1 line
Quoted 1 line

include/configs/mvf600twr.h line 14

Quoted 1 line
include/configs/mvf600twr.h new file +1 -0
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.	See

the

Quoted 20 lines
Quoted 20 lines
Quoted 17 lines
include/configs/mvf600twr.h new file +17 -0
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public
+License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#ifndef __CONFIG_H
+#define __CONFIG_H
+
+#include <asm/arch/imx-regs.h>
+#include <config_cmd_default.h>
+
+#define CONFIG_MVF600
+

[...]

Quoted 11 lines
Quoted 11 lines

include/configs/mvf600twr.h line 80

Quoted 9 lines
include/configs/mvf600twr.h new file +9 -0
+#define CONFIG_CMD_PING
+#define CONFIG_CMD_DHCP
+#define CONFIG_CMD_MII
+#define CONFIG_CMD_NET
+#define CONFIG_FEC_MXC
+#define CONFIG_MII
+#define IMX_FEC_BASE			ENET_BASE_ADDR
+#define CONFIG_FEC_XCV_TYPE		RMII
+#define CONFIG_ETHPRIME			"FEC"

You don't need to define this one with only 1 Ethernet interface

defined.

Quoted 2 lines
Quoted 1 line

But isn't the MVF600 a dual-Ethernet SoC?

[Alison Wang] Yes, MVF600 is a dual-Ethernet SoC. I will change it to

"FEC0".

Quoted 1 line

Thanks.

CONFIG_ETHPRIME should just be removed if you are not going to enable the 2nd FEC in U-Boot. But if you plan to enable the 2nd FEC, which will have to be done now or later for a dual-Ethernet SoC, then you have to:
- remove CONFIG_FEC_MXC_PHYADDR and IMX_FEC_BASE,
- define CONFIG_ETHPRIME to "FEC0",
- call fecmxc_initialize_multi() once for each FEC instead of calling fecmxc_initialize() from cpu_eth_init() in generic.c (you can define ENET1_BASE_ADDR and ENET2_BASE_ADDR instead of ENET_BASE_ADDR in
imx-regs.h,

Quoted 8 lines

and CONFIG_FEC1_MXC_PHYADDR and CONFIG_FEC2_MXC_PHYADDR instead of CONFIG_FEC_MXC_PHYADDR in mvf600twr.h, then pass them to fecmxc_initialize_multi() from cpu_eth_init(), with 0 and 1 as the
IDs),
- add support for the 2nd FEC in imx_get_mac_from_fuse(),
- update doc/README.mvf600 to say which fuses are used for the MAC
address of
the 2nd FEC.

[Alison Wang] Agree. Thanks.

Best Regards,
Alison Wang

#19 lore raw

PATCH v3 6/6 arm: mvf600: Add basic support for Vybrid MVF600TWR board

In reply to Alison Wang

Hi Alison,

Quoted 7 lines · Alison Wang

MVF600TWR is a board based on Vybrid MVF600 SoC.

This patch adds basic support for Vybrid MVF600TWR board.

[...]

Quoted 35 lines
board/freescale/mvf600twr/mvf600twr.c new file +28 -0
new file mode 100644
index 0000000..71ee12b
@@ -0,0 +1,413 @@
+/*
+ * Copyright 2013 Freescale Semiconductor, Inc.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <common.h>
+#include <asm/io.h>
+#include <asm/arch/imx-regs.h>
+#include <asm/arch/mvf_pins.h>
+#include <asm/arch/crm_regs.h>
+#include <asm/arch/clock.h>
+#include <mmc.h>
+#include <fsl_esdhc.h>
+#include <miiphy.h>

board/freescale/mvf600twr/mvf600twr.c line 38

Quoted 10 lines
board/freescale/mvf600twr/mvf600twr.c new file +10 -0
+#include <netdev.h>
+
+DECLARE_GLOBAL_DATA_PTR;
+
+#define UART_PAD_CTRL	(PAD_CTL_PUS_100K_UP | PAD_CTL_SPEED_MED | \
+			PAD_CTL_DSE_25ohm | PAD_CTL_OBE_IBE_ENABLE)
+
+#define ESDHC_PAD_CTRL	(PAD_CTL_PUE | PAD_CTL_PUS_100K_UP | \
+			PAD_CTL_SPEED_HIGH | PAD_CTL_DSE_20ohm | \
+			PAD_CTL_OBE_IBE_ENABLE)

With the changes that I have suggested in my review of your IOMUX patch, ESDHC_PAD_CTRL could be simplified by removing PAD_CTL_PUE.

And without those changes, UART_PAD_CTRL and ENET_PAD_CTRL in your current code set pull values that are actually unused (unless the corresponding PKE/PUE bits do not exist and default to pull in the pad control registers used with these definitions).

board/freescale/mvf600twr/mvf600twr.c line 43

Quoted 5 lines
board/freescale/mvf600twr/mvf600twr.c new file +5 -0
+
+#define ENET_PAD_CTRL	(PAD_CTL_PUS_47K_UP | PAD_CTL_SPEED_HIGH | \
+			PAD_CTL_DSE_50ohm | PAD_CTL_OBE_IBE_ENABLE)
+
+#define DDR_PAD_CTRL	PAD_CTL_DSE_25ohm

MUX_PAD_CTRL() could be added to the 4 pad control definitions above in order to avoid repeating it everywhere below. But using MUX_PAD_CTRL() relies on the fact that the pad control values in mvf_pins.h are all 0 (which is the case, but this is dangerous if this is changed later), so a better approach could be to use NEW_PAD_CTRL(), e.g.:

        NEW_PAD_CTRL(MVF600_PAD_DDR_A15__DDR_A_15, DDR_PAD_CTRL),
instead of:
        MVF600_PAD_DDR_A15__DDR_A_15 | MUX_PAD_CTRL(DDR_PAD_CTRL),
Quoted 66 lines
board/freescale/mvf600twr/mvf600twr.c new file +66 -0
+
+iomux_v3_cfg_t const ddr_pads[] = {
+	MVF600_PAD_DDR_A15__DDR_A_15 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_A14__DDR_A_14 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_A13__DDR_A_13 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_A12__DDR_A_12 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_A11__DDR_A_11 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_A10__DDR_A_10 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_A9__DDR_A_9 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_A8__DDR_A_8 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_A7__DDR_A_7 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_A6__DDR_A_6 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_A5__DDR_A_5 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_A4__DDR_A_4 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_A3__DDR_A_3 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_A2__DDR_A_2 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_A1__DDR_A_1 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_BA2__DDR_BA_2 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_BA1__DDR_BA_1 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_BA0__DDR_BA_0 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_CAS__DDR_CAS_B | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_CKE__DDR_CKE_0 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_CLK__DDR_CLK_0 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_CS__DDR_CS_B_0 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_D15__DDR_D_15 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_D14__DDR_D_14 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_D13__DDR_D_13 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_D12__DDR_D_12 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_D11__DDR_D_11 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_D10__DDR_D_10 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_D9__DDR_D_9 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_D8__DDR_D_8 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_D7__DDR_D_7 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_D6__DDR_D_6 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_D5__DDR_D_5 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_D4__DDR_D_4 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_D3__DDR_D_3 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_D2__DDR_D_2 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_D1__DDR_D_1 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_D0__DDR_D_0 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_DQM1__DDR_DQM_1 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_DQM0__DDR_DQM_0 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_DQS1__DDR_DQS_1 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_DQS0__DDR_DQS_0 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_RAS__DDR_RAS_B | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_WE__DDR_WE_B | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_ODT1__DDR_ODT_0 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+	MVF600_PAD_DDR_ODT0__DDR_ODT_1 | MUX_PAD_CTRL(DDR_PAD_CTRL),
+};
+
+iomux_v3_cfg_t const uart1_pads[] = {
+	MVF600_PAD_PTB4__UART1_TX | MUX_PAD_CTRL(UART_PAD_CTRL),
+	MVF600_PAD_PTB5__UART1_RX | MUX_PAD_CTRL(UART_PAD_CTRL),
+};
+
+iomux_v3_cfg_t const enet0_pads[] = {
+	MVF600_PAD_PTA6__RMII0_CLKIN | MUX_PAD_CTRL(ENET_PAD_CTRL),
+	MVF600_PAD_PTC1__RMII0_MDIO | MUX_PAD_CTRL(ENET_PAD_CTRL),
+	MVF600_PAD_PTC0__RMII0_MDC | MUX_PAD_CTRL(ENET_PAD_CTRL),
+	MVF600_PAD_PTC2__RMII0_CRS_DV | MUX_PAD_CTRL(ENET_PAD_CTRL),
+	MVF600_PAD_PTC3__RMII0_RD1 | MUX_PAD_CTRL(ENET_PAD_CTRL),
+	MVF600_PAD_PTC4__RMII0_RD0 | MUX_PAD_CTRL(ENET_PAD_CTRL),
+	MVF600_PAD_PTC5__RMII0_RXER | MUX_PAD_CTRL(ENET_PAD_CTRL),
+	MVF600_PAD_PTC6__RMII0_TD1 | MUX_PAD_CTRL(ENET_PAD_CTRL),
+	MVF600_PAD_PTC7__RMII0_TD0 | MUX_PAD_CTRL(ENET_PAD_CTRL),
+	MVF600_PAD_PTC8__RMII0_TXEN | MUX_PAD_CTRL(ENET_PAD_CTRL),

board/freescale/mvf600twr/mvf600twr.c line 119

Quoted 10 lines
board/freescale/mvf600twr/mvf600twr.c new file +10 -0
+};
+
+iomux_v3_cfg_t const esdhc1_pads[] = {
+	MVF600_PAD_PTA24__ESDHC1_CLK | MUX_PAD_CTRL(ESDHC_PAD_CTRL),
+	MVF600_PAD_PTA25__ESDHC1_CMD | MUX_PAD_CTRL(ESDHC_PAD_CTRL),
+	MVF600_PAD_PTA26__ESDHC1_DAT0 | MUX_PAD_CTRL(ESDHC_PAD_CTRL),
+	MVF600_PAD_PTA27__ESDHC1_DAT1 | MUX_PAD_CTRL(ESDHC_PAD_CTRL),
+	MVF600_PAD_PTA28__ESDHC1_DAT2 | MUX_PAD_CTRL(ESDHC_PAD_CTRL),
+	MVF600_PAD_PTA29__ESDHC1_DAT3 | MUX_PAD_CTRL(ESDHC_PAD_CTRL),
+};

[...]

Best regards,
Beno?t

#20 lore raw

v3 cover arm: mvf600: Add Freescale Vybrid MVF600 CPU and MVF600TWR board support

In reply to Alison Wang

Hi Alison,

Quoted 11 lines · Alison Wang

This series contain the support for Freescale Vybrid MVF600 CPU and MVF600TWR board.

Vybird devices are built on an asymmetrical-multiprocessing architecture using ARM cores. The families in the Vybrid portfolio span entry-level, single core Cortex-A class SoCs all the way to dual heterogeneous core SoCs with multiple communication and connectivity options.

Part of the Vybrid platform, MVF600 is a dual-core eMPU combining the ARM Cortex A5 and Cortex M4 cores.

Quoted 8 lines

MVF600 shares some IPs with i.MX family, such as FEC,ESDHC,WATCHDOG,I2C,ASRC and ESAI.
MVF600 also shares some IPs with ColdFire family, such as eDMA and DSPI. MVF600 still has its own IPs, such as PIT,SAI,UART,QSPI and DCU.

More documents for this soc can be found at:
http://www.freescale.com/webapp/sps/site/prod_summary.jsp?code=VF6xx&fsrch=1&sr=5
http://www.freescale.com/webapp/sps/site/homepage.jsp?code=VYBRID

I have a question about the naming of this SoC. On Freescale's website, it is VF6xx everywhere, but you add a leading M (_M_VF600). Is it because you are using an internal SoC name known only by Freescale and different from the marketing SoC name, or is this M from the part number, or will the marketing SoC name change later, or some other reason? Please clarify. U-Boot users must be able to identify a SoC and to find information about it easily.

Quoted 2 lines

The u-boot runs on Cortex A5 core.

[...]

Best regards,
Beno?t

A message that is not in the archive (sent off-list or not yet received): 81BA6E5E0BC2344391CABCEE22D1B6D8335A6C@039-SN1MPN1-003.039d.mgd.msft.net

#22 lore raw

v3 cover arm: mvf600: Add Freescale Vybrid MVF600 CPU and MVF600TWR board support

Hi Alison,

Quoted 42 lines · On Wednesday, May 22, 2013 5:01:44 AM, Wang Huan-B18965 wrote:

Hi, Benoit,

Quoted 33 lines

-----Original Message-----
From: Beno?t Th?baudeau [mailto:benoit.thebaudeau at advansee.com]
Sent: Wednesday, May 22, 2013 12:28 AM
To: Wang Huan-B18965
Cc: sbabic at denx.de; u-boot at lists.denx.de; Estevam Fabio-R49496
Subject: Re: [U-Boot] [PATCH v3 0/6] arm: mvf600: Add Freescale Vybrid MVF600 CPU and MVF600TWR board support

Hi Alison,

Quoted 7 lines · Alison Wang

This series contain the support for Freescale Vybrid MVF600 CPU and MVF600TWR board.

Vybird devices are built on an asymmetrical-multiprocessing architecture using ARM cores. The families in the Vybrid portfolio span entry-level, single core Cortex-A class SoCs all the way to dual heterogeneous core SoCs with multiple communication and connectivity

options.

Quoted 9 lines

Part of the Vybrid platform, MVF600 is a dual-core eMPU combining the ARM Cortex A5 and Cortex M4 cores.

MVF600 shares some IPs with i.MX family, such as FEC,ESDHC,WATCHDOG,I2C,ASRC and ESAI.
MVF600 also shares some IPs with ColdFire family, such as eDMA and DSPI. MVF600 still has its own IPs, such as PIT,SAI,UART,QSPI and DCU.

Quoted 4 lines

More documents for this soc can be found at:
http://www.freescale.com/webapp/sps/site/prod_summary.jsp?code=VF6xx&f
srch=1&sr=5
http://www.freescale.com/webapp/sps/site/homepage.jsp?code=VYBRID

Quoted 7 lines

I have a question about the naming of this SoC. On Freescale's website, it is VF6xx everywhere, but you add a leading M (_M_VF600). Is it because you are using an internal SoC name known only by Freescale and different from the marketing SoC name, or is this M from the part number, or will the marketing SoC name change later, or some other reason? Please clarify. U-Boot users must be able to identify a SoC and to find information about it easily.

Quoted 3 lines

[Alison Wang] We always use the name "MVF600" in the internal development. We will
check it with marketing team, and confirm it. Thanks.

OK. You should also check for each part of the code in this patch set if it is specific to the (M)VF600 or common to all (M)VF6xx SoCs. In the latter case, the names in the code should be changed to either (m)vf6xx or (m)vf6, just like U-Boot uses "mx5" to mean i.MX5xx. The naming for your Linux patches should also preferably be the same as in U-Boot in order to avoid confusion for users.

Best regards,
Beno?t

#23 lore raw

v3 cover arm: mvf600: Add Freescale Vybrid MVF600 CPU and MVF600TWR board support

Hi, Benoit,

Quoted 53 lines · On Wednesday, May 22, 2013 5:01:44 AM, Wang Huan-B18965 wrote:
Quoted 18 lines

Hi, Benoit,

Quoted 16 lines

-----Original Message-----
From: Beno?t Th?baudeau [mailto:benoit.thebaudeau at advansee.com]
Sent: Wednesday, May 22, 2013 12:28 AM
To: Wang Huan-B18965
Cc: sbabic at denx.de; u-boot at lists.denx.de; Estevam Fabio-R49496
Subject: Re: [U-Boot] [PATCH v3 0/6] arm: mvf600: Add Freescale Vybrid MVF600 CPU and MVF600TWR board support

Hi Alison,

Quoted 5 lines · Alison Wang

This series contain the support for Freescale Vybrid MVF600 CPU and MVF600TWR board.

Vybird devices are built on an asymmetrical-multiprocessing architecture using ARM cores. The families in the Vybrid

portfolio

Quoted 11 lines
Quoted 11 lines
Quoted 3 lines

span entry-level, single core Cortex-A class SoCs all the way to dual heterogeneous core SoCs with multiple communication and connectivity

options.

Quoted 7 lines

Part of the Vybrid platform, MVF600 is a dual-core eMPU combining the ARM Cortex A5 and Cortex M4 cores.

MVF600 shares some IPs with i.MX family, such as FEC,ESDHC,WATCHDOG,I2C,ASRC and ESAI.
MVF600 also shares some IPs with ColdFire family, such as eDMA

and DSPI.

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

MVF600 still has its own IPs, such as PIT,SAI,UART,QSPI and DCU.

More documents for this soc can be found at:

http://www.freescale.com/webapp/sps/site/prod_summary.jsp?code=VF6

Quoted 9 lines
Quoted 9 lines
Quoted 3 lines

xx&f
srch=1&sr=5
http://www.freescale.com/webapp/sps/site/homepage.jsp?code=VYBRID

I have a question about the naming of this SoC. On Freescale's website, it is VF6xx everywhere, but you add a leading M (_M_VF600). Is it because you are using an internal SoC name known only by Freescale and different from the marketing SoC name, or is this M from the part number, or will the marketing SoC name change later,

or some other reason? Please clarify.

Quoted 5 lines
Quoted 2 lines

U-Boot users must be able to identify a SoC and to find information about it easily.

[Alison Wang] We always use the name "MVF600" in the internal development. We will check it with marketing team, and confirm it. Thanks.

Quoted 6 lines

OK. You should also check for each part of the code in this patch set if it is specific to the (M)VF600 or common to all (M)VF6xx SoCs. In the latter case, the names in the code should be changed to either (m)vf6xx or (m)vf6, just like U-Boot uses "mx5" to mean i.MX5xx. The naming for your Linux patches should also preferably be the same as in U-Boot in order to avoid confusion for users.

[Alison Wang] We usually named the Powerpc(before QorIQ) as MPC and ColdFire as MCF, So we generally named the Vybrid as MVF. We had some internal discussion for this, and we think we should use VF instead of MVF, we will follow the internal suggestions to name the soc as VF610. Thanks for your comments.
We have no detail spec for other vf6xx chips so far, so from technical side we can only make sure current code in this patch set is work for VF610. So we'll use VF610 instead of vf6xx.

Best Regards,
Alison

#24 lore raw

v3 cover arm: mvf600: Add Freescale Vybrid MVF600 CPU and MVF600TWR board support

Quoted 3 lines · On 24/05/2013 08:18, Wang Huan-B18965 wrote:

[Alison Wang] We usually named the Powerpc(before QorIQ) as MPC and ColdFire as MCF, So we generally named the Vybrid as MVF. We had some internal discussion for this, and we think we should use VF instead of MVF, we will follow the internal suggestions to name the soc as VF610. Thanks for your comments.

It is nice if you use the same name everybody finds on Freescale's Website. However, I hope you decide that the names will be consistent with the kernel, and also the patches that are currently posted to linux-arm will change the processor name. The worst thing is if we get a name in u-boot and another one in kernel.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#25 lore raw

v3 cover arm: mvf600: Add Freescale Vybrid MVF600 CPU and MVF600TWR board support

Hi, Stefano,

Quoted 6 lines · On 24/05/2013 08:18, Wang Huan-B18965 wrote:
Quoted 2 lines

[Alison Wang] We usually named the Powerpc(before QorIQ) as MPC and

ColdFire as MCF, So we generally named the Vybrid as MVF.

Quoted 2 lines

We had some internal discussion for this, and we think we should use VF instead of MVF, we will follow the internal suggestions to name

Quoted 8 lines

the soc as VF610. Thanks for your comments.

It is nice if you use the same name everybody finds on Freescale's Website. However, I hope you decide that the names will be consistent with the kernel, and also the patches that are currently posted to linux-arm will change the processor name. The worst thing is if we get a name in u-boot and another one in kernel.

[Alison Wang] Thanks for your reminder, we have discussed this with the kernel maintainer and get agreement to use the SoC name vf610. We'll use the 'vf610' in both u-boot and kernel. any comments for the name? Thanks.

Best Regards,
Alison Wang

#26 lore raw

v3 cover arm: mvf600: Add Freescale Vybrid MVF600 CPU and MVF600TWR board support

Quoted 10 lines · On 28/05/2013 10:51, Wang Huan-B18965 wrote:

Hi, Stefano,

Quoted 8 lines · On 24/05/2013 08:18, Wang Huan-B18965 wrote:
Quoted 2 lines

[Alison Wang] We usually named the Powerpc(before QorIQ) as MPC and

ColdFire as MCF, So we generally named the Vybrid as MVF.

Quoted 2 lines

We had some internal discussion for this, and we think we should use VF instead of MVF, we will follow the internal suggestions to name

the soc as VF610. Thanks for your comments.

Quoted 8 lines
Quoted 6 lines

It is nice if you use the same name everybody finds on Freescale's Website. However, I hope you decide that the names will be consistent with the kernel, and also the patches that are currently posted to linux-arm will change the processor name. The worst thing is if we get a name in u-boot and another one in kernel.

[Alison Wang] Thanks for your reminder, we have discussed this with the kernel maintainer and get agreement to use the SoC name vf610. We'll use the 'vf610' in both u-boot and kernel. any comments for the name? Thanks.

No, you are the developer, you work in Freescale and your is the final decision about the names.
My point of view, and maybe it is the same for most of Freescale's customers, is to have consistent names. Everybody checking Freescale's website knows that the SOC / board is supported in u-boot and/or kernel if he finds the same names as on the website. But is the mx53loco the same as mx53qsb, the official name to buy the board ? Of course, it is the same, but not at the first glance. Or mx51evk and babbage ? Or (following some other bad examples...) ?

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#27 lore raw

v3 cover arm: mvf600: Add Freescale Vybrid MVF600 CPU and MVF600TWR board support

In reply to Wang Huan-B18965

Hi, benoit,

Quoted 51 lines
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines · Alison Wang
Quoted 5 lines

This series contain the support for Freescale Vybrid MVF600 CPU and MVF600TWR board.

Vybird devices are built on an asymmetrical-multiprocessing architecture using ARM cores. The families in the Vybrid

portfolio

Quoted 1 line
Quoted 1 line
Quoted 1 line

span entry-level, single core Cortex-A class SoCs all the way

to

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 2 lines

dual heterogeneous core SoCs with multiple communication and connectivity

options.

Quoted 7 lines

Part of the Vybrid platform, MVF600 is a dual-core eMPU combining the ARM Cortex A5 and Cortex M4 cores.

MVF600 shares some IPs with i.MX family, such as FEC,ESDHC,WATCHDOG,I2C,ASRC and ESAI.
MVF600 also shares some IPs with ColdFire family, such as eDMA

Quoted 9 lines

and DSPI.

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

MVF600 still has its own IPs, such as PIT,SAI,UART,QSPI and DCU.

More documents for this soc can be found at:

http://www.freescale.com/webapp/sps/site/prod_summary.jsp?code=VF6

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

xx&f
srch=1&sr=5

http://www.freescale.com/webapp/sps/site/homepage.jsp?code=VYBRI

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line

D

I have a question about the naming of this SoC. On Freescale's website, it is VF6xx everywhere, but you add a leading M

(_M_VF600).

Quoted 10 lines
Quoted 3 lines
Quoted 3 lines

Is it because you are using an internal SoC name known only by Freescale and different from the marketing SoC name, or is this M from the part number, or will the marketing SoC name change later,

or some other reason? Please clarify.

Quoted 5 lines
Quoted 2 lines

U-Boot users must be able to identify a SoC and to find information about it easily.

[Alison Wang] We always use the name "MVF600" in the internal development. We will check it with marketing team, and confirm it. Thanks.

Quoted 5 lines

OK. You should also check for each part of the code in this patch set if it is specific to the (M)VF600 or common to all (M)VF6xx SoCs. In the latter case, the names in the code should be changed to either (m)vf6xx or (m)vf6, just like U-Boot uses "mx5" to mean i.MX5xx. The naming for your Linux patches should also preferably be the same as

in

Quoted 1 line

U-Boot in order to avoid confusion for users.

Quoted 9 lines

[Alison Wang] We usually named the Powerpc(before QorIQ) as MPC and ColdFire as MCF, So we generally named the Vybrid as MVF.
We had some internal discussion for this, and we think we should use VF instead of MVF, we will follow the internal suggestions to name the soc as VF610. Thanks for your comments.
We have no detail spec for other vf6xx chips so far, so from technical side we can only make sure current code in this patch set is work for VF610. So we'll use VF610 instead of vf6xx.

[Alison Wang] Do you have any comments about the SoC name? I'd like to send out the next version patch set based on the new SoC name vf610. Thanks.

Best Regards,
Alison Wang