request_any_context_irq(): set IRQF_ONESHOT flag to ensure IRQ request
PATCH 1/1 request_any_context_irq(): set IRQF_ONESHOT flag to ensure IRQ request
Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail.
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
Signed-off-by Valentin Rothberg <[email protected]>
---
The function has been added by commit ae731f8d ("genirq: Introduce request_any_context_irq()"), so before "Reject bogus threaded irq requests". LXR gives me less than a dozen of references on this function, so it's likely that this code path has not been executed for a longer while.
--- kernel/irq/manage.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
kernel/irq/manage.c +2 -1
@@ -1597,7 +1597,8 @@ int request_any_context_irq(unsigned int irq, irq_handler_t handler,if (irq_settings_is_nested_thread (desc)) { ret =request_threaded_irq (irq,NULL , handler, - flags, name, dev_id); + flags |IRQF_ONESHOT , name, + dev_id);return !ret ?IRQC_IS_NESTED : ret; }
Signature · 1 line
1.9.1