Skip to contentSkip to conversation

fdtdec: Improve fdtdec_get_pci_bdf() documentation

PATCH New Bin Meng 2 participants 3 messages Mar 4, 2015 – Mar 25, 2015

lore
Share & tools
lore

Bin Meng

author
#0 lore raw

PATCH 1/1 fdtdec: Improve fdtdec_get_pci_bdf() documentation

Add the description that how the compatible property is involved in the fdtdec_get_pci_bdf() documentation.

---

 include/fdtdec.h | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
include/fdtdec.h +4 -1
index 1bc70db..eef78a7 100644
@@ -346,7 +346,10 @@ int fdtdec_get_pci_vendev(const void *blob, int node,
 
 /**
  * Look at the pci address of a device node that represents a PCI device
- * and parse the bus, device and function number from it.
+ * and parse the bus, device and function number from it. For some cases
+ * like the bus number encoded in reg property is not correct after pci
+ * enumeration, this function looks through the node's compatible strings
+ * to get these numbers extracted instead.
  *
  * @param blob		FDT blob
  * @param node		node to examine
Signature · 1 line
1.8.2.1
#1 lore raw

PATCH 1/1 fdtdec: Improve fdtdec_get_pci_bdf() documentation

Quoted 26 lines · Bin Meng

Add the description that how the compatible property is involved in the fdtdec_get_pci_bdf() documentation.

---

 include/fdtdec.h | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
include/fdtdec.h +4 -2
index 1bc70db..eef78a7 100644
@@ -346,7 +346,10 @@ int fdtdec_get_pci_vendev(const void *blob, int node,
 
 /**
  * Look at the pci address of a device node that represents a PCI device
- * and parse the bus, device and function number from it.
+ * and parse the bus, device and function number from it. For some cases
+ * like the bus number encoded in reg property is not correct after pci
+ * enumeration, this function looks through the node's compatible strings
+ * to get these numbers extracted instead.
  *
  * @param blob         FDT blob
  * @param node         node to examine
--
Quoted 2 lines

1.8.2.1

#2 lore raw

PATCH 1/1 fdtdec: Improve fdtdec_get_pci_bdf() documentation

Quoted 16 lines · Simon Glass
Quoted 15 lines · Bin Meng

Add the description that how the compatible property is involved in the fdtdec_get_pci_bdf() documentation.

---

 include/fdtdec.h | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
include/fdtdec.h +0 -0
index 1bc70db..eef78a7 100644
@@ -346,7 +346,10 @@ int fdtdec_get_pci_vendev(const void *blob, int node,
 
Quoted 15 lines
Quoted 11 lines
include/fdtdec.h +4 -2
 /**
  * Look at the pci address of a device node that represents a PCI device
- * and parse the bus, device and function number from it.
+ * and parse the bus, device and function number from it. For some cases
+ * like the bus number encoded in reg property is not correct after pci
+ * enumeration, this function looks through the node's compatible strings
+ * to get these numbers extracted instead.
  *
  * @param blob         FDT blob
  * @param node         node to examine
--
Quoted 2 lines

1.8.2.1

Applied to u-boot-x86, thanks!