Skip to contentSkip to conversation

mei: free me client references on host init

PATCH New Tomas Winkler 1 participant 2 messages Mar 4, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 mei: free me client references on host init

Fx fixes leak introduced by:
commit b7d885145538 ("mei: revamp me clients list handling")

---
 drivers/misc/mei/client.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/misc/mei/client.c +3 -0
index 98a5363e1e8a..b6fec4d15307 100644
@@ -668,14 +668,17 @@ void mei_host_client_init(struct work_struct *work)
 	me_cl = mei_me_cl_by_uuid(dev, &mei_amthif_guid);
 	if (me_cl)
 		mei_amthif_host_init(dev);
+	mei_me_cl_put(me_cl);
 
 	me_cl = mei_me_cl_by_uuid(dev, &mei_wd_guid);
 	if (me_cl)
 		mei_wd_host_init(dev);
+	mei_me_cl_put(me_cl);
 
 	me_cl = mei_me_cl_by_uuid(dev, &mei_nfc_guid);
 	if (me_cl)
 		mei_nfc_host_init(dev);
+	mei_me_cl_put(me_cl);
 
 
 	dev->dev_state = MEI_DEV_ENABLED;
Signature · 1 line
1.9.3
#1 lore raw

PATCH 2/2 mei: trace: fix missing include to linux/device.h

Fix warning (discovered using randconfig)

drivers/misc/mei/mei-trace.h:30:24: warning: 'struct device' declared
inside parameter list
TP_PROTO(const struct device *dev, const char *reg, u32 offs, u32
val),

---
 drivers/misc/mei/mei-trace.h | 2 ++
 1 file changed, 2 insertions(+)
drivers/misc/mei/mei-trace.h +2 -0
index d5c38d15cdd9..5f4e1a17360b 100644
@@ -21,6 +21,8 @@
 #include <linux/types.h>
 #include <linux/tracepoint.h>
 
+#include <linux/device.h>
+
 #undef TRACE_SYSTEM
 
 #define TRACE_SYSTEM mei
Signature · 1 line
1.9.3