Skip to contentSkip to conversation

ktap: rename recipes to indicate they are from git

PATCH New Martin Jansa 1 participant 3 messages Mar 5, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 ktap: rename recipes to indicate they are from git

* set PV so that it shows git revision and also automatically rebuilds them when SRCREV is changed

---
 meta-oe/recipes-kernel/ktap/{ktap-module_0.4.bb => ktap-module_git.bb} | 0
 meta-oe/recipes-kernel/ktap/ktap.inc                                   | 1 +
 meta-oe/recipes-kernel/ktap/{ktap_0.4.bb => ktap_git.bb}               | 0
 3 files changed, 1 insertion(+)
 rename meta-oe/recipes-kernel/ktap/{ktap-module_0.4.bb => ktap-module_git.bb} (100%)
 rename meta-oe/recipes-kernel/ktap/{ktap_0.4.bb => ktap_git.bb} (100%)
meta-oe/recipes-kernel/ktap/ktap-module_git.bb renamed from meta-oe/recipes-kernel/ktap/ktap-module_0.4.bb +0 -0
similarity index 100%
rename from meta-oe/recipes-kernel/ktap/ktap-module_0.4.bb
rename to meta-oe/recipes-kernel/ktap/ktap-module_git.bb
meta-oe/recipes-kernel/ktap/ktap.inc +1 -0
index 93a4e2c..2c94a08 100644
@@ -4,6 +4,7 @@ HOMEPAGE = "http://www.ktap.org"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://LICENSE-GPL;md5=eb723b61539feef013de476e68b5c50a"
 
+PV = "0.4+gitr${SRCPV}"
 SRCREV = "c8401e07c89cdec9a5f673da4ddb12b7982b522b"
 SRC_URI = "git://github.com/ktap/ktap.git"
 
meta-oe/recipes-kernel/ktap/ktap_git.bb renamed from meta-oe/recipes-kernel/ktap/ktap_0.4.bb +0 -0
similarity index 100%
rename from meta-oe/recipes-kernel/ktap/ktap_0.4.bb
rename to meta-oe/recipes-kernel/ktap/ktap_git.bb
Signature · 1 line
2.3.1
#1 lore raw

PATCH 2/3 ktap: change kernel-module-ktapvm RDEPENDS to RRECOMMENDS

* even if it makes sense in this case, don't give bad example for other people to copy & paste to other recipes, kernel modules should be only recommended, so that it still works fine if someone includes the module inside kernel image

---
 meta-oe/recipes-kernel/ktap/ktap_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-kernel/ktap/ktap_git.bb +1 -1
index cbdabf8..2053783 100644
@@ -23,4 +23,4 @@ do_install() {
 }
 
 PACKAGE_ARCH = "${MACHINE_ARCH}"
-RDEPENDS_${PN} = "kernel-module-ktapvm"
+RRECOMMENDS_${PN} = "kernel-module-ktapvm"
Signature · 1 line
2.3.1
#2 lore raw

PATCH 3/3 ktap-module: blacklist because it's not compatible with 3.19 kernel

In reply to Martin Jansa
---
 meta-oe/recipes-kernel/ktap/ktap-module_git.bb | 3 +++
 1 file changed, 3 insertions(+)
meta-oe/recipes-kernel/ktap/ktap-module_git.bb +3 -0
index 62f2a99..e3c94e3 100644
@@ -6,6 +6,9 @@ SUMMARY = "KTAP is a scripting dynamic tracing tool for Linux"
 
 inherit module
 
+# See https://github.com/ktap/ktap/issues/80
+PNBLACKLIST[ktap-module] ?= "Not compatible with 3.19 kernel"
+
 # Available package configs: ffi (only supported on x86_64)
 PACKAGECONFIG ?= ""
 
Signature · 1 line
2.3.1