Skip to contentSkip to conversation

Fix mssfix default value

PATCH In review Lev Stipakov 2 participants 2 messages Mar 5, 2015 – Mar 7, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix mssfix default value

Due to this bug, mssfix hasn't been assigned to fragment value and used default value (1450) instead. As a consequence, TCP packets get fragmented, which causes performance penalty.

Since dual stack patch
https://github.com/OpenVPN/openvpn/commit/23d61c56b9fd218c39ad151b01b7e2d6690e6093
OpenVPN uses options->connection_list, even for single remote.

This fix assigns mssfix value to fragment value for connection_entry inside connection_list instead of connection_entry inside options struct (which does not work for connection_list case).

---
 src/openvpn/options.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/openvpn/options.c +1 -1
index 4ea03d1..20b37db 100644
@@ -2352,7 +2352,7 @@ options_postprocess_mutate_ce (struct options *o, struct connection_entry *ce)
     {
 #ifdef ENABLE_FRAGMENT
       if (ce->fragment)
-	o->ce.mssfix = ce->fragment;
+	ce->mssfix = ce->fragment;
 #else
       msg (M_USAGE, "--mssfix must specify a parameter");
 #endif      
Signature · 1 line
1.9.1
#1 lore raw

ACK, thanks. Your patch has been applied to the master and release/2.3 branch.

commit d384a9587951617d12e31e0a18050bd86402d5df (master) commit 785297bf3c8a93ad2fca2aeae574082dc97183e6 (release/2.3)

Author: Lev Stipakov
Date:   Thu Mar 5 22:33:56 2015 +0200
     Fix mssfix default value

     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: http://article.gmane.org/gmane.network.openvpn.devel/9507
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering